Conditions | 3 |
Paths | 52 |
Total Lines | 83 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
150 | public function shipping_出荷CSV登録(\AcceptanceTester $I) |
||
151 | { |
||
152 | $I->wantTo('EA0903-UC04-T01 出荷CSV登録'); |
||
153 | |||
154 | $entityManager = Fixtures::get('entityManager'); |
||
155 | /* @var Customer $Customer */ |
||
156 | $Customer = (Fixtures::get('createCustomer'))(); |
||
157 | /* @var Order[] $Orders */ |
||
158 | $Orders = (Fixtures::get('createOrders'))($Customer, 3); |
||
159 | // 入金済みに更新しておく |
||
160 | $Status = $entityManager->getRepository('Eccube\Entity\Master\OrderStatus')->find(OrderStatus::PAID); |
||
161 | foreach ($Orders as $newOrder) { |
||
162 | $newOrder->setOrderStatus($Status); |
||
163 | } |
||
164 | $entityManager->flush(); |
||
165 | |||
166 | /* |
||
167 | * 出荷再検索 出荷日/伝票番号が登録されていないことを確認 |
||
168 | */ |
||
169 | |||
170 | $OrderManagePage = OrderManagePage::go($I) |
||
171 | ->詳細検索設定() |
||
172 | ->入力_ご注文者お名前($Customer->getName01().$Customer->getName02()) |
||
173 | ->入力_ご注文者お名前フリガナ($Customer->getKana01().$Customer->getKana02()) |
||
174 | ->検索(); |
||
175 | |||
176 | $I->see('検索結果:3件が該当しました', OrderManagePage::$検索結果_メッセージ); |
||
177 | |||
178 | $I->assertEmpty($OrderManagePage->取得_出荷伝票番号(1)); |
||
179 | $I->assertEmpty($OrderManagePage->取得_出荷伝票番号(2)); |
||
180 | $I->assertEmpty($OrderManagePage->取得_出荷伝票番号(3)); |
||
181 | $I->assertEquals('未発送', $OrderManagePage->取得_出荷日(1)); |
||
182 | $I->assertEquals('未発送', $OrderManagePage->取得_出荷日(2)); |
||
183 | $I->assertEquals('未発送', $OrderManagePage->取得_出荷日(3)); |
||
184 | |||
185 | /* |
||
186 | * 出荷CSV登録 |
||
187 | */ |
||
188 | |||
189 | $csv = implode(PHP_EOL, [ |
||
190 | '出荷ID,出荷伝票番号,出荷日', |
||
191 | $Orders[0]->getShippings()[0]->getId().',00001,2018-01-01', |
||
192 | $Orders[1]->getShippings()[0]->getId().',00002,2018-02-02', |
||
193 | $Orders[2]->getShippings()[0]->getId().',00003,2018-03-03', |
||
194 | ]); |
||
195 | |||
196 | $csvFileName = codecept_data_dir().'/shipping.csv'; |
||
197 | file_put_contents($csvFileName, $csv); |
||
198 | |||
199 | try { |
||
200 | ShippingCsvUploadPage::go($I) |
||
201 | ->入力_CSVファイル('shipping.csv') |
||
202 | ->CSVアップロード(); |
||
203 | |||
204 | $I->see('出荷登録CSVファイルをアップロードしました。', ShippingCsvUploadPage::$完了メッセージ); |
||
205 | |||
206 | /* |
||
207 | * 出荷再検索 出荷日/伝票番号が登録されたことを確認 |
||
208 | */ |
||
209 | |||
210 | $OrderManagePage = OrderManagePage::go($I) |
||
211 | ->詳細検索設定() |
||
212 | ->入力_ご注文者お名前($Customer->getName01().$Customer->getName02()) |
||
213 | ->入力_ご注文者お名前フリガナ($Customer->getKana01().$Customer->getKana02()) |
||
214 | ->検索(); |
||
215 | |||
216 | $I->see('検索結果:3件が該当しました', OrderManagePage::$検索結果_メッセージ); |
||
217 | |||
218 | $I->assertEquals('00003', $OrderManagePage->取得_出荷伝票番号(1)); |
||
219 | $I->assertEquals('00002', $OrderManagePage->取得_出荷伝票番号(2)); |
||
220 | $I->assertEquals('00001', $OrderManagePage->取得_出荷伝票番号(3)); |
||
221 | $I->assertEquals('2018/03/03', $OrderManagePage->取得_出荷日(1)); |
||
222 | $I->assertEquals('2018/02/02', $OrderManagePage->取得_出荷日(2)); |
||
223 | $I->assertEquals('2018/01/01', $OrderManagePage->取得_出荷日(3)); |
||
224 | $I->assertEquals('発送済み', $OrderManagePage->取得_ステータス(1)); |
||
225 | $I->assertEquals('発送済み', $OrderManagePage->取得_ステータス(2)); |
||
226 | $I->assertEquals('発送済み', $OrderManagePage->取得_ステータス(3)); |
||
227 | } finally { |
||
228 | if (file_exists($csvFileName)) { |
||
229 | unlink($csvFileName); |
||
230 | } |
||
231 | } |
||
232 | } |
||
233 | |||
310 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.