PageRepository::findUnusedBlocks() - Code Metrics - Inspection of "Disable coverage" - nanasess/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/sf (#31)

by Kentaro

created 2018-08-08 04:16 UTC

PageRepository::findUnusedBlocks() A

↳ Parent: PageRepository

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3.004

Importance

Changes

Metric	Value
cc	3
nc	4
nop	2
dl	0
loc	21
rs	9.584
c	0
b	0
f	0
ccs	12
cts	13
cp	0.9231
crap	3.004

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Repository;

use Doctrine\ORM\NoResultException;
use Eccube\Common\EccubeConfig;
use Eccube\Entity\Master\DeviceType;
use Eccube\Entity\Page;
use Symfony\Bridge\Doctrine\RegistryInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * PageRepository
 *
 * This class was generated by the Doctrine ORM. Add your own custom
 * repository methods below.
 */
class PageRepository extends AbstractRepository
{
    /**
     * @var EccubeConfig
     */
    protected $eccubeConfig;

    /**
     * @var string
     * @path %eccube_theme_user_data_dir% (app/template/user_data)
     */
    protected $userDataRealDir;

    /**
     * @var string
     * @path %eccube_theme_app_dir% (app/template)
     */
    protected $templateRealDir;

    /**
     * @var string
     * @path %eccube_theme_src_dir% (src/Eccube/Resource/template)
     */
    protected $templateDefaultRealDir;

    /**
     * PageRepository constructor.
     *
     * @param RegistryInterface $registry
     * @param EccubeConfig $eccubeConfig
     * @param ContainerInterface $container
     */
    public function __construct(RegistryInterface $registry, EccubeConfig $eccubeConfig, ContainerInterface $container)
    {
        parent::__construct($registry, Page::class);
        $this->eccubeConfig = $eccubeConfig;
        $this->userDataRealDir = $container->getParameter('eccube_theme_user_data_dir');
        $this->templateRealDir = $container->getParameter('eccube_theme_app_dir');
        $this->templateDefaultRealDir = $container->getParameter('eccube_theme_src_dir');
    }

    /**
     * @param DeviceType $DeviceType
     * @param int $pageId
     *
     * @return array
     */
    public function findUnusedBlocks(DeviceType $DeviceType, $pageId)
    {
        $em = $this->getEntityManager();
        $blockRepo = $em->getRepository('Eccube\Entity\Block');
        $ownBlockPositions = $this->getByDeviceTypeAndId($DeviceType, $pageId)->getBlockPositions();
        $ids = [];
        foreach ($ownBlockPositions as $ownBlockPosition) {
            $ids[] = $ownBlockPosition->getBlock()->getId();
        }

        // $idsが空配列だと、$ids以外のblockを取得するSQLが生成されないため、存在しないidを入れる
        if (empty($ids)) {
            $ids[] = \Eccube\Entity\Block::UNUSED_BLOCK_ID;
        }

        return $blockRepo->createQueryBuilder('b')
            ->where('b.id not in (:ids)')
            ->setParameter(':ids', $ids)
            ->getQuery()
            ->getResult();
    }

    /**
     * @param DeviceType $DeviceType
     * @param int $pageId
     *
     * @return mixed
     */
    public function getByDeviceTypeAndId(DeviceType $DeviceType, $pageId)
    {
        $qb = $this->createQueryBuilder('p')
            ->select('p, bp, b')
            ->leftJoin('p.BlockPositions', 'bp', 'WITH', 'p.id = bp.page_id')
            ->leftJoin('bp.Block', 'b')
            ->andWhere('p.DeviceType = :DeviceType AND p.id = :pageId')
            ->addOrderBy('bp.section', 'ASC')
            ->addOrderBy('bp.block_row', 'ASC');

        $ownResult = $qb
            ->getQuery()
            ->setParameters([
                'DeviceType' => $DeviceType,
                'pageId' => $pageId,
            ])
            ->getSingleResult();

        $qb = $this->createQueryBuilder('p')
            ->select('p, bp, b')
            ->leftJoin('p.BlockPositions', 'bp', 'WITH', 'p.id = bp.page_id')
            ->leftJoin('bp.Block', 'b')
            ->andWhere('p.DeviceType = :DeviceType AND bp.anywhere = 1')
            ->addOrderBy('bp.section', 'ASC')
            ->addOrderBy('bp.block_row', 'ASC');

        $anyResults = $qb
            ->getQuery()
            ->setParameters([
                'DeviceType' => $DeviceType,
            ])
            ->getResult();

        $OwnBlockPosition = $ownResult->getBlockPositions();
        foreach ($anyResults as $anyResult) {
            $BlockPositions = $anyResult->getBlockPositions();
            foreach ($BlockPositions as $BlockPosition) {
                if (!$OwnBlockPosition->contains($BlockPosition)) {
                    $ownResult->addBlockPosition($BlockPosition);
                }
            }
        }

        return $ownResult;
    }

    /**
     * @param DeviceType $DeviceType
     * @param string $url
     * @throw NoResultException
     *
     * @return Page
     */
    public function getByUrl(DeviceType $DeviceType, $url)
    {
        $qb = $this->createQueryBuilder('p');
        $Page = $qb->select('p, pll,l, bp, b')
            ->leftJoin('p.PageLayouts', 'pll')
            ->leftJoin('pll.Layout', 'l')
            ->leftJoin('l.BlockPositions', 'bp')
            ->leftJoin('bp.Block', 'b')
            ->where('p.url = :route')
            ->andWhere('l.DeviceType = :DeviceType')
            ->orderBy('bp.block_row', 'ASC')
            ->setParameter('route', $url)
            ->setParameter('DeviceType', $DeviceType)
            ->getQuery()
            ->useResultCache(true, $this->getCacheLifetime())
            ->getSingleResult();

        return $Page;
    }

    /**
     * @param DeviceType $DeviceType
     *
     * @return Page
     */
    public function newPage(DeviceType $DeviceType)
    {
        $Page = new \Eccube\Entity\Page();
        $Page
            ->setDeviceType($DeviceType)
            ->setEditType(Page::EDIT_TYPE_USER);

        return $Page;
    }

    /**
     * @param int $page_id
     * @param DeviceType $DeviceType
     *
     * @return Page|mixed
     */
    public function findOrCreate($page_id, DeviceType $DeviceType)
    {
        if (is_null($page_id)) {
            $Page = $this
                ->newPage($DeviceType);

            return $Page;
        } else {
            return $this->getByDeviceTypeAndId($DeviceType, $page_id);
        }
    }

    /**
     * ページの属性を取得する.
     *
     * この関数は, dtb_Page の情報を検索する.
     * $deviceTypeId は必須. デフォルト値は DEVICE_TYPE_PC.
     *
     * @param  \Eccube\Entity\Master\DeviceType  $DeviceType 端末種別ID
     * @param  string                            $where 追加の検索条件
     * @param  string[]                          $parameters 追加の検索パラメーター
     *
     * @return array                             ページ属性の配列
     */
    public function getPageList(DeviceType $DeviceType, $where = null, $parameters = [])

    {
        $qb = $this->createQueryBuilder('l')
            ->orderBy('l.id', 'DESC')
            ->where('l.DeviceType = :DeviceType')
            ->setParameter('DeviceType', $DeviceType)
            ->andWhere('l.id <> 0')
            ->andWhere('l.MasterPage is null')
            ->orderBy('l.id', 'ASC');
        if (!is_null($where)) {
            $qb->andWhere($where);
            foreach ($parameters as $key => $val) {
                $qb->setParameter($key, $val);
            }
        }

        $Pages = $qb
            ->getQuery()
            ->getResult();

        return $Pages;
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7			*
8			* http://www.lockon.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Repository;
15
16			use Doctrine\ORM\NoResultException;
17			use Eccube\Common\EccubeConfig;
18			use Eccube\Entity\Master\DeviceType;
19			use Eccube\Entity\Page;
20			use Symfony\Bridge\Doctrine\RegistryInterface;
21			use Symfony\Component\DependencyInjection\ContainerInterface;
22
23			/**
24			* PageRepository
25			*
26			* This class was generated by the Doctrine ORM. Add your own custom
27			* repository methods below.
28			*/
29			class PageRepository extends AbstractRepository
30			{
31			/**
32			* @var EccubeConfig
33			*/
34			protected $eccubeConfig;
35
36			/**
37			* @var string
38			* @path %eccube_theme_user_data_dir% (app/template/user_data)
39			*/
40			protected $userDataRealDir;
41
42			/**
43			* @var string
44			* @path %eccube_theme_app_dir% (app/template)
45			*/
46			protected $templateRealDir;
47
48			/**
49			* @var string
50			* @path %eccube_theme_src_dir% (src/Eccube/Resource/template)
51			*/
52			protected $templateDefaultRealDir;
53
54			/**
55			* PageRepository constructor.
56			*
57			* @param RegistryInterface $registry
58			* @param EccubeConfig $eccubeConfig
59			* @param ContainerInterface $container
60	712		*/
61			public function __construct(RegistryInterface $registry, EccubeConfig $eccubeConfig, ContainerInterface $container)
62	712		{
63	712		parent::__construct($registry, Page::class);
64	712		$this->eccubeConfig = $eccubeConfig;
65	712		$this->userDataRealDir = $container->getParameter('eccube_theme_user_data_dir');
66	712		$this->templateRealDir = $container->getParameter('eccube_theme_app_dir');
67			$this->templateDefaultRealDir = $container->getParameter('eccube_theme_src_dir');
68			}
69
70			/**
71			* @param DeviceType $DeviceType
72			* @param int $pageId
73			*
74			* @return array
75	1		*/
76			public function findUnusedBlocks(DeviceType $DeviceType, $pageId)
77	1		{
78	1		$em = $this->getEntityManager();
79	1		$blockRepo = $em->getRepository('Eccube\Entity\Block');
80	1		$ownBlockPositions = $this->getByDeviceTypeAndId($DeviceType, $pageId)->getBlockPositions();
81	1		$ids = [];
82	1		foreach ($ownBlockPositions as $ownBlockPosition) {
83			$ids[] = $ownBlockPosition->getBlock()->getId();
84			}
85
86	1		// $idsが空配列だと、$ids以外のblockを取得するSQLが生成されないため、存在しないidを入れる
87			if (empty($ids)) {
88			$ids[] = \Eccube\Entity\Block::UNUSED_BLOCK_ID;
89			}
90	1
91	1		return $blockRepo->createQueryBuilder('b')
92	1		->where('b.id not in (:ids)')
93	1		->setParameter(':ids', $ids)
94	1		->getQuery()
95			->getResult();
96			}
97
98			/**
99			* @param DeviceType $DeviceType
100			* @param int $pageId
101			*
102			* @return mixed
103	5		*/
104			public function getByDeviceTypeAndId(DeviceType $DeviceType, $pageId)
105	5		{
106	5		$qb = $this->createQueryBuilder('p')
107	5		->select('p, bp, b')
108	5		->leftJoin('p.BlockPositions', 'bp', 'WITH', 'p.id = bp.page_id')
109	5		->leftJoin('bp.Block', 'b')
110	5		->andWhere('p.DeviceType = :DeviceType AND p.id = :pageId')
111	5		->addOrderBy('bp.section', 'ASC')
112			->addOrderBy('bp.block_row', 'ASC');
113
114	5		$ownResult = $qb
115	5		->getQuery()
116	5		->setParameters([
117	5		'DeviceType' => $DeviceType,
118			'pageId' => $pageId,
119	5		])
120			->getSingleResult();
121	5
122	5		$qb = $this->createQueryBuilder('p')
123	5		->select('p, bp, b')
124	5		->leftJoin('p.BlockPositions', 'bp', 'WITH', 'p.id = bp.page_id')
125	5		->leftJoin('bp.Block', 'b')
126	5		->andWhere('p.DeviceType = :DeviceType AND bp.anywhere = 1')
127	5		->addOrderBy('bp.section', 'ASC')
128			->addOrderBy('bp.block_row', 'ASC');
129
130	5		$anyResults = $qb
131	5		->getQuery()
132	5		->setParameters([
133			'DeviceType' => $DeviceType,
134	5		])
135			->getResult();
136	5
137	5		$OwnBlockPosition = $ownResult->getBlockPositions();
138	5		foreach ($anyResults as $anyResult) {
139	5		$BlockPositions = $anyResult->getBlockPositions();
140	5		foreach ($BlockPositions as $BlockPosition) {
141	5		if (!$OwnBlockPosition->contains($BlockPosition)) {
142			$ownResult->addBlockPosition($BlockPosition);
143			}
144			}
145			}
146	5
147			return $ownResult;
148			}
149
150			/**
151			* @param DeviceType $DeviceType
152			* @param string $url
153			* @throw NoResultException
154			*
155	1		* @return Page
156			*/
157			public function getByUrl(DeviceType $DeviceType, $url)
158			{
159			$qb = $this->createQueryBuilder('p');
160	1		$Page = $qb->select('p, pll,l, bp, b')
161			->leftJoin('p.PageLayouts', 'pll')
162	1		->leftJoin('pll.Layout', 'l')
163	1		->leftJoin('l.BlockPositions', 'bp')
164	1		->leftJoin('bp.Block', 'b')
165	1		->where('p.url = :route')
166	1		->andWhere('l.DeviceType = :DeviceType')
167	1		->orderBy('bp.block_row', 'ASC')
168	1		->setParameter('route', $url)
169			->setParameter('DeviceType', $DeviceType)
170			->getQuery()
171	1		->useResultCache(true, $this->getCacheLifetime())
172	1		->getSingleResult();
173	1
174	1		return $Page;
175	1		}
176
177	1		/**
178			* @param DeviceType $DeviceType
179	1		*
180			* @return Page
181			*/
182			public function newPage(DeviceType $DeviceType)
183	1		{
184	1		$Page = new \Eccube\Entity\Page();
185	1		$Page
186	1		->setDeviceType($DeviceType)
187	1		->setEditType(Page::EDIT_TYPE_USER);
188	1
189	1		return $Page;
190			}
191
192	1		/**
193	1		* @param int $page_id
194	1		* @param DeviceType $DeviceType
195	1		*
196			* @return Page\|mixed
197	1		*/
198			public function findOrCreate($page_id, DeviceType $DeviceType)
199	1		{
200	1		if (is_null($page_id)) {
201	1		$Page = $this
202	1		->newPage($DeviceType);
203
204			return $Page;
205	1		} else {
206	1		return $this->getByDeviceTypeAndId($DeviceType, $page_id);
207	1		}
208	1		}
209
210	1		/**
211			* ページの属性を取得する.
212			*
213			* この関数は, dtb_Page の情報を検索する.
214			* $deviceTypeId は必須. デフォルト値は DEVICE_TYPE_PC.
215	1		*
216			* @param \Eccube\Entity\Master\DeviceType $DeviceType 端末種別ID
217			* @param string $where 追加の検索条件
218			* @param string[] $parameters 追加の検索パラメーター
219			*
220			* @return array ページ属性の配列
221			*/
222		View Code Duplication	public function getPageList(DeviceType $DeviceType, $where = null, $parameters = [])
			0 ignored issues – show Duplication introduced 2018-06-05 10:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
223	126		{
224			$qb = $this->createQueryBuilder('l')
225	126		->orderBy('l.id', 'DESC')
226			->where('l.DeviceType = :DeviceType')
227	126		->setParameter('DeviceType', $DeviceType)
228	126		->andWhere('l.id <> 0')
229			->andWhere('l.MasterPage is null')
230	126		->orderBy('l.id', 'ASC');
231			if (!is_null($where)) {
232			$qb->andWhere($where);
233			foreach ($parameters as $key => $val) {
234			$qb->setParameter($key, $val);
235			}
236			}
237
238			$Pages = $qb
239	5		->getQuery()
240			->getResult();
241	5
242			return $Pages;
243	2		}
244			}
245

nanasess / ec-cube

Pull Request — experimental/sf (#31)

PageRepository::findUnusedBlocks() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like