Completed
Branch modify-scrutinizeryml (c70e79)
by Kentaro
39:02
created
src/Eccube/Repository/AbstractRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,6 +40,6 @@
 block discarded – undo
40 40
     {
41 41
         // $options = $this->eccubeConfig['doctrine_cache'];
42 42
         // return $options['result_cache']['lifetime'];
43
-        return 0;               // FIXME
43
+        return 0; // FIXME
44 44
     }
45 45
 }
Please login to merge, or discard this patch.
src/Eccube/Repository/ShippingRepository.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
             $multi = preg_match('/^\d{0,10}$/', $searchData['multi']) ? $searchData['multi'] : null;
66 66
             $qb
67 67
                 ->andWhere('s.id = :multi OR s.name01 LIKE :likemulti OR s.name02 LIKE :likemulti OR '.
68
-                           's.kana01 LIKE :likemulti OR s.kana02 LIKE :likemulti OR s.company_name LIKE :likemulti')
68
+                            's.kana01 LIKE :likemulti OR s.kana02 LIKE :likemulti OR s.company_name LIKE :likemulti')
69 69
                 ->setParameter('multi', $multi)
70 70
                 ->setParameter('likemulti', '%'.$searchData['multi'].'%');
71 71
         }
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -242,7 +242,8 @@
 block discarded – undo
242 242
     /**
243 243
      * 同一商品のお届け先情報を取得
244 244
      *
245
-     * @param $Order
245
+     * @param \Eccube\Entity\Order|null $Order
246
+     * @param \Eccube\Entity\ProductClass|null $productClass
246 247
      *
247 248
      * @return array
248 249
      */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,10 +13,10 @@
 block discarded – undo
13 13
 
14 14
 namespace Eccube\Repository;
15 15
 
16
+use Doctrine\ORM\QueryBuilder;
16 17
 use Eccube\Entity\Shipping;
17 18
 use Eccube\Util\StringUtil;
18 19
 use Symfony\Bridge\Doctrine\RegistryInterface;
19
-use Doctrine\ORM\QueryBuilder;
20 20
 
21 21
 /**
22 22
  * ShippingRepository
Please login to merge, or discard this patch.
src/Eccube/Repository/PluginEventHandlerRepository.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -75,11 +75,11 @@  discard block
 block discarded – undo
75 75
 
76 76
         $qb = $this->createQueryBuilder('e');
77 77
         $qb->andWhere("e.priority >= $range_end ")
78
-           ->andWhere("e.priority <= $range_start ")
79
-           ->andWhere('e.event = :event')
80
-           ->setParameter('event', $event)
81
-           ->setMaxResults(1)
82
-           ->orderBy('e.priority', 'ASC');
78
+            ->andWhere("e.priority <= $range_start ")
79
+            ->andWhere('e.event = :event')
80
+            ->setParameter('event', $event)
81
+            ->setMaxResults(1)
82
+            ->orderBy('e.priority', 'ASC');
83 83
 
84 84
         $result = $qb->getQuery()->getResult();
85 85
         if (count($result)) {
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
         $qb = $this->createQueryBuilder('e');
97 97
 
98 98
         $qb->andWhere("e.priority >= $range_end ")
99
-           ->andWhere("e.priority <= $range_start ")
100
-           ->andWhere('e.priority '.($up ? '>' : '<').' :pri')
101
-           ->andWhere('e.event = :event')
102
-           ->setParameter('event', $pluginEventHandler->getEvent())
103
-           ->setParameter('pri', $pluginEventHandler->getPriority())
104
-           ->setMaxResults(1)
105
-           ->orderBy('e.priority', ($up ? 'ASC' : 'DESC'));
99
+            ->andWhere("e.priority <= $range_start ")
100
+            ->andWhere('e.priority '.($up ? '>' : '<').' :pri')
101
+            ->andWhere('e.event = :event')
102
+            ->setParameter('event', $pluginEventHandler->getEvent())
103
+            ->setParameter('pri', $pluginEventHandler->getPriority())
104
+            ->setMaxResults(1)
105
+            ->orderBy('e.priority', ($up ? 'ASC' : 'DESC'));
106 106
 
107 107
         $result = $qb->getQuery()->getResult();
108 108
 
Please login to merge, or discard this patch.
src/Eccube/Form/Type/NameType.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
                 ],
113 113
                 'constraints' => [
114 114
                     new Assert\Length([
115
-                         'max' => $this->eccubeConfig['eccube_name_len'],
115
+                            'max' => $this->eccubeConfig['eccube_name_len'],
116 116
                     ]),
117 117
                     new Assert\Regex([
118 118
                         'pattern' => '/^[^\s ]+$/u',
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
                 ],
127 127
                 'constraints' => [
128 128
                     new Assert\Length([
129
-                         'max' => $this->eccubeConfig['eccube_name_len'],
129
+                            'max' => $this->eccubeConfig['eccube_name_len'],
130 130
                     ]),
131 131
                     new Assert\Regex([
132 132
                         'pattern' => '/^[^\s ]+$/u',
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/SecurityType.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,8 +79,8 @@
 block discarded – undo
79 79
                     new Assert\NotBlank(),
80 80
                     new Assert\Length(['max' => $this->eccubeConfig['eccube_stext_len']]),
81 81
                     new Assert\Regex([
82
-                       'pattern' => '/^[0-9a-zA-Z]+$/',
83
-                   ]),
82
+                        'pattern' => '/^[0-9a-zA-Z]+$/',
83
+                    ]),
84 84
                 ],
85 85
                 'data' => $this->eccubeConfig->get('eccube_admin_route'),
86 86
             ])
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Store/PluginController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -529,7 +529,7 @@
 block discarded – undo
529 529
     {
530 530
         $curl = curl_init($url);
531 531
 
532
-        $options = [           // オプション配列
532
+        $options = [// オプション配列
533 533
             //HEADER
534 534
             CURLOPT_HTTPHEADER => [
535 535
                 'Authorization: '.base64_encode($authKey),
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -518,7 +518,7 @@
 block discarded – undo
518 518
      * APIリクエスト処理
519 519
      *
520 520
      * @param Request $request
521
-     * @param $authKey
521
+     * @param string|null $authKey
522 522
      * @param string $url
523 523
      *
524 524
      * @return array
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/Shop/ShopController.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -94,15 +94,15 @@
 block discarded – undo
94 94
                 $this->entityManager->flush();
95 95
 
96 96
                 $event = new EventArgs(
97
-                  [
97
+                    [
98 98
                     'form' => $form,
99 99
                     'BaseInfo' => $this->BaseInfo,
100
-                  ],
101
-                  $request
100
+                    ],
101
+                    $request
102 102
                 );
103 103
                 $this->eventDispatcher->dispatch(
104
-                  EccubeEvents::ADMIN_SETTING_SHOP_SHOP_INDEX_COMPLETE,
105
-                  $event
104
+                    EccubeEvents::ADMIN_SETTING_SHOP_SHOP_INDEX_COMPLETE,
105
+                    $event
106 106
                 );
107 107
 
108 108
                 $cacheUtil->clearCache();
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Shipping/EditController.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -178,13 +178,13 @@
 block discarded – undo
178 178
                     if ($form->get('notify_email')->getData()) {
179 179
                         try {
180 180
                             $this->mailService->sendShippingNotifyMail(
181
-                              $TargetShipping
181
+                                $TargetShipping
182 182
                             );
183 183
                         } catch (\Exception $e) {
184 184
                             log_error('メール通知エラー', [$TargetShipping->getId(), $e]);
185 185
                             $this->addError(
186
-                              'admin.shipping.edit.shipped_mail_failed',
187
-                              'admin'
186
+                                'admin.shipping.edit.shipped_mail_failed',
187
+                                'admin'
188 188
                             );
189 189
                         }
190 190
                     }
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,6 +24,7 @@  discard block
 block discarded – undo
24 24
 use Eccube\Repository\Master\ShippingStatusRepository;
25 25
 use Eccube\Repository\OrderItemRepository;
26 26
 use Eccube\Repository\ShippingRepository;
27
+use Eccube\Service\MailService;
27 28
 use Eccube\Service\TaxRuleService;
28 29
 use Knp\Component\Pager\PaginatorInterface;
29 30
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
@@ -32,7 +33,6 @@  discard block
 block discarded – undo
32 33
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
33 34
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
34 35
 use Symfony\Component\Serializer\SerializerInterface;
35
-use Eccube\Service\MailService;
36 36
 
37 37
 class EditController extends AbstractController
38 38
 {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Order/OrderController.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -505,8 +505,8 @@  discard block
 block discarded – undo
505 505
                 if ($flowResult->hasWarning()) {
506 506
                     foreach ($flowResult->getWarning() as $warning) {
507 507
                         $msg = $this->translator->trans('admin.order.index.bulk_warning', [
508
-                          '%orderId%' => $Order->getId(),
509
-                          '%message%' => $warning->getMessage(),
508
+                            '%orderId%' => $Order->getId(),
509
+                            '%message%' => $warning->getMessage(),
510 510
                         ]);
511 511
                         $this->addWarning($msg, 'admin');
512 512
                     }
@@ -515,8 +515,8 @@  discard block
 block discarded – undo
515 515
                 if ($flowResult->hasError()) {
516 516
                     foreach ($flowResult->getErrors() as $error) {
517 517
                         $msg = $this->translator->trans('admin.order.index.bulk_error', [
518
-                          '%orderId%' => $Order->getId(),
519
-                          '%message%' => $error->getMessage(),
518
+                            '%orderId%' => $Order->getId(),
519
+                            '%message%' => $error->getMessage(),
520 520
                         ]);
521 521
                         $this->addError($msg, 'admin');
522 522
                     }
@@ -527,8 +527,8 @@  discard block
 block discarded – undo
527 527
                     $this->purchaseFlow->purchase($Order, $purchaseContext);
528 528
                 } catch (PurchaseException $e) {
529 529
                     $msg = $this->translator->trans('admin.order.index.bulk_error', [
530
-                      '%orderId%' => $Order->getId(),
531
-                      '%message%' => $e->getMessage(),
530
+                        '%orderId%' => $Order->getId(),
531
+                        '%message%' => $e->getMessage(),
532 532
                     ]);
533 533
                     $this->addError($msg, 'admin');
534 534
                     continue;
Please login to merge, or discard this patch.
Unused Use Statements   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -17,6 +17,8 @@  discard block
 block discarded – undo
17 17
 use Eccube\Controller\AbstractController;
18 18
 use Eccube\Entity\Csv;
19 19
 use Eccube\Entity\Master\CsvType;
20
+use Eccube\Entity\Master\OrderStatus;
21
+use Eccube\Entity\Order;
20 22
 use Eccube\Entity\OrderItem;
21 23
 use Eccube\Entity\Shipping;
22 24
 use Eccube\Event\EccubeEvents;
@@ -30,19 +32,17 @@  discard block
 block discarded – undo
30 32
 use Eccube\Repository\OrderRepository;
31 33
 use Eccube\Repository\PaymentRepository;
32 34
 use Eccube\Service\CsvExportService;
35
+use Eccube\Service\PurchaseFlow\PurchaseContext;
36
+use Eccube\Service\PurchaseFlow\PurchaseException;
37
+use Eccube\Service\PurchaseFlow\PurchaseFlow;
33 38
 use Eccube\Util\FormUtil;
34 39
 use Knp\Component\Pager\PaginatorInterface;
35 40
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
36 41
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
37 42
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
43
+use Symfony\Component\HttpFoundation\RedirectResponse;
38 44
 use Symfony\Component\HttpFoundation\Request;
39 45
 use Symfony\Component\HttpFoundation\StreamedResponse;
40
-use Eccube\Entity\Master\OrderStatus;
41
-use Symfony\Component\HttpFoundation\RedirectResponse;
42
-use Eccube\Entity\Order;
43
-use Eccube\Service\PurchaseFlow\PurchaseContext;
44
-use Eccube\Service\PurchaseFlow\PurchaseFlow;
45
-use Eccube\Service\PurchaseFlow\PurchaseException;
46 46
 
47 47
 class OrderController extends AbstractController
48 48
 {
Please login to merge, or discard this patch.