ContactController - Code Metrics - Inspection of "Merge pull request #1334 from k-yamamura/bugfix-in..." - nanasess/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 3ed8ee...0f3867 )

by Kentaro

created 2015-12-21 04:18 UTC

ContactController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	12.12 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

68.75%

Metric	Value
wmc	7
lcom	0
cbo	5
dl	8
loc	66
ccs	11
cts	16
cp	0.6875
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	complete()	0	4	1
B	index()	8	57	6

How to fix Duplicated Code

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller;

use Eccube\Application;
use Symfony\Component\HttpFoundation\Request;

class ContactController

{

    public function index(Application $app, Request $request)

    {

        /* @var $builder \Symfony\Component\Form\FormBuilderInterface */
        $builder = $app['form.factory']->createBuilder('contact');

        /* @var $form \Symfony\Component\Form\FormInterface */
        $form = $builder->getForm();

        if ($app['security']->isGranted('ROLE_USER')) {
            /* @var $user \Eccube\Entity\Customer */
            $user = $app['user'];
            $form->setData(array(
                'name01' => $user->getName01(),
                'name02' => $user->getName02(),
                'kana01' => $user->getKana01(),
                'kana02' => $user->getKana02(),
                'zip01' => $user->getZip01(),
                'zip02' => $user->getZip02(),
                'pref' => $user->getPref(),
                'addr01' => $user->getAddr01(),
                'addr02' => $user->getAddr02(),
                'tel01' => $user->getTel01(),
                'tel02' => $user->getTel02(),
                'tel03' => $user->getTel03(),
                'email' => $user->getEmail(),
            ));
        }

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);

            if ($form->isValid()) {
                switch ($request->get('mode')) {
                    case 'confirm':

                        $builder->setAttribute('freeze', true);
                        $form = $builder->getForm();
                        $form->handleRequest($request);

                        return $app->render('Contact/confirm.twig', array(
                            'form' => $form->createView(),
                        ));

                    case 'complete':
                        // メール送信
                        $app['eccube.service.mail']->sendrContactMail($form->getData());

                        return $app->redirect($app->url('contact_complete'));
                        break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                }
            }
        }

        return $app->render('Contact/index.twig', array(
            'form' => $form->createView(),
        ));
    }

    public function complete(Application $app)

    {
        return $app->render('Contact/complete.twig');
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24
25			namespace Eccube\Controller;
26
27			use Eccube\Application;
28			use Symfony\Component\HttpFoundation\Request;
29
30			class ContactController
			0 ignored issues – show introduced 2015-11-21 20:00 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
31			{
32
33	5		public function index(Application $app, Request $request)
			0 ignored issues – show introduced 2015-11-21 20:00 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
34			{
35
36			/* @var $builder \Symfony\Component\Form\FormBuilderInterface */
37			$builder = $app['form.factory']->createBuilder('contact');
38
39			/* @var $form \Symfony\Component\Form\FormInterface */
40			$form = $builder->getForm();
41
42			if ($app['security']->isGranted('ROLE_USER')) {
43			/* @var $user \Eccube\Entity\Customer */
44			$user = $app['user'];
45			$form->setData(array(
46			'name01' => $user->getName01(),
47			'name02' => $user->getName02(),
48			'kana01' => $user->getKana01(),
49			'kana02' => $user->getKana02(),
50			'zip01' => $user->getZip01(),
51			'zip02' => $user->getZip02(),
52			'pref' => $user->getPref(),
53			'addr01' => $user->getAddr01(),
54			'addr02' => $user->getAddr02(),
55			'tel01' => $user->getTel01(),
56			'tel02' => $user->getTel02(),
57			'tel03' => $user->getTel03(),
58			'email' => $user->getEmail(),
59			));
60			}
61
62			if ('POST' === $request->getMethod()) {
63			$form->handleRequest($request);
64
65			if ($form->isValid()) {
66	4		switch ($request->get('mode')) {
67	4	View Code Duplication	case 'confirm':
			0 ignored issues – show Duplication introduced 2015-11-21 20:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68			$builder->setAttribute('freeze', true);
69			$form = $builder->getForm();
70			$form->handleRequest($request);
71
72	1		return $app->render('Contact/confirm.twig', array(
73	1		'form' => $form->createView(),
74			));
75
76	3		case 'complete':
77			// メール送信
78			$app['eccube.service.mail']->sendrContactMail($form->getData());
79
80			return $app->redirect($app->url('contact_complete'));
81			break;
			0 ignored issues – show Unused Code introduced 2015-11-21 20:00 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
82			}
83			}
84			}
85
86	1		return $app->render('Contact/index.twig', array(
87	1		'form' => $form->createView(),
88			));
89	5		}
90
91	1		public function complete(Application $app)
			0 ignored issues – show introduced 2015-11-21 20:00 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
92			{
93			return $app->render('Contact/complete.twig');
94	1		}
95			}
96

nanasess / ec-cube

Push — master ( 3ed8ee...0f3867 )

ContactController A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like