nanasess / ec-cube

src/Eccube/Service/Composer/OutputParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
 
     /**
      * @param $rowArray
-     * @param $key
+     * @param string $key
      *
      * @return array
      */

Spacing +5 added lines, -5 removed lines

@@ -40,7 +40,7 @@ 
         $rowArray = explode(PHP_EOL, str_replace('\r\n', PHP_EOL, $output));
         $installedLogs = array_filter(
             array_map(
-                function ($line) {
+                function($line) {
                     $matches = [];
                     preg_match('/^  - Installing (.*?) \((.*?)\) .*/', $line, $matches);
 
@@ -64,7 +64,7 @@ 
     public static function parseInfo($output)
     {
         $rowArray = explode(PHP_EOL, str_replace('\r\n', PHP_EOL, $output));
-        $infoLogs = array_filter(array_map(function ($line) {
+        $infoLogs = array_filter(array_map(function($line) {
             $matches = [];
             preg_match('/^(name|descrip.|keywords|versions|type|license|source|dist|names)\s*:\s*(.*)$/', $line, $matches);
 
@@ -89,7 +89,7 @@ 
     public static function parseConfig($output)
     {
         $rowArray = explode(PHP_EOL, str_replace('\r\n', PHP_EOL, $output));
-        $rowArray = array_filter($rowArray, function ($line) {
+        $rowArray = array_filter($rowArray, function($line) {
             return !preg_match('/^<warning>.*/', $line);
         });
 
@@ -106,7 +106,7 @@ 
     public static function parseList($output)
     {
         $rowArray = explode(PHP_EOL, str_replace('\r\n', PHP_EOL, $output));
-        $rawConfig = array_map(function ($line) {
+        $rawConfig = array_map(function($line) {
             $matches = [];
             preg_match('/^\[(.*?)\]\s?(.*)$/', $line, $matches);
 
@@ -166,7 +166,7 @@ 
     public static function parseComposerVersion($output)
     {
         $rowArray = explode(PHP_EOL, str_replace('\r\n', PHP_EOL, $output));
-        $rowArray = array_filter($rowArray, function ($line) {
+        $rowArray = array_filter($rowArray, function($line) {
             return preg_match('/^Composer */', $line);
         });
 

src/Eccube/Service/EntityProxyService.php

Doc Comments +1 added lines, -1 removed lines

@@ -204,7 +204,7 @@
     /**
      * EntityからTraitを削除.
      *
-     * @param $entityTokens Tokens Entityのトークン
+     * @param Tokens $entityTokens Tokens Entityのトークン
      * @param $trait string 削除するTraitのFQCN
      */
     private function removeTrait($entityTokens, $trait)

Spacing +4 added lines, -4 removed lines

@@ -128,13 +128,13 @@ 
             $includedFileSets[] = $includedFiles;
         }
 
-        $declaredTraits = array_map(function ($fqcn) {
+        $declaredTraits = array_map(function($fqcn) {
             // FQCNが'\'で始まるように正規化
             return strpos($fqcn, '\\') === 0 ? $fqcn : '\\'.$fqcn;
         }, get_declared_traits());
 
         // ディレクトリセットに含まれるTraitの一覧を作成
-        $traitSets = array_map(function () { return []; }, $dirSets);
+        $traitSets = array_map(function() { return []; }, $dirSets);
         foreach ($declaredTraits as $className) {
             $rc = new \ReflectionClass($className);
             $sourceFile = $rc->getFileName();
@@ -215,9 +215,9 @@ 
             $traitsTokens = array_slice($entityTokens->toArray(), $useTraitIndex + 1, $useTraitEndIndex - $useTraitIndex - 1);
 
             // Trait名の配列に変換
-            $traitNames = explode(',', implode(array_map(function ($token) {
+            $traitNames = explode(',', implode(array_map(function($token) {
                 return $token->getContent();
-            }, array_filter($traitsTokens, function ($token) {
+            }, array_filter($traitsTokens, function($token) {
                 return $token->getId() != T_WHITESPACE;
             }))));
 

src/Eccube/Service/MailService.php

Doc Comments +5 added lines, -3 removed lines

@@ -108,7 +108,7 @@ 
      * Send customer confirm mail.
      *
      * @param $Customer 会員情報
-     * @param $activateUrl アクティベート用url
+     * @param string $activateUrl アクティベート用url
      */
     public function sendCustomerConfirmMail(\Eccube\Entity\Customer $Customer, $activateUrl)
     {
@@ -305,7 +305,7 @@ 
      *
      * @param \Eccube\Entity\Order $Order 受注情報
      *
-     * @return string
+     * @return \Swift_Message
      */
     public function sendOrderMail(\Eccube\Entity\Order $Order)
     {
@@ -350,7 +350,7 @@ 
      * Send admin customer confirm mail.
      *
      * @param $Customer 会員情報
-     * @param $activateUrl アクティベート用url
+     * @param string $activateUrl アクティベート用url
      */
     public function sendAdminCustomerConfirmMail(\Eccube\Entity\Customer $Customer, $activateUrl)
     {
@@ -441,6 +441,7 @@ 
      * Send password reset notification mail.
      *
      * @param $Customer 会員情報
+     * @param string $reset_url
      */
     public function sendPasswordResetNotificationMail(\Eccube\Entity\Customer $Customer, $reset_url)
     {
@@ -487,6 +488,7 @@ 
      * Send password reset notification mail.
      *
      * @param $Customer 会員情報
+     * @param string $password
      */
     public function sendPasswordResetCompleteMail(\Eccube\Entity\Customer $Customer, $password)
     {

Spacing +1 added lines, -1 removed lines

@@ -606,7 +606,7 @@
      */
     public function getShippingNotifyMailBody(Shipping $Shipping, Order $Order, MailTemplate $MailTemplate = null)
     {
-        $ShippingItems = array_filter($Shipping->getOrderItems()->toArray(), function (OrderItem $OrderItem) use ($Order) {
+        $ShippingItems = array_filter($Shipping->getOrderItems()->toArray(), function(OrderItem $OrderItem) use ($Order) {
             return $OrderItem->getOrderId() === $Order->getId();
         });
 

src/Eccube/Service/PluginService.php

Doc Comments +19 added lines, -3 removed lines

@@ -150,7 +150,7 @@ 
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
      *
-     * @return mixed
+     * @return boolean
      *
      * @throws PluginException
      * @throws \Exception
@@ -274,6 +274,10 @@ 
         }
     }
 
+    /**
+     * @param string $archive
+     * @param string $dir
+     */
     public function unpackPluginArchive($archive, $dir)
     {
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -333,6 +337,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -350,6 +357,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -369,6 +379,9 @@ 
         return $this->projectRoot.'/app/Plugin/'.$name;
     }
 
+    /**
+     * @param string $d
+     */
     public function createPluginDir($d)
     {
         $b = @mkdir($d);
@@ -429,6 +442,9 @@ 
         return $p;
     }
 
+    /**
+     * @param string $method
+     */
     public function callPluginManagerMethod($meta, $method)
     {
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
@@ -962,7 +978,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -998,7 +1014,7 @@ 
      * @param string $pluginVersion
      * @param string $remoteVersion
      *
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use Eccube\Entity\Plugin;
 use Eccube\Entity\PluginEventHandler;
 use Eccube\Exception\PluginException;
-use Eccube\Plugin\ConfigManager;
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
 use Eccube\Repository\PluginEventHandlerRepository;
 use Eccube\Repository\PluginRepository;

Spacing +3 added lines, -3 removed lines

@@ -504,7 +504,7 @@ 
         @mkdir($outputDir);
 
         $enabledPluginCodes = array_map(
-            function ($p) { return $p->getCode(); },
+            function($p) { return $p->getCode(); },
             $this->pluginRepository->findAllEnabled()
         );
 
@@ -519,7 +519,7 @@ 
             }
         }
 
-        $enabledPluginEntityDirs = array_map(function ($code) {
+        $enabledPluginEntityDirs = array_map(function($code) {
             return $this->projectRoot."/app/Plugin/${code}/Entity";
         }, $enabledPluginCodes);
 
@@ -948,7 +948,7 @@ 
     {
         $result = array_keys($packages);
         if ($getVersion) {
-            $result = array_map(function ($package, $version) {
+            $result = array_map(function($package, $version) {
                 return $package.':'.$version;
             }, array_keys($packages), array_values($packages));
         }

src/Eccube/Service/ShoppingService.php

Doc Comments +4 added lines, -4 removed lines

@@ -279,7 +279,7 @@ 
     /**
      * 非会員情報を取得
      *
-     * @param $sesisonKey
+     * @param string $sesisonKey
      *
      * @return $Customer|null
      */
@@ -310,7 +310,7 @@ 
     /**
      * 受注情報を作成
      *
-     * @param $Customer
+     * @param null|Customer $Customer
      *
      * @return \Eccube\Entity\Order
      */
@@ -340,7 +340,7 @@ 
      * 仮受注情報作成
      *
      * @param $Customer
-     * @param $preOrderId
+     * @param string $preOrderId
      *
      * @return mixed
      *
@@ -1257,7 +1257,7 @@ 
      *
      * @param Order $Order
      *
-     * @return MailHistory
+     * @return null|\Symfony\Component\HttpFoundation\Request
      */
     public function sendOrderMail(Order $Order)
     {

src/Eccube/Service/TaxRuleService.php

Doc Comments +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
      * @param  int|null|\Eccube\Entity\Master\Pref    $pref         都道府県
      * @param  int|null|\Eccube\Entity\Master\Country $country      国
      *
-     * @return int
+     * @return double
      */
     public function getPriceIncTax($price, $product = null, $productClass = null, $pref = null, $country = null)
     {
@@ -97,8 +97,8 @@ 
     /**
      * 課税規則に応じて端数処理を行う
      *
-     * @param  float|integer $value    端数処理を行う数値
-     * @param  integer       $calcRule 課税規則
+     * @param  integer $value    端数処理を行う数値
+     * @param integer $RoundingType
      *
      * @return double        端数処理後の数値
      */

src/Eccube/ServiceProvider/QueriesServiceProvider.php

Doc Comments -1 removed lines

@@ -13,7 +13,6 @@
      * This method should only be used to configure services and parameters.
      * It should not get services.
      *
-     * @param Container $pimple A container instance
      */
     public function register(Container $app)
     {

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
      */
     public function register(Container $app)
     {
-        $app['eccube.queries'] = function () {
+        $app['eccube.queries'] = function() {
             return new \Eccube\Doctrine\Query\Queries();
         };
     }

src/Eccube/Twig/Extension/EccubeExtension.php

Doc Comments +3 added lines, -3 removed lines

@@ -53,7 +53,7 @@ 
     /**
      * Returns a list of functions to add to the existing list.
      *
-     * @return array An array of functions
+     * @return TwigFunction[] An array of functions
      */
     public function getFunctions()
     {
@@ -77,7 +77,7 @@ 
     /**
      * Returns a list of filters.
      *
-     * @return array
+     * @return TwigFilter[]
      */
     public function getFilters()
     {
@@ -103,7 +103,7 @@ 
     /**
      * Name of this extension
      *
-     * @return string
+     * @return double
      */
     public function getCalcIncTax($price, $tax_rate, $tax_rule)
     {

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
             new TwigFunction('calc_inc_tax', [$this, 'getCalcIncTax']),
             new TwigFunction('active_menus', [$this, 'getActiveMenus']),
             new TwigFunction('class_categories_as_json', [$this, 'getClassCategoriesAsJson']),
-            new TwigFunction('php_*', function () {
+            new TwigFunction('php_*', function() {
                 $arg_list = func_get_args();
                 $function = array_shift($arg_list);
                 if (is_callable($function)) {

src/Eccube/Util/CacheUtil.php

Doc Comments +3 added lines

@@ -51,6 +51,9 @@
         $this->kernel = $kernel;
     }
 
+    /**
+     * @param string $env
+     */
     public function clearCache($env = null)
     {
         $console = new Application($this->kernel);