nanasess / ec-cube

src/Eccube/Controller/Admin/AdminController.php

Doc Comments +14 added lines, -14 removed lines

@@ -347,10 +347,10 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function findOrderStatus($em, array $excludes)
     {
@@ -367,10 +367,10 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getOrderEachStatus($em, array $excludes)
     {
@@ -400,11 +400,11 @@ 
     }
 
     /**
-     * @param $em
-     * @param $dateTime
+     * @param \Doctrine\ORM\EntityManagerInterface $em
+     * @param \DateTime $dateTime
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getSalesByMonth($em, $dateTime, array $excludes)
     {
@@ -438,11 +438,11 @@ 
     }
 
     /**
-     * @param $em
-     * @param $dateTime
+     * @param \Doctrine\ORM\EntityManagerInterface $em
+     * @param \DateTime $dateTime
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getSalesByDay($em, $dateTime, array $excludes)
     {
@@ -476,9 +476,9 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -499,9 +499,9 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException

src/Eccube/Controller/Admin/Content/FileController.php

Doc Comments +13 added lines

@@ -288,6 +288,10 @@ 
         return $paths;
     }
 
+    /**
+     * @param string $topDir
+     * @param Request $request
+     */
     private function getTree($topDir, $request)
     {
         $finder = Finder::create()->in($topDir)
@@ -324,6 +328,9 @@ 
         return $tree;
     }
 
+    /**
+     * @param string $nowDir
+     */
     private function getFileList($nowDir)
     {
         $topDir = $this->getuserDataDir();
@@ -376,6 +383,9 @@ 
         return str_replace('\\', '/', realpath($path));
     }
 
+    /**
+     * @param string $topDir
+     */
     protected function checkDir($targetDir, $topDir)
     {
         $targetDir = realpath($targetDir);
@@ -384,6 +394,9 @@ 
         return strpos($targetDir, $topDir) === 0;
     }
 
+    /**
+     * @return string
+     */
     private function convertStrFromServer($target)
     {
         if ($this->encode == self::SJIS) {

Spacing +1 added lines, -1 removed lines

@@ -327,7 +327,7 @@
     private function getFileList($nowDir)
     {
         $topDir = $this->getuserDataDir();
-        $filter = function (\SplFileInfo $file) use ($topDir) {
+        $filter = function(\SplFileInfo $file) use ($topDir) {
             $acceptPath = realpath($topDir);
             $targetPath = $file->getRealPath();
 

src/Eccube/Controller/Admin/Customer/CustomerController.php

Doc Comments -1 removed lines

@@ -283,7 +283,6 @@
      *
      * @Route("/%eccube_admin_route%/customer/export", name="admin_customer_export")
      *
-     * @param Application $app
      * @param Request $request
      *
      * @return StreamedResponse

Spacing +2 added lines, -2 removed lines

@@ -298,7 +298,7 @@ 
         $em->getConfiguration()->setSQLLogger(null);
 
         $response = new StreamedResponse();
-        $response->setCallback(function () use ($request) {
+        $response->setCallback(function() use ($request) {
             // CSV種別を元に初期化.
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_CUSTOMER);
 
@@ -311,7 +311,7 @@ 
 
             // データ行の出力.
             $this->csvExportService->setExportQueryBuilder($qb);
-            $this->csvExportService->exportData(function ($entity, $csvService) use ($request) {
+            $this->csvExportService->exportData(function($entity, $csvService) use ($request) {
                 $Csvs = $csvService->getCsvs();
 
                 /** @var $Customer \Eccube\Entity\Customer */

src/Eccube/Controller/Admin/Product/CsvImportController.php

Doc Comments +4 added lines, -3 removed lines

@@ -797,6 +797,7 @@ 
      *
      * @param $row
      * @param Product $Product
+     * @param CsvImportService $data
      */
     protected function createProductImage($row, Product $Product, $data, $headerByKey)
     {
@@ -843,7 +844,7 @@ 
      *
      * @param $row
      * @param Product $Product
-     * @param $data
+     * @param CsvImportService $data
      * @param $headerByKey
      */
     protected function createProductCategory($row, Product $Product, $data, $headerByKey)
@@ -963,7 +964,7 @@ 
      *
      * @param $row
      * @param Product $Product
-     * @param $data
+     * @param CsvImportService $data
      * @param $headerByKey
      * @param null $ClassCategory1
      * @param null $ClassCategory2
@@ -1115,7 +1116,7 @@ 
      * @param $row
      * @param Product $Product
      * @param ProductClass $ProductClass
-     * @param $data
+     * @param CsvImportService $data
      *
      * @return ProductClass
      */

Spacing +3 added lines, -3 removed lines

@@ -193,10 +193,10 @@ 
 
                         return $this->render($form, $headers);
                     }
-                    $getId = function ($item) {
+                    $getId = function($item) {
                         return $item['id'];
                     };
-                    $requireHeader = array_keys(array_map($getId, array_filter($headers, function ($value) {
+                    $requireHeader = array_keys(array_map($getId, array_filter($headers, function($value) {
                         return $value['required'];
                     })));
 
@@ -693,7 +693,7 @@ 
             throw new NotFoundHttpException();
         }
 
-        $response->setCallback(function () use ($request, $headers) {
+        $response->setCallback(function() use ($request, $headers) {
             // ヘッダ行の出力
             $row = [];
             foreach ($headers as $key => $value) {

src/Eccube/Controller/Admin/Product/ProductController.php

Doc Comments +1 added lines

@@ -989,6 +989,7 @@
      *
      * @param \Eccube\Entity\Product $Product
      * @param \Eccube\Entity\Category $Category
+     * @param integer $count
      *
      * @return \Eccube\Entity\ProductCategory
      */

Spacing +3 added lines, -3 removed lines

@@ -645,7 +645,7 @@ 
 
         // ツリー表示のため、ルートからのカテゴリを取得
         $TopCategories = $this->categoryRepository->getList(null);
-        $ChoicedCategoryIds = array_map(function ($Category) {
+        $ChoicedCategoryIds = array_map(function($Category) {
             return $Category->getId();
         }, $form->get('Category')->getData());
 
@@ -892,7 +892,7 @@ 
         $em->getConfiguration()->setSQLLogger(null);
 
         $response = new StreamedResponse();
-        $response->setCallback(function () use ($request) {
+        $response->setCallback(function() use ($request) {
             // CSV種別を元に初期化.
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_PRODUCT);
 
@@ -931,7 +931,7 @@ 
             // データ行の出力.
             $this->csvExportService->setExportQueryBuilder($qb);
 
-            $this->csvExportService->exportData(function ($entity, CsvExportService $csvService) use ($request) {
+            $this->csvExportService->exportData(function($entity, CsvExportService $csvService) use ($request) {
                 $Csvs = $csvService->getCsvs();
 
                 /** @var $Product \Eccube\Entity\Product */

src/Eccube/Controller/Admin/Product/TagController.php

Doc Comments -1 removed lines

@@ -53,7 +53,6 @@
      * @Template("@admin/Product/tag.twig")
      *
      * @param Request $request
-     * @param Tag|null $Tag
      *
      * @return array|\Symfony\Component\HttpFoundation\RedirectResponse
      */

src/Eccube/Controller/Admin/Setting/System/LogController.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
     /**
      * parse log file
      *
-     * @param $logFile
+     * @param string $logFile
      * @param $formData
      *
      * @return array

Spacing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
             return $log;
         }
 
-        foreach (array_reverse(file($logFile, FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES)) as $line) {
+        foreach (array_reverse(file($logFile, FILE_IGNORE_NEW_LINES|FILE_SKIP_EMPTY_LINES)) as $line) {
             // 上限に達した場合、処理を抜ける
             if (count($log) >= $formData['line_max']) {
                 break;

src/Eccube/Controller/Admin/Shipping/ShippingController.php

Doc Comments -1 removed lines

@@ -247,7 +247,6 @@
      * @Method("PUT")
      * @Route("/%eccube_admin_route%/shipping/notify_mail/{id}", requirements={"id" = "\d+"}, name="admin_shipping_notify_mail")
      *
-     * @param Request $request
      * @param Shipping $Shipping
      *
      * @return JsonResponse

src/Eccube/Controller/Admin/Store/TemplateController.php

Doc Comments +1 added lines, -1 removed lines

@@ -122,7 +122,7 @@
      * @param Request $request
      * @param \Eccube\Entity\Template $Template
      *
-     * @return mixed
+     * @return BinaryFileResponse
      */
     public function download(Request $request, \Eccube\Entity\Template $Template)
     {

Spacing +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
 
         // ダウンロード完了後にファイルを削除する.
         // http://stackoverflow.com/questions/15238897/removing-file-after-delivering-response-with-silex-symfony
-        $this->eventDispatcher->addListener(KernelEvents::TERMINATE, function () use (
+        $this->eventDispatcher->addListener(KernelEvents::TERMINATE, function() use (
             $tmpDir,
             $tarFile,
             $tarGzFile