Eccube\Controller\Mypage\MypageController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	169
Duplicated Lines	3.55 %

Coupling/Cohesion

Components	0
Dependencies	6

Test Coverage

Coverage

80%

6 Methods

Rating	Name	Duplication	Size	Complexity
B	order()	0	30	5
A	favorite()	0	22	2
A	delete()	0	13	2
B	login()	6	24	4
A	index()	0	20	1
A	history()	0	21	2

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Controller\Mypage;

use Eccube\Application;
use Eccube\Common\Constant;
use Eccube\Controller\AbstractController;
use Eccube\Exception\CartException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class MypageController extends AbstractController

Missing class doc comment

{
    public function login(Application $app, Request $request)

Missing function doc comment

    {
        if ($app->isGranted('IS_AUTHENTICATED_FULLY')) {
            return $app->redirect($app->url('mypage'));
        }

        /* @var $form \Symfony\Component\Form\FormInterface */
        $builder = $app['form.factory']
            ->createNamedBuilder('', 'customer_login');

        if ($app->isGranted('IS_AUTHENTICATED_REMEMBERED')) {

This code seems to be duplicated across your project.

            $Customer = $app->user();
            if ($Customer) {
                $builder->get('login_email')->setData($Customer->getEmail());
            }
        }

        $form = $builder->getForm();

        return $app->render('Mypage/login.twig', array(
            'error' => $app['security.last_error']($request),
            'form' => $form->createView(),
        ));
    }

    /**
     * @param Application $app
     * @param Request     $request
     *
     * @return string
     */
    public function index(Application $app, Request $request)
    {
        $Customer = $app['user'];

        $app['orm.em']
            ->getFilters()
            ->enable('incomplete_order_status_hidden');

        // paginator
        $qb = $app['eccube.repository.order']->getQueryBuilderByCustomer($Customer);
        $pagination = $app['paginator']()->paginate(
            $qb,
            $request->get('pageno', 1),
            $app['config']['search_pmax']
        );

        return $app->render('Mypage/index.twig', array(
            'pagination' => $pagination,
        ));
    }

    /**

Doc comment for parameter "$id" missing

     * @param Application $app
     * @param Request     $request
     *
     * @return string
     */
    public function history(Application $app, Request $request, $id)

The parameter $request is not used and could be removed.

    {

        /* @var $softDeleteFilter \Eccube\Doctrine\Filter\SoftDeleteFilter */
        $softDeleteFilter = $app['orm.em']->getFilters()->getFilter('soft_delete');
        $softDeleteFilter->setExcludes(array(
            'Eccube\Entity\ProductClass',
        ));

        $Order = $app['eccube.repository.order']->findOneBy(array(
            'id' => $id,
            'Customer' => $app->user(),
        ));
        if (!$Order) {
            throw new NotFoundHttpException();
        }

        return $app->render('Mypage/history.twig', array(
            'Order' => $Order,
        ));
    }

    /**
     * @param Application $app
     * @param Request     $request
     * @param id     $id

Expected 10 spaces after parameter type; 5 found

     *
     * @return string
     */
    public function order(Application $app, Request $request, $id)

The parameter $request is not used and could be removed.

    {

        $this->isTokenValid($app);

        $Customer = $app->user();

        /* @var $Order \Eccube\Entity\Order */
        $Order = $app['eccube.repository.order']->findOneBy(array(
            'id' => $id,
            'Customer' => $Customer,
        ));
        if (!$Order) {
            throw new NotFoundHttpException();
        }

        foreach ($Order->getOrderDetails() as $OrderDetail) {
            try {
                if ($OrderDetail->getProduct()) {
                    $app['eccube.service.cart']->addProduct($OrderDetail->getProductClass()->getId(), $OrderDetail->getQuantity())->save();
                } else {
                    $app->addRequestError('cart.product.delete');
                }
            } catch (CartException $e) {
                $app->addRequestError($e->getMessage());
            }
        }

        return $app->redirect($app->url('cart'));
    }

    /**
     * @param Application $app
     * @param Request     $request
     *
     * @return string
     */
    public function favorite(Application $app, Request $request)
    {
        $BaseInfo = $app['eccube.repository.base_info']->get();

        if ($BaseInfo->getOptionFavoriteProduct() == Constant::ENABLED) {
            $Customer = $app->user();

            // paginator
            $qb = $app['eccube.repository.product']->getFavoriteProductQueryBuilderByCustomer($Customer);
            $pagination = $app['paginator']()->paginate(
                $qb,
                $request->get('pageno', 1),
                $app['config']['search_pmax']
            );

            return $app->render('Mypage/favorite.twig', array(
                'pagination' => $pagination,
            ));
        } else {
            throw new NotFoundHttpException();
        }
    }

    /**

Doc comment for parameter "$id" missing

     * @param Application $app
     * @param Request     $request

There is no parameter named $request. Was it maybe removed?

Doc comment for parameter $request does not match actual variable name $id

     *
     * @return string
     */
    public function delete(Application $app, $id)
    {
        $this->isTokenValid($app);

        $Customer = $app->user();

        $Product = $app['eccube.repository.product']->find($id);
        if ($Product) {
            $app['eccube.repository.customer_favorite_product']->deleteFavorite($Customer, $Product);
        }

        return $app->redirect($app->url('mypage_favorite'));
    }
}