Eccube\Controller\Admin\Order\MailController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	274
Duplicated Lines	13.5 %

Coupling/Cohesion

Components	1
Dependencies	14

Test Coverage

Coverage

76.55%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	view()	0	26	3
A	createBody()	0	8	1
B	index()	18	89	5
C	mailAll()	19	99	7

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Controller\Admin\Order;

use Eccube\Controller\AbstractController;
use Eccube\Entity\MailHistory;
use Eccube\Entity\Order;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Admin\MailType;
use Eccube\Repository\MailHistoryRepository;
use Eccube\Repository\OrderRepository;
use Eccube\Service\MailService;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class MailController extends AbstractController

Missing class doc comment

{
    /**
     * @var MailService
     */
    protected $mailService;

    /**
     * @var MailHistoryRepository
     */
    protected $mailHistoryRepository;

    /**
     * @Inject(OrderRepository::class)
     *
     * @var OrderRepository
     */
    protected $orderRepository;

    /**
     * MailController constructor.
     *
     * @param MailService $mailService

Expected 11 spaces after parameter type; 1 found

     * @param MailHistoryRepository $mailHistoryRepository
     * @param OrderRepository $orderRepository

Expected 7 spaces after parameter type; 1 found

     */
    public function __construct(
        MailService $mailService,
        MailHistoryRepository $mailHistoryRepository,
        OrderRepository $orderRepository
    ) {
        $this->mailService = $mailService;
        $this->mailHistoryRepository = $mailHistoryRepository;
        $this->orderRepository = $orderRepository;
    }

    /**

Doc comment for parameter "$request" missing

Doc comment for parameter "$Order" missing

     * @Route("/%eccube_admin_route%/order/{id}/mail", requirements={"id" = "\d+"}, name="admin_order_mail")
     * @Template("@admin/Order/mail.twig")
     */

Missing @return tag in function comment

    public function index(Request $request, Order $Order)
    {
        $MailHistories = $this->mailHistoryRepository->findBy(['Order' => $Order]);

        $builder = $this->formFactory->createBuilder(MailType::class);

        $event = new EventArgs(
            [
                'builder' => $builder,
                'Order' => $Order,
                'MailHistories' => $MailHistories,
            ],
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_INDEX_INITIALIZE, $event);

        $form = $builder->getForm();

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);

            $mode = $request->get('mode');

            // テンプレート変更の場合は. バリデーション前に内容差し替え.
            if ($mode == 'change') {
                if ($form->get('template')->isValid()) {

This code seems to be duplicated across your project.

                    /** @var $data \Eccube\Entity\MailTemplate */
                    $MailTemplate = $form->get('template')->getData();
                    $form = $builder->getForm();
                    $event = new EventArgs(
                        [
                            'form' => $form,
                            'Order' => $Order,
                            'MailTemplate' => $MailTemplate,
                        ],
                        $request
                    );
                    $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_INDEX_CHANGE, $event);
                    $form->get('template')->setData($MailTemplate);
                    $form->get('mail_subject')->setData($MailTemplate->getMailSubject());
                    $form->get('mail_header')->setData($MailTemplate->getMailHeader());
                    $form->get('mail_footer')->setData($MailTemplate->getMailFooter());
                }
            } else {
                if ($form->isValid()) {
                    $data = $form->getData();
                    $body = $this->createBody($data['mail_header'], $data['mail_footer'], $Order);

                    // メール送信
                    $this->mailService->sendAdminOrderMail($Order, $data);

                    // 送信履歴を保存.
                    $MailTemplate = $form->get('template')->getData();
                    $MailHistory = new MailHistory();
                    $MailHistory
                        ->setMailSubject($data['mail_subject'])
                        ->setMailBody($body)
                        ->setSendDate(new \DateTime())
                        ->setOrder($Order);

                    $this->entityManager->persist($MailHistory);
                    $this->entityManager->flush($MailHistory);

The call to EntityManagerInterface::flush() has too many arguments starting with $MailHistory.

                    $event = new EventArgs(
                        [
                            'form' => $form,
                            'Order' => $Order,
                            'MailTemplate' => $MailTemplate,
                            'MailHistory' => $MailHistory,
                        ],
                        $request
                    );
                    $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_INDEX_COMPLETE, $event);

                    return $this->redirectToRoute('admin_order_page', ['page_no' => $this->session->get('eccube.admin.order.search.page_no', 1)]);
                }
            }
        }

        // 本文確認用
        $body = $this->createBody('', '', $Order);

        return [
            'form' => $form->createView(),
            'Order' => $Order,
            'MailHistories' => $MailHistories,
            'body' => $body,
        ];
    }

    /**

Doc comment for parameter "$request" missing

     * @Route("/%eccube_admin_route%/order/mail/view", name="admin_order_mail_view")
     * @Template("@admin/Order/mail_view.twig")
     */

Missing @return tag in function comment

    public function view(Request $request)
    {
        if (!$request->isXmlHttpRequest()) {
            throw new BadRequestHttpException();
        }

        $id = $request->get('id');
        $MailHistory = $this->mailHistoryRepository->find($id);

        if (null === $MailHistory) {
            throw new NotFoundHttpException('history not found.');
        }

        $event = new EventArgs(
            [
                'MailHistory' => $MailHistory,
            ],
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_VIEW_COMPLETE, $event);

        return [
            'mail_subject' => $MailHistory->getMailSubject(),
            'body' => $MailHistory->getMailBody(),
        ];
    }

    /**

Doc comment for parameter "$request" missing

     * @Route("/%eccube_admin_route%/order/mail/mail_all", name="admin_order_mail_all")
     * @Template("@admin/Order/mail_all.twig")
     */

Missing @return tag in function comment

    public function mailAll(Request $request)
    {
        $builder = $this->formFactory->createBuilder(MailType::class);

        $event = new EventArgs(
            [
                'builder' => $builder,
            ],
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_MAIL_ALL_INITIALIZE, $event);

        $form = $builder->getForm();

        $ids = '';

$ids is not used, you could remove the assignment.

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);

            $mode = $request->get('mode');

            $ids = $request->get('ids');

            // テンプレート変更の場合は. バリデーション前に内容差し替え.
            if ($mode == 'change') {
                if ($form->get('template')->isValid()) {

This code seems to be duplicated across your project.

                    /** @var $data \Eccube\Entity\MailTemplate */
                    $MailTemplate = $form->get('template')->getData();
                    $form = $builder->getForm();

                    $event = new EventArgs(
                        [
                            'form' => $form,
                            'MailTemplate' => $MailTemplate,
                        ],
                        $request
                    );
                    $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_MAIL_ALL_CHANGE, $event);

                    $form->get('template')->setData($MailTemplate);
                    $form->get('mail_subject')->setData($MailTemplate->getMailSubject());
                    $form->get('mail_header')->setData($MailTemplate->getMailHeader());
                    $form->get('mail_footer')->setData($MailTemplate->getMailFooter());
                }
            } else {
                if ($form->isValid()) {
                    $data = $form->getData();

                    $ids = explode(',', $ids);

                    foreach ($ids as $value) {
                        $Order = $this->orderRepository->find($value);

                        $body = $this->createBody($data['mail_header'], $data['mail_footer'], $Order);

                        // メール送信
                        $this->mailService->sendAdminOrderMail($Order, $data);

$Order is of type object|null, but the function expects a object<Eccube\Entity\Order>.

                        // 送信履歴を保存.
                        $MailHistory = new MailHistory();
                        $MailHistory
                            ->setMailSubject($data['mail_subject'])
                            ->setMailBody($body)
                            ->setSendDate(new \DateTime())
                            ->setOrder($Order);
                        $this->entityManager->persist($MailHistory);
                    }

                    $this->entityManager->flush($MailHistory);

The variable $MailHistory does not seem to be defined for all execution paths leading up to this point.

The call to EntityManagerInterface::flush() has too many arguments starting with $MailHistory.

                    $event = new EventArgs(
                        [
                            'form' => $form,
                            'MailHistory' => $MailHistory,
                        ],
                        $request
                    );
                    $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_ORDER_MAIL_MAIL_ALL_COMPLETE, $event);

                    return $this->redirectToRoute('admin_order_page', ['page_no' => $this->session->get('eccube.admin.order.search.page_no', 1)]);
                }
            }
        } else {
            $ids = implode(',', (array) $request->get('ids'));
        }

        // 本文確認用
        $body = '';
        if ($ids != '') {
            $idArray = explode(',', $ids);
            $Order = $this->orderRepository->find($idArray[0]);
            $body = $this->createBody('', '', $Order);
        }

        return [
            'form' => $form->createView(),
            'ids' => $ids,
            'body' => $body,
        ];
    }

    private function createBody($header, $footer, $Order)
    {
        return $this->renderView('@admin/Mail/order.twig', [
            'header' => $header,
            'footer' => $footer,
            'Order' => $Order,
        ]);
    }
}