TaxRuleRepository::getByRule()   F
last analyzed

Complexity

Conditions 27
Paths > 20000

Size

Total Lines 141
Code Lines 85

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 46
CRAP Score 49.44

Importance

Changes 0
Metric Value
cc 27
eloc 85
nc 83269
nop 4
dl 0
loc 141
rs 2
c 0
b 0
f 0
ccs 46
cts 67
cp 0.6866
crap 49.44

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
/*
3
 * This file is part of EC-CUBE
4
 *
5
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6
 *
7
 * http://www.lockon.co.jp/
8
 *
9
 * This program is free software; you can redistribute it and/or
10
 * modify it under the terms of the GNU General Public License
11
 * as published by the Free Software Foundation; either version 2
12
 * of the License, or (at your option) any later version.
13
 *
14
 * This program is distributed in the hope that it will be useful,
15
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
 * GNU General Public License for more details.
18
 *
19
 * You should have received a copy of the GNU General Public License
20
 * along with this program; if not, write to the Free Software
21
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
22
 */
23
24
25
namespace Eccube\Repository;
26
27
use Doctrine\ORM\EntityRepository;
28
use Doctrine\ORM\NoResultException;
29
use Eccube\Common\Constant;
30
31
/**
32
 * TaxRuleRepository
33
 *
34
 * This class was generated by the Doctrine ORM. Add your own custom
35
 * repository methods below.
36
 */
37
class TaxRuleRepository extends EntityRepository
38
{
39
    private $rules = array();
40
41
    protected $app;
42
43 625
    public function setApplication($app)
0 ignored issues
show
introduced by
Missing function doc comment
Loading history...
44
    {
45 625
        $this->app = $app;
46 625
    }
47
48 1
    public function newTaxRule()
0 ignored issues
show
introduced by
Missing function doc comment
Loading history...
49
    {
50
        $TaxRule = new \Eccube\Entity\TaxRule();
51 1
        $CalcRule = $this->getEntityManager()
52 1
            ->getRepository('Eccube\Entity\Master\Taxrule')
53
            ->find(1);
54
        $TaxRule->setCalcRule($CalcRule);
55
        $TaxRule->setTaxAdjust(0);
56
        $TaxRule->setDelFlg(0);
57
58 1
        return $TaxRule;
59
    }
60
61
    /**
62
     * 現在有効な税率設定情報を返す
63
     *
64
     * @param  int|null|\Eccube\Entity\Product        $Product      商品
65
     * @param  int|null|\Eccube\Entity\ProductClass   $ProductClass 商品規格
66
     * @param  int|null|\Eccube\Entity\Master\Pref    $Pref         都道府県
67
     * @param  int|null|\Eccube\Entity\Master\Country $Country      国
68
     * @return \Eccube\Entity\TaxRule                 税設定情報
69
     *
70
     * @throws NoResultException
71
     */
72 225
    public function getByRule($Product = null, $ProductClass = null, $Pref = null, $Country = null)
73
    {
74 2
        if (!$this->app) {
75
            throw new \LogicException();
76
        }
77
78
        // Pref Country 設定
79
        if (!$Pref && !$Country && $this->app['security']->getToken() && $this->app['security']->isGranted('ROLE_USER')) {
80
            /* @var $Customer \Eccube\Entity\Customer */
81
            $Customer = $this->app['security']->getToken()->getUser();
82
            $Pref = $Customer->getPref();
83
            $Country = $Customer->getCountry();
84
        }
85
86
        // 商品単位税率設定がOFFの場合
87
        /** @var $BaseInfo \Eccube\Entity\BaseInfo */
88
        $BaseInfo = $this->app['eccube.repository.base_info']->get();
89
        if ($BaseInfo->getOptionProductTaxRule() !== Constant::ENABLED) {
90 2
            $Product = null;
91 2
            $ProductClass = null;
92
        }
93
94
        // Cache Key 設定
95 2
        if ($Product instanceof \Eccube\Entity\Product) {
0 ignored issues
show
Bug introduced by
The class Eccube\Entity\Product does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
96
            $productId = $Product->getId();
97 2
        } elseif ($Product) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $Product of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
98
            $productId = $Product;
99
        } else {
100 2
            $productId = '0';
101 2
        }
102 2
        if ($ProductClass instanceof \Eccube\Entity\ProductClass) {
0 ignored issues
show
Bug introduced by
The class Eccube\Entity\ProductClass does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
103
            $productClassId = $ProductClass->getId();
104 2
        } elseif ($ProductClass) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $ProductClass of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
105
            $productClassId = $ProductClass;
106
        } else {
107 2
            $productClassId = '0';
108 1
        }
109 2
        if ($Pref instanceof \Eccube\Entity\Master\Pref) {
0 ignored issues
show
Bug introduced by
The class Eccube\Entity\Master\Pref does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
110
            $prefId = $Pref->getId();
111 2
        } elseif ($Pref) {
112
            $prefId = $Pref;
113
        } else {
114 2
            $prefId = '0';
115 1
        }
116 2
        if ($Country instanceof \Eccube\Entity\Master\Country) {
0 ignored issues
show
Bug introduced by
The class Eccube\Entity\Master\Country does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
117
            $countryId = $Country->getId();
118 2
        } elseif ($Country) {
119
            $countryId = $Country;
120
        } else {
121 2
            $countryId = '0';
122 2
        }
123 2
        $cacheKey = $productId.':'.$productClassId.':'.$prefId.':'.$countryId;
124
125
        // すでに取得している場合はキャッシュから
126 2
        if (isset($this->rules[$cacheKey])) {
127 12
            return $this->rules[$cacheKey];
128
        }
129
130 225
        $parameters = array();
131 225
        $qb = $this->createQueryBuilder('t')
132
            ->where('t.apply_date < :apply_date');
133
        $parameters[':apply_date'] = new \DateTime();
134
135 225
        // Pref
136
        if ($Pref) {
137 37
            $qb->andWhere('t.Pref IS NULL OR t.Pref = :Pref');
138
            $parameters['Pref'] = $Pref;
139
        } else {
140 37
            $qb->andWhere('t.Pref IS NULL');
141
        }
142
143 225
        // Country
144
        if ($Country) {
145 2
            $qb->andWhere('t.Country IS NULL OR t.Country = :Country');
146
            $parameters['Country'] = $Country;
147
        } else {
148 2
            $qb->andWhere('t.Country IS NULL');
149
        }
150
151
        /*
152
         * Product, ProductClass が persist される前に TaxRuleEventSubscriber によってアクセスされる
153
         * 場合があるため、ID の存在もチェックする.
154
         * https://github.com/EC-CUBE/ec-cube/issues/677
155
         */
156
157 225
        // Product
158
        if ($Product && $productId > 0) {
159 2
            $qb->andWhere('t.Product IS NULL OR t.Product = :Product');
160
            $parameters['Product'] = $Product;
161
        } else {
162 2
            $qb->andWhere('t.Product IS NULL');
163
        }
164
165 225
        // ProductClass
166
        if ($ProductClass && $productClassId > 0) {
167 1
            $qb->andWhere('t.ProductClass IS NULL OR t.ProductClass = :ProductClass');
168
            $parameters['ProductClass'] = $ProductClass;
169
        } else {
170 1
            $qb->andWhere('t.ProductClass IS NULL');
171
        }
172
173 225
        $TaxRules = $qb
174 225
            ->setParameters($parameters)
175 225
            ->orderBy('t.apply_date', 'DESC') // 実際は usort() でソートする
176
            ->getQuery()
177
            ->getResult();
178
179
        // 地域設定を優先するが、システムパラメーターなどに設定を持っていくか
180
        // 後に書いてあるほど優先される
181 225
        $priorityKeys = explode(',', $this->app['config']['tax_rule_priority']);
0 ignored issues
show
Unused Code introduced by
$priorityKeys is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
182
        $priorityKeys = array();
183
        foreach (explode(',', $this->app['config']['tax_rule_priority']) as $key) {
184
            $priorityKeys[] = str_replace('_', '', preg_replace('/_id\z/', '', $key));
185
        }
186
187 225
        foreach ($TaxRules as $TaxRule) {
188
            $rank = 0;
189
            foreach ($priorityKeys as $index => $key) {
190
                $arrayProperties = array_change_key_case($TaxRule->toArray());
191
                if ($arrayProperties[$key]) {
0 ignored issues
show
Coding Style introduced by
Blank line found at start of control structure
Loading history...
192
193 4
                    // 配列の数値添字を重みとして利用する
194
                    $rank += 1 << ($index + 1);
195
                }
196
            }
197
            $TaxRule->setRank($rank);
198
        }
199
200
        // 適用日降順, rank 降順にソートする
201
        usort($TaxRules, function($a, $b) {
0 ignored issues
show
Coding Style introduced by
Expected 1 space after FUNCTION keyword; 0 found
Loading history...
202
            return $a->compareTo($b);
203
        });
204 225
205 225
        if (!empty($TaxRules)) {
206
            $this->rules[$cacheKey] = $TaxRules[0];
207 225
208
            return $TaxRules[0];
209
        } else {
210
            throw new NoResultException();
211
        }
212
    }
213
214
    /**
215
     * getList
216
     *
217
     * @return array|null
218 3
     */
219
    public function getList()
220 3
    {
221 3
        $qb = $this->createQueryBuilder('t')
222
            ->orderBy('t.apply_date', 'DESC')
223
            ->where('t.Product IS NULL AND t.ProductClass IS NULL');
224 3
        $TaxRules = $qb
225
            ->getQuery()
226
            ->getResult();
227 3
228
        return $TaxRules;
229
    }
230
231
    /**
232
     * getById
233
     *
234
     * @param  int   $id
0 ignored issues
show
introduced by
Expected 1 spaces after parameter type; 3 found
Loading history...
235
     * @return array
236 1
     */
237
    public function getById($id)
238
    {
239
        $criteria = array(
240 1
            'id' => $id,
241
        );
242
243
        return $this->findOneBy($criteria);
244
    }
245
246
    /**
247
     * getByTime
248
     *
249
     * @param  string $applyDate
250
     * @return mixed
251
     */
252
    public function getByTime($applyDate)
253
    {
254
        $criteria = array(
255
            'apply_date' => $applyDate,
256
        );
257
258
        return $this->findOneBy($criteria);
259
    }
260
261
    /**
262
     * 税規約の削除.
263
     *
264
     * @param  int|\Eccube\Entity\TaxRule $TaxRule 税規約
265
     * @return void
266
     * @throws NoResultException
267 2
     */
268
    public function delete($TaxRule)
269 2
    {
270
        if (!$TaxRule instanceof \Eccube\Entity\TaxRule) {
0 ignored issues
show
Bug introduced by
The class Eccube\Entity\TaxRule does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
271
            $TaxRule = $this->find($TaxRule);
272 2
        }
273
        if (!$TaxRule) {
274
            throw new NoResultException;
0 ignored issues
show
introduced by
Use parentheses when instantiating classes
Loading history...
275
        }
276
        $TaxRule->setDelFlg(1);
277
        $em = $this->getEntityManager();
278
        $em->persist($TaxRule);
279 2
        $em->flush();
280
    }
281
282
    /**
283
     * TaxRule のキャッシュをクリアする.
284
     *
285
     * getByRule() をコールすると、結果をキャッシュし、2回目以降はデータベースへアクセスしない.
286
     * このメソッドをコールすると、キャッシュをクリアし、再度データベースを参照して結果を取得する.
287 7
     */
288
    public function clearCache()
289 7
    {
290 7
        $this->rules = array();
291
    }
292
}
293