UploadedFileValidator - Code Metrics - Inspection of "Merge branch 'validators' into development" - nafigator/Veles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 604b38...f68d97 )

by Alexander

created 2015-12-11 13:43 UTC

UploadedFileValidator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
lcom	1
cbo	0
dl	0
loc	66
ccs	23
cts	23
cp	1
rs	10
c	1
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	check()	20	3
A	getMimeByExtension()	11	2

<?php
/**
 * Class for uploaded file validation
 *
 * @file      UploadedFileValidator.php
 *
 * PHP version 5.4+
 *
 * @author    Yancharuk Alexander <alex at itvault dot info>
 * @copyright © 2012-2015 Alexander Yancharuk <alex at itvault at info>
 * @date      2013-08-03 11:04
 * @license   The BSD 3-Clause License
 *            <https://tldrlegal.com/license/bsd-3-clause-license-(revised)>
 */

namespace Veles\Validators;

/**
 * Class UploadedFileValidator
 *
 * @author  Yancharuk Alexander <alex at itvault dot info>
 */
class UploadedFileValidator implements iValidator
{
	/** @var array */
	protected $allowed_extensions = [];

	/**
	 * Creates validator instance
	 *
	 * @param string $ext_string List of valid extension separated by comma
	 */
	public function __construct($ext_string = 'gif,jpg,jpeg,png')
	{
		$extensions = explode(',', $ext_string);

		foreach ($extensions as $extension) {
			$this->allowed_extensions[trim($extension)] = true;
		}
	}

	/**
	 * Uploaded file validation
	 *
	 * @param mixed $value Index name in $_FILE array
	 *
	 * @return bool
	 */
	public function check($value)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		$file_name = strtolower($_FILES[$value]['name']);

		if (false === strpos($file_name, '.')) {
			return false;
		}

		$array    = explode('.', $file_name);
		$file_ext = strtolower(end($array));

		if (!isset($this->allowed_extensions[$file_ext])) {
			return false;
		}

		$real_mime = (new \finfo(FILEINFO_MIME))
			->file($_FILES[$value]['tmp_name']);

		return $real_mime === $this->getMimeByExtension($file_ext);
	}

	/**
	 * Get MIME type for given extension
	 *
	 * @param string $ext File extension
	 *
	 * @return string
	 */
	public function getMimeByExtension($ext)
	{
		$mime_types = [
			'gif'  => 'image/gif; charset=binary',
			'png'  => 'image/png; charset=binary',
			'jpeg' => 'image/jpeg; charset=binary',
			'jpg'  => 'image/jpeg; charset=binary'
		];

		return isset($mime_types[$ext]) ? $mime_types[$ext] : '';
	}
}


1		<?php
2		/**
3		* Class for uploaded file validation
4		*
5		* @file UploadedFileValidator.php
6		*
7		* PHP version 5.4+
8		*
9		* @author Yancharuk Alexander <alex at itvault dot info>
10		* @copyright © 2012-2015 Alexander Yancharuk <alex at itvault at info>
11		* @date 2013-08-03 11:04
12		* @license The BSD 3-Clause License
13		* <https://tldrlegal.com/license/bsd-3-clause-license-(revised)>
14		*/
15
16		namespace Veles\Validators;
17
18		/**
19		* Class UploadedFileValidator
20		*
21		* @author Yancharuk Alexander <alex at itvault dot info>
22		*/
23		class UploadedFileValidator implements iValidator
24		{
25		/** @var array */
26		protected $allowed_extensions = [];
27
28		/**
29		* Creates validator instance
30		*
31		* @param string $ext_string List of valid extension separated by comma
32		*/
33	2	public function __construct($ext_string = 'gif,jpg,jpeg,png')
34		{
35	2	$extensions = explode(',', $ext_string);
36
37	2	foreach ($extensions as $extension) {
38	2	$this->allowed_extensions[trim($extension)] = true;
39	2	}
40	2	}
41
42		/**
43		* Uploaded file validation
44		*
45		* @param mixed $value Index name in $_FILE array
46		*
47		* @return bool
48		*/
49	6	public function check($value)
		1 ignored issue – show Coding Style introduced 2015-12-08 19:18 UTC by Report Bug Copy Issue Report `check` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
50		{
51	6	$file_name = strtolower($_FILES[$value]['name']);
52
53	6	if (false === strpos($file_name, '.')) {
54	1	return false;
55		}
56
57	5	$array = explode('.', $file_name);
58	5	$file_ext = strtolower(end($array));
59
60	5	if (!isset($this->allowed_extensions[$file_ext])) {
61	1	return false;
62		}
63
64	4	$real_mime = (new \finfo(FILEINFO_MIME))
65	4	->file($_FILES[$value]['tmp_name']);
66
67	4	return $real_mime === $this->getMimeByExtension($file_ext);
68		}
69
70		/**
71		* Get MIME type for given extension
72		*
73		* @param string $ext File extension
74		*
75		* @return string
76		*/
77	4	public function getMimeByExtension($ext)
78		{
79		$mime_types = [
80	4	'gif' => 'image/gif; charset=binary',
81	4	'png' => 'image/png; charset=binary',
82	4	'jpeg' => 'image/jpeg; charset=binary',
83		'jpg' => 'image/jpeg; charset=binary'
84	4	];
85
86	4	return isset($mime_types[$ext]) ? $mime_types[$ext] : '';
87		}
88		}
89

nafigator / Veles

Push — development ( 604b38...f68d97 )

UploadedFileValidator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like