Issues in Request.php (master) - Issues in master - nabble/ajde - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1919)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Ajde/Http/Request.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class Ajde_Http_Request extends Ajde_Object_Standard
{
    const TYPE_STRING = 1;
    const TYPE_HTML = 2;
    const TYPE_INTEGER = 3;
    const TYPE_FLOAT = 4;
    const TYPE_RAW = 5;

    const FORM_MIN_TIME = 0;    // minimum time to have a post form returned (seconds)
    const FORM_MAX_TIME = 3600;    // timeout of post forms (seconds)

    /**
     * @var Ajde_Core_Route
     */
    protected $_route = null;
    protected $_postData = [];

    /**
     * @throws Ajde_Core_Exception_Security
     *
     * @return Ajde_Http_Request
     */
    public static function fromGlobal()
    {
        $instance = new self();
        $post = self::globalPost();
        if (!empty($post) && self::requirePostToken() && !self::_isWhitelisted()) {

            // Measures against CSRF attacks
            $session = new Ajde_Session('AC.Form');
            if (!isset($post['_token']) || !$session->has('formTime')) {
                $exception = new Ajde_Core_Exception_Security('No form token received or no form time set, bailing out to prevent CSRF attack');
                if (config('app.debug') === true) {

                    Ajde_Http_Response::setResponseType(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
                    throw $exception;
                } else {
                    // Prevent inf. loops
                    unset($_POST);
                    unset($_REQUEST);
                    // Rewrite
                    Ajde_Exception_Log::logException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    Ajde_Http_Response::dieOnCode(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
                }
            }

            $formToken = $post['_token'];
            if (!self::verifyFormToken($formToken) || !self::verifyFormTime()) {
                // TODO:
                if (!self::verifyFormToken($formToken)) {
                    $exception = new Ajde_Core_Exception_Security('No matching form token (got '.self::_getHashFromSession($formToken).', expected '.self::_tokenHash($formToken).'), bailing out to prevent CSRF attack');
                } else {
                    $exception = new Ajde_Core_Exception_Security('Form token timed out, bailing out to prevent CSRF attack');
                }
                if (config('app.debug') === true) {

                    Ajde_Http_Response::setResponseType(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
                    throw $exception;
                } else {
                    // Prevent inf. loops
                    unset($_POST);
                    unset($_REQUEST);
                    // Rewrite
                    Ajde_Exception_Log::logException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    Ajde_Http_Response::dieOnCode(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
                }
            }
        }

        // Security measure, protect $_POST
        $global = self::globalGet();
        foreach ($global as $key => $value) {
            $instance->set($key, $value);
        }

        $instance->_postData = self::globalPost();
        if (!empty($instance->_postData)) {
            Ajde_Cache::getInstance()->disable();
        }

        return $instance;
    }

    public static function getRefferer()
    {
        return @$_SERVER['HTTP_REFERER'];
    }

    public static function globalGet()
    {
        return isset($_GET) ? $_GET : (isset($_REQUEST) ? $_REQUEST : []);
    }

    public static function globalPost()
    {
        return isset($_POST) ? $_POST : (isset($_REQUEST) ? $_REQUEST : []);
    }

    // From http://stackoverflow.com/a/10372836/938297
    public static function getRealIp()
    {
        if (!empty($_SERVER['HTTP_CLIENT_IP'])) {
            return $_SERVER['HTTP_CLIENT_IP'];
        } else {
            if (!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
                return $_SERVER['HTTP_X_FORWARDED_FOR'];
            } else {
                return $_SERVER['REMOTE_ADDR'];
            }
        }
    }

    /**
     * Security.
     */
    private static function autoEscapeString()
    {
        return config('security.autoEscapeString') == true;
    }

    private static function autoCleanHtml()
    {
        return config('security.autoCleanHtml') == true;
    }

    private static function requirePostToken()
    {
        return config('security.csrf.requirePostToken') == true;
    }

    /**
     * CSRF prevention token.
     */
    public static function getFormToken()
    {
        static $token;
        if (!isset($token)) {
            Ajde_Cache::getInstance()->disable();
            $token = md5(uniqid(rand(), true));
            $session = new Ajde_Session('AC.Form');
            $tokenDictionary = self::_getTokenDictionary($session);
            $tokenDictionary[$token] = self::_tokenHash($token);
            $session->set('formTokens', $tokenDictionary);
        }
        self::markFormTime();

        return $token;
    }

    public static function verifyFormToken($requestToken)
    {
        return self::_tokenHash($requestToken) === self::_getHashFromSession($requestToken);
    }

    private static function _tokenHash($token)
    {
        return md5($token.$_SERVER['REMOTE_ADDR'].$_SERVER['HTTP_USER_AGENT'].config('security.secret'));
    }

    private static function _isWhitelisted()
    {
        $route = issetor($_GET['_route'], false);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        foreach (config('security.csrf.postWhitelistRoutes') as $whitelist) {
            if (stripos($route, $whitelist) === 0) {
                return true;
            }
        }

        return false;
    }

    private static function _getTokenDictionary(&$session = null)
    {
        if (!isset($session)) {
            $session = new Ajde_Session('AC.Form');
        }
        $tokenDictionary = ($session->has('formTokens') ? $session->get('formTokens') : []);
        if (!is_array($tokenDictionary)) {
            $tokenDictionary = [];
        }

        return $tokenDictionary;
    }

    private static function _getHashFromSession($token)
    {
        $tokenDictionary = self::_getTokenDictionary();

        return issetor($tokenDictionary[$token], '');
    }

    public static function markFormTime()
    {
        $time = time();
        $session = new Ajde_Session('AC.Form');
        $session->set('formTime', $time);

        return $time;
    }

    public static function verifyFormTime()
    {
        $session = new Ajde_Session('AC.Form');
        $sessionTime = $session->get('formTime');
        if ((time() - $sessionTime) < self::FORM_MIN_TIME ||
            (time() - $sessionTime) > self::FORM_MAX_TIME
        ) {
            return false;
        } else {
            return true;
        }
    }

    public static function isAjax()
    {
        return !empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest';
    }

    /**
     * @return string Lowercase request method
     */
    public static function method()
    {
        return strtolower($_SERVER['REQUEST_METHOD']);
    }

    /**
     * Helpers.
     */
    public function get($key)
    {
        return $this->getParam($key);
    }

    public function getParam($key, $default = null, $type = self::TYPE_STRING, $post = false)
    {
        $data = $this->_data;
        if ($post === true) {
            $data = $this->getPostData();
        }
        if (isset($data[$key])) {
            switch ($type) {
                case self::TYPE_HTML:
                    if ($this->autoCleanHtml() === true) {
                        return Ajde_Component_String::clean($data[$key]);
                    } else {
                        return $data[$key];
                    }
                    break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                case self::TYPE_INTEGER:
                    return (int) $data[$key];
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                case self::TYPE_FLOAT:
                    return (float) $data[$key];
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                case self::TYPE_RAW:
                    return $data[$key];
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                case self::TYPE_STRING:
                default:
                    if ($this->autoEscapeString() === true) {
                        if (is_array($data[$key])) {
                            array_walk($data[$key], ['Ajde_Component_String', 'escape']);

                            return $data[$key];
                        } else {
                            return Ajde_Component_String::escape($data[$key]);
                        }
                    } else {
                        return $data[$key];
                    }
            }
        } else {
            if (isset($default)) {
                return $default;
            } else {
                // TODO:
                throw new Ajde_Exception("Parameter '$key' not present in request and no default value given");
            }
        }
    }

    public function getStr($key, $default)
    {
        return $this->getString($key, $default);
    }

    public function getInt($key, $default)
    {
        return $this->getInteger($key, $default);
    }

    public function getString($key, $default = null)
    {
        return $this->getParam($key, $default, self::TYPE_STRING);
    }

    public function getHtml($key, $default = null)
    {
        return $this->getParam($key, $default, self::TYPE_HTML);
    }

    public function getInteger($key, $default = null)
    {
        return $this->getParam($key, $default, self::TYPE_INTEGER);
    }

    public function getFloat($key, $default = null)
    {
        return $this->getParam($key, $default, self::TYPE_FLOAT);
    }

    public function getRaw($key, $default = null)
    {
        return $this->getParam($key, $default, self::TYPE_RAW);
    }

    /**
     * FORM.
     */
    public function getCheckbox($key, $post = true)
    {
        if ($this->getParam($key, false, self::TYPE_RAW, $post) === 'on') {
            return true;
        } else {
            return false;
        }
    }

    /**
     * POST.
     */
    public function getPostData()
    {
        return $this->_postData;
    }

    public function getPostParam($key, $default = null, $type = self::TYPE_STRING)
    {
        return $this->getParam($key, $default, $type, true);
    }

    public function getPostRaw($key, $default = null)
    {
        return $this->getParam($key, $default, self::TYPE_RAW, true);
    }

    public function hasPostParam($key)
    {
        return array_key_exists($key, $this->_postData);
    }

    /**
     * @return Ajde_Core_Route
     */
    public function getRoute()
    {
        if (!isset($this->_route)) {
            $route = $this->extractRoute();
            $this->_route = new Ajde_Core_Route($route);
            foreach ($this->_route->values() as $part => $value) {
                if (!$this->hasNotEmpty($part)) {
                    $this->set($part, $value);
                }
            }
        }

        return $this->_route;
    }

    private function extractRoute()
    {
        // Strip query string
        $URIComponents = explode('?', $_SERVER['REQUEST_URI']);
        $requestURI = reset($URIComponents);

        // Route is the part after our base path
        $baseURI = str_replace('index.php', '', $_SERVER['PHP_SELF']);

        // Strip public from request and base
        $requestURI = str_replace(PUBLIC_DIR, '', $requestURI);
        $baseURI = str_replace(PUBLIC_DIR, '', $baseURI);

        // TODO: potential bug when baseuri is something like /node (now all requests with /node/node will return '')
        return $baseURI !== '/' ? str_replace($baseURI, '', $requestURI) : trim($requestURI, '/');
    }

    public function initRoute()
    {
        $route = $this->getRoute();

        return $route;
    }

    public static function getClientIP()
    {
        if (array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER)) {
            return $_SERVER['HTTP_X_FORWARDED_FOR'];
        } else {
            if (array_key_exists('REMOTE_ADDR', $_SERVER)) {
                return $_SERVER['REMOTE_ADDR'];
            } else {
                if (array_key_exists('HTTP_CLIENT_IP', $_SERVER)) {
                    return $_SERVER['HTTP_CLIENT_IP'];
                }
            }
        }

        return '';
    }
}


1		<?php
2
3		class Ajde_Http_Request extends Ajde_Object_Standard
4		{
5		const TYPE_STRING = 1;
6		const TYPE_HTML = 2;
7		const TYPE_INTEGER = 3;
8		const TYPE_FLOAT = 4;
9		const TYPE_RAW = 5;
10
11		const FORM_MIN_TIME = 0; // minimum time to have a post form returned (seconds)
12		const FORM_MAX_TIME = 3600; // timeout of post forms (seconds)
13
14		/**
15		* @var Ajde_Core_Route
16		*/
17		protected $_route = null;
18		protected $_postData = [];
19
20		/**
21		* @throws Ajde_Core_Exception_Security
22		*
23		* @return Ajde_Http_Request
24		*/
25		public static function fromGlobal()
26		{
27		$instance = new self();
28		$post = self::globalPost();
29		if (!empty($post) && self::requirePostToken() && !self::_isWhitelisted()) {
30
31		// Measures against CSRF attacks
32		$session = new Ajde_Session('AC.Form');
33		if (!isset($post['_token']) \|\| !$session->has('formTime')) {
34		$exception = new Ajde_Core_Exception_Security('No form token received or no form time set, bailing out to prevent CSRF attack');
35	View Code Duplication	if (config('app.debug') === true) {
		0 ignored issues – show Duplication introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		Ajde_Http_Response::setResponseType(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
37		throw $exception;
38		} else {
39		// Prevent inf. loops
40		unset($_POST);
41		unset($_REQUEST);
42		// Rewrite
43		Ajde_Exception_Log::logException($exception);
		0 ignored issues – show Documentation introduced 2016-09-18 20:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$exception` is of type `object<Ajde_Core_Exception_Security>`, but the function expects a `object<Throwable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44		Ajde_Http_Response::dieOnCode(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
45		}
46		}
47
48		$formToken = $post['_token'];
49		if (!self::verifyFormToken($formToken) \|\| !self::verifyFormTime()) {
50		// TODO:
51		if (!self::verifyFormToken($formToken)) {
52		$exception = new Ajde_Core_Exception_Security('No matching form token (got '.self::_getHashFromSession($formToken).', expected '.self::_tokenHash($formToken).'), bailing out to prevent CSRF attack');
53		} else {
54		$exception = new Ajde_Core_Exception_Security('Form token timed out, bailing out to prevent CSRF attack');
55		}
56	View Code Duplication	if (config('app.debug') === true) {
		0 ignored issues – show Duplication introduced 2016-09-18 20:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		Ajde_Http_Response::setResponseType(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
58		throw $exception;
59		} else {
60		// Prevent inf. loops
61		unset($_POST);
62		unset($_REQUEST);
63		// Rewrite
64		Ajde_Exception_Log::logException($exception);
		0 ignored issues – show Documentation introduced 2016-09-18 20:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$exception` is of type `object<Ajde_Core_Exception_Security>`, but the function expects a `object<Throwable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
65		Ajde_Http_Response::dieOnCode(Ajde_Http_Response::RESPONSE_TYPE_FORBIDDEN);
66		}
67		}
68		}
69
70		// Security measure, protect $_POST
71		$global = self::globalGet();
72		foreach ($global as $key => $value) {
73		$instance->set($key, $value);
74		}
75
76		$instance->_postData = self::globalPost();
77		if (!empty($instance->_postData)) {
78		Ajde_Cache::getInstance()->disable();
79		}
80
81		return $instance;
82		}
83
84		public static function getRefferer()
85		{
86		return @$_SERVER['HTTP_REFERER'];
87		}
88
89		public static function globalGet()
90		{
91		return isset($_GET) ? $_GET : (isset($_REQUEST) ? $_REQUEST : []);
92		}
93
94		public static function globalPost()
95		{
96		return isset($_POST) ? $_POST : (isset($_REQUEST) ? $_REQUEST : []);
97		}
98
99		// From http://stackoverflow.com/a/10372836/938297
100		public static function getRealIp()
101		{
102		if (!empty($_SERVER['HTTP_CLIENT_IP'])) {
103		return $_SERVER['HTTP_CLIENT_IP'];
104		} else {
105		if (!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
106		return $_SERVER['HTTP_X_FORWARDED_FOR'];
107		} else {
108		return $_SERVER['REMOTE_ADDR'];
109		}
110		}
111		}
112
113		/**
114		* Security.
115		*/
116		private static function autoEscapeString()
117		{
118		return config('security.autoEscapeString') == true;
119		}
120
121		private static function autoCleanHtml()
122		{
123		return config('security.autoCleanHtml') == true;
124		}
125
126		private static function requirePostToken()
127		{
128		return config('security.csrf.requirePostToken') == true;
129		}
130
131		/**
132		* CSRF prevention token.
133		*/
134		public static function getFormToken()
135		{
136		static $token;
137		if (!isset($token)) {
138		Ajde_Cache::getInstance()->disable();
139		$token = md5(uniqid(rand(), true));
140		$session = new Ajde_Session('AC.Form');
141		$tokenDictionary = self::_getTokenDictionary($session);
142		$tokenDictionary[$token] = self::_tokenHash($token);
143		$session->set('formTokens', $tokenDictionary);
144		}
145		self::markFormTime();
146
147		return $token;
148		}
149
150		public static function verifyFormToken($requestToken)
151		{
152		return self::_tokenHash($requestToken) === self::_getHashFromSession($requestToken);
153		}
154
155		private static function _tokenHash($token)
156		{
157		return md5($token.$_SERVER['REMOTE_ADDR'].$_SERVER['HTTP_USER_AGENT'].config('security.secret'));
158		}
159
160		private static function _isWhitelisted()
161		{
162		$route = issetor($_GET['_route'], false);
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$route` is correct as `issetor($_GET['_route'], false)` (which targets `issetor()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
163		foreach (config('security.csrf.postWhitelistRoutes') as $whitelist) {
164		if (stripos($route, $whitelist) === 0) {
165		return true;
166		}
167		}
168
169		return false;
170		}
171
172		private static function _getTokenDictionary(&$session = null)
173		{
174		if (!isset($session)) {
175		$session = new Ajde_Session('AC.Form');
176		}
177		$tokenDictionary = ($session->has('formTokens') ? $session->get('formTokens') : []);
178		if (!is_array($tokenDictionary)) {
179		$tokenDictionary = [];
180		}
181
182		return $tokenDictionary;
183		}
184
185		private static function _getHashFromSession($token)
186		{
187		$tokenDictionary = self::_getTokenDictionary();
188
189		return issetor($tokenDictionary[$token], '');
190		}
191
192		public static function markFormTime()
193		{
194		$time = time();
195		$session = new Ajde_Session('AC.Form');
196		$session->set('formTime', $time);
197
198		return $time;
199		}
200
201		public static function verifyFormTime()
202		{
203		$session = new Ajde_Session('AC.Form');
204		$sessionTime = $session->get('formTime');
205		if ((time() - $sessionTime) < self::FORM_MIN_TIME \|\|
206		(time() - $sessionTime) > self::FORM_MAX_TIME
207		) {
208		return false;
209		} else {
210		return true;
211		}
212		}
213
214		public static function isAjax()
215		{
216		return !empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest';
217		}
218
219		/**
220		* @return string Lowercase request method
221		*/
222		public static function method()
223		{
224		return strtolower($_SERVER['REQUEST_METHOD']);
225		}
226
227		/**
228		* Helpers.
229		*/
230		public function get($key)
231		{
232		return $this->getParam($key);
233		}
234
235		public function getParam($key, $default = null, $type = self::TYPE_STRING, $post = false)
236		{
237		$data = $this->_data;
238		if ($post === true) {
239		$data = $this->getPostData();
240		}
241		if (isset($data[$key])) {
242		switch ($type) {
243		case self::TYPE_HTML:
244		if ($this->autoCleanHtml() === true) {
245		return Ajde_Component_String::clean($data[$key]);
246		} else {
247		return $data[$key];
248		}
249		break;
		0 ignored issues – show Unused Code introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
250		case self::TYPE_INTEGER:
251		return (int) $data[$key];
252		break;
		0 ignored issues – show Unused Code introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
253		case self::TYPE_FLOAT:
254		return (float) $data[$key];
255		break;
		0 ignored issues – show Unused Code introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
256		case self::TYPE_RAW:
257		return $data[$key];
258		break;
		0 ignored issues – show Unused Code introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
259		case self::TYPE_STRING:
260		default:
261		if ($this->autoEscapeString() === true) {
262		if (is_array($data[$key])) {
263		array_walk($data[$key], ['Ajde_Component_String', 'escape']);
264
265		return $data[$key];
266		} else {
267		return Ajde_Component_String::escape($data[$key]);
268		}
269		} else {
270		return $data[$key];
271		}
272		}
273		} else {
274		if (isset($default)) {
275		return $default;
276		} else {
277		// TODO:
278		throw new Ajde_Exception("Parameter '$key' not present in request and no default value given");
279		}
280		}
281		}
282
283		public function getStr($key, $default)
284		{
285		return $this->getString($key, $default);
286		}
287
288		public function getInt($key, $default)
289		{
290		return $this->getInteger($key, $default);
291		}
292
293		public function getString($key, $default = null)
294		{
295		return $this->getParam($key, $default, self::TYPE_STRING);
296		}
297
298		public function getHtml($key, $default = null)
299		{
300		return $this->getParam($key, $default, self::TYPE_HTML);
301		}
302
303		public function getInteger($key, $default = null)
304		{
305		return $this->getParam($key, $default, self::TYPE_INTEGER);
306		}
307
308		public function getFloat($key, $default = null)
309		{
310		return $this->getParam($key, $default, self::TYPE_FLOAT);
311		}
312
313		public function getRaw($key, $default = null)
314		{
315		return $this->getParam($key, $default, self::TYPE_RAW);
316		}
317
318		/**
319		* FORM.
320		*/
321		public function getCheckbox($key, $post = true)
322		{
323		if ($this->getParam($key, false, self::TYPE_RAW, $post) === 'on') {
324		return true;
325		} else {
326		return false;
327		}
328		}
329
330		/**
331		* POST.
332		*/
333		public function getPostData()
334		{
335		return $this->_postData;
336		}
337
338		public function getPostParam($key, $default = null, $type = self::TYPE_STRING)
339		{
340		return $this->getParam($key, $default, $type, true);
341		}
342
343		public function getPostRaw($key, $default = null)
344		{
345		return $this->getParam($key, $default, self::TYPE_RAW, true);
346		}
347
348		public function hasPostParam($key)
349		{
350		return array_key_exists($key, $this->_postData);
351		}
352
353		/**
354		* @return Ajde_Core_Route
355		*/
356		public function getRoute()
357		{
358		if (!isset($this->_route)) {
359		$route = $this->extractRoute();
360		$this->_route = new Ajde_Core_Route($route);
361		foreach ($this->_route->values() as $part => $value) {
362		if (!$this->hasNotEmpty($part)) {
363		$this->set($part, $value);
364		}
365		}
366		}
367
368		return $this->_route;
369		}
370
371		private function extractRoute()
372		{
373		// Strip query string
374		$URIComponents = explode('?', $_SERVER['REQUEST_URI']);
375		$requestURI = reset($URIComponents);
376
377		// Route is the part after our base path
378		$baseURI = str_replace('index.php', '', $_SERVER['PHP_SELF']);
379
380		// Strip public from request and base
381		$requestURI = str_replace(PUBLIC_DIR, '', $requestURI);
382		$baseURI = str_replace(PUBLIC_DIR, '', $baseURI);
383
384		// TODO: potential bug when baseuri is something like /node (now all requests with /node/node will return '')
385		return $baseURI !== '/' ? str_replace($baseURI, '', $requestURI) : trim($requestURI, '/');
386		}
387
388		public function initRoute()
389		{
390		$route = $this->getRoute();
391
392		return $route;
393		}
394
395		public static function getClientIP()
396		{
397		if (array_key_exists('HTTP_X_FORWARDED_FOR', $_SERVER)) {
398		return $_SERVER['HTTP_X_FORWARDED_FOR'];
399		} else {
400		if (array_key_exists('REMOTE_ADDR', $_SERVER)) {
401		return $_SERVER['REMOTE_ADDR'];
402		} else {
403		if (array_key_exists('HTTP_CLIENT_IP', $_SERVER)) {
404		return $_SERVER['HTTP_CLIENT_IP'];
405		}
406		}
407		}
408
409		return '';
410		}
411		}
412

nabble / ajde

Issues (1919)

Security Analysis not enabled

lib/Ajde/Http/Request.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like