Issues in Controller.php (master) - Issues in master - nabble/ajde - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1919)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Ajde/Controller.php (14 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class Ajde_Controller extends Ajde_Object_Standard
{
    /**
     * @var Ajde_View
     */
    protected $_view = null;

    /**
     * @var Ajde_Core_Route
     */
    protected $_route = null;

    public function __construct($action = null, $format = null)
    {
        $this->setModule(strtolower(str_replace('Controller', '', get_class($this))));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if (!isset($action) || !isset($format)) {
            $defaultParts = config('routes.default');
        }
        $this->setAction(isset($action) ? $action : $defaultParts['action']);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $this->setFormat(isset($format) ? $format : $defaultParts['format']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $route = new Ajde_Core_Route($this->getAction());
        $route->setFormat($this->getFormat());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->_route = $route;
    }

    public function __fallback($method, $arguments)
    {
        if (Ajde_Event::has('Ajde_Controller', 'call')) {
            return Ajde_Event::trigger('Ajde_Controller', 'call', [$method, $arguments]);
        }
        throw new Ajde_Exception('Call to undefined method '.get_class($this)."::$method()", 90006);
    }

    public function getModule()
    {
        return $this->get('module');
    }

    public function getAction()
    {
        return $this->get('action');
    }

    public function getFormat()
    {
        return $this->get('format');
    }

    public function getId()
    {
        return $this->get('id');
    }

    public function getRoute()
    {
        return $this->_route;
    }

    public function getCanonicalUrl()
    {
        return $this->_route->buildRoute();
    }

    /**
     * @param Ajde_Core_Route $route
     *
     * @return Ajde_Controller
     */
    public static function fromRoute(Ajde_Core_Route $route)
    {
        if ($controller = $route->getController()) {
            $moduleController = ucfirst($route->getModule()).ucfirst($controller).'Controller';
        } else {
            $moduleController = ucfirst($route->getModule()).'Controller';
        }
        if (!class_exists($moduleController)) {

            // Prevent resursive 404 routing
            $errorRoutes = config('routes.errors');
            if (isset($errorRoutes[Ajde_Http_Response::RESPONSE_TYPE_NOTFOUND])) {
                $notFoundRoute = new Ajde_Core_Route($errorRoutes[Ajde_Http_Response::RESPONSE_TYPE_NOTFOUND]);
                if ($route->buildRoute() == $notFoundRoute->buildRoute()) {
                    Ajde_Http_Response::setResponseType(404);
                    die('<h2>Ouch, something broke.</h2><p>This is serious. We tried to give you a nice error page, but even that failed.</p><button onclick="location.href=\''.config('app.rootUrl').'\';">Go back to homepage</button>');
                }
            }

            if (class_exists('Ajde_Exception')) {
                $exception = new Ajde_Core_Exception_Routing("Controller $moduleController for module {$route->getModule()} not found",
                    90008);
            } else {
                // Normal exception here to prevent [Class 'Ajde_Exception' not found] errors...
                $exception = new Exception("Controller $moduleController for module {$route->getModule()} not found");
            }
            Ajde::routingError($exception);
        }
        $controller = new $moduleController($route->getAction(), $route->getFormat());
        $controller->_route = $route;
        foreach ($route->values() as $part => $value) {
            $controller->set($part, $value);
        }

        return $controller;
    }

    /**
     * @param string|null $action
     * @param string|null $format
     *
     * @throws Ajde_Exception
     * @throws Exception
     *
     * @return mixed
     */
    public function invoke($action = null, $format = null)
    {
        $timerKey = Ajde::app()->addTimer((string) $this->_route);
        $action = issetor($action, $this->getAction());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $format = issetor($format, $this->getFormat());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $method = strtolower($_SERVER['REQUEST_METHOD']);

        $tryTheseFunctions = [];

        $formatFunction = $action.ucfirst($format);
        $defaultFunction = $action.'Default';
        $emptyFunction = $action;

        $tryTheseFunctions[] = $formatFunction.ucfirst($method);
        $tryTheseFunctions[] = $defaultFunction.ucfirst($method);
        $tryTheseFunctions[] = $emptyFunction.ucfirst($method);
        $tryTheseFunctions[] = $formatFunction;
        $tryTheseFunctions[] = $defaultFunction;
        $tryTheseFunctions[] = $emptyFunction;

        $invokeFunction = '';

        foreach ($tryTheseFunctions as $tryFunction) {
            if (method_exists($this, $tryFunction)) {
                $invokeFunction = $tryFunction;
                break;
            }
        }
        //        dump(get_class($this) . '::' .  $invokeFunction);

        if (!$invokeFunction) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $exception = new Ajde_Core_Exception_Routing(sprintf('Action %s for module %s not found',
                $this->getAction(),
                $this->getModule()
            ), 90011);
            Ajde::routingError($exception);
        }

        $return = true;
        if (method_exists($this, 'beforeInvoke')) {

            $return = $this->beforeInvoke();

            if ($return !== true && $return !== false) {
                // TODO:
                throw new Ajde_Exception(sprintf('beforeInvoke() must return either TRUE or FALSE'));
            }
        }
        if ($return === true) {
            $return = $this->$invokeFunction();
            if (method_exists($this, 'afterInvoke')) {
                $this->afterInvoke();

            }
        }
        Ajde::app()->endTimer($timerKey);

        return $return;
    }

    /**
     * @return Ajde_View
     */
    public function getView()
    {
        if (!isset($this->_view)) {
            $this->_view = Ajde_View::fromController($this);
        }

        return $this->_view;
    }

    /**
     * @param Ajde_View $view
     */
    public function setView(Ajde_View $view)
    {
        $this->_view = $view;
    }

    /**
     * Shorthand for $controller->getView()->getContents();.
     */
    public function render()
    {
        $return = true;
        if (method_exists($this, 'beforeRender')) {

            $return = $this->beforeRender();

            if ($return !== true && $return !== false) {
                // TODO:
                throw new Ajde_Exception(sprintf('beforeRender() must return either TRUE or FALSE'));
            }
        }
        if ($return === true) {
            return $this->getView()->getContents();
        }
    }

    public function loadTemplate()
    {
        throw new Ajde_Core_Exception_Deprecated();
        $view = Ajde_View::fromController($this);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

        return $view->getContents();
    }

    public function redirect($route = Ajde_Http_Response::REDIRECT_SELF)
    {
        Ajde::app()->getResponse()->setRedirect($route);
    }

    public function rewrite($route)
    {
        Ajde::app()->getResponse()->dieOnRoute($route);
    }

    public function updateCache()
    {
        // TODO:
        throw new Ajde_Core_Exception_Deprecated();
    }

    /**
     * @param Ajde_Model|Ajde_Collection $object
     */
    public function touchCache($object = null)
    {
        Ajde_Cache::getInstance()->updateHash(isset($object) ? $object->hash() : time());
    }
}


Issues (1919)

Security Analysis not enabled

lib/Ajde/Controller.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1		<?php
2
3		class Ajde_Controller extends Ajde_Object_Standard
4		{
5		/**
6		* @var Ajde_View
7		*/
8		protected $_view = null;
9
10		/**
11		* @var Ajde_Core_Route
12		*/
13		protected $_route = null;
14
15		public function __construct($action = null, $format = null)
16		{
17		$this->setModule(strtolower(str_replace('Controller', '', get_class($this))));
		0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setModule` does not exist on `object<Ajde_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
18		if (!isset($action) \|\| !isset($format)) {
19		$defaultParts = config('routes.default');
20		}
21		$this->setAction(isset($action) ? $action : $defaultParts['action']);
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$defaultParts` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setAction` does not exist on `object<Ajde_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
22		$this->setFormat(isset($format) ? $format : $defaultParts['format']);
		0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setFormat` does not exist on `object<Ajde_Controller>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
23
24		$route = new Ajde_Core_Route($this->getAction());
25		$route->setFormat($this->getFormat());
		0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setFormat` does not exist on `object<Ajde_Core_Route>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
26		$this->_route = $route;
27		}
28
29		public function __fallback($method, $arguments)
30		{
31		if (Ajde_Event::has('Ajde_Controller', 'call')) {
32		return Ajde_Event::trigger('Ajde_Controller', 'call', [$method, $arguments]);
33		}
34		throw new Ajde_Exception('Call to undefined method '.get_class($this)."::$method()", 90006);
35		}
36
37		public function getModule()
38		{
39		return $this->get('module');
40		}
41
42		public function getAction()
43		{
44		return $this->get('action');
45		}
46
47		public function getFormat()
48		{
49		return $this->get('format');
50		}
51
52		public function getId()
53		{
54		return $this->get('id');
55		}
56
57		public function getRoute()
58		{
59		return $this->_route;
60		}
61
62		public function getCanonicalUrl()
63		{
64		return $this->_route->buildRoute();
65		}
66
67		/**
68		* @param Ajde_Core_Route $route
69		*
70		* @return Ajde_Controller
71		*/
72		public static function fromRoute(Ajde_Core_Route $route)
73		{
74		if ($controller = $route->getController()) {
75		$moduleController = ucfirst($route->getModule()).ucfirst($controller).'Controller';
76		} else {
77		$moduleController = ucfirst($route->getModule()).'Controller';
78		}
79		if (!class_exists($moduleController)) {
80
81		// Prevent resursive 404 routing
82		$errorRoutes = config('routes.errors');
83		if (isset($errorRoutes[Ajde_Http_Response::RESPONSE_TYPE_NOTFOUND])) {
84		$notFoundRoute = new Ajde_Core_Route($errorRoutes[Ajde_Http_Response::RESPONSE_TYPE_NOTFOUND]);
85		if ($route->buildRoute() == $notFoundRoute->buildRoute()) {
86		Ajde_Http_Response::setResponseType(404);
87		die('<h2>Ouch, something broke.</h2><p>This is serious. We tried to give you a nice error page, but even that failed.</p><button onclick="location.href=\''.config('app.rootUrl').'\';">Go back to homepage</button>');
88		}
89		}
90
91		if (class_exists('Ajde_Exception')) {
92		$exception = new Ajde_Core_Exception_Routing("Controller $moduleController for module {$route->getModule()} not found",
93		90008);
94		} else {
95		// Normal exception here to prevent [Class 'Ajde_Exception' not found] errors...
96		$exception = new Exception("Controller $moduleController for module {$route->getModule()} not found");
97		}
98		Ajde::routingError($exception);
99		}
100		$controller = new $moduleController($route->getAction(), $route->getFormat());
101		$controller->_route = $route;
102		foreach ($route->values() as $part => $value) {
103		$controller->set($part, $value);
104		}
105
106		return $controller;
107		}
108
109		/**
110		* @param string\|null $action
111		* @param string\|null $format
112		*
113		* @throws Ajde_Exception
114		* @throws Exception
115		*
116		* @return mixed
117		*/
118		public function invoke($action = null, $format = null)
119		{
120		$timerKey = Ajde::app()->addTimer((string) $this->_route);
121		$action = issetor($action, $this->getAction());
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$action` is correct as `issetor($action, $this->getAction())` (which targets `issetor()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
122		$format = issetor($format, $this->getFormat());
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$format` is correct as `issetor($format, $this->getFormat())` (which targets `issetor()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
123		$method = strtolower($_SERVER['REQUEST_METHOD']);
124
125		$tryTheseFunctions = [];
126
127		$formatFunction = $action.ucfirst($format);
128		$defaultFunction = $action.'Default';
129		$emptyFunction = $action;
130
131		$tryTheseFunctions[] = $formatFunction.ucfirst($method);
132		$tryTheseFunctions[] = $defaultFunction.ucfirst($method);
133		$tryTheseFunctions[] = $emptyFunction.ucfirst($method);
134		$tryTheseFunctions[] = $formatFunction;
135		$tryTheseFunctions[] = $defaultFunction;
136		$tryTheseFunctions[] = $emptyFunction;
137
138		$invokeFunction = '';
139
140		foreach ($tryTheseFunctions as $tryFunction) {
141		if (method_exists($this, $tryFunction)) {
142		$invokeFunction = $tryFunction;
143		break;
144		}
145		}
146		// dump(get_class($this) . '::' . $invokeFunction);
147
148		if (!$invokeFunction) {
		0 ignored issues – show Bug Best Practice introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$invokeFunction` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
149		$exception = new Ajde_Core_Exception_Routing(sprintf('Action %s for module %s not found',
150		$this->getAction(),
151		$this->getModule()
152		), 90011);
153		Ajde::routingError($exception);
154		}
155
156		$return = true;
157	View Code Duplication	if (method_exists($this, 'beforeInvoke')) {
		0 ignored issues – show Duplication introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
158		$return = $this->beforeInvoke();
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `beforeInvoke()` does not exist on `Ajde_Controller`. Did you maybe mean `invoke()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
159		if ($return !== true && $return !== false) {
160		// TODO:
161		throw new Ajde_Exception(sprintf('beforeInvoke() must return either TRUE or FALSE'));
162		}
163		}
164		if ($return === true) {
165		$return = $this->$invokeFunction();
166		if (method_exists($this, 'afterInvoke')) {
167		$this->afterInvoke();
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `afterInvoke()` does not exist on `Ajde_Controller`. Did you maybe mean `invoke()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
168		}
169		}
170		Ajde::app()->endTimer($timerKey);
171
172		return $return;
173		}
174
175		/**
176		* @return Ajde_View
177		*/
178		public function getView()
179		{
180		if (!isset($this->_view)) {
181		$this->_view = Ajde_View::fromController($this);
182		}
183
184		return $this->_view;
185		}
186
187		/**
188		* @param Ajde_View $view
189		*/
190		public function setView(Ajde_View $view)
191		{
192		$this->_view = $view;
193		}
194
195		/**
196		* Shorthand for $controller->getView()->getContents();.
197		*/
198		public function render()
199		{
200		$return = true;
201	View Code Duplication	if (method_exists($this, 'beforeRender')) {
		0 ignored issues – show Duplication introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
202		$return = $this->beforeRender();
		0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `beforeRender()` does not exist on `Ajde_Controller`. Did you maybe mean `render()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
203		if ($return !== true && $return !== false) {
204		// TODO:
205		throw new Ajde_Exception(sprintf('beforeRender() must return either TRUE or FALSE'));
206		}
207		}
208		if ($return === true) {
209		return $this->getView()->getContents();
210		}
211		}
212
213		public function loadTemplate()
214		{
215		throw new Ajde_Core_Exception_Deprecated();
216		$view = Ajde_View::fromController($this);
		0 ignored issues – show Unused Code introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$view = \Ajde_View::fromController($this);` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
217
218		return $view->getContents();
219		}
220
221		public function redirect($route = Ajde_Http_Response::REDIRECT_SELF)
222		{
223		Ajde::app()->getResponse()->setRedirect($route);
224		}
225
226		public function rewrite($route)
227		{
228		Ajde::app()->getResponse()->dieOnRoute($route);
229		}
230
231		public function updateCache()
232		{
233		// TODO:
234		throw new Ajde_Core_Exception_Deprecated();
235		}
236
237		/**
238		* @param Ajde_Model\|Ajde_Collection $object
239		*/
240		public function touchCache($object = null)
241		{
242		Ajde_Cache::getInstance()->updateHash(isset($object) ? $object->hash() : time());
243		}
244		}
245

nabble / ajde

Issues (1919)

Security Analysis not enabled

lib/Ajde/Controller.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like