Issues in Application.php (master) - Issues in master - nabble/ajde - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1919)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Ajde/Application.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class Ajde_Application extends Ajde_Object_Singleton
{
    protected $_timers = [];
    protected $_timerLevel = 0;

    /**
     * @staticvar Ajde_Application $instance
     *
     * @return Ajde_Application
     */
    public static function getInstance()
    {
        static $instance;

        return $instance === null ? $instance = new self() : $instance;
    }

    /**
     * @return Ajde_Application
     */
    public static function app()
    {
        return self::getInstance();
    }

    /**
     * @return Ajde_Application
     */
    public static function create()
    {
        return self::getInstance();
    }

    public function addTimer($description)
    {
        $this->_timers[] = [
            'description' => $description,
            'level'       => $this->_timerLevel,
            'start'       => microtime(true),
            'end'         => null,
            'total'       => null,
        ];
        $this->_timerLevel++;

        return $this->getLastTimerKey();
    }

    public function getLastTimerKey()
    {
        end($this->_timers);

        return key($this->_timers);
    }

    public function endTimer($key)
    {
        $this->_timerLevel--;
        $this->_timers[$key]['end'] = $end = microtime(true);
        $this->_timers[$key]['total'] = round(($end - $this->_timers[$key]['start']) * 1000, 0);

        return $this->_timers[$key]['total'];
    }

    public function getTimers()
    {
        return $this->_timers;
    }

    public function run()
    {
        // For debugger
        $this->addTimer('<i>Application</i>');

        // Create fresh response
        $timer = $this->addTimer('Create response');
        $response = new Ajde_Http_Response();
        $this->setResponse($response);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterResponseCreated');

        // Bootstrap init
        $timer = $this->addTimer('Run bootstrap queue');
        $bootstrap = new Ajde_Core_Bootstrap();
        $bootstrap->run();
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterBootstrap');

        // Get request
        $timer = $this->addTimer('Read in global request');
        $request = $this->loadRequest();
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterRequestCreated');

        // Get route
        $timer = $this->addTimer('Initialize route');
        $route = $request->initRoute();
        $this->setRoute($route);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterRouteInitialized');

        // Load document
        $timer = $this->addTimer('Create document');
        $document = Ajde_Document::fromRoute($route);
        $this->setDocument($document);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterDocumentCreated');

        // Load controller
        $timer = $this->addTimer('Load controller');
        $controller = Ajde_Controller::fromRoute($route);
        $this->setController($controller);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterControllerCreated');

        // Invoke controller action
        $timer = $this->addTimer('Invoke controller');
        $actionResult = $controller->invoke();
        $document->setBody($actionResult);
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterControllerInvoked');

        // Get document contents
        $timer = $this->addTimer('Render document');
        $contents = $document->render();
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterDocumentRendered');

        // Let the cache handle the contents and have it saved to the response
        $timer = $this->addTimer('Save to response');
        $cache = Ajde_Cache::getInstance();
        $cache->setContents($contents);
        $cache->saveResponse();
        $this->endTimer($timer);

        Ajde_Event::trigger($this, 'onAfterResponseSaved');

        // Output the buffer
        $response->send();

        Ajde_Event::trigger($this, 'onAfterResponseSent');
    }

    public static function routingError(Exception $exception)
    {
        if (config('app.debug') === true) {
            throw $exception;
        } else {
            if (class_exists('Ajde_Exception_Log')) {
                Ajde_Exception_Log::logException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
            Ajde_Http_Response::redirectNotFound();
        }
    }

    public function loadRequest()
    {
        $request = Ajde_Http_Request::fromGlobal();
        $this->setRequest($request);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        return $request;
    }

    /**
     * @return Ajde_Http_Request
     */
    public function getRequest()
    {
        if (!$this->has('request')) {
            $this->loadRequest();
        }

        return $this->get('request');
    }

    /**
     * @return Ajde_Http_Response
     */
    public function getResponse()
    {
        return $this->get('response');
    }

    /**
     * @return Ajde_Core_Route
     */
    public function getRoute()
    {
        return $this->get('route');
    }

    /**
     * @return Ajde_Document
     */
    public function getDocument()
    {
        return $this->get('document');
    }

    /**
     * @return Ajde_Controller
     */
    public function getController()
    {
        return $this->get('controller');
    }

    public static function includeFile($filename)
    {
        Ajde_Cache::getInstance()->addFile($filename);
        include $filename;
    }

    public static function includeFileOnce($filename)
    {
        Ajde_Cache::getInstance()->addFile($filename);
        include_once $filename;
    }
}


1			<?php
2
3			class Ajde_Application extends Ajde_Object_Singleton
4			{
5			protected $_timers = [];
6			protected $_timerLevel = 0;
7
8			/**
9			* @staticvar Ajde_Application $instance
10			*
11			* @return Ajde_Application
12			*/
13			public static function getInstance()
14			{
15			static $instance;
16
17			return $instance === null ? $instance = new self() : $instance;
18			}
19
20			/**
21			* @return Ajde_Application
22			*/
23			public static function app()
24			{
25			return self::getInstance();
26			}
27
28			/**
29			* @return Ajde_Application
30			*/
31			public static function create()
32			{
33			return self::getInstance();
34			}
35
36			public function addTimer($description)
37			{
38			$this->_timers[] = [
39			'description' => $description,
40			'level' => $this->_timerLevel,
41			'start' => microtime(true),
42			'end' => null,
43			'total' => null,
44			];
45			$this->_timerLevel++;
46
47			return $this->getLastTimerKey();
48			}
49
50			public function getLastTimerKey()
51			{
52			end($this->_timers);
53
54			return key($this->_timers);
55			}
56
57			public function endTimer($key)
58			{
59			$this->_timerLevel--;
60			$this->_timers[$key]['end'] = $end = microtime(true);
61			$this->_timers[$key]['total'] = round(($end - $this->_timers[$key]['start']) * 1000, 0);
62
63			return $this->_timers[$key]['total'];
64			}
65
66			public function getTimers()
67			{
68			return $this->_timers;
69			}
70
71			public function run()
72			{
73			// For debugger
74			$this->addTimer('<i>Application</i>');
75
76			// Create fresh response
77			$timer = $this->addTimer('Create response');
78			$response = new Ajde_Http_Response();
79			$this->setResponse($response);
			0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setResponse` does not exist on `object<Ajde_Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
80			$this->endTimer($timer);
81
82			Ajde_Event::trigger($this, 'onAfterResponseCreated');
83
84			// Bootstrap init
85			$timer = $this->addTimer('Run bootstrap queue');
86			$bootstrap = new Ajde_Core_Bootstrap();
87			$bootstrap->run();
88			$this->endTimer($timer);
89
90			Ajde_Event::trigger($this, 'onAfterBootstrap');
91
92			// Get request
93			$timer = $this->addTimer('Read in global request');
94			$request = $this->loadRequest();
95			$this->endTimer($timer);
96
97			Ajde_Event::trigger($this, 'onAfterRequestCreated');
98
99			// Get route
100			$timer = $this->addTimer('Initialize route');
101			$route = $request->initRoute();
102			$this->setRoute($route);
			0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setRoute` does not exist on `object<Ajde_Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
103			$this->endTimer($timer);
104
105			Ajde_Event::trigger($this, 'onAfterRouteInitialized');
106
107			// Load document
108			$timer = $this->addTimer('Create document');
109			$document = Ajde_Document::fromRoute($route);
110			$this->setDocument($document);
			0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setDocument` does not exist on `object<Ajde_Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
111			$this->endTimer($timer);
112
113			Ajde_Event::trigger($this, 'onAfterDocumentCreated');
114
115			// Load controller
116			$timer = $this->addTimer('Load controller');
117			$controller = Ajde_Controller::fromRoute($route);
118			$this->setController($controller);
			0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setController` does not exist on `object<Ajde_Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
119			$this->endTimer($timer);
120
121			Ajde_Event::trigger($this, 'onAfterControllerCreated');
122
123			// Invoke controller action
124			$timer = $this->addTimer('Invoke controller');
125			$actionResult = $controller->invoke();
126			$document->setBody($actionResult);
127			$this->endTimer($timer);
128
129			Ajde_Event::trigger($this, 'onAfterControllerInvoked');
130
131			// Get document contents
132			$timer = $this->addTimer('Render document');
133			$contents = $document->render();
134			$this->endTimer($timer);
135
136			Ajde_Event::trigger($this, 'onAfterDocumentRendered');
137
138			// Let the cache handle the contents and have it saved to the response
139			$timer = $this->addTimer('Save to response');
140			$cache = Ajde_Cache::getInstance();
141			$cache->setContents($contents);
142			$cache->saveResponse();
143			$this->endTimer($timer);
144
145			Ajde_Event::trigger($this, 'onAfterResponseSaved');
146
147			// Output the buffer
148			$response->send();
149
150			Ajde_Event::trigger($this, 'onAfterResponseSent');
151			}
152
153			public static function routingError(Exception $exception)
154			{
155			if (config('app.debug') === true) {
156			throw $exception;
157			} else {
158			if (class_exists('Ajde_Exception_Log')) {
159			Ajde_Exception_Log::logException($exception);
			0 ignored issues – show Documentation introduced 2016-09-18 20:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$exception` is of type `object<Exception>`, but the function expects a `object<Throwable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
160			}
161			Ajde_Http_Response::redirectNotFound();
162			}
163			}
164
165			public function loadRequest()
166			{
167			$request = Ajde_Http_Request::fromGlobal();
168			$this->setRequest($request);
			0 ignored issues – show Documentation Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setRequest` does not exist on `object<Ajde_Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
169
170			return $request;
171			}
172
173			/**
174			* @return Ajde_Http_Request
175			*/
176			public function getRequest()
177			{
178			if (!$this->has('request')) {
179			$this->loadRequest();
180			}
181
182			return $this->get('request');
183			}
184
185			/**
186			* @return Ajde_Http_Response
187			*/
188			public function getResponse()
189			{
190			return $this->get('response');
191			}
192
193			/**
194			* @return Ajde_Core_Route
195			*/
196			public function getRoute()
197			{
198			return $this->get('route');
199			}
200
201			/**
202			* @return Ajde_Document
203			*/
204			public function getDocument()
205			{
206			return $this->get('document');
207			}
208
209			/**
210			* @return Ajde_Controller
211			*/
212			public function getController()
213			{
214			return $this->get('controller');
215			}
216
217			public static function includeFile($filename)
218			{
219			Ajde_Cache::getInstance()->addFile($filename);
220			include $filename;
221			}
222
223			public static function includeFileOnce($filename)
224			{
225			Ajde_Cache::getInstance()->addFile($filename);
226			include_once $filename;
227			}
228			}
229

nabble / ajde

Issues (1919)

Security Analysis not enabled

lib/Ajde/Application.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like