View GitHub Repository ajde

Schedule Inspection
Subscribe

Code Duplication    Length = 5-5 lines in 3 locations

core/modules/_core/_coreCrudController.php 3 locations

@@ 307-311 (lines=5) @@
304 
            $statement = $model->getConnection()->prepare($sql);
305 
            $statement->execute();
306 
            $result = $statement->fetch(PDO::FETCH_ASSOC);
307 
            if ($result === false || empty($result)) {
308 
                $sortValue = 0;
309 
            } else {
310 
                $sortValue = $result['min'];
311 
            }
312 

                                

                                                            

                                    313
                                    
                                    
            $success = true;

                                

                                                            

                                    314
                                    
                                    
            foreach ($ids as $id) {

                                

                                                                                

                                
                                
                                    @@ 347-351 (lines=5) @@
                                
                            


                                                            

                                    344
                                    
                                    
            $statement = $model->getConnection()->prepare($sql);

                                

                                                            

                                    345
                                    
                                    
            $statement->execute();

                                

                                                            

                                    346
                                    
                                    
            $result = $statement->fetch(PDO::FETCH_ASSOC);

                                

                                                            

                                    347
                                    
                                    
            if ($result === false || empty($result)) {

                                

                                                            

                                    348
                                    
                                    
                $sortValue = 0;

                                

                                                            

                                    349
                                    
                                    
            } else {

                                

                                                            

                                    350
                                    
                                    
                $sortValue = $result['min'];

                                

                                                            

                                    351
                                    
                                    
            }

                                

                                                            

                                    352
                                    
                                    

                                

                                                            

                                    353
                                    
                                    
            $success = true;

                                

                                                            

                                    354
                                    
                                    
            foreach ($ids as $id) {

                                

                                                                                

                                
                                
                                    @@ 684-688 (lines=5) @@
                                
                            


                                                            

                                    681
                                    
                                    
                        $statement = $model->getConnection()->prepare($sql);

                                

                                                            

                                    682
                                    
                                    
                        $statement->execute();

                                

                                                            

                                    683
                                    
                                    
                        $result = $statement->fetch(PDO::FETCH_ASSOC);

                                

                                                            

                                    684
                                    
                                    
                        if ($result === false || empty($result)) {

                                

                                                            

                                    685
                                    
                                    
                            $sortValue = 999;

                                

                                                            

                                    686
                                    
                                    
                        } else {

                                

                                                            

                                    687
                                    
                                    
                            $sortValue = $result['max'] + 1;

                                

                                                            

                                    688
                                    
                                    
                        }

                                

                                                            

                                    689
                                    
                                    
                        $fieldList .= ', '.$extraField['name'];

                                

                                                            

                                    690
                                    
                                    
                        $valueList = '?, ?, ?';

                                

                                                            

                                    691
                                    
                                    
                        $values[] = $sortValue;