Ajde_Db::install() - Code Metrics - nabble/ajde - Measure and Improve Code Quality continuously with Scrutinizer

Ajde_Db::install() A
last analyzed 2016-09-18 20:02 UTC

↳ Parent: Ajde_Db

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

class Ajde_Db extends Ajde_Object_Singleton
{
    protected $_adapter = null;
    protected $_tables = null;

    const FIELD_TYPE_NUMERIC = 'numeric';
    const FIELD_TYPE_TEXT = 'text';
    const FIELD_TYPE_ENUM = 'enum';
    const FIELD_TYPE_DATE = 'date';
    const FIELD_TYPE_SPATIAL = 'spatial';

    /**
     * @return Ajde_Db
     */
    public static function getInstance()
    {
        static $instance;

        return $instance === null ? $instance = new self() : $instance;
    }

    protected function __construct()
    {
        $adapterName = 'Ajde_Db_Adapter_'.ucfirst(config('database.adapter'));
        $host = config('database.host');
        $db = config('database.db');
        $user = config('database.user');
        $password = config('database.password');

        // TODO Move DSN template to adapter
        $this->_adapter = new $adapterName([
            'host'   => $host,
            'dbname' => $db,
        ], $user, $password);
    }

    /**
     * @return Ajde_Db_Adapter_Abstract
     */
    public function getAdapter()
    {
        return $this->_adapter;
    }

    /**
     * @return Ajde_Db_PDO
     */
    public function getConnection()
    {
        return $this->_adapter->getConnection();
    }

    public function getTable($tableName)
    {
        if (!isset($this->_tables[$tableName])) {
            $this->_tables[$tableName] = new Ajde_Db_Table($tableName);
        }

        return $this->_tables[$tableName];
    }

    public function executeFile($filename)
    {
        // @see http://stackoverflow.com/a/10209702/938297

        // time limit
        @set_time_limit(5 * 60);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        // load file
        $commands = file_get_contents($filename);

        // delete comments
        $lines = explode("\n", $commands);
        $commands = '';
        foreach ($lines as $line) {
            $line = trim($line);
            if ($line && !(substr($line, 0, 2) === '--')) {
                $commands .= $line."\n";
            }
        }

        // convert to array
        $commands = explode(';'.PHP_EOL, $commands);

        // run commands
        $total = $success = 0;
        foreach ($commands as $command) {
            if (trim($command)) {
                try {
                    $success += ($this->getConnection()->query($command) === false ? 0 : 1);
                } catch (Exception $e) {
                    echo $e->getMessage().'<br/>';
                }
                $total += 1;
            }
        }

        // return number of successful queries and total number of queries found
        return [
            'success' => $success,
            'total'   => $total,
        ];
    }

    public function version()
    {
        $results = $this->getConnection()->query("SELECT v FROM ajde WHERE k = 'version' LIMIT 1");
        foreach ($results as $result) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $version = $result[0];
        }

        return $version;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function update()
    {
        $dbVersion = $this->version();
        $this->installFromVersion($dbVersion);
        $this->updateVersion();

        return true;
    }

    private function installFromVersion($version = 'v0')
    {
        $sqlFiles = Ajde_Fs_Find::findFiles(DEV_DIR.'db'.DIRECTORY_SEPARATOR, 'v*.sql');
        usort($sqlFiles, [$this, 'versionSort']);
        foreach ($sqlFiles as $sqlFile) {
            $sqlFileVersion = pathinfo($sqlFile, PATHINFO_FILENAME);
            if (version_compare($sqlFileVersion, $version) > 0) {
                $this->executeFile($sqlFile);
            }
        }
    }

    private function versionSort($a, $b)
    {
        return version_compare($a, $b);
    }

    private function updateVersion($version = AJDE_VERSION)
    {
        $this->getConnection()->query("UPDATE ajde SET v = '".$version."' WHERE k = 'version' LIMIT 1");
    }

    public function install()
    {
        if ($this->isInstalled()) {
            die('DB already installed');
        }

        $this->installFromVersion();
        $this->updateVersion();

        die('DB installed. <a href="index.php">Proceed to homepage</a>');
    }

    private function isInstalled()
    {
        return $this->getConnection()->query("SHOW TABLES LIKE 'ajde'")->rowCount() > 0;
    }
}


1			<?php
2
3			class Ajde_Db extends Ajde_Object_Singleton
4			{
5			protected $_adapter = null;
6			protected $_tables = null;
7
8			const FIELD_TYPE_NUMERIC = 'numeric';
9			const FIELD_TYPE_TEXT = 'text';
10			const FIELD_TYPE_ENUM = 'enum';
11			const FIELD_TYPE_DATE = 'date';
12			const FIELD_TYPE_SPATIAL = 'spatial';
13
14			/**
15			* @return Ajde_Db
16			*/
17			public static function getInstance()
18			{
19			static $instance;
20
21			return $instance === null ? $instance = new self() : $instance;
22			}
23
24			protected function __construct()
25			{
26			$adapterName = 'Ajde_Db_Adapter_'.ucfirst(config('database.adapter'));
27			$host = config('database.host');
28			$db = config('database.db');
29			$user = config('database.user');
30			$password = config('database.password');
31
32			// TODO Move DSN template to adapter
33			$this->_adapter = new $adapterName([
34			'host' => $host,
35			'dbname' => $db,
36			], $user, $password);
37			}
38
39			/**
40			* @return Ajde_Db_Adapter_Abstract
41			*/
42			public function getAdapter()
43			{
44			return $this->_adapter;
45			}
46
47			/**
48			* @return Ajde_Db_PDO
49			*/
50			public function getConnection()
51			{
52			return $this->_adapter->getConnection();
53			}
54
55			public function getTable($tableName)
56			{
57			if (!isset($this->_tables[$tableName])) {
58			$this->_tables[$tableName] = new Ajde_Db_Table($tableName);
59			}
60
61			return $this->_tables[$tableName];
62			}
63
64			public function executeFile($filename)
65			{
66			// @see http://stackoverflow.com/a/10209702/938297
67
68			// time limit
69			@set_time_limit(5 * 60);
			0 ignored issues – show Security Best Practice introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
70
71			// load file
72			$commands = file_get_contents($filename);
73
74			// delete comments
75			$lines = explode("\n", $commands);
76			$commands = '';
77			foreach ($lines as $line) {
78			$line = trim($line);
79			if ($line && !(substr($line, 0, 2) === '--')) {
80			$commands .= $line."\n";
81			}
82			}
83
84			// convert to array
85			$commands = explode(';'.PHP_EOL, $commands);
86
87			// run commands
88			$total = $success = 0;
89			foreach ($commands as $command) {
90			if (trim($command)) {
91			try {
92			$success += ($this->getConnection()->query($command) === false ? 0 : 1);
93			} catch (Exception $e) {
94			echo $e->getMessage().'<br/>';
95			}
96			$total += 1;
97			}
98			}
99
100			// return number of successful queries and total number of queries found
101			return [
102			'success' => $success,
103			'total' => $total,
104			];
105			}
106
107			public function version()
108			{
109			$results = $this->getConnection()->query("SELECT v FROM ajde WHERE k = 'version' LIMIT 1");
110			foreach ($results as $result) {
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report The expression `$results` of type `null\|object<PDOStatement>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
111			$version = $result[0];
112			}
113
114			return $version;
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report The variable `$version` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
115			}
116
117			public function update()
118			{
119			$dbVersion = $this->version();
120			$this->installFromVersion($dbVersion);
121			$this->updateVersion();
122
123			return true;
124			}
125
126			private function installFromVersion($version = 'v0')
127			{
128			$sqlFiles = Ajde_Fs_Find::findFiles(DEV_DIR.'db'.DIRECTORY_SEPARATOR, 'v*.sql');
129			usort($sqlFiles, [$this, 'versionSort']);
130			foreach ($sqlFiles as $sqlFile) {
131			$sqlFileVersion = pathinfo($sqlFile, PATHINFO_FILENAME);
132			if (version_compare($sqlFileVersion, $version) > 0) {
133			$this->executeFile($sqlFile);
134			}
135			}
136			}
137
138			private function versionSort($a, $b)
139			{
140			return version_compare($a, $b);
141			}
142
143			private function updateVersion($version = AJDE_VERSION)
144			{
145			$this->getConnection()->query("UPDATE ajde SET v = '".$version."' WHERE k = 'version' LIMIT 1");
146			}
147
148			public function install()
149			{
150			if ($this->isInstalled()) {
151			die('DB already installed');
152			}
153
154			$this->installFromVersion();
155			$this->updateVersion();
156
157			die('DB installed. <a href="index.php">Proceed to homepage</a>');
158			}
159
160			private function isInstalled()
161			{
162			return $this->getConnection()->query("SHOW TABLES LIKE 'ajde'")->rowCount() > 0;
163			}
164			}
165

nabble / ajde

Ajde_Db::install() A last analyzed 2016-09-18 20:02 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Ajde_Db::install() A
last analyzed 2016-09-18 20:02 UTC