Ajde_Collection_View::__construct() - Code Metrics - nabble/ajde - Measure and Improve Code Quality continuously with Scrutinizer

Ajde_Collection_View::__construct() A
last analyzed 2016-09-18 20:02 UTC

↳ Parent: Ajde_Collection_View

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	17
nc	1
nop	2
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0

<?php

class Ajde_Collection_View extends Ajde_Object_Standard
{
    private $_tableName;

    private $_rowCount;

    public function __construct($tableName, $listOptions = [])
    {
        $this->_tableName = $tableName;

        $defaultOptions = [
            'page'              => 1,
            'pageSize'          => 100,
            'filter'            => [],
            'search'            => null,
            'orderBy'           => null,
            'orderDir'          => Ajde_Query::ORDER_ASC,
            'viewType'          => 'list',
            'filterVisible'     => false,
            'disableFilter'     => false,
            'mainFilter'        => '',
            'mainFilterGrouper' => '',
            'columns'           => [],
        ];
        $options = array_merge($defaultOptions, $listOptions);
        $this->setOptions($options);
    }

    public function setOptions($options)
    {
        foreach ($options as $key => $value) {
            $this->set($key, $value);
        }
    }

    public function getPage()
    {
        return parent::getPage();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getPageSize()
    {
        return parent::getPageSize();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getSearch()
    {
        return parent::getSearch();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getOrderBy()
    {
        return parent::getOrderBy();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getOrderDir()
    {
        return parent::getOrderDir();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getFilter()
    {
        return parent::getFilter();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getViewType()
    {
        return parent::getViewType();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getFilterVisible()
    {
        return parent::getFilterVisible();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getDisableFilter()
    {
        return parent::getDisableFilter();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getMainFilter()
    {
        return parent::getMainFilter();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getMainFilterGrouper()
    {
        return parent::getMainFilterGrouper();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function getFilterForField($fieldName)
    {
        $filters = $this->getFilter();
        if (!array_key_exists($fieldName, $filters)) {
            return;
        }

        return $filters[$fieldName];
    }

    public function getRowCount(Ajde_Collection $collection = null)
    {
        if (isset($collection)) {
            return $collection->count(true);
        }
        if (!isset($this->_rowCount)) {
            $sql = 'SELECT COUNT(*) AS count FROM '.$this->_tableName;
            $connection = Ajde_Db::getInstance()->getConnection();
            $statement = $connection->prepare($sql);
            $statement->execute();
            $result = $statement->fetch(PDO::FETCH_ASSOC);
            $this->_rowCount = $result['count'];
        }

        return $this->_rowCount;
    }

    public function setColumns($columns)
    {
        $this->set('columns', $columns);
    }

    public function getColumns()
    {
        return $this->get('columns');
    }

    public function getPageCount(Ajde_Collection $collection = null)
    {
        return ceil($this->getRowCount($collection) / $this->getPageSize());
    }

    public function getRowStart()
    {
        return ($this->getPage() - 1) * $this->getPageSize();
    }
}


1			<?php
2
3			class Ajde_Collection_View extends Ajde_Object_Standard
4			{
5			private $_tableName;
6
7			private $_rowCount;
8
9			public function __construct($tableName, $listOptions = [])
10			{
11			$this->_tableName = $tableName;
12
13			$defaultOptions = [
14			'page' => 1,
15			'pageSize' => 100,
16			'filter' => [],
17			'search' => null,
18			'orderBy' => null,
19			'orderDir' => Ajde_Query::ORDER_ASC,
20			'viewType' => 'list',
21			'filterVisible' => false,
22			'disableFilter' => false,
23			'mainFilter' => '',
24			'mainFilterGrouper' => '',
25			'columns' => [],
26			];
27			$options = array_merge($defaultOptions, $listOptions);
28			$this->setOptions($options);
29			}
30
31			public function setOptions($options)
32			{
33			foreach ($options as $key => $value) {
34			$this->set($key, $value);
35			}
36			}
37
38			public function getPage()
39			{
40			return parent::getPage();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getPage()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
41			}
42
43			public function getPageSize()
44			{
45			return parent::getPageSize();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getPageSize()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
46			}
47
48			public function getSearch()
49			{
50			return parent::getSearch();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getSearch()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
51			}
52
53			public function getOrderBy()
54			{
55			return parent::getOrderBy();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getOrderBy()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
56			}
57
58			public function getOrderDir()
59			{
60			return parent::getOrderDir();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getOrderDir()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
61			}
62
63			public function getFilter()
64			{
65			return parent::getFilter();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getFilter()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `AclCollection`, `Ajde_Acl_Collection`, `Ajde_Acl_Proxy_Collection`, `Ajde_Collection`, `Ajde_Collection_View`, `Ajde_Collection_With_Acl`, `Ajde_Collection_With_AclI18n`, `Ajde_Collection_With_I18n`, `Ajde_Crud_Options_List_View`, `Ajde_Lang_Proxy_Collection`, `Ajde_Shop_Cart_Item_Collection`, `CartCollection`, `CartItemCollection`, `EmailCollection`, `FormCollection`, `LogCollection`, `MailerlogCollection`, `MediaCollection`, `MediatypeCollection`, `MenuCollection`, `MetaCollection`, `NodeCollection`, `NodetypeCollection`, `ProductCollection`, `RevisionCollection`, `SettingCollection`, `SsoCollection`, `SubmissionCollection`, `TagCollection`, `TemplateCollection`, `TestCollection`, `TransactionCollection`, `TransactionItemCollection`, `UserCollection`, `UsergroupCollection`, `VatCollection`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
66			}
67
68			public function getViewType()
69			{
70			return parent::getViewType();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getViewType()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
71			}
72
73			public function getFilterVisible()
74			{
75			return parent::getFilterVisible();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getFilterVisible()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
76			}
77
78			public function getDisableFilter()
79			{
80			return parent::getDisableFilter();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getDisableFilter()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
81			}
82
83			public function getMainFilter()
84			{
85			return parent::getMainFilter();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getMainFilter()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
86			}
87
88			public function getMainFilterGrouper()
89			{
90			return parent::getMainFilterGrouper();
			0 ignored issues – show Bug introduced 2015-12-10 15:15 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajde_Object_Standard` as the method `getMainFilterGrouper()` does only exist in the following sub-classes of `Ajde_Object_Standard`: `Ajde_Collection_View`, `Ajde_Crud_Options_List_View`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
91			}
92
93			public function getFilterForField($fieldName)
94			{
95			$filters = $this->getFilter();
96			if (!array_key_exists($fieldName, $filters)) {
97			return;
98			}
99
100			return $filters[$fieldName];
101			}
102
103			public function getRowCount(Ajde_Collection $collection = null)
104			{
105			if (isset($collection)) {
106			return $collection->count(true);
107			}
108			if (!isset($this->_rowCount)) {
109			$sql = 'SELECT COUNT(*) AS count FROM '.$this->_tableName;
110			$connection = Ajde_Db::getInstance()->getConnection();
111			$statement = $connection->prepare($sql);
112			$statement->execute();
113			$result = $statement->fetch(PDO::FETCH_ASSOC);
114			$this->_rowCount = $result['count'];
115			}
116
117			return $this->_rowCount;
118			}
119
120			public function setColumns($columns)
121			{
122			$this->set('columns', $columns);
123			}
124
125			public function getColumns()
126			{
127			return $this->get('columns');
128			}
129
130			public function getPageCount(Ajde_Collection $collection = null)
131			{
132			return ceil($this->getRowCount($collection) / $this->getPageSize());
133			}
134
135			public function getRowStart()
136			{
137			return ($this->getPage() - 1) * $this->getPageSize();
138			}
139			}
140

nabble / ajde

Ajde_Collection_View::__construct() A last analyzed 2016-09-18 20:02 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Ajde_Collection_View::__construct() A
last analyzed 2016-09-18 20:02 UTC