nZEDb / nZEDb

misc/testing/DB/convert_mysql_tables.php

Upper-Lower-Casing +16 added lines, -16 removed lines

@@ -10,26 +10,26 @@ 
 
 if (isset($argv[1]) && isset($argv[2]) && $argv[2] == "fmyisam") {
 	$tbl = $argv[1];
-	printf($cli->header("Converting $tbl"));
+	printf($cli->header("converting $tbl"));
 	$pdo->queryExec("ALTER TABLE $tbl ENGINE=MYISAM ROW_FORMAT=FIXED");
 } else if (isset($argv[1]) && isset($argv[2]) && $argv[2] == "dmyisam") {
 	$tbl = $argv[1];
-	printf($cli->header("Converting $tbl"));
+	printf($cli->header("converting $tbl"));
 	$pdo->queryExec("ALTER TABLE $tbl ENGINE=MYISAM ROW_FORMAT=DYNAMIC");
 } else if (isset($argv[1]) && isset($argv[2]) && $argv[2] == "cinnodb") {
 	$tbl = $argv[1];
-	printf($cli->header("Converting $tbl"));
+	printf($cli->header("converting $tbl"));
 	$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=COMPRESSED");
 } else if (isset($argv[1]) && isset($argv[2]) && $argv[2] == "dinnodb") {
 	$tbl = $argv[1];
-	printf($cli->header("Converting $tbl"));
+	printf($cli->header("converting $tbl"));
 	$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=DYNAMIC");
 } else if (isset($argv[1]) && $argv[1] == "fmyisam") {
 	$sql = 'SHOW TABLE STATUS WHERE (Engine != "MyIsam" OR Row_format != "FIXED") AND Engine != "SPHINX"';
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=MYISAM ROW_FORMAT=FIXED");
 	}
 } else if (isset($argv[1]) && $argv[1] == "dmyisam") {
@@ -37,7 +37,7 @@ 
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=MYISAM ROW_FORMAT=DYNAMIC");
 	}
 } else if (isset($argv[1]) && $argv[1] == "dinnodb") {
@@ -50,7 +50,7 @@ 
 			$tbl !== 'consoleinfo' &&
 			$tbl !== 'musicinfo'
 		) {
-			printf($cli->header("Converting $tbl"));
+			printf($cli->header("converting $tbl"));
 			$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=DYNAMIC");
 		}
 	}
@@ -58,7 +58,7 @@ 
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=DYNAMIC");
 	}
 } else if (isset($argv[1]) && $argv[1] == "cinnodb") {
@@ -72,7 +72,7 @@ 
 			$tbl !== 'consoleinfo' &&
 			$tbl !== 'musicinfo'
 		) {
-			printf($cli->header("Converting $tbl"));
+			printf($cli->header("converting $tbl"));
 			$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=COMPRESSED");
 		}
 	}
@@ -80,14 +80,14 @@ 
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=DYNAMIC");
 	}
 	$sql = 'SHOW TABLE STATUS WHERE Name IN ("release_search_data", "bookinfo", "consoleinfo", "musicinfo") AND (Engine != "InnoDB" || Row_format != "Compressed")';
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=COMPRESSED");
 	}
 } else if (isset($argv[1]) && $argv[1] == "cinnodb-noparts") {
@@ -102,7 +102,7 @@ 
 			$tbl !== 'musicinfo' &&
 			!preg_match('/parts/', $tbl)
 		) {
-			printf($cli->header("Converting $tbl"));
+			printf($cli->header("converting $tbl"));
 			$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=COMPRESSED");
 		}
 	}
@@ -110,28 +110,28 @@ 
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=DYNAMIC");
 	}
 	$sql = 'SHOW TABLE STATUS WHERE Name LIKE "parts%" AND (Engine != "MyISAM" || Row_format != "Dynamic")';
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=MyISAM ROW_FORMAT=DYNAMIC");
 	}
 	$sql = 'SHOW TABLE STATUS WHERE Name IN ("release_search_data", "bookinfo", "consoleinfo", "musicinfo") AND (Engine != "InnoDB" || Row_format != "Compressed")';
 	$tables = $pdo->query($sql);
 	foreach ($tables as $row) {
 		$tbl = $row['name'];
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=INNODB ROW_FORMAT=COMPRESSED");
 	}
 } else if (isset($argv[1]) && $argv[1] == "collections") {
 	$arr = ["parts", "binaries", "collections"];
 	foreach ($arr as $row) {
 		$tbl = $row;
-		printf($cli->header("Converting $tbl"));
+		printf($cli->header("converting $tbl"));
 		$pdo->queryExec("ALTER TABLE $tbl ENGINE=MYISAM ROW_FORMAT=FIXED");
 	}
 } else {

nzedb/Binaries.php

Spacing +1 added lines, -1 removed lines

@@ -390,7 +390,7 @@
 				}
 				$this->partRepair($groupMySQL);
 				$mgrPosters = $this->getMultiGroupPosters();
-				if ($this->allAsMgr === true || ! empty($mgrPosters)) {
+				if ($this->allAsMgr === true || !empty($mgrPosters)) {
 					$tableNames = ProcessReleasesMultiGroup::tableNames();
 					$this->partRepair($groupMySQL, $tableNames);
 				}

Braces +3 added lines, -3 removed lines

@@ -747,7 +747,8 @@ 
 				if (!stristr($header['Subject'], 'yEnc')) {
 					$header['matches'][1] .= ' yEnc';
 				}
-			} else { // It failed to match, so no parts data. Log the Subject IF option is
+			} else {
+// It failed to match, so no parts data. Log the Subject IF option is
 				// enabled AND it's not prefixed by '"Usenet Index Post'
 				if ($this->_showDroppedYEncParts === true && strpos($header['Subject'], '"Usenet Index Post') !== 0) {
 					file_put_contents(
@@ -868,8 +869,7 @@ 
 			"INSERT IGNORE INTO {$this->tableNames['pname']} (binaries_id, number, messageid, partnumber, size) VALUES ";
 
 		// Loop articles, figure out files/parts.
-		foreach ($headers as $this->header)
-		{
+		foreach ($headers as $this->header) {
 			// Set up the info for inserting into parts/binaries/collections tables.
 			if (!isset($articles[$this->header['matches'][1]])) {
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -685,7 +685,7 @@ 
 			if ($this->_nntp::isError($headers)) {
 				$message = ($headers->code == 0 ? 'Unknown error' : $headers->message);
 				$this->log(
-					"Code {$headers->code}: $message\nSkipping group: {$this->groupMySQL['name']}",
+					"code {$headers->code}: $message\nSkipping group: {$this->groupMySQL['name']}",
 					__FUNCTION__,
 					Logger::LOG_WARNING,
 					'error'
@@ -711,7 +711,7 @@ 
 
 		$headersRepaired = $rangeNotReceived = $this->headersReceived = $this->headersNotInserted = [];
 
-		foreach ($headers AS $header) {
+		foreach ($headers as $header) {
 
 			// Check if we got the article or not.
 			if (isset($header['Number'])) {

app/controllers/PagesController.php

Braces +2 added lines, -1 removed lines

@@ -23,7 +23,8 @@
  * For example, browsing to `/pages/about/company` will render
  * `/views/pages/about/company.html.php`.
  */
-class PagesController extends \lithium\action\Controller {
+class PagesController extends \lithium\action\Controller
+{
 
 	public function view()
 	{

nzedb/processing/post/AniDB.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -255,7 +255,7 @@
 				$this->updateRelease($anidbId['anidbid'], $release['id']);
 
 				$this->pdo->log->doEcho(
-					$this->pdo->log->headerOver("Matched {$type} AniDB ID: ") .
+					$this->pdo->log->headerOver("matched {$type} AniDB ID: ") .
 					$this->pdo->log->primary($anidbId['anidbid']) .
 					$this->pdo->log->alternateOver('   Title: ') .
 					$this->pdo->log->primary($anidbId['title']) .

nzedb/utility/Misc.php

Indentation +11 added lines, -11 removed lines

@@ -189,14 +189,14 @@ 
 
 
 /**
-	 * Use cURL To download a web page into a string.
-	 *
-	 * @param array $options See details below.
-	 *
-	 * @return mixed|false
-	 * @access public
-	 * @static
-	 */
+ * Use cURL To download a web page into a string.
+ *
+ * @param array $options See details below.
+ *
+ * @return mixed|false
+ * @access public
+ * @static
+ */
 	public static function getUrl(array $options = [])
 	{
 		$defaults = [
@@ -208,10 +208,10 @@ 
 			'useragent'      => '',    // String ; User agent string.
 			'cookie'         => '',    // String ; Cookie string.
 			'requestheaders' => [],    // Array  ; List of request headers.
-			                           //          Example: ["Content-Type: application/json", "DNT: 1"]
+									   //          Example: ["Content-Type: application/json", "DNT: 1"]
 			'verifycert'     => true,  // Boolean; Verify certificate authenticity?
-			                           //          Since curl does not have a verify self signed certs option,
-			                           //          you should use this instead if your cert is self signed.
+									   //          Since curl does not have a verify self signed certs option,
+									   //          you should use this instead if your cert is self signed.
 		];
 
 		$options += $defaults;

Spacing +26 added lines, -28 removed lines

@@ -200,16 +200,16 @@ 
 	public static function getUrl(array $options = [])
 	{
 		$defaults = [
-			'url'            => '',    // String ; The URL to download.
+			'url'            => '', // String ; The URL to download.
 			'method'         => 'get', // String ; Http method, get/post/etc..
-			'postdata'       => '',    // String ; Data to send on post method.
-			'language'       => '',    // String ; Language in request header string.
+			'postdata'       => '', // String ; Data to send on post method.
+			'language'       => '', // String ; Language in request header string.
 			'debug'          => false, // Boolean; Show curl debug information.
-			'useragent'      => '',    // String ; User agent string.
-			'cookie'         => '',    // String ; Cookie string.
-			'requestheaders' => [],    // Array  ; List of request headers.
+			'useragent'      => '', // String ; User agent string.
+			'cookie'         => '', // String ; Cookie string.
+			'requestheaders' => [], // Array  ; List of request headers.
 			                           //          Example: ["Content-Type: application/json", "DNT: 1"]
-			'verifycert'     => true,  // Boolean; Verify certificate authenticity?
+			'verifycert'     => true, // Boolean; Verify certificate authenticity?
 			                           //          Since curl does not have a verify self signed certs option,
 			                           //          you should use this instead if your cert is self signed.
 		];
@@ -311,7 +311,7 @@ 
 			$response = $client->get($url)->getBody()->getContents();
 		} catch (RequestException $e) {
 			if ($e->hasResponse()) {
-				if($e->getCode() === 404) {
+				if ($e->getCode() === 404) {
 					ColorCLI::doEcho(ColorCLI::notice('Data not available on server'));
 				} else if ($e->getCode() === 503) {
 					ColorCLI::doEcho(ColorCLI::notice('Service unavailable'));
@@ -689,7 +689,7 @@ 
 	public static function maintainanceCheck($outputMessage = true): ?bool
 	{
 		if (defined('MAINTENANCE_MODE_ENABLED') && MAINTENANCE_MODE_ENABLED === true) {
-			if (!in_array($_SERVER['REMOTE_ADDR'], MAINTENANCE_MODE_IP_EXCEPTIONS) ) {
+			if (!in_array($_SERVER['REMOTE_ADDR'], MAINTENANCE_MODE_IP_EXCEPTIONS)) {
 				$page = (isset($_GET['page']) ? $_GET['page'] : 'content');
 				switch ($page) {
 					case 'api':
@@ -757,13 +757,13 @@ 
 	public static function xmlToArray(\SimpleXMLElement $xml, $options = array()): array
 	{
 		$defaults = array(
-			'namespaceSeparator' => ':',//you may want this to be something other than a colon
-			'attributePrefix' => '@',   //to distinguish between attributes and nodes with the same name
-			'alwaysArray' => array(),   //array of xml tag names which should always become arrays
-			'autoArray' => true,        //only create arrays for tags which appear more than once
-			'textContent' => '$',       //key used for the text content of elements
-			'autoText' => true,         //skip textContent key if node has no attributes or child nodes
-			'keySearch' => false,       //optional search and replace on tag and attribute names
+			'namespaceSeparator' => ':', //you may want this to be something other than a colon
+			'attributePrefix' => '@', //to distinguish between attributes and nodes with the same name
+			'alwaysArray' => array(), //array of xml tag names which should always become arrays
+			'autoArray' => true, //only create arrays for tags which appear more than once
+			'textContent' => '$', //key used for the text content of elements
+			'autoText' => true, //skip textContent key if node has no attributes or child nodes
+			'keySearch' => false, //optional search and replace on tag and attribute names
 			'keyReplace' => false       //replace values for above search values (as passed to str_replace())
 		);
 		$options = array_merge($defaults, $options);
@@ -899,8 +899,8 @@ 
 	{
 		// Check to make sure the user has their settings correct.
 		if (PHPMAILER_USE_SMTP === true) {
-			if ((! \defined('PHPMAILER_SMTP_HOST') || PHPMAILER_SMTP_HOST === '') ||
-				(! \defined('PHPMAILER_SMTP_PORT') || PHPMAILER_SMTP_PORT === '')
+			if ((!\defined('PHPMAILER_SMTP_HOST') || PHPMAILER_SMTP_HOST === '') ||
+				(!\defined('PHPMAILER_SMTP_PORT') || PHPMAILER_SMTP_PORT === '')
 			) {
 				throw new PHPMailerException(
 					'You opted to use SMTP but the PHPMAILER_SMTP_HOST and/or PHPMAILER_SMTP_PORT is/are not defined correctly! Either fix the missing/incorrect values or change PHPMAILER_USE_SMTP to false in the www/settings.php'
@@ -909,8 +909,8 @@ 
 
 			// If the user enabled SMTP & Auth but did not setup credentials, throw an exception.
 			if (\defined('PHPMAILER_SMTP_AUTH') && PHPMAILER_SMTP_AUTH === true) {
-				if ((! \defined('PHPMAILER_SMTP_USER') || PHPMAILER_SMTP_USER === '') ||
-					(! \defined('PHPMAILER_SMTP_PASSWORD') || PHPMAILER_SMTP_PASSWORD === '')
+				if ((!\defined('PHPMAILER_SMTP_USER') || PHPMAILER_SMTP_USER === '') ||
+					(!\defined('PHPMAILER_SMTP_PASSWORD') || PHPMAILER_SMTP_PASSWORD === '')
 				) {
 					throw new PHPMailerException(
 						'You opted to use SMTP and SMTP Auth but the PHPMAILER_SMTP_USER and/or PHPMAILER_SMTP_PASSWORD is/are not defined correctly. Please set them in www/settings.php'
@@ -927,7 +927,7 @@ 
 		 *
 		 * @todo Log this failure.
 		 */
-		if (! ($mail instanceof \PHPMailer\PHPMailer\PHPMailer)) {
+		if (!($mail instanceof \PHPMailer\PHPMailer\PHPMailer)) {
 			$result = self::sendEmailViaPHP($to, $subject, $body, $from);
 		} else {
 			$mail->isHTML(true);
@@ -947,11 +947,9 @@ 
 				}
 			}
 
-			$fromEmail = (PHPMAILER_FROM_EMAIL === '') ? Settings::value('site.main.email') :
-				PHPMAILER_FROM_EMAIL;
-			$fromName = (PHPMAILER_FROM_NAME === '') ? Settings::value('site.main.title') :
-				PHPMAILER_FROM_NAME;
-			$replyTo = ! empty($from) ? $from : PHPMAILER_REPLYTO;
+			$fromEmail = (PHPMAILER_FROM_EMAIL === '') ? Settings::value('site.main.email') : PHPMAILER_FROM_EMAIL;
+			$fromName = (PHPMAILER_FROM_NAME === '') ? Settings::value('site.main.title') : PHPMAILER_FROM_NAME;
+			$replyTo = !empty($from) ? $from : PHPMAILER_REPLYTO;
 
 			if (PHPMAILER_BCC !== '') {
 				$mail->addBCC(PHPMAILER_BCC);
@@ -966,7 +964,7 @@ 
 
 			$result = $mail->send();
 
-			if (! $result) {
+			if (!$result) {
 				//@todo Log failed email send attempt.
 				throw new PHPMailerException('Unable to send mail. Error: ' . $mail->ErrorInfo);
 			}
@@ -1040,7 +1038,7 @@ 
 			"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" .
 			'<error code="' . $status . '" description="' . $message . "\"/>\n";
 		header('Content-type: text/xml');
-		header('Content-Length: ' . \strlen($response) );
+		header('Content-Length: ' . \strlen($response));
 		header('X-nZEDb: API ERROR [' . $status . '] ' . $message);
 		http_response_code($status);
 

Braces +12 added lines, -4 removed lines

@@ -775,8 +775,10 @@ 
 			//get attributes from all namespaces
 			foreach ($xml->attributes($namespace) as $attributeName => $attribute) {
 				//replace characters in attribute name
-				if ($options['keySearch']) $attributeName =
+				if ($options['keySearch']) {
+					$attributeName =
 					str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
+				}
 				$attributeKey = $options['attributePrefix']
 					. ($prefix ? $prefix . $options['namespaceSeparator'] : '')
 					. $attributeName;
@@ -790,10 +792,14 @@ 
 				$childProperties = current($childArray);
 
 				//replace characters in tag name
-				if ($options['keySearch']) $childTagName =
+				if ($options['keySearch']) {
+					$childTagName =
 					str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
+				}
 				//add namespace prefix, if any
-				if ($prefix) $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+				if ($prefix) {
+					$childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+				}
 
 				if (!isset($tagsArray[$childTagName])) {
 					//only entry with this key
@@ -817,7 +823,9 @@ 
 		//get text content of node
 		$textContentArray = array();
 		$plainText = trim((string)$xml);
-		if ($plainText !== '') $textContentArray[$options['textContent']] = $plainText;
+		if ($plainText !== '') {
+			$textContentArray[$options['textContent']] = $plainText;
+		}
 
 		//stick it all together
 		$propertiesArray = !$options['autoText'] || $attributesArray || $tagsArray || ($plainText === '')

www/pages/contact-us.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 		}
 	}
 
-	if (! \preg_match("/\n/i", $_POST['useremail'])) {
+	if (!\preg_match("/\n/i", $_POST['useremail'])) {
 		Misc::sendEmail($mailto, $mailsubj, $mailbody, $email);
 	}
 	$msg = "<h2 style='text-align:center;'>Thank you for getting in touch with " . $title . '.</h2>';

app/extensions/command/verify/Tables.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -197,7 +197,7 @@
 		$rows = \file($options['file']);
 
 		if (! \is_array($rows)) {
-			throw new \InvalidArgumentException("File {$options['file']} did not return a list of rows!");
+			throw new \InvalidArgumentException("file {$options['file']} did not return a list of rows!");
 		}
 
 		// Move the column names/order off of the array.

Spacing +6 added lines, -6 removed lines

@@ -118,9 +118,9 @@ 
 			//$groups = new Groups();
 			/* @var $ids string[][] */
 			foreach ($ids as $groupID) {
-				if (! \in_array('binaries_' . $groupID, $binaries, false) ||
-					! \in_array('collections_' . $groupID, $collections, false) ||
-					! \in_array('parts_' . $groupID, $parts, false)
+				if (!\in_array('binaries_' . $groupID, $binaries, false) ||
+					!\in_array('collections_' . $groupID, $collections, false) ||
+					!\in_array('parts_' . $groupID, $parts, false)
 				) {
 					echo "Creating missing tables for group id: $groupID" . PHP_EOL;
 					$errors[] = $groupID;
@@ -199,16 +199,16 @@ 
 		$fix = $output = $test = '';
 		\extract($options, EXTR_IF_EXISTS | EXTR_REFS); // create short-name variable refs
 
-		if (! \is_callable($test)) {
+		if (!\is_callable($test)) {
 			throw new \InvalidArgumentException('The option "test" must be a closure to perform the test!');
 		}
 
-		if (! \file_exists($options['file'])) {
+		if (!\file_exists($options['file'])) {
 			throw new \InvalidArgumentException("Unable to find {$options['file']}!");
 		}
 		$rows = \file($options['file']);
 
-		if (! \is_array($rows)) {
+		if (!\is_array($rows)) {
 			throw new \InvalidArgumentException("File {$options['file']} did not return a list of rows!");
 		}
 

misc/update/nix/multiprocessing/postprocess.php

Spacing +1 added lines, -1 removed lines

@@ -17,6 +17,6 @@
 
 use nzedb\libraries\Forking;
 
-declare(ticks = 1);
+declare(ticks=1);
 
 (new Forking())->processWorkType('postProcess_' . $argv[1], (isset($argv[2]) && $argv[2] === 'true' ? [0 => true] : []));

misc/update/nix/multiprocessing/releases.php

Spacing +1 added lines, -1 removed lines

@@ -4,6 +4,6 @@
 
 use nzedb\libraries\Forking;
 
-declare(ticks = 1);
+declare(ticks=1);
 
 (new Forking())->processWorkType('releases');