Video::getEmbed() - Code Metrics - Inspection of "Enable laravel 5.5 auto discovery" - nWidart/laravel-videoable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7fe1f3...1b6da9 )

by Nicolas

created 2017-06-02 09:45 UTC

Video::getEmbed() A

↳ Parent: Video

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php

namespace Nwidart\LaravelVideoable\Models;

use Illuminate\Database\Eloquent\Model;
use Nwidart\LaravelVideoable\Exceptions\VideoPresenterNotFound;

class Video extends Model
{
    protected $table = 'laravel_videoables';
    protected $fillable = ['source', 'code', 'title', 'width', 'height', 'videoable_id', 'videoable_type'];

    public function videoable()
    {
        return $this->morphTo();
    }

    public function getEmbed()
    {
        $sourceClass = config("laravel-videoable.sources.{$this->source}");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (class_exists($sourceClass) === false) {
            throw new VideoPresenterNotFound($sourceClass);
        }

        return (new $sourceClass(get_object_vars($this)))->getEmbedCode();
    }
}


1		<?php
2
3		namespace Nwidart\LaravelVideoable\Models;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Nwidart\LaravelVideoable\Exceptions\VideoPresenterNotFound;
7
8		class Video extends Model
9		{
10		protected $table = 'laravel_videoables';
11		protected $fillable = ['source', 'code', 'title', 'width', 'height', 'videoable_id', 'videoable_type'];
12
13		public function videoable()
14		{
15		return $this->morphTo();
16		}
17
18	4	public function getEmbed()
19		{
20	4	$sourceClass = config("laravel-videoable.sources.{$this->source}");
		0 ignored issues – show Documentation introduced 2017-02-21 12:17 UTC by Report Bug Copy Issue Report The property `source` does not exist on `object<Nwidart\LaravelVideoable\Models\Video>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
21
22	4	if (class_exists($sourceClass) === false) {
23	1	throw new VideoPresenterNotFound($sourceClass);
24		}
25
26	3	return (new $sourceClass(get_object_vars($this)))->getEmbedCode();
27		}
28		}
29

nWidart / laravel-videoable

Push — master ( 7fe1f3...1b6da9 )

Video::getEmbed() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like