Completed
Pull Request — master (#463)
by František
06:37
created
src/Collection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      */
25 25
     public function toArray()
26 26
     {
27
-        return array_map(function ($value) {
27
+        return array_map(function($value) {
28 28
             if ($value instanceof Module) {
29 29
                 $attributes = $value->json()->getAttributes();
30 30
                 $attributes["path"] = $value->getPath();
Please login to merge, or discard this patch.
src/Laravel/Repository.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Nwidart\Modules\Laravel;
4 4
 
5
-use Nwidart\Modules\Json;
6 5
 use Nwidart\Modules\Repository as BaseRepository;
7 6
 
8 7
 class Repository extends BaseRepository
Please login to merge, or discard this patch.
src/Lumen/Repository.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Nwidart\Modules\Lumen;
4 4
 
5
-use Nwidart\Modules\Json;
6 5
 use Nwidart\Modules\Repository as BaseRepository;
7 6
 
8 7
 class Repository extends BaseRepository
Please login to merge, or discard this patch.
src/Repository.php 2 patches
Doc Comments   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -115,7 +115,6 @@  discard block
 block discarded – undo
115 115
     /**
116 116
      * Creates a new Module instance
117 117
      * 
118
-     * @param Container $app
119 118
      * @param $name
120 119
      * @param $path
121 120
      * @return \Nwidart\Modules\Module
@@ -420,7 +419,7 @@  discard block
 block discarded – undo
420 419
     /**
421 420
      * Get module path for a specific module.
422 421
      *
423
-     * @param $module
422
+     * @param string $module
424 423
      *
425 424
      * @return string
426 425
      */
@@ -448,9 +447,9 @@  discard block
 block discarded – undo
448 447
     /**
449 448
      * Get a specific config data from a configuration file.
450 449
      *
451
-     * @param $key
450
+     * @param string $key
452 451
      *
453
-     * @param null $default
452
+     * @param string $default
454 453
      * @return mixed
455 454
      */
456 455
     public function config($key, $default = null)
@@ -650,7 +649,7 @@  discard block
 block discarded – undo
650 649
     /**
651 650
      * Get stub path.
652 651
      *
653
-     * @return string|null
652
+     * @return string|boolean
654 653
      */
655 654
     public function getStubPath()
656 655
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
             $paths = array_merge($paths, $this->config('scan.paths'));
107 107
         }
108 108
 
109
-        $paths = array_map(function ($path) {
109
+        $paths = array_map(function($path) {
110 110
             return ends_with($path, '/*') ? $path : str_finish($path, '/*');
111 111
         }, $paths);
112 112
 
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
      */
191 191
     public function getCached()
192 192
     {
193
-        return $this->app['cache']->remember($this->config('cache.key'), $this->config('cache.lifetime'), function () {
193
+        return $this->app['cache']->remember($this->config('cache.key'), $this->config('cache.lifetime'), function() {
194 194
             return $this->toCollection()->toArray();
195 195
         });
196 196
     }
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
     {
279 279
         $modules = $this->enabled();
280 280
 
281
-        uasort($modules, function (Module $a, Module $b) use ($direction) {
281
+        uasort($modules, function(Module $a, Module $b) use ($direction) {
282 282
             if ($a->order == $b->order) {
283 283
                 return 0;
284 284
             }
@@ -428,9 +428,9 @@  discard block
 block discarded – undo
428 428
     public function getModulePath($module)
429 429
     {
430 430
         try {
431
-            return $this->findOrFail($module)->getPath() . '/';
431
+            return $this->findOrFail($module)->getPath().'/';
432 432
         } catch (ModuleNotFoundException $e) {
433
-            return $this->getPath() . '/' . Str::studly($module) . '/';
433
+            return $this->getPath().'/'.Str::studly($module).'/';
434 434
         }
435 435
     }
436 436
 
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
      */
444 444
     public function assetPath($module) : string
445 445
     {
446
-        return $this->config('paths.assets') . '/' . $module;
446
+        return $this->config('paths.assets').'/'.$module;
447 447
     }
448 448
 
449 449
     /**
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
      */
457 457
     public function config($key, $default = null)
458 458
     {
459
-        return $this->app['config']->get('modules.' . $key, $default);
459
+        return $this->app['config']->get('modules.'.$key, $default);
460 460
     }
461 461
 
462 462
     /**
@@ -557,9 +557,9 @@  discard block
 block discarded – undo
557 557
         }
558 558
         list($name, $url) = explode(':', $asset);
559 559
 
560
-        $baseUrl = str_replace(public_path() . DIRECTORY_SEPARATOR, '', $this->getAssetsPath());
560
+        $baseUrl = str_replace(public_path().DIRECTORY_SEPARATOR, '', $this->getAssetsPath());
561 561
 
562
-        $url = $this->app['url']->asset($baseUrl . "/{$name}/" . $url);
562
+        $url = $this->app['url']->asset($baseUrl."/{$name}/".$url);
563 563
 
564 564
         return str_replace(['http://', 'https://'], '//', $url);
565 565
     }
Please login to merge, or discard this patch.
src/Support/Stub.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
      */
72 72
     public function getPath()
73 73
     {
74
-        $path = static::getBasePath() . $this->path;
74
+        $path = static::getBasePath().$this->path;
75 75
 
76
-        return file_exists($path) ? $path : __DIR__ . '/../Commands/stubs' . $this->path;
76
+        return file_exists($path) ? $path : __DIR__.'/../Commands/stubs'.$this->path;
77 77
     }
78 78
 
79 79
     /**
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         $contents = file_get_contents($this->getPath());
107 107
 
108 108
         foreach ($this->replaces as $search => $replace) {
109
-            $contents = str_replace('$' . strtoupper($search) . '$', $replace, $contents);
109
+            $contents = str_replace('$'.strtoupper($search).'$', $replace, $contents);
110 110
         }
111 111
 
112 112
         return $contents;
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
      */
133 133
     public function saveTo($path, $filename)
134 134
     {
135
-        return file_put_contents($path . '/' . $filename, $this->getContents());
135
+        return file_put_contents($path.'/'.$filename, $this->getContents());
136 136
     }
137 137
 
138 138
     /**
Please login to merge, or discard this patch.
config/config.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 
25 25
     'stubs' => [
26 26
         'enabled' => false,
27
-        'path' => base_path() . '/vendor/nwidart/laravel-modules/src/Commands/stubs',
27
+        'path' => base_path().'/vendor/nwidart/laravel-modules/src/Commands/stubs',
28 28
         'files' => [
29 29
             'start' => 'start.php',
30 30
             'routes' => 'Http/routes.php',
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         'replacements' => [
37 37
             'start' => ['LOWER_NAME', 'ROUTES_LOCATION'],
38 38
             'routes' => ['LOWER_NAME', 'STUDLY_NAME', 'MODULE_NAMESPACE'],
39
-            'json' => ['LOWER_NAME', 'STUDLY_NAME', 'MODULE_NAMESPACE','START_FILE'],
39
+            'json' => ['LOWER_NAME', 'STUDLY_NAME', 'MODULE_NAMESPACE', 'START_FILE'],
40 40
             'views/index' => ['LOWER_NAME'],
41 41
             'views/master' => ['STUDLY_NAME'],
42 42
             'scaffold/config' => ['STUDLY_NAME'],
Please login to merge, or discard this patch.