Nwidart\Modules\Commands\InstallCommand

Complexity

Total Complexity

14

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	installFromFile()	0	22	3
B	install()	0	29	6
A	getArguments()	0	7	1
A	getOptions()	0	10	1
A	handle()	0	15	2

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Console\Command;
use Nwidart\Modules\Json;
use Nwidart\Modules\Process\Installer;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;

class InstallCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:install';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Install the specified module by given package name (vendor/name).';

    /**
     * Create a new command instance.
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     */
    public function handle()
    {
        if (is_null($this->argument('name'))) {
            $this->installFromFile();

            return;
        }

        $this->install(
            $this->argument('name'),

It seems like $this->argument('name') targeting Illuminate\Console\Command::argument() can also be of type array; however, Nwidart\Modules\Commands\InstallCommand::install() does only seem to accept string, maybe add an additional type check?

            $this->argument('version'),

It seems like $this->argument('version') targeting Illuminate\Console\Command::argument() can also be of type array; however, Nwidart\Modules\Commands\InstallCommand::install() does only seem to accept string, maybe add an additional type check?

            $this->option('type'),

It seems like $this->option('type') targeting Illuminate\Console\Command::option() can also be of type array; however, Nwidart\Modules\Commands\InstallCommand::install() does only seem to accept string, maybe add an additional type check?

            $this->option('tree')

$this->option('tree') is of type string|array, but the function expects a boolean.

        );
    }

    /**
     * Install modules from modules.json file.
     */
    protected function installFromFile()
    {
        if (!file_exists($path = base_path('modules.json'))) {
            $this->error("File 'modules.json' does not exist in your project root.");

            return;
        }

        $modules = Json::make($path);

        $dependencies = $modules->get('require', []);

        foreach ($dependencies as $module) {
            $module = collect($module);

            $this->install(
                $module->get('name'),
                $module->get('version'),
                $module->get('type')
            );
        }
    }

    /**
     * Install the specified module.
     *
     * @param string $name
     * @param string $version
     * @param string $type
     * @param bool   $tree
     */
    protected function install($name, $version = 'dev-master', $type = 'composer', $tree = false)
    {
        $installer = new Installer(
            $name,
            $version,
            $type ?: $this->option('type'),

It seems like $type ?: $this->option('type') can also be of type array; however, Nwidart\Modules\Process\Installer::__construct() does only seem to accept string|null, maybe add an additional type check?

            $tree ?: $this->option('tree')
        );

        $installer->setRepository($this->laravel['modules']);

        $installer->setConsole($this);

        if ($timeout = $this->option('timeout')) {
            $installer->setTimeout($timeout);

$timeout is of type string|array, but the function expects a integer.

        }

        if ($path = $this->option('path')) {
            $installer->setPath($path);

It seems like $path defined by $this->option('path') on line 105 can also be of type array; however, Nwidart\Modules\Process\Installer::setPath() does only seem to accept string, maybe add an additional type check?

        }

        $installer->run();

        if (!$this->option('no-update')) {
            $this->call('module:update', [
                'module' => $installer->getModuleName(),
            ]);
        }
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return array(
            array('name', InputArgument::OPTIONAL, 'The name of module will be installed.'),
            array('version', InputArgument::OPTIONAL, 'The version of module will be installed.'),
        );
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return array(
            array('timeout', null, InputOption::VALUE_OPTIONAL, 'The process timeout.', null),
            array('path', null, InputOption::VALUE_OPTIONAL, 'The installation path.', null),
            array('type', null, InputOption::VALUE_OPTIONAL, 'The type of installation.', null),
            array('tree', null, InputOption::VALUE_NONE, 'Install the module as a git subtree', null),
            array('no-update', null, InputOption::VALUE_NONE, 'Disables the automatic update of the dependencies.', null),
        );
    }
}