ListCommand - Code Metrics - Inspection of "Adding new testcase for the list command" - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 108005...aa54f5 )

by Nicolas

created 2019-09-02 13:14 UTC

ListCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	80
Duplicated Lines	8.75 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

86.96%

Importance

Changes

Metric	Value
dl	7
loc	80
ccs	20
cts	23
cp	0.8696
rs	10
c	0
b	0
f	0
wmc	9
lcom	0
cbo	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getOptions()	7	7	1
A	handle()	0	4	1
A	getRows()	0	16	3
A	getModules()	0	20	4

How to fix Duplicated Code

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Console\Command;
use Nwidart\Modules\Module;
use Symfony\Component\Console\Input\InputOption;

class ListCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:list';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Show list of all modules.';

    /**
     * Execute the console command.
     */
    public function handle()
    {
        $this->table(['Name', 'Status', 'Order', 'Path'], $this->getRows());
    }

    /**
     * Get table rows.
     *
     * @return array
     */
    public function getRows()
    {
        $rows = [];

        /** @var Module $module */
        foreach ($this->getModules() as $module) {
            $rows[] = [
                $module->getName(),
                $module->isEnabled() ? 'Enabled' : 'Disabled',
                $module->get('order'),
                $module->getPath(),
            ];
        }

        return $rows;
    }

    public function getModules()
    {
        switch ($this->option('only')) {
            case 'enabled':
                return $this->laravel['modules']->getByStatus(1);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'disabled':
                return $this->laravel['modules']->getByStatus(0);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'ordered':
                return $this->laravel['modules']->getOrdered($this->option('direction'));
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                return $this->laravel['modules']->all();
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['only', 'o', InputOption::VALUE_OPTIONAL, 'Types of modules will be displayed.', null],
            ['direction', 'd', InputOption::VALUE_OPTIONAL, 'The direction of ordering.', 'asc'],
        ];
    }
}


1			<?php
2
3			namespace Nwidart\Modules\Commands;
4
5			use Illuminate\Console\Command;
6			use Nwidart\Modules\Module;
7			use Symfony\Component\Console\Input\InputOption;
8
9			class ListCommand extends Command
10			{
11			/**
12			* The console command name.
13			*
14			* @var string
15			*/
16			protected $name = 'module:list';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Show list of all modules.';
24
25			/**
26			* Execute the console command.
27			*/
28	1		public function handle()
29			{
30	1		$this->table(['Name', 'Status', 'Order', 'Path'], $this->getRows());
31	1		}
32
33			/**
34			* Get table rows.
35			*
36			* @return array
37			*/
38	1		public function getRows()
39			{
40	1		$rows = [];
41
42			/** @var Module $module */
43	1		foreach ($this->getModules() as $module) {
44	1		$rows[] = [
45	1		$module->getName(),
46	1		$module->isEnabled() ? 'Enabled' : 'Disabled',
47	1		$module->get('order'),
48	1		$module->getPath(),
49			];
50			}
51
52	1		return $rows;
53			}
54
55	1		public function getModules()
56			{
57	1		switch ($this->option('only')) {
58	1		case 'enabled':
59			return $this->laravel['modules']->getByStatus(1);
60			break;
			0 ignored issues – show Unused Code introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
61
62	1		case 'disabled':
63			return $this->laravel['modules']->getByStatus(0);
64			break;
			0 ignored issues – show Unused Code introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
65
66	1		case 'ordered':
67			return $this->laravel['modules']->getOrdered($this->option('direction'));
68			break;
			0 ignored issues – show Unused Code introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
69
70			default:
71	1		return $this->laravel['modules']->all();
72			break;
			0 ignored issues – show Unused Code introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
73			}
74			}
75
76			/**
77			* Get the console command options.
78			*
79			* @return array
80			*/
81	120	View Code Duplication	protected function getOptions()
82			{
83			return [
84	120		['only', 'o', InputOption::VALUE_OPTIONAL, 'Types of modules will be displayed.', null],
85			['direction', 'd', InputOption::VALUE_OPTIONAL, 'The direction of ordering.', 'asc'],
86			];
87			}
88			}
89

nWidart / laravel-modules

Push — master ( 108005...aa54f5 )

ListCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like