PublishTranslationCommand - Code Metrics - Inspection of "Testing model generation" - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 15e02a...758c52 )

by Nicolas

created 2016-06-29 13:02 UTC

PublishTranslationCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	73
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

12.5%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	2
dl	73
loc	73
ccs	3
cts	24
cp	0.125
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	fire()	8	8	2
A	publishAll()	6	6	2
A	publish()	15	15	2
A	getArguments()	6	6	1

How to fix Duplicated Code

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Console\Command;
use Nwidart\Modules\Module;
use Nwidart\Modules\Publishing\LangPublisher;
use Symfony\Component\Console\Input\InputArgument;

class PublishTranslationCommand extends Command

{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:publish-translation';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Publish a module\'s translations to the application';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        if ($name = $this->argument('module')) {
            return $this->publish($name);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        $this->publishAll();
    }

    /**
     * Publish assets from all modules.
     */
    public function publishAll()
    {
        foreach ($this->laravel['modules']->enabled() as $module) {
            $this->publish($module);
        }
    }

    /**
     * Publish assets from the specified module.
     *
     * @param string $name
     */
    public function publish($name)
    {
        if ($name instanceof Module) {
            $module = $name;
        } else {
            $module = $this->laravel['modules']->findOrFail($name);
        }

        with(new LangPublisher($module))
            ->setRepository($this->laravel['modules'])
            ->setConsole($this)
            ->publish();

        $this->line("<info>Published</info>: {$module->getStudlyName()}");
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['module', InputArgument::OPTIONAL, 'The name of module will be used.'],
        ];
    }
}


1			<?php
2
3			namespace Nwidart\Modules\Commands;
4
5			use Illuminate\Console\Command;
6			use Nwidart\Modules\Module;
7			use Nwidart\Modules\Publishing\LangPublisher;
8			use Symfony\Component\Console\Input\InputArgument;
9
10		View Code Duplication	class PublishTranslationCommand extends Command
			0 ignored issues – show Duplication introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11			{
12			/**
13			* The console command name.
14			*
15			* @var string
16			*/
17			protected $name = 'module:publish-translation';
18
19			/**
20			* The console command description.
21			*
22			* @var string
23			*/
24			protected $description = 'Publish a module\'s translations to the application';
25
26			/**
27			* Execute the console command.
28			*
29			* @return mixed
30			*/
31			public function fire()
32			{
33			if ($name = $this->argument('module')) {
34			return $this->publish($name);
			0 ignored issues – show Bug introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report It seems like `$name` defined by `$this->argument('module')` on line `33` can also be of type `array`; however, `Nwidart\Modules\Commands...ationCommand::publish()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35			}
36
37			$this->publishAll();
38			}
39
40			/**
41			* Publish assets from all modules.
42			*/
43			public function publishAll()
44			{
45			foreach ($this->laravel['modules']->enabled() as $module) {
46			$this->publish($module);
47			}
48			}
49
50			/**
51			* Publish assets from the specified module.
52			*
53			* @param string $name
54			*/
55			public function publish($name)
56			{
57			if ($name instanceof Module) {
58			$module = $name;
59			} else {
60			$module = $this->laravel['modules']->findOrFail($name);
61			}
62
63			with(new LangPublisher($module))
64			->setRepository($this->laravel['modules'])
65			->setConsole($this)
66			->publish();
67
68			$this->line("<info>Published</info>: {$module->getStudlyName()}");
69			}
70
71			/**
72			* Get the console command arguments.
73			*
74			* @return array
75			*/
76	16		protected function getArguments()
77			{
78			return [
79	16		['module', InputArgument::OPTIONAL, 'The name of module will be used.'],
80	16		];
81			}
82			}
83

nWidart / laravel-modules

Push — master ( 15e02a...758c52 )

PublishTranslationCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like