ModuleMakeCommand::handle() - Code Metrics - Inspection of "Merge pull request #459 from filtration/patch-1" - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0fd405...f8ea68 )

by Nicolas

created 2018-01-13 15:58 UTC

ModuleMakeCommand::handle() A

↳ Parent: ModuleMakeCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	11
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	15
ccs	12
cts	12
cp	1
crap	2
rs	9.4285

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Console\Command;
use Nwidart\Modules\Generators\ModuleGenerator;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;

class ModuleMakeCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:make';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a new module.';

    /**
     * Execute the console command.
     */
    public function handle()
    {
        $names = $this->argument('name');

        foreach ($names as $name) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            with(new ModuleGenerator($name))
                ->setFilesystem($this->laravel['files'])
                ->setModule($this->laravel['modules'])
                ->setConfig($this->laravel['config'])
                ->setConsole($this)
                ->setForce($this->option('force'))
                ->setPlain($this->option('plain'))
                ->generate();
        }
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['name', InputArgument::IS_ARRAY, 'The names of modules will be created.'],
        ];
    }

    protected function getOptions()
    {
        return [
            ['plain', 'p', InputOption::VALUE_NONE, 'Generate a plain module (without some resources).'],
            ['force', null, InputOption::VALUE_NONE, 'Force the operation to run when module already exist.'],
        ];
    }
}


1		<?php
2
3		namespace Nwidart\Modules\Commands;
4
5		use Illuminate\Console\Command;
6		use Nwidart\Modules\Generators\ModuleGenerator;
7		use Symfony\Component\Console\Input\InputArgument;
8		use Symfony\Component\Console\Input\InputOption;
9
10		class ModuleMakeCommand extends Command
11		{
12		/**
13		* The console command name.
14		*
15		* @var string
16		*/
17		protected $name = 'module:make';
18
19		/**
20		* The console command description.
21		*
22		* @var string
23		*/
24		protected $description = 'Create a new module.';
25
26		/**
27		* Execute the console command.
28		*/
29	91	public function handle()
30		{
31	91	$names = $this->argument('name');
32
33	91	foreach ($names as $name) {
		0 ignored issues – show Bug introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report The expression `$names` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
34	91	with(new ModuleGenerator($name))
35	91	->setFilesystem($this->laravel['files'])
36	91	->setModule($this->laravel['modules'])
37	91	->setConfig($this->laravel['config'])
38	91	->setConsole($this)
39	91	->setForce($this->option('force'))
40	91	->setPlain($this->option('plain'))
41	91	->generate();
42		}
43	91	}
44
45		/**
46		* Get the console command arguments.
47		*
48		* @return array
49		*/
50	91	protected function getArguments()
51		{
52		return [
53	91	['name', InputArgument::IS_ARRAY, 'The names of modules will be created.'],
54		];
55		}
56
57	91	protected function getOptions()
58		{
59		return [
60	91	['plain', 'p', InputOption::VALUE_NONE, 'Generate a plain module (without some resources).'],
61		['force', null, InputOption::VALUE_NONE, 'Force the operation to run when module already exist.'],
62		];
63		}
64		}
65

nWidart / laravel-modules

Push — master ( 0fd405...f8ea68 )

ModuleMakeCommand::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like