Completed
Pull Request — master (#790)
by
unknown
03:34
created
src/Publishing/Publisher.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
     /**
89 89
      * Get module instance.
90 90
      *
91
-     * @return \Nwidart\Modules\Module
91
+     * @return string
92 92
      */
93 93
     public function getModule()
94 94
     {
Please login to merge, or discard this patch.
src/Support/Migrations/NameParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
     /**
91 91
      * Get matches data from regex.
92 92
      *
93
-     * @return array
93
+     * @return string[]
94 94
      */
95 95
     public function getMatches()
96 96
     {
Please login to merge, or discard this patch.
src/Commands/MigrationMakeCommand.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     /**
69 69
      * @throws \InvalidArgumentException
70 70
      *
71
-     * @return mixed
71
+     * @return MigrationMakeCommand
72 72
      */
73 73
     protected function getTemplateContents()
74 74
     {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     }
109 109
 
110 110
     /**
111
-     * @return mixed
111
+     * @return string
112 112
      */
113 113
     protected function getDestinationFilePath()
114 114
     {
Please login to merge, or discard this patch.
src/Process/Installer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
     /**
107 107
      * Set console command instance.
108 108
      *
109
-     * @param \Illuminate\Console\Command $console
109
+     * @param \Nwidart\Modules\Commands\InstallCommand $console
110 110
      *
111 111
      * @return $this
112 112
      */
Please login to merge, or discard this patch.
src/FileRepository.php 1 patch
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -126,9 +126,7 @@  discard block
 block discarded – undo
126 126
     /**
127 127
      * Creates a new Module instance
128 128
      *
129
-     * @param Container $app
130
-     * @param string $args
131
-     * @param string $path
129
+     * @param string[] $args
132 130
      * @return \Nwidart\Modules\Module
133 131
      */
134 132
     abstract protected function createModule(...$args);
@@ -632,7 +630,7 @@  discard block
 block discarded – undo
632 630
     /**
633 631
      * Get stub path.
634 632
      *
635
-     * @return string|null
633
+     * @return string|boolean
636 634
      */
637 635
     public function getStubPath()
638 636
     {
Please login to merge, or discard this patch.
src/Module.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -239,7 +239,7 @@
 block discarded – undo
239 239
     /**
240 240
      * Get a specific data from composer.json file by given the key.
241 241
      *
242
-     * @param $key
242
+     * @param string $key
243 243
      * @param null $default
244 244
      *
245 245
      * @return mixed
Please login to merge, or discard this patch.
src/Activators/FileActivator.php 1 patch
Indentation   +94 added lines, -94 removed lines patch added patch discarded remove patch
@@ -8,100 +8,100 @@  discard block
 block discarded – undo
8 8
 
9 9
 class FileActivator implements ActivatorInterface
10 10
 {
11
-	/**
12
-	 * @var string
13
-	 */
14
-	protected $cacheKey;
15
-
16
-	/**
17
-	 * @var string
18
-	 */
19
-	protected $cacheLifetime;
20
-
21
-	/**
22
-	 * Array of modules activation statuses
23
-	 * 
24
-	 * @var array
25
-	 */
26
-	protected $installed;
27
-
28
-	/**
29
-	 * File used to store activation statuses
30
-	 * 
31
-	 * @var string
32
-	 */
33
-	protected $fileInstalled;
34
-
35
-	public function __construct(Container $app)
36
-	{
37
-		$this->cache = $app['cache'];
38
-		$this->files = $app['files'];
39
-		$this->config = $app['config'];
40
-		$this->fileInstalled = $this->config('file');
41
-		$this->cacheKey = $this->config('cache-key');
42
-		$this->cacheLifetime = $this->config('cache-lifetime');
43
-		$this->installed = $this->getCached();
44
-	}
45
-
46
-	/**
47
-	 * Get installed cache
48
-	 * 
49
-	 * @return array
50
-	 */
51
-	protected function getCached()
52
-	{
53
-		if(!$this->config->get('modules.cache.enabled')) return $this->readJson();
11
+    /**
12
+     * @var string
13
+     */
14
+    protected $cacheKey;
15
+
16
+    /**
17
+     * @var string
18
+     */
19
+    protected $cacheLifetime;
20
+
21
+    /**
22
+     * Array of modules activation statuses
23
+     * 
24
+     * @var array
25
+     */
26
+    protected $installed;
27
+
28
+    /**
29
+     * File used to store activation statuses
30
+     * 
31
+     * @var string
32
+     */
33
+    protected $fileInstalled;
34
+
35
+    public function __construct(Container $app)
36
+    {
37
+        $this->cache = $app['cache'];
38
+        $this->files = $app['files'];
39
+        $this->config = $app['config'];
40
+        $this->fileInstalled = $this->config('file');
41
+        $this->cacheKey = $this->config('cache-key');
42
+        $this->cacheLifetime = $this->config('cache-lifetime');
43
+        $this->installed = $this->getCached();
44
+    }
45
+
46
+    /**
47
+     * Get installed cache
48
+     * 
49
+     * @return array
50
+     */
51
+    protected function getCached()
52
+    {
53
+        if(!$this->config->get('modules.cache.enabled')) return $this->readJson();
54 54
 		
55
-		return $this->cache->remember($this->cacheKey, $this->cacheLifetime, function () {
55
+        return $this->cache->remember($this->cacheKey, $this->cacheLifetime, function () {
56 56
             return $this->readJson();
57 57
         });
58
-	}
59
-
60
-	/**
61
-	 * Forgets the installed cache
62
-	 */
63
-	protected function forgetCache()
64
-	{
65
-		$this->cache->forget($this->cacheKey);
66
-	}
67
-
68
-	/**
69
-	 * Reads a config parameter
70
-	 * 
71
-	 * @param  string $key     [description]
72
-	 * @param  $default
73
-	 * @return mixed
74
-	 */
75
-	protected function config(string $key, $default = null)
58
+    }
59
+
60
+    /**
61
+     * Forgets the installed cache
62
+     */
63
+    protected function forgetCache()
64
+    {
65
+        $this->cache->forget($this->cacheKey);
66
+    }
67
+
68
+    /**
69
+     * Reads a config parameter
70
+     * 
71
+     * @param  string $key     [description]
72
+     * @param  $default
73
+     * @return mixed
74
+     */
75
+    protected function config(string $key, $default = null)
76 76
     {
77 77
         return $this->config->get('modules.activators.file.' . $key, $default);
78 78
     }
79 79
 
80
-	/**
81
-	 * Reads the installed json file
82
-	 * 
83
-	 * @return array
84
-	 */
85
-	protected function readJson()
86
-	{
87
-		if(!$this->files->exists($this->fileInstalled)) return [];
88
-		return json_decode($this->files->get($this->fileInstalled), true);
89
-	}
90
-
91
-	/**
92
-	 * Writes the installed json file
93
-	 */
94
-	protected function writeJson()
95
-	{
96
-		$this->files->put($this->fileInstalled, json_encode($this->installed, JSON_PRETTY_PRINT));
97
-	}
98
-
99
-	/**
80
+    /**
81
+     * Reads the installed json file
82
+     * 
83
+     * @return array
84
+     */
85
+    protected function readJson()
86
+    {
87
+        if(!$this->files->exists($this->fileInstalled)) return [];
88
+        return json_decode($this->files->get($this->fileInstalled), true);
89
+    }
90
+
91
+    /**
92
+     * Writes the installed json file
93
+     */
94
+    protected function writeJson()
95
+    {
96
+        $this->files->put($this->fileInstalled, json_encode($this->installed, JSON_PRETTY_PRINT));
97
+    }
98
+
99
+    /**
100 100
      * @inheritDoc
101 101
      */
102 102
     public function enable(Module $module)
103 103
     {
104
-    	$this->setActiveByName($module->getName(), 1);
104
+        $this->setActiveByName($module->getName(), 1);
105 105
     }
106 106
 
107 107
     /**
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function disable(Module $module)
111 111
     {
112
-		$this->setActiveByName($module->getName(), 0);
112
+        $this->setActiveByName($module->getName(), 0);
113 113
     }
114 114
 
115 115
     /**
@@ -117,8 +117,8 @@  discard block
 block discarded – undo
117 117
      */
118 118
     public function isStatus(Module $module, $status)
119 119
     {
120
-    	if(!isset($this->installed[$module->getName()])) return false;
121
-    	return $this->installed[$module->getName()] == $status;
120
+        if(!isset($this->installed[$module->getName()])) return false;
121
+        return $this->installed[$module->getName()] == $status;
122 122
     }
123 123
 
124 124
     /**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
      */
127 127
     public function setActive(Module $module, $active)
128 128
     {
129
-    	$this->setActiveByName($module->getName(), $active);
129
+        $this->setActiveByName($module->getName(), $active);
130 130
     }
131 131
 
132 132
     /**
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
      */
135 135
     public function setActiveByName(string $name, $status)
136 136
     {
137
-    	$this->installed[$name] = (int)$status;
138
-    	$this->writeJson();
139
-    	$this->forgetCache();
137
+        $this->installed[$name] = (int)$status;
138
+        $this->writeJson();
139
+        $this->forgetCache();
140 140
     }
141 141
 
142 142
     /**
@@ -144,9 +144,9 @@  discard block
 block discarded – undo
144 144
      */
145 145
     public function delete(Module $module)
146 146
     {
147
-    	if(!isset($this->installed[$module->getName()])) return;
148
-    	unset($this->installed[$module->getName()]);
149
-    	$this->writeJson();
150
-    	$this->forgetCache();
147
+        if(!isset($this->installed[$module->getName()])) return;
148
+        unset($this->installed[$module->getName()]);
149
+        $this->writeJson();
150
+        $this->forgetCache();
151 151
     }
152 152
 }
Please login to merge, or discard this patch.