FactoryMakeCommand::getArguments() - Code Metrics - Inspection of "Renaming command files to use same semantics as La..." - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#354)

by Martin

created 2017-09-26 08:54 UTC

FactoryMakeCommand::getArguments() A

↳ Parent: FactoryMakeCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	7
ccs	2
cts	2
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Support\Str;
use Nwidart\Modules\Support\Stub;
use Nwidart\Modules\Traits\ModuleCommandTrait;
use Symfony\Component\Console\Input\InputArgument;

class FactoryMakeCommand extends GeneratorCommand
{

    use ModuleCommandTrait;

    /**
     * The name of argument name.
     *
     * @var string
     */
    protected $argumentName = 'name';

    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:make-factory';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a new model factory for the specified module.';


    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['name', InputArgument::REQUIRED, 'The name of the factory.'],
            ['module', InputArgument::OPTIONAL, 'The name of module will be used.'],
        ];
    }


    /**
     * @return mixed
     */
    protected function getTemplateContents()
    {
        return (new Stub('/factory.stub'))->render();
    }


    /**
     * @return mixed
     */
    protected function getDestinationFilePath()
    {
        $path = $this->laravel['modules']->getModulePath($this->getModuleName());

        return $path.'Database/factories/'.$this->getFileName();
    }


    /**
     * @return string
     */
    private function getFileName()
    {
        return Str::studly($this->argument('name')).'.php';

    }
}


1		<?php
2
3		namespace Nwidart\Modules\Commands;
4
5		use Illuminate\Support\Str;
6		use Nwidart\Modules\Support\Stub;
7		use Nwidart\Modules\Traits\ModuleCommandTrait;
8		use Symfony\Component\Console\Input\InputArgument;
9
10		class FactoryMakeCommand extends GeneratorCommand
11		{
12
13		use ModuleCommandTrait;
14
15		/**
16		* The name of argument name.
17		*
18		* @var string
19		*/
20		protected $argumentName = 'name';
21
22		/**
23		* The console command name.
24		*
25		* @var string
26		*/
27		protected $name = 'module:make-factory';
28
29		/**
30		* The console command description.
31		*
32		* @var string
33		*/
34		protected $description = 'Create a new model factory for the specified module.';
35
36
37		/**
38		* Get the console command arguments.
39		*
40		* @return array
41		*/
42	60	protected function getArguments()
43		{
44		return [
45	60	['name', InputArgument::REQUIRED, 'The name of the factory.'],
46		['module', InputArgument::OPTIONAL, 'The name of module will be used.'],
47		];
48		}
49
50
51		/**
52		* @return mixed
53		*/
54	1	protected function getTemplateContents()
55		{
56	1	return (new Stub('/factory.stub'))->render();
57		}
58
59
60		/**
61		* @return mixed
62		*/
63	1	protected function getDestinationFilePath()
64		{
65	1	$path = $this->laravel['modules']->getModulePath($this->getModuleName());
66
67	1	return $path.'Database/factories/'.$this->getFileName();
68		}
69
70
71		/**
72		* @return string
73		*/
74	1	private function getFileName()
75		{
76	1	return Str::studly($this->argument('name')).'.php';
		0 ignored issues – show Bug introduced 2017-09-25 08:47 UTC by Report Bug Copy Issue Report It seems like `$this->argument('name')` targeting `Illuminate\Console\Command::argument()` can also be of type `array`; however, `Illuminate\Support\Str::studly()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
77		}
78		}
79

nWidart / laravel-modules

Pull Request — master (#354)

FactoryMakeCommand::getArguments() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like