UseCommand::fire() - Code Metrics - Inspection of "Making the $migrations parameter optional on getLa..." - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#166)

by Josh

created 2017-03-15 17:27 UTC

UseCommand::fire() A

↳ Parent: UseCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	0
cts	8
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	0
crap	6

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Str;
use Symfony\Component\Console\Input\InputArgument;

class UseCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:use';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Use the specified module.';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        $module = Str::studly($this->argument('module'));


        if (!$this->laravel['modules']->has($module)) {
            $this->error("Module [{$module}] does not exists.");

            return;
        }

        $this->laravel['modules']->setUsed($module);

        $this->info("Module [{$module}] used successfully.");
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return array(
            array('module', InputArgument::REQUIRED, 'The name of module will be used.'),
        );
    }
}


1		<?php
2
3		namespace Nwidart\Modules\Commands;
4
5		use Illuminate\Console\Command;
6		use Illuminate\Support\Str;
7		use Symfony\Component\Console\Input\InputArgument;
8
9		class UseCommand extends Command
10		{
11		/**
12		* The console command name.
13		*
14		* @var string
15		*/
16		protected $name = 'module:use';
17
18		/**
19		* The console command description.
20		*
21		* @var string
22		*/
23		protected $description = 'Use the specified module.';
24
25		/**
26		* Execute the console command.
27		*
28		* @return mixed
29		*/
30		public function fire()
31		{
32		$module = Str::studly($this->argument('module'));
		0 ignored issues – show Bug introduced 2016-06-28 11:31 UTC by Report Bug Copy Issue Report It seems like `$this->argument('module')` targeting `Illuminate\Console\Command::argument()` can also be of type `array`; however, `Illuminate\Support\Str::studly()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
33
34		if (!$this->laravel['modules']->has($module)) {
35		$this->error("Module [{$module}] does not exists.");
36
37		return;
38		}
39
40		$this->laravel['modules']->setUsed($module);
41
42		$this->info("Module [{$module}] used successfully.");
43		}
44
45		/**
46		* Get the console command arguments.
47		*
48		* @return array
49		*/
50	43	protected function getArguments()
51		{
52		return array(
53	43	array('module', InputArgument::REQUIRED, 'The name of module will be used.'),
54	43	);
55		}
56		}
57

nWidart / laravel-modules

Pull Request — master (#166)

UseCommand::fire() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like