Completed
Pull Request — master (#355)
by
unknown
11:28
created
src/Module.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
      *
45 45
      * @param Container $app
46 46
      * @param $name
47
-     * @param $path
47
+     * @param string $path
48 48
      */
49 49
     public function __construct(Container $app, $name, $path)
50 50
     {
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
     /**
189 189
      * Get json contents from the cache, setting as needed.
190 190
      *
191
-     * @param $file
191
+     * @param string $file
192 192
      *
193 193
      * @return Json
194 194
      */
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     /**
220 220
      * Get a specific data from composer.json file by given the key.
221 221
      *
222
-     * @param $key
222
+     * @param string $key
223 223
      * @param null $default
224 224
      *
225 225
      * @return mixed
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     /**
298 298
      * Determine whether the given status same with the current module status.
299 299
      *
300
-     * @param $status
300
+     * @param integer $status
301 301
      *
302 302
      * @return bool
303 303
      */
@@ -349,9 +349,9 @@  discard block
 block discarded – undo
349 349
     /**
350 350
      * Set active state for current module.
351 351
      *
352
-     * @param $active
352
+     * @param integer $active
353 353
      *
354
-     * @return bool
354
+     * @return integer
355 355
      */
356 356
     public function setActive($active)
357 357
     {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     {
187 187
         $lowerName = $this->getLowerName();
188 188
 
189
-        $langPath = $this->getPath() . "/Resources/lang";
189
+        $langPath = $this->getPath()."/Resources/lang";
190 190
 
191 191
         if (is_dir($langPath)) {
192 192
             $this->loadTranslationsFrom($langPath, $lowerName);
@@ -206,8 +206,8 @@  discard block
 block discarded – undo
206 206
             $file = 'module.json';
207 207
         }
208 208
 
209
-        return array_get($this->moduleJson, $file, function () use ($file) {
210
-            return $this->moduleJson[$file] = new Json($this->getPath() . '/' . $file, $this->app['files']);
209
+        return array_get($this->moduleJson, $file, function() use ($file) {
210
+            return $this->moduleJson[$file] = new Json($this->getPath().'/'.$file, $this->app['files']);
211 211
         });
212 212
     }
213 213
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
      */
259 259
     protected function fireEvent($event)
260 260
     {
261
-        $this->app['events']->fire(sprintf('modules.%s.' . $event, $this->getLowerName()), [$this]);
261
+        $this->app['events']->fire(sprintf('modules.%s.'.$event, $this->getLowerName()), [$this]);
262 262
     }
263 263
     /**
264 264
      * Register the aliases from this module.
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
     protected function registerFiles()
284 284
     {
285 285
         foreach ($this->get('files', []) as $file) {
286
-            include $this->path . '/' . $file;
286
+            include $this->path.'/'.$file;
287 287
         }
288 288
     }
289 289
 
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
      */
405 405
     public function getExtraPath($path)
406 406
     {
407
-        return $this->getPath() . '/' . $path;
407
+        return $this->getPath().'/'.$path;
408 408
     }
409 409
 
410 410
     /**
Please login to merge, or discard this patch.
src/Laravel/Repository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
         $modules = [];
40 40
 
41 41
         foreach ($cached as $name => $module) {
42
-            $path = $this->config('paths.modules') . '/' . $name;
42
+            $path = $this->config('paths.modules').'/'.$name;
43 43
 
44 44
             $modules[$name] = new Module($this->app, $name, $path);
45 45
         }
Please login to merge, or discard this patch.
src/Laravel/Module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
      */
15 15
     public function getCachedServicesPath()
16 16
     {
17
-        return Str::replaceLast('services.php', $this->getSnakeName() . '_module.php', $this->app->getCachedServicesPath());
17
+        return Str::replaceLast('services.php', $this->getSnakeName().'_module.php', $this->app->getCachedServicesPath());
18 18
     }
19 19
 
20 20
     /**
Please login to merge, or discard this patch.
src/Lumen/Module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
      */
13 13
     public function getCachedServicesPath()
14 14
     {
15
-        return Str::replaceLast('services.php', $this->getSnakeName() . '_module.php', $this->app->basePath('storage/app/') . 'services.php');
15
+        return Str::replaceLast('services.php', $this->getSnakeName().'_module.php', $this->app->basePath('storage/app/').'services.php');
16 16
     }
17 17
 
18 18
     /**
Please login to merge, or discard this patch.
src/LaravelModulesServiceProvider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function setupStubPath()
32 32
     {
33
-        Stub::setBasePath(__DIR__ . '/Commands/stubs');
33
+        Stub::setBasePath(__DIR__.'/Commands/stubs');
34 34
 
35
-        $this->app->booted(function ($app) {
35
+        $this->app->booted(function($app) {
36 36
             if ($app['modules']->config('stubs.enabled') === true) {
37 37
                 Stub::setBasePath($app['modules']->config('stubs.path'));
38 38
             }
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
      */
45 45
     protected function registerServices()
46 46
     {
47
-        $this->app->singleton('modules', function ($app) {
47
+        $this->app->singleton('modules', function($app) {
48 48
             $path = $app['config']->get('modules.paths.modules');
49 49
 
50 50
             return new \Nwidart\Modules\Laravel\Repository($app, $path);
Please login to merge, or discard this patch.
src/LumenModulesServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function setupStubPath()
32 32
     {
33
-        Stub::setBasePath(__DIR__ . '/Commands/stubs');
33
+        Stub::setBasePath(__DIR__.'/Commands/stubs');
34 34
 
35 35
         if (app('modules')->config('stubs.enabled') === true) {
36 36
             Stub::setBasePath(app('modules')->config('stubs.path'));
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      */
43 43
     protected function registerServices()
44 44
     {
45
-        $this->app->singleton('modules', function ($app) {
45
+        $this->app->singleton('modules', function($app) {
46 46
             $path = $app['config']->get('modules.paths.modules');
47 47
 
48 48
             return new \Nwidart\Modules\Lumen\Repository($app, $path);
Please login to merge, or discard this patch.
src/ModulesServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      */
44 44
     protected function registerNamespaces()
45 45
     {
46
-        $configPath = __DIR__ . '/../config/config.php';
46
+        $configPath = __DIR__.'/../config/config.php';
47 47
 
48 48
         $this->mergeConfigFrom($configPath, 'modules');
49 49
         $this->publishes([
Please login to merge, or discard this patch.
src/Lumen/Repository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
         $modules = [];
40 40
 
41 41
         foreach ($cached as $name => $module) {
42
-            $path = $this->config('paths.modules') . '/' . $name;
42
+            $path = $this->config('paths.modules').'/'.$name;
43 43
 
44 44
             $modules[$name] = new Module($this->app, $name, $path);
45 45
         }
Please login to merge, or discard this patch.
src/Generators/ModuleGenerator.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
                 return;
281 281
             }
282 282
 
283
-            $path = $this->module->getModulePath($this->getName()) . '/' . $folder;
283
+            $path = $this->module->getModulePath($this->getName()).'/'.$folder;
284 284
 
285 285
             $this->filesystem->makeDirectory($path, 0755, true);
286 286
 
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
      */
296 296
     public function generateGitKeep($path)
297 297
     {
298
-        $this->filesystem->put($path . '/.gitkeep', '');
298
+        $this->filesystem->put($path.'/.gitkeep', '');
299 299
     }
300 300
 
301 301
     /**
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
     public function generateFiles()
305 305
     {
306 306
         foreach ($this->getFiles() as $stub => $file) {
307
-            $path = $this->module->getModulePath($this->getName()) . $file;
307
+            $path = $this->module->getModulePath($this->getName()).$file;
308 308
 
309 309
             if (!$this->filesystem->isDirectory($dir = dirname($path))) {
310 310
                 $this->filesystem->makeDirectory($dir, 0775, true);
@@ -328,13 +328,13 @@  discard block
 block discarded – undo
328 328
         ]);
329 329
 
330 330
         $this->console->call('module:make-provider', [
331
-            'name' => $this->getName() . 'ServiceProvider',
331
+            'name' => $this->getName().'ServiceProvider',
332 332
             'module' => $this->getName(),
333 333
             '--master' => true,
334 334
         ]);
335 335
 
336 336
         $this->console->call('module:make-controller', [
337
-            'controller' => $this->getName() . 'Controller',
337
+            'controller' => $this->getName().'Controller',
338 338
             'module' => $this->getName(),
339 339
         ]);
340 340
     }
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
     protected function getStubContents($stub)
350 350
     {
351 351
         return (new Stub(
352
-            '/' . $stub . '.stub',
352
+            '/'.$stub.'.stub',
353 353
             $this->getReplacement($stub)
354 354
         )
355 355
         )->render();
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
         $replaces = [];
384 384
 
385 385
         foreach ($keys as $key) {
386
-            if (method_exists($this, $method = 'get' . ucfirst(studly_case(strtolower($key))) . 'Replacement')) {
386
+            if (method_exists($this, $method = 'get'.ucfirst(studly_case(strtolower($key))).'Replacement')) {
387 387
                 $replaces[$key] = call_user_func([$this, $method]);
388 388
             } else {
389 389
                 $replaces[$key] = null;
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
      */
399 399
     private function generateModuleJsonFile()
400 400
     {
401
-        $path = $this->module->getModulePath($this->getName()) . 'module.json';
401
+        $path = $this->module->getModulePath($this->getName()).'module.json';
402 402
 
403 403
         if (!$this->filesystem->isDirectory($dir = dirname($path))) {
404 404
             $this->filesystem->makeDirectory($dir, 0775, true);
@@ -415,13 +415,13 @@  discard block
 block discarded – undo
415 415
      */
416 416
     private function cleanModuleJsonFile()
417 417
     {
418
-        $path = $this->module->getModulePath($this->getName()) . 'module.json';
418
+        $path = $this->module->getModulePath($this->getName()).'module.json';
419 419
 
420 420
         $content = $this->filesystem->get($path);
421 421
         $namespace = $this->getModuleNamespaceReplacement();
422 422
         $studlyName = $this->getStudlyNameReplacement();
423 423
 
424
-        $provider = '"' . $namespace . '\\\\' . $studlyName . '\\\\Providers\\\\' . $studlyName . 'ServiceProvider"';
424
+        $provider = '"'.$namespace.'\\\\'.$studlyName.'\\\\Providers\\\\'.$studlyName.'ServiceProvider"';
425 425
 
426 426
         $content = str_replace($provider, '', $content);
427 427
 
Please login to merge, or discard this patch.