Nwidart\Modules\Generators\Command

Complexity

Total Complexity

4

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	appendable()	0	4	1
A	getFileName()	0	10	3

<?php

namespace Nwidart\Modules\Generators;

use Illuminate\Support\Str;
use Nwidart\Modules\Commands\GeneratorCommand;

abstract class Command extends GeneratorCommand
{

    /**
     * The name to be appended to the generated resources.
     *
     * @var null|string
     */
    protected $appendable;

    /**
     * Getter for appendable
     *
     * @return void
     */
    public function appendable()
    {
        return $this->appendable;
    }

    /**
     * Get and resolve the filename.
     *
     * @return string
     */
    protected function getFileName(): string
    {

        $name = Str::studly($this->argument($this->argumentName));

It seems like $this->argument($this->argumentName) targeting Illuminate\Console\Concerns\InteractsWithIO::argument() can also be of type array or null; however, Illuminate\Support\Str::studly() does only seem to accept string, maybe add an additional type check?

        if ($this->appendable() && !Str::contains(strtolower($name), strtolower($this->appendable()))) {

The expression $this->appendable() of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $name .= Str::studly($this->appendable());
        }

        return Str::singular(Str::studly($name));
    }
}