PublishConfigurationCommand::getServiceProviderForModule() - Code Metrics - Inspection of "Improve README.md" - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#203)

unknown

created 2017-04-19 19:18 UTC

getServiceProviderForModule() A

↳ Parent: PublishConfigurationCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	2

<?php

namespace Nwidart\Modules\Commands;

use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;

class PublishConfigurationCommand extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'module:publish-config';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Publish a module\'s config files to the application';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        if ($module = $this->argument('module')) {
            $this->publishConfiguration($module);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            return;
        }

        foreach ($this->laravel['modules']->enabled() as $module) {
            $this->publishConfiguration($module->getName());
        }
    }

    /**
     * @param string $module
     * @return string
     */
    private function getServiceProviderForModule($module)
    {
        $namespace = $this->laravel['config']->get('modules.namespace');
        $studlyName = studly_case($module);

        return "$namespace\\$studlyName\\Providers\\{$studlyName}ServiceProvider";
    }

    /**
     * @param string $module
     */
    private function publishConfiguration($module)
    {
        $this->call('vendor:publish', [
            '--provider' => $this->getServiceProviderForModule($module),
            '--force' => $this->option('force'),
            '--tag' => ['config'],
        ]);
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['module', InputArgument::OPTIONAL, 'The name of module being used.'],
        ];
    }

    /**
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['--force', '-f', InputOption::VALUE_NONE, 'Force the publishing of config files'],
        ];
    }
}


1		<?php
2
3		namespace Nwidart\Modules\Commands;
4
5		use Illuminate\Console\Command;
6		use Symfony\Component\Console\Input\InputArgument;
7		use Symfony\Component\Console\Input\InputOption;
8
9		class PublishConfigurationCommand extends Command
10		{
11		/**
12		* The console command name.
13		*
14		* @var string
15		*/
16		protected $name = 'module:publish-config';
17
18		/**
19		* The console command description.
20		*
21		* @var string
22		*/
23		protected $description = 'Publish a module\'s config files to the application';
24
25		/**
26		* Execute the console command.
27		*
28		* @return mixed
29		*/
30		public function fire()
31		{
32		if ($module = $this->argument('module')) {
33		$this->publishConfiguration($module);
		0 ignored issues – show Bug introduced 2016-07-09 15:40 UTC by Report Bug Copy Issue Report It seems like `$module` defined by `$this->argument('module')` on line `32` can also be of type `array`; however, `Nwidart\Modules\Commands...:publishConfiguration()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34
35		return;
36		}
37
38		foreach ($this->laravel['modules']->enabled() as $module) {
39		$this->publishConfiguration($module->getName());
40		}
41		}
42
43		/**
44		* @param string $module
45		* @return string
46		*/
47		private function getServiceProviderForModule($module)
48		{
49		$namespace = $this->laravel['config']->get('modules.namespace');
50		$studlyName = studly_case($module);
51
52		return "$namespace\\$studlyName\\Providers\\{$studlyName}ServiceProvider";
53		}
54
55		/**
56		* @param string $module
57		*/
58		private function publishConfiguration($module)
59		{
60		$this->call('vendor:publish', [
61		'--provider' => $this->getServiceProviderForModule($module),
62		'--force' => $this->option('force'),
63		'--tag' => ['config'],
64		]);
65		}
66
67		/**
68		* Get the console command arguments.
69		*
70		* @return array
71		*/
72	43	protected function getArguments()
73		{
74		return [
75	43	['module', InputArgument::OPTIONAL, 'The name of module being used.'],
76		];
77		}
78
79		/**
80		* @return array
81		*/
82	43	protected function getOptions()
83		{
84		return [
85	43	['--force', '-f', InputOption::VALUE_NONE, 'Force the publishing of config files'],
86		];
87		}
88		}
89

nWidart / laravel-modules

Pull Request — master (#203)

getServiceProviderForModule() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like