Issues in LaravelFileRepository.php - New Issues - Inspection of "Preparing dependencies for laravel 6.0" - nWidart/laravel-modules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4fafa1...e65f27 )

by Nicolas

created 2019-09-03 15:54 UTC

src/Laravel/LaravelFileRepository.php (2 issues)

Labels

Bug 1
Documentation 1

Severity

Major 1
Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nwidart\Modules\Laravel;

use Nwidart\Modules\FileRepository;

class LaravelFileRepository extends FileRepository
{
    /**
     * {@inheritdoc}
     */
    protected function createModule(...$args)
    {
        return new Module(...$args);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Nwidart\Modules\Laravel;
4
5		use Nwidart\Modules\FileRepository;
6
7		class LaravelFileRepository extends FileRepository
8		{
9		/**
10		* {@inheritdoc}
11		*/
12	133	protected function createModule(...$args)
13		{
14	133	return new Module(...$args);
		0 ignored issues – show Bug introduced 2017-11-25 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Module::__construct()` misses some required arguments starting with `$name`. Loading history... Documentation introduced 2017-11-25 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$args` is of type `array<integer,?>`, but the function expects a `object<Illuminate\Container\Container>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
15		}
16		}
17

nWidart / laravel-modules

Push — master ( 4fafa1...e65f27 )

src/Laravel/LaravelFileRepository.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like