Completed
Pull Request — master (#279)
by
unknown
03:10
created
src/Generators/ModuleGenerator.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     public function generateFolders()
277 277
     {
278 278
         foreach ($this->getFolders() as $folder) {
279
-            $path = $this->module->getModulePath($this->getName()) . '/' . $folder;
279
+            $path = $this->module->getModulePath($this->getName()).'/'.$folder;
280 280
 
281 281
             $this->filesystem->makeDirectory($path, 0755, true);
282 282
 
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
      */
292 292
     public function generateGitKeep($path)
293 293
     {
294
-        $this->filesystem->put($path . '/.gitkeep', '');
294
+        $this->filesystem->put($path.'/.gitkeep', '');
295 295
     }
296 296
 
297 297
     /**
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
     public function generateFiles()
301 301
     {
302 302
         foreach ($this->getFiles() as $stub => $file) {
303
-            $path = $this->module->getModulePath($this->getName()) . $file;
303
+            $path = $this->module->getModulePath($this->getName()).$file;
304 304
 
305 305
             if (!$this->filesystem->isDirectory($dir = dirname($path))) {
306 306
                 $this->filesystem->makeDirectory($dir, 0775, true);
@@ -324,13 +324,13 @@  discard block
 block discarded – undo
324 324
         ]);
325 325
 
326 326
         $this->console->call('module:make-provider', [
327
-            'name' => $this->getName() . 'ServiceProvider',
327
+            'name' => $this->getName().'ServiceProvider',
328 328
             'module' => $this->getName(),
329 329
             '--master' => true,
330 330
         ]);
331 331
 
332 332
         $this->console->call('module:make-controller', [
333
-            'controller' => $this->getName() . 'Controller',
333
+            'controller' => $this->getName().'Controller',
334 334
             'module' => $this->getName(),
335 335
         ]);
336 336
     }
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
     protected function getStubContents($stub)
346 346
     {
347 347
         return (new Stub(
348
-            '/' . $stub . '.stub',
348
+            '/'.$stub.'.stub',
349 349
             $this->getReplacement($stub))
350 350
         )->render();
351 351
     }
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
         $replaces = [];
379 379
 
380 380
         foreach ($keys as $key) {
381
-            if (method_exists($this, $method = 'get' . ucfirst(studly_case(strtolower($key))) . 'Replacement')) {
381
+            if (method_exists($this, $method = 'get'.ucfirst(studly_case(strtolower($key))).'Replacement')) {
382 382
                 $replaces[$key] = call_user_func([$this, $method]);
383 383
             } else {
384 384
                 $replaces[$key] = null;
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
      */
394 394
     private function generateModuleJsonFile()
395 395
     {
396
-        $path = $this->module->getModulePath($this->getName()) . 'module.json';
396
+        $path = $this->module->getModulePath($this->getName()).'module.json';
397 397
 
398 398
         if (!$this->filesystem->isDirectory($dir = dirname($path))) {
399 399
             $this->filesystem->makeDirectory($dir, 0775, true);
@@ -410,13 +410,13 @@  discard block
 block discarded – undo
410 410
      */
411 411
     private function cleanModuleJsonFile()
412 412
     {
413
-        $path = $this->module->getModulePath($this->getName()) . 'module.json';
413
+        $path = $this->module->getModulePath($this->getName()).'module.json';
414 414
 
415 415
         $content = $this->filesystem->get($path);
416 416
         $namespace = $this->getModuleNamespaceReplacement();
417 417
         $studlyName = $this->getStudlyNameReplacement();
418 418
 
419
-        $provider = '"' . $namespace . '\\\\' . $studlyName . '\\\\Providers\\\\' . $studlyName . 'ServiceProvider"';
419
+        $provider = '"'.$namespace.'\\\\'.$studlyName.'\\\\Providers\\\\'.$studlyName.'ServiceProvider"';
420 420
 
421 421
         $content = str_replace($provider, '', $content);
422 422
 
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('module_path')) {
3
+if (!function_exists('module_path')) {
4 4
     function module_path($name)
5 5
     {
6 6
         $module = app('modules')->find($name);
Please login to merge, or discard this patch.
src/Module.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      *
44 44
      * @param Application $app
45 45
      * @param $name
46
-     * @param $path
46
+     * @param string $path
47 47
      */
48 48
     public function __construct(Application $app, $name, $path)
49 49
     {
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
     /**
188 188
      * Get json contents from the cache, setting as needed.
189 189
      *
190
-     * @param $file
190
+     * @param string $file
191 191
      *
192 192
      * @return Json
193 193
      */
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     /**
219 219
      * Get a specific data from composer.json file by given the key.
220 220
      *
221
-     * @param $key
221
+     * @param string $key
222 222
      * @param null $default
223 223
      *
224 224
      * @return mixed
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
     /**
297 297
      * Determine whether the given status same with the current module status.
298 298
      *
299
-     * @param $status
299
+     * @param integer $status
300 300
      *
301 301
      * @return bool
302 302
      */
@@ -348,9 +348,9 @@  discard block
 block discarded – undo
348 348
     /**
349 349
      * Set active state for current module.
350 350
      *
351
-     * @param $active
351
+     * @param integer $active
352 352
      *
353
-     * @return bool
353
+     * @return integer
354 354
      */
355 355
     public function setActive($active)
356 356
     {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
     {
178 178
         $lowerName = $this->getLowerName();
179 179
 
180
-        $langPath = $this->getPath() . "/Resources/lang";
180
+        $langPath = $this->getPath()."/Resources/lang";
181 181
 
182 182
         if (is_dir($langPath)) {
183 183
             $this->loadTranslationsFrom($langPath, $lowerName);
@@ -197,8 +197,8 @@  discard block
 block discarded – undo
197 197
             $file = 'module.json';
198 198
         }
199 199
 
200
-        return array_get($this->moduleJson, $file, function () use ($file) {
201
-            return $this->moduleJson[$file] = new Json($this->getPath() . '/' . $file, $this->app['files']);
200
+        return array_get($this->moduleJson, $file, function() use ($file) {
201
+            return $this->moduleJson[$file] = new Json($this->getPath().'/'.$file, $this->app['files']);
202 202
         });
203 203
     }
204 204
 
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
      */
250 250
     protected function fireEvent($event)
251 251
     {
252
-        $this->app['events']->fire(sprintf('modules.%s.' . $event, $this->getLowerName()), [$this]);
252
+        $this->app['events']->fire(sprintf('modules.%s.'.$event, $this->getLowerName()), [$this]);
253 253
     }
254 254
 
255 255
     /**
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
     protected function registerFiles()
280 280
     {
281 281
         foreach ($this->get('files', []) as $file) {
282
-            include $this->path . '/' . $file;
282
+            include $this->path.'/'.$file;
283 283
         }
284 284
     }
285 285
 
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
      */
401 401
     public function getExtraPath($path)
402 402
     {
403
-        return $this->getPath() . '/' . $path;
403
+        return $this->getPath().'/'.$path;
404 404
     }
405 405
 
406 406
     /**
Please login to merge, or discard this patch.
src/LaravelModulesServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -31,9 +31,9 @@
 block discarded – undo
31 31
      */
32 32
     public function setupStubPath()
33 33
     {
34
-        Stub::setBasePath(__DIR__ . '/Commands/stubs');
34
+        Stub::setBasePath(__DIR__.'/Commands/stubs');
35 35
 
36
-        $this->app->booted(function ($app) {
36
+        $this->app->booted(function($app) {
37 37
             if ($app['modules']->config('stubs.enabled') === true) {
38 38
                 Stub::setBasePath($app['modules']->config('stubs.path'));
39 39
             }
Please login to merge, or discard this patch.
src/LumenModulesServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      */
25 25
     public function setupStubPath()
26 26
     {
27
-        Stub::setBasePath(__DIR__ . '/Commands/stubs');
27
+        Stub::setBasePath(__DIR__.'/Commands/stubs');
28 28
 
29 29
         if (app('modules')->config('stubs.enabled') === true) {
30 30
             Stub::setBasePath(app('modules')->config('stubs.path'));
Please login to merge, or discard this patch.
src/ModulesServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      */
44 44
     protected function registerNamespaces()
45 45
     {
46
-        $configPath = __DIR__ . '/../config/config.php';
46
+        $configPath = __DIR__.'/../config/config.php';
47 47
 
48 48
         $this->mergeConfigFrom($configPath, 'modules');
49 49
         $this->publishes([
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     protected function registerServices()
58 58
     {
59
-        $this->app->singleton('modules', function ($app) {
59
+        $this->app->singleton('modules', function($app) {
60 60
             $path = $app['config']->get('modules.paths.modules');
61 61
 
62 62
             return new Repository($app, $path);
Please login to merge, or discard this patch.
src/Process/Updater.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
         $this->installRequires($module);
21 21
         $this->installDevRequires($module);
22 22
         
23
-        if($copyToMainComposer) {
23
+        if ($copyToMainComposer) {
24 24
             $this->copyScriptsToMainComposerJson($module);
25 25
         }
26 26
     }
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
             $concatenatedPackages .= "\"{$name}:{$version}\" ";
38 38
         }
39 39
 
40
-        if(!empty($concatenatedPackages)) {
40
+        if (!empty($concatenatedPackages)) {
41 41
             $this->run("composer require {$concatenatedPackages}");
42 42
         }
43 43
     }
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
             $concatenatedPackages .= "\"{$name}:{$version}\" ";
55 55
         }
56 56
 
57
-        if(!empty($concatenatedPackages)) {
57
+        if (!empty($concatenatedPackages)) {
58 58
             $this->run("composer require --dev {$concatenatedPackages}");
59 59
         }
60 60
     }
Please login to merge, or discard this patch.