Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | class MenuTest extends BaseTestCase |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * @var Menu |
||
| 12 | */ |
||
| 13 | private $menu; |
||
| 14 | |||
| 15 | public function setUp() : void |
||
| 16 | { |
||
| 17 | parent::setUp(); |
||
| 18 | $this->menu = app(Menu::class); |
||
| 19 | } |
||
| 20 | /** @test */ |
||
| 21 | public function it_generates_an_empty_menu() |
||
| 22 | { |
||
| 23 | $this->menu->create('test', function (MenuBuilder $menu) { |
||
|
|
|||
| 24 | }); |
||
| 25 | |||
| 26 | $expected = <<<TEXT |
||
| 27 | |||
| 28 | <ul class="nav navbar-nav"> |
||
| 29 | |||
| 30 | </ul> |
||
| 31 | |||
| 32 | TEXT; |
||
| 33 | |||
| 34 | self::assertEquals($expected, $this->menu->get('test')); |
||
| 35 | } |
||
| 36 | |||
| 37 | /** @test */ |
||
| 38 | public function it_makes_is_an_alias_for_create() |
||
| 39 | { |
||
| 40 | $this->menu->make('test', function (MenuBuilder $menu) { |
||
| 41 | }); |
||
| 42 | |||
| 43 | $expected = <<<TEXT |
||
| 44 | |||
| 45 | <ul class="nav navbar-nav"> |
||
| 46 | |||
| 47 | </ul> |
||
| 48 | |||
| 49 | TEXT; |
||
| 50 | |||
| 51 | self::assertEquals($expected, $this->menu->get('test')); |
||
| 52 | } |
||
| 53 | |||
| 54 | /** @test */ |
||
| 55 | public function it_render_is_an_alias_of_get() |
||
| 56 | { |
||
| 57 | $this->menu->make('test', function (MenuBuilder $menu) { |
||
| 58 | }); |
||
| 59 | |||
| 60 | $expected = <<<TEXT |
||
| 61 | |||
| 62 | <ul class="nav navbar-nav"> |
||
| 63 | |||
| 64 | </ul> |
||
| 65 | |||
| 66 | TEXT; |
||
| 67 | |||
| 68 | self::assertEquals($expected, $this->menu->render('test')); |
||
| 69 | } |
||
| 70 | |||
| 71 | /** @test */ |
||
| 72 | public function it_can_get_the_instance_of_a_menu() |
||
| 78 | } |
||
| 79 | |||
| 80 | /** @test */ |
||
| 81 | public function it_can_modify_a_menu_instance() |
||
| 91 | } |
||
| 92 | |||
| 93 | /** @test */ |
||
| 94 | public function it_gets_a_partial_for_dropdown_styles() |
||
| 100 | } |
||
| 101 | |||
| 102 | /** @test */ |
||
| 103 | public function it_can_get_all_menus() |
||
| 111 | } |
||
| 112 | |||
| 113 | /** @test */ |
||
| 114 | public function it_can_count_menus() |
||
| 122 | } |
||
| 123 | |||
| 124 | /** @test */ |
||
| 125 | public function it_can_destroy_all_menus() |
||
| 135 | } |
||
| 136 | |||
| 137 | /** @test */ |
||
| 180 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.