Issues in Presenter.php - New Issues - Inspection of "Hidden Items" - nWidart/laravel-menus - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#57)

by Kyle

created 2025-04-26 22:50 UTC

src/Presenters/Presenter.php (4 issues)

Labels

Severity

<?php

namespace KyleMassacre\Menus\Presenters;

use KyleMassacre\Menus\Contracts\MenuItemContract;

abstract class Presenter implements PresenterInterface
{
    /**
     * Get open tag wrapper.
     *
     * @return string
     */
    public function getOpenTagWrapper(): ?string
    {
    }

    /**
     * Get close tag wrapper.
     *
     * @return string
     */
    public function getCloseTagWrapper(): ?string
    {
    }

    /**
     * Get menu tag without dropdown wrapper.
     *
     * @param MenuItemContract $item
     *
     * @return string
     */
    public function getMenuWithoutDropdownWrapper(MenuItemContract $item): ?string
    {
    }

    /**
     * Get divider tag wrapper.
     *
     * @return string
     */
    public function getDividerWrapper(): ?string
    {
    }

    /**
     * Get header dropdown tag wrapper.
     *
     * @param MenuItemContract $item
     *
     * @return null|string
     */
    public function getHeaderWrapper(MenuItemContract $item): ?string
    {
    }

    /**
     * Get menu tag with dropdown wrapper.
     *
     * @param \KyleMassacre\Menus\MenuItem $item
     *
     * @return string
     */
    public function getMenuWithDropDownWrapper(MenuItemContract $item): ?string
    {
    }

    /**
     * Get multi level dropdown menu wrapper.
     *
     * @param \KyleMassacre\Menus\MenuItem $item
     *
     * @return string
     */
    public function getMultiLevelDropdownWrapper(MenuItemContract $item): string
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * Get child menu items.
     *
     * @param \KyleMassacre\Menus\MenuItem $item
     *
     * @return string
     */
    public function getChildMenuItems(MenuItemContract $item): string
    {
        $results = '';
        foreach ($item->getChildren() as $child) {
            if ($child->hidden()) {
                continue;
            }

            if ($child->hasSubMenu()) {
                $results .= $this->getMultiLevelDropdownWrapper($child);
            } elseif ($child->isHeader()) {
                $results .= $this->getHeaderWrapper($child);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            } elseif ($child->isDivider()) {
                $results .= $this->getDividerWrapper();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            } else {
                $results .= $this->getMenuWithoutDropdownWrapper($child);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }
        }

        return $results;
    }
}


1			<?php
2
3			namespace KyleMassacre\Menus\Presenters;
4
5			use KyleMassacre\Menus\Contracts\MenuItemContract;
6
7			abstract class Presenter implements PresenterInterface
8			{
9			/**
10			* Get open tag wrapper.
11			*
12			* @return string
13			*/
14			public function getOpenTagWrapper(): ?string
15			{
16			}
17
18			/**
19			* Get close tag wrapper.
20			*
21			* @return string
22			*/
23			public function getCloseTagWrapper(): ?string
24			{
25			}
26
27			/**
28			* Get menu tag without dropdown wrapper.
29			*
30			* @param MenuItemContract $item
31			*
32			* @return string
33			*/
34			public function getMenuWithoutDropdownWrapper(MenuItemContract $item): ?string
35			{
36			}
37
38			/**
39			* Get divider tag wrapper.
40			*
41			* @return string
42			*/
43			public function getDividerWrapper(): ?string
44			{
45			}
46
47			/**
48			* Get header dropdown tag wrapper.
49			*
50			* @param MenuItemContract $item
51			*
52			* @return null\|string
53			*/
54			public function getHeaderWrapper(MenuItemContract $item): ?string
55			{
56			}
57
58			/**
59			* Get menu tag with dropdown wrapper.
60			*
61			* @param \KyleMassacre\Menus\MenuItem $item
62			*
63			* @return string
64			*/
65			public function getMenuWithDropDownWrapper(MenuItemContract $item): ?string
66			{
67			}
68
69			/**
70			* Get multi level dropdown menu wrapper.
71			*
72			* @param \KyleMassacre\Menus\MenuItem $item
73			*
74			* @return string
75			*/
76			public function getMultiLevelDropdownWrapper(MenuItemContract $item): string
77			{
78			}
			0 ignored issues – show Bug Best Practice introduced 2024-04-01 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
79
80			/**
81			* Get child menu items.
82			*
83			* @param \KyleMassacre\Menus\MenuItem $item
84			*
85			* @return string
86			*/
87			public function getChildMenuItems(MenuItemContract $item): string
88			{
89			$results = '';
90			foreach ($item->getChildren() as $child) {
91			if ($child->hidden()) {
92			continue;
93			}
94
95			if ($child->hasSubMenu()) {
96			$results .= $this->getMultiLevelDropdownWrapper($child);
97			} elseif ($child->isHeader()) {
98			$results .= $this->getHeaderWrapper($child);
			0 ignored issues – show Bug introduced 2024-04-01 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getHeaderWrapper($child)` targeting `KyleMassacre\Menus\Prese...ter::getHeaderWrapper()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
99			} elseif ($child->isDivider()) {
100			$results .= $this->getDividerWrapper();
			0 ignored issues – show Bug introduced 2024-04-01 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getDividerWrapper()` targeting `KyleMassacre\Menus\Prese...er::getDividerWrapper()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
101			} else {
102			$results .= $this->getMenuWithoutDropdownWrapper($child);
			0 ignored issues – show Bug introduced 2024-04-01 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getMenuWithoutDropdownWrapper($child)` targeting `KyleMassacre\Menus\Prese...ithoutDropdownWrapper()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
103			}
104			}
105
106			return $results;
107			}
108			}
109

nWidart / laravel-menus

Pull Request — master (#57)

src/Presenters/Presenter.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like