n7olkachev / laravel-computed-properties

src/ComputedProperties.php

<?php

namespace N7olkachev\ComputedProperties;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Query\Builder as QueryBuilder;

trait ComputedProperties
{
    public static function bootComputedProperties()
    {
        Builder::macro('withComputed', function ($properties) {
            collect($properties)->each(function ($property) {
                if (!$this->model->hasComputedProperty($property)) {

The variable $this seems to be never defined.

The property model does not exist on N7olkachev\ComputedProperties\ComputedProperties. Since you implemented __get, consider adding a @property annotation.

                    throw new \InvalidArgumentException("Computed property [$property] does not exist");
                }

                $query = $this->model->callComputedProperty($property, true);

                if (is_null($this->query->columns)) {

The property query does not exist on N7olkachev\ComputedProperties\ComputedProperties. Since you implemented __get, consider adding a @property annotation.

                    $this->query->select([$this->query->from.'.*']);
                }

                $this->selectSub($query, $property);

It seems like selectSub() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            });

            return $this;

The variable $this seems to be never defined.

        });
    }

    public function __get($key)
    {
        if (!array_key_exists($key, $this->attributes) && $this->hasComputedProperty($key)) {
            $query = $this->callComputedProperty($key, false);
            $result = (array) $query->first();
            $this->attributes[$key] = array_first($result);

The property attributes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        return parent::__get($key);
    }

    public function hasComputedProperty($property)
    {
        return method_exists($this, $this->computedPropertyMethodName($property));
    }

    public function computedPropertyMethodName($property)
    {
        return 'computed' . ucfirst(camel_case($property));
    }

    public function callComputedProperty($property, $runningInQuery)
    {
        $method = $this->computedPropertyMethodName($property);
        $query = $this->$method(new ModelProxy($this, $runningInQuery));

        if ($query instanceof Builder) {
            $query = $query->toBase();
        }

        if (!$query instanceof QueryBuilder) {
            throw new \UnexpectedValueException("Computed property must return EloquentBuilder or QueryBuilder instance");
        }

        return $query;
    }
}