ContainerBuilder::build() - Code Metrics - Inspection of "add ServiceProviderInterface" - n1215/tsukuyomi-demo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d73238...0eea34 )

by n

created 2017-12-08 12:25 UTC

ContainerBuilder::build() A

↳ Parent: ContainerBuilder

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php
declare(strict_types=1);

namespace App\Container;

use App\Providers\ServiceProviderInterface;
use Illuminate\Container\Container;

class ContainerBuilder
{
    /** @var ServiceProviderInterface[] */
    private $providers;

    /**
     * @param string[] $providerClasses
     */
    public function __construct(array $providerClasses)
    {
        $this->providers = [];
        foreach($providerClasses as $providerClass) {
            $this->addProvider($providerClass);
        }
    }

    private function addProvider(string $providerClass)
    {
        $provider = new $providerClass();
        if (!is_subclass_of($providerClass, ServiceProviderInterface::class)) {

            throw new \InvalidArgumentException('provider must implement' . ServiceProviderInterface::class . '.');
        }

        $this->providers[] = $provider;
    }

    public function build(): Container
    {
        $container = new Container();
        foreach ($this->providers as $provider) {
            $provider->register($container);
        }

        return $container;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace App\Container;
5
6		use App\Providers\ServiceProviderInterface;
7		use Illuminate\Container\Container;
8
9		class ContainerBuilder
10		{
11		/** @var ServiceProviderInterface[] */
12		private $providers;
13
14		/**
15		* @param string[] $providerClasses
16		*/
17	2	public function __construct(array $providerClasses)
18		{
19	2	$this->providers = [];
20	2	foreach($providerClasses as $providerClass) {
21	2	$this->addProvider($providerClass);
22		}
23	1	}
24
25	2	private function addProvider(string $providerClass)
26		{
27	2	$provider = new $providerClass();
28	2	if (!is_subclass_of($providerClass, ServiceProviderInterface::class)) {
		0 ignored issues – show Bug introduced 2017-12-08 12:28 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\App\Providers\ServiceProviderInterface::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
29	1	throw new \InvalidArgumentException('provider must implement' . ServiceProviderInterface::class . '.');
30		}
31
32	1	$this->providers[] = $provider;
33	1	}
34
35	1	public function build(): Container
36		{
37	1	$container = new Container();
38	1	foreach ($this->providers as $provider) {
39	1	$provider->register($container);
40		}
41
42	1	return $container;
43		}
44		}
45

n1215 / tsukuyomi-demo

Push — master ( d73238...0eea34 )

ContainerBuilder::build() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like