mysociety / theyworkforyou

tests/UserTest.php

<?php

/**
 * Provides test methods for user functionality.
 */
class UserTest extends TWFY_Database_TestCase {
    /**
     * Loads the user testing fixture.
     */
    public function getDataSet() {
        return $this->createMySQLXMLDataSet(dirname(__FILE__) . '/_fixtures/user.xml');

Are you sure the usage of $this->createMySQLXMLDataSet(dirname(__FILE__) . '/_fixtures/user.xml') targeting TWFY_Database_TestCase::createMySQLXMLDataSet() seems to always return null.

    }

    /**
     * Ensures the database is prepared and the user class is included for every test.
     */
    public function setUp(): void {
        parent::setUp();

        include_once('www/includes/easyparliament/user.php');
    }

    public function testAddUser() {
        $u = new USER();

        $details = [
            "firstname" => 'Test',
            "lastname" => 'User',
            "email" => 'test@example.org',
            "postcode" => 'EH1 99SP',
            "mp_alert" => false,
            "url" => '',
            "password" => '',
            "optin" => '0',
            "status" => 'User',
        ];
        $u->add($details, false);

        $id = $u->user_id();
        $u->init($id);

        $this->assertEquals('Test', $u->firstname());
        $this->assertEquals('EH1 99SP', $u->postcode());
    }

    public function testEditUser() {
        $_COOKIE['epuser_id'] = '1.5ce7f6e2d7de4db00c297e1da0d48ac';
        $u = new THEUSER();
        $u->loggedin = 1;

        $this->assertEquals('Test', $u->firstname());

        $d = $u->update_self([

The assignment to $d is dead and can be removed.

            'firstname' => 'Experiment',
            'lastname' => 'User',
            'postcode' => 'EH1 99SP',
            'password' => '',
            'url' => '',
            'optin' => 0,
            'user_id' => 1,
        ]);

        $this->assertEquals('Experiment', $u->firstname());
    }

    public function testEditUserEmail() {
        $_COOKIE['epuser_id'] = '1.5ce7f6e2d7de4db00c297e1da0d48ac';
        $u = new THEUSER();
        $u->loggedin = 1;

        $this->assertEquals('user@example.org', $u->email());

        $d = $u->update_self([

The assignment to $d is dead and can be removed.

            'firstname' => 'Experiment',
            'lastname' => 'User',
            'email' => 'user@example.com',
            'postcode' => 'EH1 99SP',
            'password' => '',
            'url' => '',
            'optin' => 0,
            'user_id' => 1,
        ], false);

        // email should not change as user needs to confirm
        $this->assertEquals('user@example.org', $u->email());

        $tokenCount = $this->getRowCount('tokens', 'data = "1::user@example.com"');
        $this->assertEquals(1, $tokenCount, 'correct number of email confirm tokens');

        // token is based on the time so we can't test for it
        $queryTable = self::$db->query(
            'SELECT type, data FROM tokens WHERE data = "1::user@example.com"'
        )->fetch();

        $this->assertEquals('E', $queryTable['type']);
        $this->assertEquals('1::user@example.com', $queryTable['data']);

        $alertCount = $this->getRowCount('alerts', 'email = "user@example.org"');
        $this->assertEquals(1, $alertCount, 'correct number of alerts');

        $tokenRow = self::$db->query(
            'SELECT token, type, data FROM tokens WHERE data = "1::user@example.com"'
        )->fetch();

        $token = '2-' . $tokenRow['token'];

        $u->confirm_email($token, false);

        $this->assertEquals('user@example.com', $u->email(), 'confirming with token updates email address');
        $tokenCount = $this->getRowCount('tokens', 'data = "1::user@example.com"');
        $this->assertEquals(0, $tokenCount, 'token deleted once email confirmed');

        $alertCount = $this->getRowCount('alerts', 'email = "user@example.com"');
        $this->assertEquals(1, $alertCount, 'one alert for new email address');

        $alertCount = $this->getRowCount('alerts', 'email = "user@example.org"');
        $this->assertEquals(0, $alertCount, 'no alerts for old email address');
    }

    public function testExpiredToken() {
        $_COOKIE['epuser_id'] = '1.5ce7f6e2d7de4db00c297e1da0d48ac';
        $u = new THEUSER();
        $u->loggedin = 1;

        $this->assertEquals('user@example.org', $u->email(), 'confirming inital email address');

        $tokenCount = $this->getRowCount('tokens', 'data = "1::user@example.net"');
        $this->assertEquals(1, $tokenCount, 'correct number of email confirm tokens');

        $token = '2-lkdsjafhsadjhf';

        $u->confirm_email($token, false);
        $this->assertEquals('user@example.org', $u->email(), 'expired token does not update email address');

        $tokenCount = $this->getRowCount('tokens', 'data = "1::user@example.net"');
        $this->assertEquals(1, $tokenCount, 'correct number of email confirm tokens');
    }

}