Passed
Pull Request — master (#1868)
by
unknown
35:27
created
classes/DataClass/Regmem/Person.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,6 +42,6 @@
 block discarded – undo
42 42
                 return $category;
43 43
             }
44 44
         }
45
-        throw new InvalidArgumentException("Category $categoryId not found in register");
45
+        throw new InvalidArgumentException("category $categoryId not found in register");
46 46
     }
47 47
 }
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/_register_field.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,11 +13,14 @@
 block discarded – undo
13 13
             <?php $detail = $upper_detail; ?>
14 14
         </ul>
15 15
         </li>
16
-    <?php else : ?>
16
+    <?php else {
17
+    : ?>
17 18
         <li class="interest-detail">
18 19
         <?php if ($detail->has_value()): ?>
19 20
             <span class="interest-detail-name"><?= $detail->display_as ?>: </span>
20 21
             <span class="interest-detail-value"><?= htmlspecialchars($detail->value) ?></span>
21
-        <?php endif; ?>
22
+        <?php endif;
23
+}
24
+?>
22 25
         </li>
23 26
     <?php endif; ?>
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/interests/_register_field.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,12 +13,15 @@
 block discarded – undo
13 13
             <?php $detail = $upper_detail; ?>
14 14
         </ul>
15 15
         </li>
16
-    <?php else : ?>
16
+    <?php else {
17
+    : ?>
17 18
         <?php if ($detail->has_value()): ?>
18 19
         <li class="interest-detail">
19 20
             <span class="interest-detail-name"><?= $detail->display_as ?>: </span>
20 21
             <span class="interest-detail-value"><?= htmlspecialchars($detail->value) ?></span>
21 22
         </li>
22
-        <?php endif; ?>
23
+        <?php endif;
24
+}
25
+?>
23 26
 
24 27
     <?php endif; ?>
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/interests/highlighted_2024.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
                                     <th>MP's comment</th>
54 54
                                 </tr>
55 55
                     <?php foreach ($register->persons as $person) { ?>
56
-                        <?php foreach($person->categories as $category) { ?>
56
+                        <?php foreach ($person->categories as $category) { ?>
57 57
                             <?php if ($category->category_id != $category_id) { ?>
58 58
                                 <?php continue; ?>
59 59
                             <?php }; ?>
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/interests/_register_entry.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,9 +28,12 @@
 block discarded – undo
28 28
     <?php // This is a more mininal style of entry, don't use the header structure, just print the xml content?>
29 29
     <?php if ($entry->content_format == "xml") : ?>
30 30
         <?= $entry->content ?>
31
-    <?php else: ?>
31
+    <?php else {
32
+    : ?>
32 33
         <p class="interest-content"><?= htmlspecialchars($entry->content) ?></p>
33
-    <?php endif; ?>
34
+    <?php endif;
35
+}
36
+?>
34 37
 <?php endif; ?>
35 38
 
36 39
     </ul>
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/homepage/devolved-list.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2
-$nav_items =  [
2
+$nav_items = [
3 3
     ['hansard', 'alldebatesfront', 'mps', 'peers', 'interests_home', 'wranswmsfront', 'divisions_recent_commons', 'divisions_recent_lords'],
4 4
     ['sp_home', 'sp_home', 'spdebatesfront', 'msps', 'interest_category_sp', 'spwransfront', 'divisions_recent_sp'],
5
-    ['wales_home', 'wales_home', 'wales_debates', 'mss','interest_category_wp', 'welshlanguage', 'divisions_recent_wales'],
6
-    ['ni_home', 'ni_home', 'nioverview', 'mlas','interest_category_ni'],
5
+    ['wales_home', 'wales_home', 'wales_debates', 'mss', 'interest_category_wp', 'welshlanguage', 'divisions_recent_wales'],
6
+    ['ni_home', 'ni_home', 'nioverview', 'mlas', 'interest_category_ni'],
7 7
 ];
8 8
 
9 9
 ?>  
Please login to merge, or discard this patch.
classes/DataClass/Regmem/CategoryList.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
 
17 17
     public function limitToCategoryIds(array $categoryIds) {
18 18
         // Filter the categories to only include those with the given IDs
19
-        $this->items = array_filter($this->items, function ($category) use ($categoryIds) {
19
+        $this->items = array_filter($this->items, function($category) use ($categoryIds) {
20 20
             return in_array($category->category_id, $categoryIds);
21 21
         });
22 22
     }
Please login to merge, or discard this patch.
classes/Renderer/Header.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 
170 170
         if ($nextprev) {
171 171
             // Four different kinds of back/forth links we might build.
172
-            $links =  ["first", "prev", "up", "next", "last"];
172
+            $links = ["first", "prev", "up", "next", "last"];
173 173
 
174 174
             foreach ($links as $type) {
175 175
                 if ($link = $this->generate_next_prev_link($nextprev, $type)) {
@@ -307,9 +307,9 @@  discard block
 block discarded – undo
307 307
         // Page names mapping to those in metadata.php.
308 308
         // Links in the top menu, and the sublinks we see if
309 309
         // we're within that section.
310
-        $nav_items =  [
310
+        $nav_items = [
311 311
             ['home'],
312
-            ['hansard', 'mps', 'peers', 'alldebatesfront', 'interests_home', 'wranswmsfront', 'pbc_front', 'divisions_recent_commons', 'divisions_recent_lords',  'calendar_summary'],
312
+            ['hansard', 'mps', 'peers', 'alldebatesfront', 'interests_home', 'wranswmsfront', 'pbc_front', 'divisions_recent_commons', 'divisions_recent_lords', 'calendar_summary'],
313 313
             ['sp_home', 'spoverview', 'msps', 'interest_category_sp', 'spdebatesfront', 'divisions_recent_sp'], #'spwransfront'
314 314
             ['ni_home', 'nioverview', 'mlas', 'interest_category_ni'],
315 315
             ['wales_home', 'seneddoverview', 'mss', 'interest_category_wp', 'wales_debates', 'divisions_recent_wales'],
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/votes.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@  discard block
 block discarded – undo
131 131
 
132 132
                     <ul class="vote-descriptions">
133 133
                               <?php foreach ($sig_diff_policy->policy_pairs as $policy_pair) {
134
-                                  include '_vote_description.php';
135
-                              } ?>
134
+                                    include '_vote_description.php';
135
+                                } ?>
136 136
                             </ul>
137 137
 
138 138
                     <?php } ?>
@@ -165,9 +165,9 @@  discard block
 block discarded – undo
165 165
                             <ul class="vote-descriptions">
166 166
                               <?php foreach ($segment->policy_pairs as $policy_pair) {
167 167
 
168
-                                  include '_vote_description.php';
168
+                                    include '_vote_description.php';
169 169
 
170
-                              } ?>
170
+                                } ?>
171 171
                             </ul>
172 172
 
173 173
                             <p class="voting-information-provenance">
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 
24 24
                 <h3 class="browse-content">Comparison periods</h3>
25 25
                     <ul> 
26
-                    <?php foreach($available_periods as $period) { ?>
26
+                    <?php foreach ($available_periods as $period) { ?>
27 27
                         <li class="active"><a href="?comparison_period=<?= $period->lslug() ?>"><?= $period->description ?></a></li>
28 28
                     <?php } ?>
29 29
                     </ul>
Please login to merge, or discard this patch.