mysociety /
theyworkforyou
| Total Complexity | 43 |
| Total Lines | 253 |
| Duplicated Lines | 0 % |
| Coverage | 54.84% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like People often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use People, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class People { |
||
| 15 | |||
| 16 | public $type; |
||
| 17 | public $rep_name; |
||
| 18 | public $rep_plural; |
||
| 19 | public $house; |
||
| 20 | public $cons_type; |
||
| 21 | public $reg_cons_type; |
||
| 22 | public $subs_missing_image = true; |
||
| 23 | public $db; |
||
| 24 | |||
| 25 | 4 | public function __construct() { |
|
| 26 | 4 | global $this_page; |
|
| 27 | 4 | $this_page = $this->type; |
|
| 28 | 4 | $this->db = new \ParlDB(); |
|
| 29 | 4 | } |
|
| 30 | |||
| 31 | 2 | protected function getRegionalReps($user) { |
|
| 32 | 2 | return $user->getRegionalReps($this->reg_cons_type, $this->house); |
|
| 33 | } |
||
| 34 | |||
| 35 | 4 | public function getData($args = array()) { |
|
| 36 | 4 | $data = $this->_get_data_by_group($args); |
|
| 37 | |||
| 38 | 4 | $user = new User(); |
|
| 39 | 4 | if ( $reps = $this->getRegionalReps($user) ) { |
|
| 40 | $data['reps'] = $reps; |
||
| 41 | } |
||
| 42 | |||
| 43 | 4 | $data['mp_data'] = $user->getRep($this->cons_type, $this->house); |
|
| 44 | 4 | $data['data'] = $this->addImagesToData($data['data']); |
|
| 45 | 4 | $data['urls'] = $this->addUrlsToData(); |
|
| 46 | 4 | $data['order'] = isset($args['order']) ? $args['order'] : 'l'; |
|
| 47 | 4 | $data['rep_plural'] = $this->rep_plural; |
|
| 48 | 4 | $data['rep_name'] = $this->rep_name; |
|
| 49 | 4 | $data['type'] = $this->type; |
|
| 50 | |||
| 51 | 4 | return $data; |
|
| 52 | } |
||
| 53 | |||
| 54 | public function getArgs() { |
||
| 55 | $args = array(); |
||
| 56 | |||
| 57 | if (get_http_var('f') == 'csv') { |
||
| 58 | $args['f'] = 'csv'; |
||
| 59 | } |
||
| 60 | |||
| 61 | $date = get_http_var('date'); |
||
| 62 | if ($date) { |
||
| 63 | $date = parse_date($date); |
||
| 64 | if ($date) { |
||
| 65 | $args['date'] = $date['iso']; |
||
| 66 | } |
||
| 67 | } elseif (get_http_var('all')) { |
||
| 68 | $args['all'] = true; |
||
| 69 | } |
||
| 70 | |||
| 71 | if ( $this->type == 'peers' ) { |
||
| 72 | $args['order'] = 'name'; |
||
| 73 | } |
||
| 74 | |||
| 75 | $order = get_http_var('o'); |
||
| 76 | $orders = array( |
||
| 77 | 'n' => 'name', 'f' => 'given_name', 'l' => 'family_name', |
||
| 78 | 'c' => 'constituency', 'p' => 'party', 'd' => 'debates', |
||
| 79 | ); |
||
| 80 | if (array_key_exists($order, $orders)) { |
||
| 81 | $args['order'] = $orders[$order]; |
||
| 82 | } |
||
| 83 | |||
| 84 | return $args; |
||
| 85 | } |
||
| 86 | |||
| 87 | public function setMetaData($args) { |
||
| 88 | global $this_page, $DATA; |
||
| 89 | |||
| 90 | if (isset($args['date'])) { |
||
| 91 | $DATA->set_page_metadata($this_page, 'title', $this->rep_plural . ', as on ' . format_date($args['date'], LONGDATEFORMAT)); |
||
| 92 | } elseif (isset($args['all'])) { |
||
| 93 | $DATA->set_page_metadata($this_page, 'title', 'All ' . $this->rep_plural . ', including former ones'); |
||
| 94 | } else { |
||
| 95 | $DATA->set_page_metadata($this_page, 'title', 'All ' . $this->rep_plural); |
||
| 96 | } |
||
| 97 | } |
||
| 98 | |||
| 99 | protected function getCSVHeaders() { |
||
| 100 | return array('Person ID', 'Name', 'Party', 'Constituency', 'URI'); |
||
| 101 | } |
||
| 102 | |||
| 103 | protected function getCSVRow($details) { |
||
| 110 | ); |
||
| 111 | } |
||
| 112 | |||
| 113 | public function sendAsCSV($data) { |
||
| 114 | header('Content-Disposition: attachment; filename=' . $this->type . '.csv'); |
||
| 115 | header('Content-Type: text/csv'); |
||
| 116 | $out = fopen('php://output', 'w'); |
||
| 117 | |||
| 118 | $headers = $this->getCSVHeaders(); |
||
| 119 | if ($data['info']['order'] == 'debates') { |
||
| 120 | $headers[] = 'Debates spoken in the last year'; |
||
| 121 | } |
||
| 122 | fputcsv($out, $headers); |
||
|
Bug
introduced
by
|
|||
| 123 | |||
| 124 | foreach ($data['data'] as $pid => $details) { |
||
| 125 | $row = $this->getCSVRow($details); |
||
| 126 | if ($data['info']['order'] == 'debates') { |
||
| 127 | $row[] = $details['data_value']; |
||
| 128 | } |
||
| 129 | fputcsv($out, $row); |
||
| 130 | } |
||
| 131 | |||
| 132 | fclose($out); |
||
| 133 | } |
||
| 134 | |||
| 135 | 4 | private function addImagesToData($data) { |
|
| 144 | } |
||
| 145 | |||
| 146 | 4 | private function addUrlsToData() { |
|
| 147 | 4 | global $this_page; |
|
| 148 | |||
| 175 | } |
||
| 176 | |||
| 177 | 4 | private function _get_data_by_group($args) { |
|
| 271 |
Loading history...
