Failed Conditions
Pull Request — master (#1328)
by Nick
33:04 queued 18:05
created
classes/FacebookLogin.php 4 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@
 block discarded – undo
23 23
         return $this->fb;
24 24
     }
25 25
 
26
+    /**
27
+     * @return string
28
+     */
26 29
     public function getLoginURL() {
27 30
         $helper = $this->getFacebookObject()->getRedirectLoginHelper();
28 31
         $permissions = ['email'];
Please login to merge, or discard this patch.
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -13,11 +13,11 @@  discard block
 block discarded – undo
13 13
 
14 14
     public function getFacebookObject() {
15 15
         if (!isset($this->fb)) {
16
-          $this->fb = new \Facebook\Facebook([
16
+            $this->fb = new \Facebook\Facebook([
17 17
             'app_id' => FACEBOOK_APP_ID,
18 18
             'app_secret' => FACEBOOK_APP_SECRET,
19 19
             'default_graph_version' => 'v2.2',
20
-          ]);
20
+            ]);
21 21
         }
22 22
 
23 23
         return $this->fb;
@@ -30,46 +30,46 @@  discard block
 block discarded – undo
30 30
     }
31 31
 
32 32
     public function handleFacebookRedirect() {
33
-      $helper = $this->getFacebookObject()->getRedirectLoginHelper();
33
+        $helper = $this->getFacebookObject()->getRedirectLoginHelper();
34 34
 
35
-      $data = array('login_url' => $this->getLoginURL());
35
+        $data = array('login_url' => $this->getLoginURL());
36 36
 
37
-      try {
37
+        try {
38 38
         $accessToken = $helper->getAccessToken();
39
-      } catch(\Facebook\Exceptions\FacebookResponseException $e) {
39
+        } catch(\Facebook\Exceptions\FacebookResponseException $e) {
40 40
         $data['error'] = 'Graph returned an error: ' . $e->getMessage();
41 41
         return $data;
42
-      } catch(\Facebook\Exceptions\FacebookSDKException $e) {
42
+        } catch(\Facebook\Exceptions\FacebookSDKException $e) {
43 43
         $data['error'] = 'Facebook SDK returned an error: ' . $e->getMessage();
44 44
         return $data;
45
-      }
45
+        }
46 46
 
47
-      $token = $this->checkAccessToken($accessToken);
47
+        $token = $this->checkAccessToken($accessToken);
48 48
 
49
-      if ($token) {
50
-          return array('token' => $token);
51
-      } else {
52
-          $data['error'] = 'Problem getting Facebook token';
53
-          return $data;
54
-      }
49
+        if ($token) {
50
+            return array('token' => $token);
51
+        } else {
52
+            $data['error'] = 'Problem getting Facebook token';
53
+            return $data;
54
+        }
55 55
     }
56 56
 
57 57
 
58 58
     private function checkAccessToken($accessToken) {
59
-      if (!isset($accessToken)) {
60
-          return False;
61
-      }
59
+        if (!isset($accessToken)) {
60
+            return False;
61
+        }
62 62
 
63
-      if (! $accessToken->isLongLived()) {
63
+        if (! $accessToken->isLongLived()) {
64 64
         $oAuth2Client = $this->getFacebookObject()->getOAuth2Client();
65 65
         try {
66
-          $accessToken = $oAuth2Client->getLongLivedAccessToken($accessToken);
66
+            $accessToken = $oAuth2Client->getLongLivedAccessToken($accessToken);
67 67
         } catch (\Facebook\Exceptions\FacebookSDKException $e) {
68
-          return False;
68
+            return False;
69
+        }
69 70
         }
70
-      }
71 71
 
72
-      return $accessToken;
72
+        return $accessToken;
73 73
     }
74 74
 
75 75
     public function loginUser($accessToken) {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
             'optin' => $THEUSER->optin(),
159 159
             'emailpublic' => False,
160 160
             'password' => '',
161
-         );
161
+            );
162 162
 
163 163
         $THEUSER->update_self_no_confirm($details);
164 164
     }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
     private function checkAccessToken($accessToken) {
59 59
       if (!isset($accessToken)) {
60
-          return False;
60
+          return false;
61 61
       }
62 62
 
63 63
       if (! $accessToken->isLongLived()) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         try {
66 66
           $accessToken = $oAuth2Client->getLongLivedAccessToken($accessToken);
67 67
         } catch (\Facebook\Exceptions\FacebookSDKException $e) {
68
-          return False;
68
+          return false;
69 69
         }
70 70
       }
71 71
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
         $expires = intval($accessToken->getExpiresAt()->format('U'));
87 87
         twfy_debug("THEUSER", "Facebook access token expires at " . $expires);
88 88
 
89
-        $success = False;
89
+        $success = false;
90 90
         if ($user_id) {
91 91
             twfy_debug("THEUSER", "Faceook user exists in the database: " . $user_id);
92 92
             $success = $THEUSER->init($user_id);
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
             return $logged_in;
113 113
         }
114 114
 
115
-        return False;
115
+        return false;
116 116
     }
117 117
 
118 118
     public function createUser($accessToken, $user) {
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
128 128
             'url' => '',
129 129
             'status' => '',
130 130
             'password' => '',
131
-            'optin' => False,
132
-            'emailpublic' => False,
133
-            'mp_alert' => False,
131
+            'optin' => false,
132
+            'emailpublic' => false,
133
+            'mp_alert' => false,
134 134
             'facebook_id' => $user['id']
135 135
         );
136 136
         $added = $THEUSER->add($details, false);
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
             'postcode' => $THEUSER->postcode(),
157 157
             'url' => $THEUSER->url(),
158 158
             'optin' => $THEUSER->optin(),
159
-            'emailpublic' => False,
159
+            'emailpublic' => false,
160 160
             'password' => '',
161 161
          );
162 162
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
 
37 37
       try {
38 38
         $accessToken = $helper->getAccessToken();
39
-      } catch(\Facebook\Exceptions\FacebookResponseException $e) {
39
+      } catch (\Facebook\Exceptions\FacebookResponseException $e) {
40 40
         $data['error'] = 'Graph returned an error: ' . $e->getMessage();
41 41
         return $data;
42
-      } catch(\Facebook\Exceptions\FacebookSDKException $e) {
42
+      } catch (\Facebook\Exceptions\FacebookSDKException $e) {
43 43
         $data['error'] = 'Facebook SDK returned an error: ' . $e->getMessage();
44 44
         return $data;
45 45
       }
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
           return False;
61 61
       }
62 62
 
63
-      if (! $accessToken->isLongLived()) {
63
+      if (!$accessToken->isLongLived()) {
64 64
         $oAuth2Client = $this->getFacebookObject()->getOAuth2Client();
65 65
         try {
66 66
           $accessToken = $oAuth2Client->getLongLivedAccessToken($accessToken);
Please login to merge, or discard this patch.
classes/Model/Featured.php 3 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -52,6 +52,11 @@  discard block
 block discarded – undo
52 52
         $this->_set('featured_related', $related);
53 53
     }
54 54
 
55
+    /**
56
+     * @param string $key
57
+     *
58
+     * @return string
59
+     */
55 60
     private function _get($key) {
56 61
         $text = NULL;
57 62
 
@@ -72,6 +77,9 @@  discard block
 block discarded – undo
72 77
         return $text;
73 78
     }
74 79
 
80
+    /**
81
+     * @param string $key
82
+     */
75 83
     private function _set($key, $value) {
76 84
         if ( trim($value) == '' ) {
77 85
             $value = NULL;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
         if ($q->rows) {
66 66
             $text = $q->field(0, 'value');
67
-            if ( trim($text) == '' ) {
67
+            if (trim($text) == '') {
68 68
                 $text = NULL;
69 69
             }
70 70
         }
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
     }
74 74
 
75 75
     private function _set($key, $value) {
76
-        if ( trim($value) == '' ) {
76
+        if (trim($value) == '') {
77 77
             $value = NULL;
78 78
         }
79 79
         $check_q = $this->db->query(
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
                 ':key' => $key
83 83
             )
84 84
         );
85
-        if ( $check_q->rows ) {
85
+        if ($check_q->rows) {
86 86
             $set_q = $this->db->query("UPDATE editorial set value = :value WHERE item = :key",
87 87
                 array(
88 88
                     ':key' => $key,
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
             );
99 99
         }
100 100
 
101
-        if ( $set_q->success() ) {
101
+        if ($set_q->success()) {
102 102
             return true;
103 103
         }
104 104
         return false;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
     }
54 54
 
55 55
     private function _get($key) {
56
-        $text = NULL;
56
+        $text = null;
57 57
 
58 58
         $q = $this->db->query(
59 59
             "SELECT value FROM editorial WHERE item = :key",
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         if ($q->rows) {
66 66
             $text = $q->field(0, 'value');
67 67
             if ( trim($text) == '' ) {
68
-                $text = NULL;
68
+                $text = null;
69 69
             }
70 70
         }
71 71
 
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 
75 75
     private function _set($key, $value) {
76 76
         if ( trim($value) == '' ) {
77
-            $value = NULL;
77
+            $value = null;
78 78
         }
79 79
         $check_q = $this->db->query(
80 80
             "SELECT value FROM editorial WHERE item = :key",
Please login to merge, or discard this patch.
www/includes/test/utility_test.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,11 +12,11 @@
 block discarded – undo
12 12
 
13 13
 class UtilityTest extends UnitTestCase{
14 14
 
15
-  public function testVerpEnvelopeSenderCanCreateStandardSender() {
15
+    public function testVerpEnvelopeSenderCanCreateStandardSender() {
16 16
     $sender = twfy_verp_envelope_sender('[email protected]');
17 17
     $expected_sender = 'twfy+aperson=a.nother.dom@' + EMAILDOMAIN;
18 18
     $this->assertEqual($sender, $expected_sender, 'verp_envelope_sender can create a sender for a standard address');
19
-  }
19
+    }
20 20
 
21 21
 }
22 22
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,18 +3,18 @@
 block discarded – undo
3 3
  * SimpleTest tests for the functions in utility.php
4 4
  * $Id: utility_test.php,v 1.3 2009-06-25 12:23:58 louise Exp $
5 5
  */
6
-error_reporting (E_ALL);
6
+error_reporting(E_ALL);
7 7
 ini_set("display_errors", 1);
8 8
 include_once dirname(__FILE__) . '/../../../conf/general';
9 9
 include_once '../utility.php';
10 10
 include_once 'simpletest/unit_tester.php';
11 11
 include_once 'simpletest/reporter.php';
12 12
 
13
-class UtilityTest extends UnitTestCase{
13
+class UtilityTest extends UnitTestCase {
14 14
 
15 15
   public function testVerpEnvelopeSenderCanCreateStandardSender() {
16 16
     $sender = twfy_verp_envelope_sender('[email protected]');
17
-    $expected_sender = 'twfy+aperson=a.nother.dom@' + EMAILDOMAIN;
17
+    $expected_sender = 'twfy+aperson=a.nother.dom@' +EMAILDOMAIN;
18 18
     $this->assertEqual($sender, $expected_sender, 'verp_envelope_sender can create a sender for a standard address');
19 19
   }
20 20
 
Please login to merge, or discard this patch.
www/includes/easyparliament/init.php 3 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,9 @@
 block discarded – undo
41 41
 twfy_debug_timestamp("after including utility.php");
42 42
 
43 43
 // Set the default timezone
44
-if(function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
44
+if(function_exists('date_default_timezone_set')) {
45
+    date_default_timezone_set(TIMEZONE);
46
+}
45 47
 
46 48
 // Only do clever things with errors if we're not testing, otherwise show as default
47 49
 
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
 include_once (INCLUDESPATH."easyparliament/user.php");
93 93
 
94 94
 // Test to see if this is a new-style template using the renderer class.
95
-if (! isset($new_style_template) OR $new_style_template !== TRUE) {
95
+if (! isset($new_style_template) or $new_style_template !== true) {
96 96
 
97 97
     // This is an old-style page. Use the old page classes.
98 98
     include_once (INCLUDESPATH."easyparliament/page.php");
Please login to merge, or discard this patch.
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 First some things to help make our PHP nicer and betterer
5 5
 ********************************************************************************/
6 6
 
7
-error_reporting (E_ALL);
7
+error_reporting(E_ALL);
8 8
 
9 9
 /********************************************************************************
10 10
 Now some constants that are the same for live and dev versions
@@ -12,22 +12,22 @@  discard block
 block discarded – undo
12 12
 ********************************************************************************/
13 13
 
14 14
 // In case we need to switch these off globally at some point...
15
-define ("ALLOWCOMMENTS", true);
16
-define ("ALLOWTRACKBACKS", true);
15
+define("ALLOWCOMMENTS", true);
16
+define("ALLOWTRACKBACKS", true);
17 17
 
18 18
 // These variables are so we can keep date/time formats consistent across the site
19 19
 // and change them easily.
20 20
 // Formats here: http://www.php.net/manual/en/function.date.php
21
-define ("LONGERDATEFORMAT",		"l, j F Y");// Monday, 31 December 2003
22
-define ("LONGDATEFORMAT", 		"j F Y"); 	// 31 December 2003
23
-define ("SHORTDATEFORMAT", 		"j M Y");	// 31 Dec 2003
24
-define ("TIMEFORMAT", 			"g:i a");	// 11:59 pm
21
+define("LONGERDATEFORMAT", "l, j F Y"); // Monday, 31 December 2003
22
+define("LONGDATEFORMAT", "j F Y"); // 31 December 2003
23
+define("SHORTDATEFORMAT", "j M Y"); // 31 Dec 2003
24
+define("TIMEFORMAT", "g:i a"); // 11:59 pm
25 25
 
26
-define ("SHORTDATEFORMAT_SQL",	"%e %b %Y"); // 31 Dec 2003
27
-define ("TIMEFORMAT_SQL", 		"%l:%i %p"); // 11:59 PM
26
+define("SHORTDATEFORMAT_SQL", "%e %b %Y"); // 31 Dec 2003
27
+define("TIMEFORMAT_SQL", "%l:%i %p"); // 11:59 PM
28 28
 
29 29
 // Where we store the postcode of users if they search for an MP by postcode.
30
-define ('POSTCODE_COOKIE', 		'eppc');
30
+define('POSTCODE_COOKIE', 'eppc');
31 31
 
32 32
 /********************************************************************************
33 33
 And now all the files we'll include on every page.
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 twfy_debug_timestamp("after including utility.php");
42 42
 
43 43
 // Set the default timezone
44
-if(function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
44
+if (function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
45 45
 
46 46
 // Only do clever things with errors if we're not testing, otherwise show as default
47 47
 
@@ -70,40 +70,40 @@  discard block
 block discarded – undo
70 70
 
71 71
 // The time the page starts, so we can display the total at the end.
72 72
 // getmicrotime() is in utiltity.php.
73
-define ("STARTTIME", getmicrotime());
73
+define("STARTTIME", getmicrotime());
74 74
 if (!isset($_SERVER['WINDIR'])) {
75 75
     $rusage = getrusage();
76
-    define ('STARTTIMES', $rusage['ru_stime.tv_sec']*1000000 + $rusage['ru_stime.tv_usec']);
77
-    define ('STARTTIMEU', $rusage['ru_utime.tv_sec']*1000000 + $rusage['ru_utime.tv_usec']);
76
+    define('STARTTIMES', $rusage['ru_stime.tv_sec'] * 1000000 + $rusage['ru_stime.tv_usec']);
77
+    define('STARTTIMEU', $rusage['ru_utime.tv_sec'] * 1000000 + $rusage['ru_utime.tv_usec']);
78 78
 }
79 79
 
80 80
 $DATA = new \MySociety\TheyWorkForYou\Data;
81 81
 
82 82
 class ParlDB extends \MySociety\TheyWorkForYou\Db\Connection {
83 83
     public function __construct() {
84
-        $this->init (OPTION_TWFY_DB_HOST, OPTION_TWFY_DB_USER, OPTION_TWFY_DB_PASS, OPTION_TWFY_DB_NAME);
84
+        $this->init(OPTION_TWFY_DB_HOST, OPTION_TWFY_DB_USER, OPTION_TWFY_DB_PASS, OPTION_TWFY_DB_NAME);
85 85
     }
86 86
 }
87 87
 
88 88
 $filter = new \MySociety\TheyWorkForYou\Utility\LibFilter;
89 89
 
90
-include_once (INCLUDESPATH."easyparliament/user.php");
90
+include_once (INCLUDESPATH . "easyparliament/user.php");
91 91
 
92 92
 // Test to see if this is a new-style template using the renderer class.
93
-if (! isset($new_style_template) OR $new_style_template !== TRUE) {
93
+if (!isset($new_style_template) OR $new_style_template !== TRUE) {
94 94
 
95 95
     // This is an old-style page. Use the old page classes.
96
-    include_once (INCLUDESPATH."easyparliament/page.php");
96
+    include_once (INCLUDESPATH . "easyparliament/page.php");
97 97
 
98 98
 }
99 99
 
100
-include_once (INCLUDESPATH."easyparliament/hansardlist.php");
101
-include_once (INCLUDESPATH."dbtypes.php");
102
-include_once (INCLUDESPATH."easyparliament/commentlist.php");
103
-include_once (INCLUDESPATH."easyparliament/comment.php");
104
-include_once (INCLUDESPATH."easyparliament/trackback.php");
100
+include_once (INCLUDESPATH . "easyparliament/hansardlist.php");
101
+include_once (INCLUDESPATH . "dbtypes.php");
102
+include_once (INCLUDESPATH . "easyparliament/commentlist.php");
103
+include_once (INCLUDESPATH . "easyparliament/comment.php");
104
+include_once (INCLUDESPATH . "easyparliament/trackback.php");
105 105
 
106 106
 // Added in as new module by Richard Allan MP
107
-include_once (INCLUDESPATH."easyparliament/alert.php");
107
+include_once (INCLUDESPATH . "easyparliament/alert.php");
108 108
 
109 109
 twfy_debug_timestamp("at end of init.php");
Please login to merge, or discard this patch.
www/includes/easyparliament/metadata.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
         'url'			=> 'peer/'
531 531
     ),
532 532
     'peers' => array (
533
-         'menu'			=> array (
533
+            'menu'			=> array (
534 534
             'text'			=> 'Lords',
535 535
             'title'			=> "List of all Lords"
536 536
         ),
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
         'url'			=> 'peers/'
540 540
     ),
541 541
 'overview' => array (
542
-     'menu'			=> array (
542
+        'menu'			=> array (
543 543
         'text'			=> 'Overview',
544 544
         'title'			=> "Overview of the UK Parliament"
545 545
     ),
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
         'url'			=> 'rss/mp/'
592 592
     ),
593 593
     'mps' => array (
594
-         'menu'			=> array (
594
+            'menu'			=> array (
595 595
             'text'			=> 'MPs',
596 596
             'title'			=> "List of all Members of Parliament (MPs)"
597 597
         ),
Please login to merge, or discard this patch.
Spacing   +235 added lines, -235 removed lines patch added patch discarded remove patch
@@ -65,10 +65,10 @@  discard block
 block discarded – undo
65 65
 
66 66
 */
67 67
 
68
-$this->page = array (
68
+$this->page = array(
69 69
 
70 70
 // Things used on EVERY page, unless overridden for a page:
71
-    'default' => array (
71
+    'default' => array(
72 72
         'parent'	=> '',
73 73
         'session_vars' => array('super_debug'),
74 74
         'sitetitle'		=> 'TheyWorkForYou',
@@ -78,117 +78,117 @@  discard block
 block discarded – undo
78 78
 
79 79
 // KEEP THE PAGES IN ALPHABETICAL ORDER! TA.
80 80
 
81
-    'about' => array (
81
+    'about' => array(
82 82
         'title'			=> 'About us',
83 83
         'url'			=> 'about/'
84 84
     ),
85
-    'parliaments' => array (
85
+    'parliaments' => array(
86 86
         'title' 	=> 'Parliaments and assemblies',
87 87
         'url'       => 'parliaments/'
88 88
     ),
89 89
 
90
-    'alert_stats' => array (
90
+    'alert_stats' => array(
91 91
         'title'			=> 'Email alerts statistics',
92 92
         'parent'		=> 'admin',
93 93
         'url'			=> 'admin/alert_stats.php',
94 94
     ),
95
-    'admin_badusers' => array (
95
+    'admin_badusers' => array(
96 96
         'title'			=> 'Bad users',
97 97
         'parent'		=> 'admin',
98 98
         'url'			=> 'admin/badusers.php'
99 99
     ),
100
-    'admin_home' => array (
100
+    'admin_home' => array(
101 101
         'title'			=> 'Home',
102 102
         'parent'		=> 'admin',
103 103
         'url'			=> 'admin/'
104 104
     ),
105
-    'admin_comments' => array (
105
+    'admin_comments' => array(
106 106
         'title'			=> 'Recent comments',
107 107
         'parent'		=> 'admin',
108 108
         'url'			=> 'admin/comments.php'
109 109
     ),
110
-    'admin_commentreport' => array (
110
+    'admin_commentreport' => array(
111 111
         'title'			=> 'Processing a comment report',
112 112
         'parent'		=> 'admin',
113 113
         'url'			=> 'admin/report.php',
114
-        'session_vars'	=> array ('rid', 'cid')
114
+        'session_vars'	=> array('rid', 'cid')
115 115
     ),
116
-    'admin_commentreports' => array (
116
+    'admin_commentreports' => array(
117 117
         'title'			=> 'Outstanding comment reports',
118 118
         'parent'		=> 'admin',
119 119
         'url'			=> 'admin/reports.php'
120 120
     ),
121
-    'admin_failedsearches' => array (
121
+    'admin_failedsearches' => array(
122 122
         'title'			=> 'Failed searches',
123 123
         'parent'		=> 'admin',
124 124
         'url'			=> 'admin/failedsearches.php'
125 125
     ),
126
-    'admin_glossary' => array (
126
+    'admin_glossary' => array(
127 127
         'title'			=> 'Manage glossary entries',
128 128
         'parent'		=> 'admin',
129 129
         'url'			=> 'admin/glossary.php'
130 130
     ),
131
-    'admin_glossary_pending' => array (
131
+    'admin_glossary_pending' => array(
132 132
         'title'			=> 'Review pending glossary entries',
133 133
         'parent'		=> 'admin',
134 134
         'url'			=> 'admin/glossary_pending.php'
135 135
     ),
136
-    'admin_searchlogs' => array (
136
+    'admin_searchlogs' => array(
137 137
         'title'			=> 'Recent searches',
138 138
         'parent'		=> 'admin',
139 139
         'url'			=> 'admin/searchlogs.php'
140 140
     ),
141
-    'admin_popularsearches' => array (
141
+    'admin_popularsearches' => array(
142 142
         'title'			=> 'Popular searches in last 30 days (first 1000)',
143 143
         'parent'		=> 'admin',
144 144
         'url'			=> 'admin/popularsearches.php'
145 145
     ),
146
-    'admin_statistics' => array (
146
+    'admin_statistics' => array(
147 147
         'title'			=> 'General statistics',
148 148
         'parent'		=> 'admin',
149 149
         'url'			=> 'admin/statistics.php'
150 150
     ),
151
-    'admin_reportstats' => array (
151
+    'admin_reportstats' => array(
152 152
         'title'			=> 'Reporting statistics',
153 153
         'parent'		=> 'admin',
154 154
         'url'			=> 'admin/reporting_stats.php'
155 155
     ),
156
-    'admin_trackbacks' => array (
156
+    'admin_trackbacks' => array(
157 157
         'title'			=> 'Recent trackbacks',
158 158
         'parent'		=> 'admin',
159 159
         'url'			=> 'admin/trackbacks.php'
160 160
     ),
161
-    'admin_photos' => array (
161
+    'admin_photos' => array(
162 162
         'title'			=> 'Photo upload/attribution',
163 163
         'parent'		=> 'admin',
164 164
         'url'			=> 'admin/photos.php',
165 165
     ),
166
-    'admin_mpurls' => array (
166
+    'admin_mpurls' => array(
167 167
         'title'			=> 'MP Websites',
168 168
         'parent'		=> 'admin',
169 169
         'url'			=> 'admin/websites.php',
170 170
     ),
171
-    'admin_policies' => array (
171
+    'admin_policies' => array(
172 172
         'title'			=> 'MP Policy details',
173 173
         'parent'		=> 'admin',
174 174
         'url'			=> 'admin/policies.php',
175 175
     ),
176
-    'admin_banner' => array (
176
+    'admin_banner' => array(
177 177
         'title'			=> 'Edit Banner',
178 178
         'parent'		=> 'admin',
179 179
         'url'			=> 'admin/banner.php',
180 180
     ),
181
-    'admin_featured' => array (
181
+    'admin_featured' => array(
182 182
         'title'			=> 'Featured debates',
183 183
         'parent'		=> 'admin',
184 184
         'url'			=> 'admin/featured.php',
185 185
     ),
186
-    'admin_topics' => array (
186
+    'admin_topics' => array(
187 187
         'title'			=> 'Topics',
188 188
         'parent'		=> 'admin',
189 189
         'url'			=> 'admin/topics.php',
190 190
     ),
191
-    'admin_edittopics' => array (
191
+    'admin_edittopics' => array(
192 192
         'title'			=> 'Edit Topic',
193 193
         'parent'		=> 'admin_topics',
194 194
         'url'			=> 'admin/edittopic.php',
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
196 196
 
197 197
 // Added by Richard Allan for email alert functions
198 198
 
199
-    'alert' => array (
200
-        'menu'			=> array (
199
+    'alert' => array(
200
+        'menu'			=> array(
201 201
             'text'			=> 'Email Alerts',
202 202
             'title'			=> "Set up alerts for updates on an MP or Peer by email",
203 203
             'sidebar'		=> 'alert'
@@ -206,30 +206,30 @@  discard block
 block discarded – undo
206 206
         'title'			=> 'TheyWorkForYou Email Alerts',
207 207
         'url'			=> 'alert/',
208 208
     ),
209
-    'alertwelcome' => array (
209
+    'alertwelcome' => array(
210 210
         'title'			=> 'Email Alerts',
211 211
         'url'			=> 'alert/',
212 212
     ),
213 213
 
214 214
 // End of ALERTS additions
215 215
 
216
-    'api_front'		=> array (
217
-        'menu'			=> array (
216
+    'api_front'		=> array(
217
+        'menu'			=> array(
218 218
             'text'			=> 'API',
219 219
             'title'			=> 'Access our data'
220 220
         ),
221 221
         'title'			=> 'TheyWorkForYou API',
222 222
         'url'			=> 'api/'
223 223
     ),
224
-    'api_doc_front'		=> array (
225
-        'menu'			=> array (
224
+    'api_doc_front'		=> array(
225
+        'menu'			=> array(
226 226
             'text'			=> 'API',
227 227
             'title'			=> 'Access our data'
228 228
         ),
229 229
         'parent'		=> 'api_front',
230 230
         'url'			=> 'api/'
231 231
     ),
232
-    'api_key'		=> array (
232
+    'api_key'		=> array(
233 233
         'title'			=> 'API Keys',
234 234
         'parent'		=> 'api_front',
235 235
         'url'			=> 'api/key'
@@ -240,69 +240,69 @@  discard block
 block discarded – undo
240 240
         'url' => 'boundaries/',
241 241
     ),
242 242
 
243
-    'calendar_summary' => array (
244
-        'menu'			=> array (
243
+    'calendar_summary' => array(
244
+        'menu'			=> array(
245 245
             'text'			=> 'Upcoming',
246 246
             'title'			=> '',
247 247
         ),
248 248
         'parent'		=> 'hansard',
249 249
         'url'			=> 'calendar/'
250 250
     ),
251
-    'calendar_future_head' => array (
251
+    'calendar_future_head' => array(
252 252
         'parent'		=> 'calendar_summary',
253 253
         'title'			=> 'Upcoming business',
254 254
         'url'			=> 'calendar/'
255 255
     ),
256
-    'calendar_future' => array (
256
+    'calendar_future' => array(
257 257
         'parent'		=> 'calendar_future_head',
258 258
         'url'			=> 'calendar/'
259 259
     ),
260
-    'calendar_today_head' => array (
260
+    'calendar_today_head' => array(
261 261
         'parent'		=> 'calendar_summary',
262 262
         'title'			=> 'Today’s business',
263 263
         'url'			=> 'calendar/'
264 264
     ),
265
-    'calendar_today' => array (
265
+    'calendar_today' => array(
266 266
         'parent'		=> 'calendar_today_head',
267 267
         'url'			=> 'calendar/'
268 268
     ),
269
-    'calendar_past_head' => array (
269
+    'calendar_past_head' => array(
270 270
         'parent'		=> 'calendar_summary',
271 271
         'title'			=> 'Previous business',
272 272
         'url'			=> 'calendar/'
273 273
     ),
274
-    'calendar_past' => array (
274
+    'calendar_past' => array(
275 275
         'parent'		=> 'calendar_past_head',
276 276
         'url'			=> 'calendar/'
277 277
     ),
278 278
 
279
-    'cards' => array (
279
+    'cards' => array(
280 280
         'title'			=> 'MP Stats Cards',
281 281
         'url'			=> 'cards/'
282 282
     ),
283 283
 
284
-    'campaign_foi' => array (
284
+    'campaign_foi' => array(
285 285
         'title'			=> 'Freedom of Information (Parliament) Order 2009',
286 286
         'url'			=> 'foiorder2009/'
287 287
     ),
288
-    'campaign' => array (
288
+    'campaign' => array(
289 289
         'title'			=> '', #Free Our Bills!',
290 290
         'url'			=> 'freeourbills/'
291 291
     ),
292
-    'campaign_edm' => array (
292
+    'campaign_edm' => array(
293 293
         'title'			=> 'Early Day Motion',
294 294
         'parent'		=> 'campaign',
295 295
         'url'			=> 'freeourbills/'
296 296
     ),
297 297
 
298
-    'commentreport' => array (
298
+    'commentreport' => array(
299 299
         'title'			=> 'Reporting a comment',
300 300
         'url'			=> 'report/',
301
-        'session_vars'	=> array ('id')
301
+        'session_vars'	=> array('id')
302 302
     ),
303 303
 
304
-    'comments_recent' => array (
305
-        'menu'			=> array (
304
+    'comments_recent' => array(
305
+        'menu'			=> array(
306 306
             'text'			=> 'Recent comments',
307 307
             'title'			=> "Recently posted comments"
308 308
         ),
@@ -311,8 +311,8 @@  discard block
 block discarded – undo
311 311
         'url'			=> 'comments/recent/'
312 312
     ),
313 313
 
314
-    'contact' => array (
315
-        'menu'			=> array (
314
+    'contact' => array(
315
+        'menu'			=> array(
316 316
             'text'			=> 'Contact',
317 317
             'title'			=> '',
318 318
         ),
@@ -323,23 +323,23 @@  discard block
 block discarded – undo
323 323
         'title' => 'News',
324 324
         'url' => 'https://www.mysociety.org/category/projects/theyworkforyou/'
325 325
     ),
326
-    'debate'  => array (
326
+    'debate'  => array(
327 327
         'parent'		=> 'debatesfront',
328 328
         'url'			=> 'debates/',
329
-        'session_vars'	=> array ('id'),
329
+        'session_vars'	=> array('id'),
330 330
     ),
331
-    'debates'  => array (
331
+    'debates'  => array(
332 332
         'parent'		=> 'debatesfront',
333 333
         'url'			=> 'debates/',
334
-        'session_vars'	=> array ('id'),
334
+        'session_vars'	=> array('id'),
335 335
     ),
336
-    'debatesday' => array (
336
+    'debatesday' => array(
337 337
         'parent'		=> 'debatesfront',
338
-        'session_vars'	=> array ('d'),
338
+        'session_vars'	=> array('d'),
339 339
         'url'			=> 'debates/',
340 340
     ),
341
-    'alldebatesfront' => array (
342
-        'menu'			=> array (
341
+    'alldebatesfront' => array(
342
+        'menu'			=> array(
343 343
             'text'			=> 'Debates',
344 344
             'title'			=> "Debates in the House of Commons, Westminster Hall, and the House of Lords"
345 345
         ),
@@ -348,8 +348,8 @@  discard block
 block discarded – undo
348 348
         'rss'			=> 'rss/debates.rss',
349 349
         'url'			=> 'debates/'
350 350
     ),
351
-    'debatesfront' => array (
352
-        'menu'			=> array (
351
+    'debatesfront' => array(
352
+        'menu'			=> array(
353 353
             'text'			=> 'Commons debates',
354 354
             'title'			=> "Debates in the House of Commons"
355 355
         ),
@@ -358,12 +358,12 @@  discard block
 block discarded – undo
358 358
         'rss'			=> 'rss/debates.rss',
359 359
         'url'			=> 'debates/'
360 360
     ),
361
-    'debatesyear' => array (
361
+    'debatesyear' => array(
362 362
         'parent'		=> 'debatesfront',
363 363
         'url'			=> 'debates/'
364 364
     ),
365
-    'divisions_recent' => array (
366
-        'menu'			=> array (
365
+    'divisions_recent' => array(
366
+        'menu'			=> array(
367 367
             'text'			=> 'Recent Votes',
368 368
             'title'			=> ''
369 369
         ),
@@ -371,12 +371,12 @@  discard block
 block discarded – undo
371 371
         'title'			=> 'Recent Votes',
372 372
         'url'			=> 'divisions/'
373 373
     ),
374
-    'divisions_vote' => array (
374
+    'divisions_vote' => array(
375 375
         'parent'		=> 'divisions_recent',
376 376
         'title'			=> 'Vote',
377 377
         'url'			=> 'divisions/division.php'
378 378
     ),
379
-    'epvote' => array (
379
+    'epvote' => array(
380 380
         'url'			=> 'vote/'
381 381
     ),
382 382
 
@@ -385,19 +385,19 @@  discard block
 block discarded – undo
385 385
         'title'			=> 'TheyWorkForYou Google gadget',
386 386
     ),
387 387
 
388
-    'glossary' => array (
388
+    'glossary' => array(
389 389
         'heading'		=> 'Glossary',
390 390
         'parent'		=> 'help_us_out',
391 391
         'url'			=> 'glossary/'
392 392
     ),
393
-    'glossary_item' => array (
393
+    'glossary_item' => array(
394 394
         'heading'		=> 'Glossary heading',
395 395
         'parent'		=> 'help_us_out',
396 396
         'url'			=> 'glossary/',
397
-        'session_vars'	=> array ('g')
397
+        'session_vars'	=> array('g')
398 398
     ),
399
-    'hansard' => array (
400
-        'menu'			=> array (
399
+    'hansard' => array(
400
+        'menu'			=> array(
401 401
             'text'			=> 'UK Parliament',
402 402
             'title'			=> "Houses of Parliament debates, Written Answers, Statements, Westminster Hall debates, and Bill Committees"
403 403
         ),
@@ -405,16 +405,16 @@  discard block
 block discarded – undo
405 405
         'url'			=> ''
406 406
     ),
407 407
         // Hansard landing page
408
-        'hansard_landing' => array (
408
+        'hansard_landing' => array(
409 409
                 'title'                 => 'Hansard',
410 410
                 'url'                   => 'search-hansard/',
411 411
         ),
412
-    'help' => array (
412
+    'help' => array(
413 413
         'title'			=> 'Help - Frequently Asked Questions',
414 414
         'url'			=> 'help/'
415 415
     ),
416
-    'help_us_out' => array (
417
-        'menu'			=> array (
416
+    'help_us_out' => array(
417
+        'menu'			=> array(
418 418
             'text'			=> 'Glossary',
419 419
             'title'			=> "Parliament's jargon explained"
420 420
         ),
@@ -423,88 +423,88 @@  discard block
 block discarded – undo
423 423
         'url'			=> 'addterm/',
424 424
         'sidebar'		=> 'glossary_add'
425 425
     ),
426
-    'home' => array (
426
+    'home' => array(
427 427
         'title'			=> "UK Parliament",
428 428
         'rss'			=> 'news/index.rdf',
429 429
         'url'			=> ''
430 430
     ),
431
-    'houserules' => array (
431
+    'houserules' => array(
432 432
         'title'			=> 'House rules',
433 433
         'url'			=> 'houserules/'
434 434
     ),
435 435
 
436
-    'linktous' => array (
436
+    'linktous' => array(
437 437
         'title'			=> 'Link to us',
438 438
         'heading'		=> 'How to link to us',
439 439
         'url'			=> 'help/linktous/'
440 440
     ),
441
-    'api' => array (
441
+    'api' => array(
442 442
         'title'			=> 'API',
443 443
         'heading'		=> 'API - Query the TheyWorkForYou database',
444 444
         'url'			=> 'api/'
445 445
     ),
446
-    'data' => array (
446
+    'data' => array(
447 447
         'title'			=> 'Raw Data',
448 448
         'heading'		=> 'Raw data (XML) - the data behind TheyWorkForYou and Public Whip',
449 449
         'url'			=> 'http://parser.theyworkforyou.com'
450 450
     ),
451
-    'pombola' => array (
451
+    'pombola' => array(
452 452
         'title'			=> 'Pombola',
453 453
         'heading'		=> 'mySociety\'s platform for running a Parliamentary monitoring site like this',
454 454
         'url'			=> 'https://www.mysociety.org/projects/parliamentarymonitoring/pombola'
455 455
     ),
456
-    'devmailinglist' => array (
456
+    'devmailinglist' => array(
457 457
         'title'			=> 'Developer mailing list',
458 458
         'heading'		=> 'Developer mailing list',
459 459
         'url'			=> 'https://groups.google.com/a/mysociety.org/forum/#!forum/theyworkforyou'
460 460
     ),
461
-    'code' => array (
461
+    'code' => array(
462 462
         'title'			=> 'Source code',
463 463
         'heading'		=> 'TheyWorkForYou Source code',
464 464
         'url'			=> 'https://github.com/mysociety/theyworkforyou'
465 465
     ),
466
-    'irc' => array (
466
+    'irc' => array(
467 467
         'title'			=> 'IRC chat channel',
468 468
         'heading'		=> 'IRC chat channel',
469 469
         'url'			=> 'http://www.irc.mysociety.org/'
470 470
     ),
471
-    'newzealand' => array (
471
+    'newzealand' => array(
472 472
         'title'			=> 'New Zealand',
473 473
         'heading'		=> 'They Work For You - New Zealand',
474 474
         'url'			=> 'http://www.theyworkforyou.co.nz/'
475 475
     ),
476
-    'australia' => array (
476
+    'australia' => array(
477 477
         'title'			=> 'Australia',
478 478
         'heading'		=> 'Open Australia',
479 479
         'url'			=> 'http://www.openaustralia.org/'
480 480
     ),
481
-    'ireland' => array (
481
+    'ireland' => array(
482 482
         'title'			=> 'Ireland',
483 483
         'heading'		=> 'TheyWorkForYou for the Houses of the Oireachtas',
484 484
         'url'			=> 'http://www.kildarestreet.com/'
485 485
     ),
486
-    'mzalendo' => array (
486
+    'mzalendo' => array(
487 487
         'title'			=> 'Mzalendo',
488 488
         'heading'		=> 'Keeping an eye on the Kenyan Parliament',
489 489
         'url'			=> 'http://info.mzalendo.com/'
490 490
     ),
491
-    'lordsdebate'  => array (
491
+    'lordsdebate'  => array(
492 492
         'parent'		=> 'lordsdebatesfront',
493 493
         'url'			=> 'lords/',
494
-        'session_vars'	=> array ('id'),
494
+        'session_vars'	=> array('id'),
495 495
     ),
496
-    'lordsdebates'  => array (
496
+    'lordsdebates'  => array(
497 497
         'parent'		=> 'lordsdebatesfront',
498 498
         'url'			=> 'lords/',
499
-        'session_vars'	=> array ('id'),
499
+        'session_vars'	=> array('id'),
500 500
     ),
501
-    'lordsdebatesday' => array (
501
+    'lordsdebatesday' => array(
502 502
         'parent'		=> 'lordsdebatesfront',
503
-        'session_vars'	=> array ('d'),
503
+        'session_vars'	=> array('d'),
504 504
         'url'			=> 'lords/',
505 505
     ),
506
-    'lordsdebatesfront' => array (
507
-        'menu'			=> array (
506
+    'lordsdebatesfront' => array(
507
+        'menu'			=> array(
508 508
             'text'			=> 'Lords debates',
509 509
             'title'			=> "House of Lords debates"
510 510
         ),
@@ -513,24 +513,24 @@  discard block
 block discarded – undo
513 513
         'rss'			=> 'rss/lords.rss',
514 514
         'url'			=> 'lords/'
515 515
     ),
516
-    'lordsdebatesyear' => array (
516
+    'lordsdebatesyear' => array(
517 517
         'parent'		=> 'lordsdebatesfront',
518 518
         'url'			=> 'lords/'
519 519
     ),
520 520
 
521 521
         // Parliament landing page
522
-        'parliament_landing' => array (
522
+        'parliament_landing' => array(
523 523
                 'title'                 => 'Parliament',
524 524
                 'url'                   => 'parliament/',
525 525
         ),
526 526
 
527
-    'peer' => array (
527
+    'peer' => array(
528 528
         'parent'		=> 'peers',
529 529
         'title'			=> 'Peer',
530 530
         'url'			=> 'peer/'
531 531
     ),
532
-    'peers' => array (
533
-         'menu'			=> array (
532
+    'peers' => array(
533
+         'menu'			=> array(
534 534
             'text'			=> 'Lords',
535 535
             'title'			=> "List of all Lords"
536 536
         ),
@@ -538,8 +538,8 @@  discard block
 block discarded – undo
538 538
         'title'			=> '',
539 539
         'url'			=> 'peers/'
540 540
     ),
541
-'overview' => array (
542
-     'menu'			=> array (
541
+'overview' => array(
542
+     'menu'			=> array(
543 543
         'text'			=> 'Overview',
544 544
         'title'			=> "Overview of the UK Parliament"
545 545
     ),
@@ -548,50 +548,50 @@  discard block
 block discarded – undo
548 548
     'rss'			=> 'news/index.rdf',
549 549
     'url'			=> ''
550 550
 ),
551
-    'mla' => array (
551
+    'mla' => array(
552 552
         'parent'		=> 'mlas',
553 553
         'title'			=> 'Find your MLA',
554 554
         'url'			=> 'mla/'
555 555
     ),
556
-    'mlas' => array (
556
+    'mlas' => array(
557 557
         'parent'		=> 'ni_home',
558
-        'menu'			=> array (
558
+        'menu'			=> array(
559 559
             'text'			=> 'MLAs',
560 560
             'title'			=> "List of all Members of the Northern Ireland Assembly (MLAs)"
561 561
         ),
562 562
         'title'			=> '',
563 563
         'url'			=> 'mlas/'
564 564
     ),
565
-    'msps' => array (
565
+    'msps' => array(
566 566
         'parent'		=> 'sp_home',
567
-        'menu'			=> array (
567
+        'menu'			=> array(
568 568
             'text'			=> 'MSPs',
569 569
             'title'			=> "List of Members of the Scottish Parliament (MSPs)"
570 570
         ),
571 571
         'title'			=> '',
572 572
         'url'			=> 'msps/'
573 573
     ),
574
-    'msp' => array (
574
+    'msp' => array(
575 575
         'parent'		=> 'msps',
576 576
         'title'			=> 'Find your MSP',
577 577
         'url'			=> 'msp/'
578 578
     ),
579 579
     /* Not 'Your MP', whose name is 'yourmp'... */
580
-    'mp' => array (
580
+    'mp' => array(
581 581
         'parent'			=> 'mps',
582 582
         'title'			=> 'Find your MP',
583 583
         'url'			=> 'mp/'
584 584
     ),
585
-    'emailfriend' => array (
585
+    'emailfriend' => array(
586 586
         'title'			=> 'Send this page to a friend',
587 587
         'url'			=> 'email/'
588 588
     ),
589 589
     // The directory MPs' RSS feeds are stored in.
590
-    'mp_rss' => array (
590
+    'mp_rss' => array(
591 591
         'url'			=> 'rss/mp/'
592 592
     ),
593
-    'mps' => array (
594
-         'menu'			=> array (
593
+    'mps' => array(
594
+         'menu'			=> array(
595 595
             'text'			=> 'MPs',
596 596
             'title'			=> "List of all Members of Parliament (MPs)"
597 597
         ),
@@ -602,16 +602,16 @@  discard block
 block discarded – undo
602 602
 
603 603
     /* Northern Ireland Assembly */
604 604
     'ni_home' => array(
605
-        'menu'			=> array (
605
+        'menu'			=> array(
606 606
             'text'			=> 'Northern Ireland Assembly',
607 607
             'title'			=> 'Full authority over <em>transferred matters</em>, which include agriculture, education, employment, the environment and health'
608 608
         ),
609 609
         'title'			=> 'Northern Ireland Assembly',
610 610
         'url'			=> 'ni/'
611 611
     ),
612
-    'nioverview' => array (
612
+    'nioverview' => array(
613 613
         'parent'		=> 'ni_home',
614
-        'menu'			=> array (
614
+        'menu'			=> array(
615 615
             'text'			=> 'Debates',
616 616
             'title'			=> "Overview of the Northern Ireland Assembly debates"
617 617
         ),
@@ -619,23 +619,23 @@  discard block
 block discarded – undo
619 619
         'rss'			=> 'rss/ni.rss',
620 620
         'url'			=> 'ni/'
621 621
     ),
622
-    'nidebate'  => array (
622
+    'nidebate'  => array(
623 623
         'parent'		=> 'nidebatesfront',
624 624
         'url'			=> 'ni/',
625
-        'session_vars'	=> array ('id'),
625
+        'session_vars'	=> array('id'),
626 626
     ),
627
-    'nidebates'  => array (
627
+    'nidebates'  => array(
628 628
         'parent'		=> 'nidebatesfront',
629 629
         'url'			=> 'ni/',
630
-        'session_vars'	=> array ('id'),
630
+        'session_vars'	=> array('id'),
631 631
     ),
632
-    'nidebatesday' => array (
632
+    'nidebatesday' => array(
633 633
         'parent'		=> 'nidebatesfront',
634
-        'session_vars'	=> array ('d'),
634
+        'session_vars'	=> array('d'),
635 635
         'url'			=> 'ni/',
636 636
     ),
637
-    'nidebatesfront' => array (
638
-        'menu'			=> array (
637
+    'nidebatesfront' => array(
638
+        'menu'			=> array(
639 639
             'text'			=> 'Debates',
640 640
             'title'			=> "Northern Ireland Assembly debates"
641 641
         ),
@@ -644,24 +644,24 @@  discard block
 block discarded – undo
644 644
         'rss'			=> 'rss/ni.rss',
645 645
         'url'			=> 'ni/'
646 646
     ),
647
-    'nidebatesyear' => array (
647
+    'nidebatesyear' => array(
648 648
         'parent'		=> 'nidebatesfront',
649 649
         'url'			=> 'ni/'
650 650
     ),
651 651
 
652
-    'otheruseredit' => array (
652
+    'otheruseredit' => array(
653 653
         'pg'			=> 'editother',
654 654
         'title'			=> "Editing a user's data",
655 655
         'url'			=> 'user/'
656 656
     ),
657
-    'privacy' => array (
657
+    'privacy' => array(
658 658
         'title'			=> 'Privacy Policy',
659 659
         'url'			=> 'privacy/'
660 660
     ),
661 661
 
662 662
     /* Public bill committees */
663
-    'pbc_front' => array (
664
-        'menu'			=> array (
663
+    'pbc_front' => array(
664
+        'menu'			=> array(
665 665
             'text'			=> 'Bill Committees',
666 666
             'title'			=> "Public Bill Committees (formerly Standing Committees) debates"
667 667
         ),
@@ -679,17 +679,17 @@  discard block
 block discarded – undo
679 679
         'title' => '',
680 680
         'url' => 'pbc/',
681 681
         'parent' => 'pbc_front',
682
-        'session_vars'	=> array ('bill'),
682
+        'session_vars'	=> array('bill'),
683 683
     ),
684 684
     'pbc_clause' => array(
685 685
         'parent'		=> 'pbc_front',
686 686
         'url'			=> 'pbc/',
687
-        'session_vars'	=> array ('id'),
687
+        'session_vars'	=> array('id'),
688 688
     ),
689 689
     'pbc_speech' => array(
690 690
         'parent'		=> 'pbc_front',
691 691
         'url'			=> 'pbc/',
692
-        'session_vars'	=> array ('id'),
692
+        'session_vars'	=> array('id'),
693 693
     ),
694 694
 
695 695
     'people' => array(
@@ -701,62 +701,62 @@  discard block
 block discarded – undo
701 701
         'url'			=> '',
702 702
     ),
703 703
 
704
-    'raw' => array (
704
+    'raw' => array(
705 705
         'title'			=> 'Raw data',
706 706
         'url'			=> 'raw/'
707 707
     ),
708 708
 
709
-    'regmem' => array (
709
+    'regmem' => array(
710 710
         'title'			=> 'Changes to the Register of Members\' Interests',
711 711
         'url'			=> 'regmem/'
712 712
     ),
713 713
 
714
-    'regmem_date' => array (
714
+    'regmem_date' => array(
715 715
         'url'			=> 'regmem/',
716 716
         'parent'		=> 'regmem'
717 717
     ),
718 718
 
719
-    'regmem_mp' => array (
719
+    'regmem_mp' => array(
720 720
         'url'			=> 'regmem/',
721 721
         'parent'		=> 'regmem'
722 722
     ),
723 723
 
724
-    'regmem_diff' => array (
724
+    'regmem_diff' => array(
725 725
         'url'			=> 'regmem/',
726 726
         'parent'		=> 'regmem'
727 727
     ),
728 728
 
729
-    'royal' => array (
729
+    'royal' => array(
730 730
         'parent'        => 'hansard',
731 731
         'title'         => 'Royal',
732 732
         'url'           => 'royal/',
733 733
     ),
734 734
 
735
-    'topic' => array (
735
+    'topic' => array(
736 736
         'parent'        => 'topics',
737 737
         'url'           => 'topic/topic.php',
738 738
     ),
739 739
 
740
-    'topics' => array (
740
+    'topics' => array(
741 741
         'title'        => 'Topics',
742 742
         'url'          => 'topic/',
743 743
     ),
744 744
 
745
-    'search'		=> array (
745
+    'search'		=> array(
746 746
         'sidebar'		=> 'search',
747 747
         'url'			=> 'search/',
748 748
         'robots'		=> 'noindex, nofollow',
749 749
         'heading'		=> '',
750
-        'session_vars'	=> array ('q', 's', 'pid', 'o', 'pop')
750
+        'session_vars'	=> array('q', 's', 'pid', 'o', 'pop')
751 751
     ),
752
-    'search_help'		=> array (
752
+    'search_help'		=> array(
753 753
         'sidebar'		=> 'search',
754 754
         'title'			=> 'Help with searching',
755 755
         'url'			=> 'search/'
756 756
     ),
757 757
 
758
-    'sitenews'		=> array (
759
-        'menu'			=> array (
758
+    'sitenews'		=> array(
759
+        'menu'			=> array(
760 760
             'text'			=> 'TheyWorkForYou news',
761 761
             'title'			=> "News about changes to this website"
762 762
         ),
@@ -766,68 +766,68 @@  discard block
 block discarded – undo
766 766
         'title'			=> 'TheyWorkForYou news',
767 767
         'url'			=> 'news/'
768 768
     ),
769
-    'sitenews_archive'		=> array (
769
+    'sitenews_archive'		=> array(
770 770
         'parent'		=> 'sitenews',
771 771
         'rss'			=> 'news/index.rdf',
772 772
         'sidebar'		=> 'sitenews',
773 773
         'title'			=> 'Archive',
774 774
         'url'			=> 'news/archives/'
775 775
     ),
776
-    'sitenews_atom' 	=> array (
776
+    'sitenews_atom' 	=> array(
777 777
         'url'			=> 'news/atom.xml'
778 778
     ),
779
-    'sitenews_date'	=> array (
779
+    'sitenews_date'	=> array(
780 780
         'parent'		=> 'sitenews',
781 781
         'rss'			=> 'news/index.rdf',
782 782
         'sidebar'		=> 'sitenews'
783 783
     ),
784
-    'sitenews_individual'	=> array (
784
+    'sitenews_individual'	=> array(
785 785
         'parent'		=> 'sitenews',
786 786
         'rss'			=> 'news/index.rdf',
787 787
         'sidebar'		=> 'sitenews',
788 788
     ),
789
-    'sitenews_rss1' 	=> array (
789
+    'sitenews_rss1' 	=> array(
790 790
         'url'			=> 'news/index.rdf'
791 791
     ),
792
-    'sitenews_rss2' 	=> array (
792
+    'sitenews_rss2' 	=> array(
793 793
         'url'			=> 'news/index.xml'
794 794
     ),
795 795
 
796 796
     /* Scottish Parliament */
797 797
     'sp_home' => array(
798
-        'menu'			=> array (
798
+        'menu'			=> array(
799 799
             'text'			=> 'Scottish Parliament',
800 800
             'title'			=> 'Scottish education, health, agriculture, justice, prisons and other devolved areas. Some tax-varying powers'
801 801
         ),
802 802
         'title'			=> 'Scottish Parliament',
803 803
         'url'			=> 'scotland/'
804 804
     ),
805
-    'spoverview' => array (
805
+    'spoverview' => array(
806 806
         'parent'		=> 'sp_home',
807
-        'menu'			=> array (
807
+        'menu'			=> array(
808 808
             'text'			=> 'Overview',
809 809
             'title'			=> "Overview of the Scottish Parliament"
810 810
         ),
811 811
         'title'			=> '',
812 812
         'url'			=> 'scotland/'
813 813
     ),
814
-    'spdebate'  => array (
814
+    'spdebate'  => array(
815 815
         'parent'		=> 'spdebatesfront',
816 816
         'url'			=> 'sp/',
817
-        'session_vars'	=> array ('id'),
817
+        'session_vars'	=> array('id'),
818 818
     ),
819
-    'spdebates'  => array (
819
+    'spdebates'  => array(
820 820
         'parent'		=> 'spdebatesfront',
821 821
         'url'			=> 'sp/',
822
-        'session_vars'	=> array ('id'),
822
+        'session_vars'	=> array('id'),
823 823
     ),
824
-    'spdebatesday' => array (
824
+    'spdebatesday' => array(
825 825
         'parent'		=> 'spdebatesfront',
826
-        'session_vars'	=> array ('d'),
826
+        'session_vars'	=> array('d'),
827 827
         'url'			=> 'sp/',
828 828
     ),
829
-    'spdebatesfront' => array (
830
-        'menu'			=> array (
829
+    'spdebatesfront' => array(
830
+        'menu'			=> array(
831 831
             'text'			=> 'Debates',
832 832
             'title'			=> ''
833 833
         ),
@@ -836,21 +836,21 @@  discard block
 block discarded – undo
836 836
         'url'			=> 'sp/'
837 837
     ),
838 838
 
839
-    'spdebatesyear' => array (
839
+    'spdebatesyear' => array(
840 840
         'parent'		=> 'spdebatesfront',
841 841
         'url'			=> 'sp/'
842 842
     ),
843
-    'spwrans'  => array (
843
+    'spwrans'  => array(
844 844
         'parent'		=> 'spwransfront',
845 845
         'url'			=> 'spwrans/',
846 846
         #'session_vars'	=> array ('id'),
847 847
     ),
848
-    'spwransday'  => array (
848
+    'spwransday'  => array(
849 849
         'parent'		=> 'spwransfront',
850 850
         'url'			=> 'spwrans/'
851 851
     ),
852
-    'spwransfront'  => array (
853
-        'menu'			=> array (
852
+    'spwransfront'  => array(
853
+        'menu'			=> array(
854 854
             'text'			=> 'Written Answers',
855 855
             'title'			=> ''
856 856
         ),
@@ -863,38 +863,38 @@  discard block
 block discarded – undo
863 863
         'title'			=> 'For questions asked by ',
864 864
         'url'			=> 'spwrans/'
865 865
     ),
866
-    'spwransyear' => array (
866
+    'spwransyear' => array(
867 867
         'parent'		=> 'spwransfront',
868 868
         'url'			=> 'spwrans/'
869 869
     ),
870 870
 
871 871
     // Topic pages
872 872
 
873
-    'topic' => array (
873
+    'topic' => array(
874 874
         'url'           => 'topic/',
875 875
         'title'         => 'Topics'
876 876
     ),
877 877
 
878
-    'topicbenefits' => array (
878
+    'topicbenefits' => array(
879 879
         'url'           => 'topic/benefits',
880 880
         'parent'        => 'topic',
881 881
         'title'         => 'Benefits'
882 882
     ),
883 883
 
884
-    'topiccrimestats' => array (
884
+    'topiccrimestats' => array(
885 885
         'url'           => 'topic/crime-stats',
886 886
         'parent'        => 'topic',
887 887
         'title'         => 'Crime Statistics'
888 888
     ),
889 889
 
890
-    'topicnhs' => array (
890
+    'topicnhs' => array(
891 891
         'url'           => 'topic/nhs',
892 892
         'parent'        => 'topic',
893 893
         'title'         => 'NHS'
894 894
     ),
895 895
 
896 896
     // The URL 3rd parties need to ping something here.
897
-    'trackback' => array (
897
+    'trackback' => array(
898 898
         'url'			=> 'trackback/'
899 899
     ),
900 900
 
@@ -907,29 +907,29 @@  discard block
 block discarded – undo
907 907
         'url'			=> 'user/alerts/',
908 908
         'parent'		=> 'userviewself'
909 909
     ),
910
-    'userchangepc' => array (
910
+    'userchangepc' => array(
911 911
         'title'			=> 'Change your postcode',
912 912
         'url'			=> 'user/changepc/'
913 913
     ),
914
-    'userconfirm' => array (
914
+    'userconfirm' => array(
915 915
         'url'			=> 'user/confirm/'
916 916
     ),
917
-    'userconfirmed' => array (
917
+    'userconfirmed' => array(
918 918
         'sidebar'		=> 'userconfirmed',
919 919
         'title'			=> 'Welcome to TheyWorkForYou!',
920 920
         'url'			=> 'user/confirm/'
921 921
     ),
922
-    'userconfirmfailed' => array (
922
+    'userconfirmfailed' => array(
923 923
         'title'			=> 'Oops!',
924 924
         'url'			=> 'user/confirm/'
925 925
     ),
926
-    'useredit' => array (
926
+    'useredit' => array(
927 927
         'pg'			=> 'edit',
928 928
         'title'			=> 'Edit your details',
929 929
         'url'			=> 'user/'
930 930
     ),
931
-    'userjoin' => array (
932
-                'menu'                  => array (
931
+    'userjoin' => array(
932
+                'menu'                  => array(
933 933
                         'text'                  => 'Join',
934 934
                         'title'                 => "Joining is free and allows you to annotate speeches"
935 935
                 ),
@@ -938,8 +938,8 @@  discard block
 block discarded – undo
938 938
                 'title'                 => 'Join TheyWorkForYou',
939 939
                 'url'                   => 'user/'
940 940
         ),
941
-    'getinvolved' => array (
942
-        'menu'			=> array (
941
+    'getinvolved' => array(
942
+        'menu'			=> array(
943 943
             'text'			=> 'Get involved',
944 944
             'title'			=> "Contribute to TheyWorkForYou"
945 945
         ),
@@ -948,8 +948,8 @@  discard block
 block discarded – undo
948 948
         'title'			=> 'Contribute to TheyWorkForYou',
949 949
         'url'			=> 'getinvolved/'
950 950
     ),
951
-    'userlogin' => array (
952
-        'menu'			=> array (
951
+    'userlogin' => array(
952
+        'menu'			=> array(
953 953
             'text'			=> 'Sign in',
954 954
             'title'			=> "If you've already joined , sign in to add annotations"
955 955
         ),
@@ -958,33 +958,33 @@  discard block
 block discarded – undo
958 958
         'url'			=> 'user/login/'
959 959
     ),
960 960
 
961
-    'userlogout' => array (
962
-        'menu'			=> array (
961
+    'userlogout' => array(
962
+        'menu'			=> array(
963 963
             'text'			=> 'Sign out',
964 964
             'title'			=> "Sign out"
965 965
         ),
966 966
         'url'			=> 'user/logout/'
967 967
     ),
968
-    'userpassword' => array (
968
+    'userpassword' => array(
969 969
         'title'			=> 'Change password',
970 970
         'url'			=> 'user/password/'
971 971
     ),
972
-    'userprompt' => array (
972
+    'userprompt' => array(
973 973
         'title'			=> 'Please sign in',
974 974
         'url'			=> 'user/prompt/'
975 975
     ),
976
-    'userview' => array (
976
+    'userview' => array(
977 977
         'session_vars'	=> array('u'),
978 978
         'url'			=> 'user/'
979 979
     ),
980
-    'userviewself' => array (
981
-        'menu'			=> array (
980
+    'userviewself' => array(
981
+        'menu'			=> array(
982 982
             'text'			=> 'Your details',
983 983
             'title'			=> "View and edit your details"
984 984
         ),
985 985
         'url'			=> 'user/'
986 986
     ),
987
-    'userwelcome' => array (
987
+    'userwelcome' => array(
988 988
         'title'			=> 'Welcome!',
989 989
         'url'			=> 'user/'
990 990
     ),
@@ -1012,23 +1012,23 @@  discard block
 block discarded – undo
1012 1012
     ),
1013 1013
 
1014 1014
     /* Westminster Hall */
1015
-    'whall'  => array (
1015
+    'whall'  => array(
1016 1016
         'parent'		=> 'whallfront',
1017 1017
         'url'			=> 'whall/',
1018
-        'session_vars'	=> array ('id'),
1018
+        'session_vars'	=> array('id'),
1019 1019
     ),
1020
-    'whalls'  => array (
1020
+    'whalls'  => array(
1021 1021
         'parent'		=> 'whallfront',
1022 1022
         'url'			=> 'whall/',
1023
-        'session_vars'	=> array ('id'),
1023
+        'session_vars'	=> array('id'),
1024 1024
     ),
1025
-    'whallday' => array (
1025
+    'whallday' => array(
1026 1026
         'parent'		=> 'whallfront',
1027
-        'session_vars'	=> array ('d'),
1027
+        'session_vars'	=> array('d'),
1028 1028
         'url'			=> 'whall/',
1029 1029
     ),
1030
-    'whallfront' => array (
1031
-        'menu'			=> array (
1030
+    'whallfront' => array(
1031
+        'menu'			=> array(
1032 1032
             'text'			=> 'Westminster Hall',
1033 1033
             'title'			=> "Westminster Hall debates"
1034 1034
         ),
@@ -1037,23 +1037,23 @@  discard block
 block discarded – undo
1037 1037
         'rss'			=> 'rss/whall.rss',
1038 1038
         'url'			=> 'whall/'
1039 1039
     ),
1040
-    'whallyear' => array (
1040
+    'whallyear' => array(
1041 1041
         'parent'		=> 'whallfront',
1042 1042
         'url'			=> 'whall/'
1043 1043
     ),
1044 1044
 
1045
-    'wms' => array (
1045
+    'wms' => array(
1046 1046
         'parent'		=> 'wranswmsfront',
1047 1047
         'url'			=> 'wms/',
1048 1048
         'session_vars'	=> array('id')
1049 1049
     ),
1050
-    'wmsday' => array (
1050
+    'wmsday' => array(
1051 1051
         'parent'		=> 'wmsfront',
1052 1052
         'session_vars'	=> array('d'),
1053 1053
         'url'			=> 'wms/'
1054 1054
     ),
1055
-    'wmsfront' => array (
1056
-        'menu'			=> array (
1055
+    'wmsfront' => array(
1056
+        'menu'			=> array(
1057 1057
             'text'			=> 'Written Ministerial Statements',
1058 1058
             'title'			=> ''
1059 1059
         ),
@@ -1062,22 +1062,22 @@  discard block
 block discarded – undo
1062 1062
         'rss'			=> 'rss/wms.rss',
1063 1063
         'url'			=> 'wms/'
1064 1064
     ),
1065
-    'wmsyear' => array (
1065
+    'wmsyear' => array(
1066 1066
         'parent'		=> 'wmsfront',
1067 1067
         'url'			=> 'wms/'
1068 1068
     ),
1069 1069
 
1070
-    'wrans'  => array (
1070
+    'wrans'  => array(
1071 1071
         'parent'		=> 'wranswmsfront',
1072 1072
         'url'			=> 'wrans/',
1073
-        'session_vars'	=> array ('id')
1073
+        'session_vars'	=> array('id')
1074 1074
     ),
1075
-    'wransday'  => array (
1075
+    'wransday'  => array(
1076 1076
         'parent'		=> 'wransfront',
1077 1077
         'url'			=> 'wrans/'
1078 1078
     ),
1079
-    'wransfront'  => array (
1080
-        'menu'			=> array (
1079
+    'wransfront'  => array(
1080
+        'menu'			=> array(
1081 1081
             'text'			=> 'Written Answers',
1082 1082
             'title'			=> "Written Answers"
1083 1083
         ),
@@ -1090,13 +1090,13 @@  discard block
 block discarded – undo
1090 1090
         'title'			=> 'For questions asked by ',
1091 1091
         'url'			=> 'wrans/'
1092 1092
     ),
1093
-    'wransyear' => array (
1093
+    'wransyear' => array(
1094 1094
         'parent'		=> 'wransfront',
1095 1095
         'url'			=> 'wrans/'
1096 1096
     ),
1097 1097
 
1098
-    'wranswmsfront'  => array (
1099
-        'menu'			=> array (
1098
+    'wranswmsfront'  => array(
1099
+        'menu'			=> array(
1100 1100
             'text'			=> 'Written Answers',
1101 1101
             'title'			=> 'Written Answers and Statements',
1102 1102
         ),
@@ -1113,8 +1113,8 @@  discard block
 block discarded – undo
1113 1113
         'title' => 'Your representative',
1114 1114
         'url' => 'your/',
1115 1115
     ),
1116
-    'yourmp' => array (
1117
-        'menu'			=> array (
1116
+    'yourmp' => array(
1117
+        'menu'			=> array(
1118 1118
             'text'			=> 'Your MP',
1119 1119
             'title'			=> "Find out about your Member of Parliament"
1120 1120
         ),
@@ -1123,8 +1123,8 @@  discard block
 block discarded – undo
1123 1123
         'url'			=> 'mp/',
1124 1124
         'parent'			=> 'mps',
1125 1125
     ),
1126
-    'yourmp_recent' => array (
1127
-        'menu'			=> array (
1126
+    'yourmp_recent' => array(
1127
+        'menu'			=> array(
1128 1128
             'text'			=> 'Recent appearances',
1129 1129
             'title'			=> "Recent speeches and written answers by this MP"
1130 1130
         ),
@@ -1132,8 +1132,8 @@  discard block
 block discarded – undo
1132 1132
         'title'			=> "Your MP's recent appearances in parliament",
1133 1133
         'url'			=> 'mp/?recent=1'
1134 1134
     ),
1135
-    'yourmsp' => array (
1136
-        'menu'			=> array (
1135
+    'yourmsp' => array(
1136
+        'menu'			=> array(
1137 1137
             'text'			=> 'Your MSPs',
1138 1138
             'title'			=> "Find out about your Members of the Scottish Parliament"
1139 1139
         ),
@@ -1142,8 +1142,8 @@  discard block
 block discarded – undo
1142 1142
         'title'			=> 'Your MSPs',
1143 1143
         'url'			=> 'msp/'
1144 1144
     ),
1145
-    'yourmla' => array (
1146
-        'menu'			=> array (
1145
+    'yourmla' => array(
1146
+        'menu'			=> array(
1147 1147
             'text'			=> 'Your MLAs',
1148 1148
             'title'			=> "Find out about your Members of the Legislative Assembly"
1149 1149
         ),
@@ -1159,38 +1159,38 @@  discard block
 block discarded – undo
1159 1159
 // The text displayed on the page itself will also be this,
1160 1160
 // UNLESS the section has a 'heading', in which case that's used instead.
1161 1161
 
1162
-$this->section = array (
1162
+$this->section = array(
1163 1163
 
1164 1164
 
1165
-    'about' => array (
1165
+    'about' => array(
1166 1166
         'title' 	=> 'About Us'
1167 1167
     ),
1168
-    'admin' => array (
1168
+    'admin' => array(
1169 1169
         'title'		=> 'Admin'
1170 1170
     ),
1171
-    'debates' => array (
1171
+    'debates' => array(
1172 1172
         'title' 	=> 'Debates',
1173 1173
         'heading'	=> 'House of Commons Debates'
1174 1174
     ),
1175
-    'help_us_out' => array (
1175
+    'help_us_out' => array(
1176 1176
         'title' 	=> 'Help Us Out'
1177 1177
     ),
1178
-    'hansard' => array (
1178
+    'hansard' => array(
1179 1179
         'title' 	=> 'Hansard'
1180 1180
     ),
1181
-    'home' => array (
1181
+    'home' => array(
1182 1182
         'title' 	=> 'Home'
1183 1183
     ),
1184
-    'mp' => array (
1184
+    'mp' => array(
1185 1185
         'title' 	=> 'Your MP'
1186 1186
     ),
1187
-    'search' => array (
1187
+    'search' => array(
1188 1188
         'title' 	=> 'Search'
1189 1189
     ),
1190
-    'sitenews' => array (
1190
+    'sitenews' => array(
1191 1191
         'title' 	=> 'TheyWorkForYou news'
1192 1192
     ),
1193
-    'wrans' => array (
1193
+    'wrans' => array(
1194 1194
         'title' 	=> 'Written Answers'
1195 1195
     )
1196 1196
 
Please login to merge, or discard this patch.
www/includes/easyparliament/people.php 2 patches
Braces   +25 added lines, -18 removed lines patch added patch discarded remove patch
@@ -107,15 +107,17 @@  discard block
 block discarded – undo
107 107
             $query .= 'LEFT OUTER JOIN personinfo ON member.person_id = personinfo.person_id AND data_key="' . $personinfo_key . '" ';
108 108
         }
109 109
         $query .= ' JOIN person_names p ON p.person_id = member.person_id AND p.type = "name" ';
110
-        if (isset($args['date']))
111
-            $query .= 'AND start_date <= :date AND :date <= end_date ';
112
-        else
113
-            $query .= 'AND end_date="9999-12-31" ';
110
+        if (isset($args['date'])) {
111
+                    $query .= 'AND start_date <= :date AND :date <= end_date ';
112
+        } else {
113
+                    $query .= 'AND end_date="9999-12-31" ';
114
+        }
114 115
         $query .= 'WHERE house=' . $args['house'] . ' ';
115
-        if (isset($args['date']))
116
-            $query .= 'AND entered_house <= :date AND :date <= left_house ';
117
-        elseif (!isset($args['all']) || $args['house'] == 1)
118
-            $query .= 'AND left_house = (SELECT MAX(left_house) FROM member) ';
116
+        if (isset($args['date'])) {
117
+                    $query .= 'AND entered_house <= :date AND :date <= left_house ';
118
+        } elseif (!isset($args['all']) || $args['house'] == 1) {
119
+                    $query .= 'AND left_house = (SELECT MAX(left_house) FROM member) ';
120
+        }
119 121
 
120 122
         if (isset($args['order'])) {
121 123
             $order = $args['order'];
@@ -174,8 +176,9 @@  discard block
 block discarded – undo
174 176
                 $data[$p_id] = $narray;
175 177
             }
176 178
         }
177
-        if ($args['house'] == 2 && ($order == 'name' || $order == 'constituency'))
178
-            uasort($data, array($this, 'by_peer_name'));
179
+        if ($args['house'] == 2 && ($order == 'name' || $order == 'constituency')) {
180
+                    uasort($data, array($this, 'by_peer_name'));
181
+        }
179 182
 
180 183
         $data = array (
181 184
             'info' => array (
@@ -188,14 +191,18 @@  discard block
 block discarded – undo
188 191
 
189 192
     }
190 193
     public function by_peer_name($a, $b) {
191
-        if (!$a['family_name'] && !$b['family_name'])
192
-            return strcmp($a['lordofname'], $b['lordofname']);
193
-        if (!$a['family_name'])
194
-            return strcmp($a['lordofname'], $b['family_name']);
195
-        if (!$b['family_name'])
196
-            return strcmp($a['family_name'], $b['lordofname']);
197
-        if (strcmp($a['family_name'], $b['family_name']))
198
-            return strcmp($a['family_name'], $b['family_name']);
194
+        if (!$a['family_name'] && !$b['family_name']) {
195
+                    return strcmp($a['lordofname'], $b['lordofname']);
196
+        }
197
+        if (!$a['family_name']) {
198
+                    return strcmp($a['lordofname'], $b['family_name']);
199
+        }
200
+        if (!$b['family_name']) {
201
+                    return strcmp($a['family_name'], $b['lordofname']);
202
+        }
203
+        if (strcmp($a['family_name'], $b['family_name'])) {
204
+                    return strcmp($a['family_name'], $b['family_name']);
205
+        }
199 206
         return strcmp($a['lordofname'], $b['lordofname']);
200 207
     }
201 208
 
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
         $this->db = new ParlDB;
15 15
     }
16 16
 
17
-    public function display ($view, $args=array(), $format='html') {
17
+    public function display($view, $args = array(), $format = 'html') {
18 18
         global $PAGE;
19 19
 
20 20
         $validviews = array('mps', 'peers', 'mlas', 'msps');
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
         if (in_array($view, $validviews)) {
23 23
 
24 24
             // What function do we call for this view?
25
-            $function = '_get_data_by_'.$view;
25
+            $function = '_get_data_by_' . $view;
26 26
 
27 27
             // Get all the data that's to be rendered.
28 28
             $data = $this->$function($args);
29 29
 
30 30
         } else {
31
-            $PAGE->error_message ("You haven't specified a view type.");
31
+            $PAGE->error_message("You haven't specified a view type.");
32 32
             return false;
33 33
         }
34 34
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 
40 40
 
41 41
 
42
-    public function render($view, $data, $format='html') {
42
+    public function render($view, $data, $format = 'html') {
43 43
         // Once we have the data that's to be rendered,
44 44
         // include the template.
45 45
 
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         }
50 50
 
51 51
         //This should really be a single template? (rjp)
52
-        include (INCLUDESPATH."easyparliament/templates/$format/people_$view" . ".php");
52
+        include (INCLUDESPATH . "easyparliament/templates/$format/people_$view" . ".php");
53 53
         return true;
54 54
 
55 55
     }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         $q = $this->db->query($query . "ORDER BY $sqlorder", $params);
132 132
 
133 133
         $data = array();
134
-        for ($row=0; $row<$q->rows(); $row++) {
134
+        for ($row = 0; $row < $q->rows(); $row++) {
135 135
             $p_id = $q->field($row, 'person_id');
136 136
             $dept = $q->field($row, 'dept');
137 137
             $pos = $q->field($row, 'position');
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
                     $q->field($row, 'lordofname'));
145 145
                 $constituency = $q->field($row, 'constituency');
146 146
                 $url = make_member_url($name, $constituency, $args['house'], $p_id);
147
-                $narray = array (
147
+                $narray = array(
148 148
                     'person_id' 	=> $p_id,
149 149
                     'given_name' => $q->field($row, 'given_name'),
150 150
                     'family_name' => $q->field($row, 'family_name'),
@@ -177,8 +177,8 @@  discard block
 block discarded – undo
177 177
         if ($args['house'] == 2 && ($order == 'name' || $order == 'constituency'))
178 178
             uasort($data, array($this, 'by_peer_name'));
179 179
 
180
-        $data = array (
181
-            'info' => array (
180
+        $data = array(
181
+            'info' => array(
182 182
                 'order' => $order
183 183
             ),
184 184
             'data' => $data
Please login to merge, or discard this patch.
www/includes/easyparliament/glossary.php 2 patches
Braces   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -107,19 +107,19 @@  discard block
 block discarded – undo
107 107
             if (isset($args['glossary_id']) && ($args['glossary_id'] != "")) {
108 108
                 $next = 0; $first_term = null;
109 109
                 foreach ($this->terms as $term) {
110
-                    if (!$first_term) $first_term = $term;
110
+                    if (!$first_term) {
111
+                        $first_term = $term;
112
+                    }
111 113
                     $last_term = $term;
112 114
                     if ($next == 1) {
113 115
                         $this->next_term = $term;
114 116
                         break;
115
-                    }
116
-                    elseif ($term['glossary_id'] == $args['glossary_id']) {
117
+                    } elseif ($term['glossary_id'] == $args['glossary_id']) {
117 118
                         $this->glossary_id = $args['glossary_id'];
118 119
                         $this->current_term = $term;
119 120
                         $next = 1;
120 121
 
121
-                    }
122
-                    else {
122
+                    } else {
123 123
                         $this->previous_term = $term;
124 124
                     }
125 125
                 }
@@ -134,8 +134,7 @@  discard block
 block discarded – undo
134 134
             }
135 135
 
136 136
             return ($this->num_terms);
137
-        }
138
-        else {
137
+        } else {
139 138
             return false;
140 139
         }
141 140
     }
@@ -278,8 +277,9 @@  discard block
 block discarded – undo
278 277
 
279 278
         // check for any glossary terms to replace
280 279
         foreach ($this->replace_order as $glossary_id => $count) {
281
-            if ($glossary_id == $this->glossary_id)
282
-                continue;
280
+            if ($glossary_id == $this->glossary_id) {
281
+                            continue;
282
+            }
283 283
 
284 284
             $term_body = $this->terms[$glossary_id]['body'];
285 285
             $term_title = $this->terms[$glossary_id]['title'];
@@ -290,12 +290,10 @@  discard block
 block discarded – undo
290 290
             // catch glossary terms within their own definitions
291 291
             if ($glossary_id == $this->glossary_id) {
292 292
                 $replacewords[] = "<strong>\\1</strong>";
293
-            }
294
-            else {
293
+            } else {
295 294
                 if ($this_page == "admin_glossary") {
296 295
                     $link_url = "#gl".$glossary_id;
297
-                }
298
-                else {
296
+                } else {
299 297
                     $link_url = $URL->generate('url');
300 298
                 }
301 299
                 $title = _htmlentities(trim_characters($term_body, 0, 80));
@@ -304,8 +302,9 @@  discard block
 block discarded – undo
304 302
         }
305 303
         // Highlight all occurrences of another glossary term in the definition.
306 304
         $body = preg_replace($findwords, $replacewords, $body, 1);
307
-        if (isset($this->glossary_id))
308
-            $body = preg_replace("/(?<![>\.\'\/])\b(" . $this->terms[$this->glossary_id]['title'] . ")\b(?![<\'])/i", '<strong>\\1</strong>', $body, 1);
305
+        if (isset($this->glossary_id)) {
306
+                    $body = preg_replace("/(?<![>\.\'\/])\b(" . $this->terms[$this->glossary_id]['title'] . ")\b(?![<\'])/i", '<strong>\\1</strong>', $body, 1);
307
+        }
309 308
 
310 309
         // Replace any phrases in wikipedia
311 310
         // TODO: Merge this code into above, so our gloss and wikipedia
Please login to merge, or discard this patch.
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -21,20 +21,20 @@  discard block
 block discarded – undo
21 21
 */
22 22
 
23 23
 // This handles basic insertion and approval functions for all epobjects
24
-include_once INCLUDESPATH."easyparliament/searchengine.php";
24
+include_once INCLUDESPATH . "easyparliament/searchengine.php";
25 25
 
26 26
 class GLOSSARY {
27 27
 
28
-    public $num_terms;			// how many glossary entries do we have
28
+    public $num_terms; // how many glossary entries do we have
29 29
                             // (changes depending on how GLOSSARY is called
30
-    public $hansard_count;		// how many times does the phrase appear in hansard?
31
-    public $query;				// search term
32
-    public $glossary_id;		// if this is set then we only have 1 glossary term
33
-    public $current_term;		// will only be set if we have a valid epobject_id
30
+    public $hansard_count; // how many times does the phrase appear in hansard?
31
+    public $query; // search term
32
+    public $glossary_id; // if this is set then we only have 1 glossary term
33
+    public $current_term; // will only be set if we have a valid epobject_id
34 34
     public $current_letter;
35 35
 
36 36
     // constructor...
37
-    public function __construct($args=array()) {
37
+    public function __construct($args = array()) {
38 38
     // We can optionally start the glossary with one of several arguments
39 39
     //		1. glossary_id - treat the glossary as a single term
40 40
     //		2. glossary_term - search within glossary for a term
@@ -73,16 +73,16 @@  discard block
 block discarded – undo
73 73
 
74 74
             // These stop stupid submissions.
75 75
             // everything should be lowercase.
76
-            $this->stopwords = array( "the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate" );
76
+            $this->stopwords = array("the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate");
77 77
 
78 78
     }
79 79
 
80
-    public function get_glossary_item($args=array()) {
80
+    public function get_glossary_item($args = array()) {
81 81
         // Search for and fetch glossary item with title or glossary_id
82 82
         // We could also search glossary text that contains the title text, for cross references
83 83
 
84 84
         $this->alphabet = array();
85
-        foreach (range ("A", "Z") as $letter) {
85
+        foreach (range("A", "Z") as $letter) {
86 86
             $this->alphabet[$letter] = array();
87 87
         }
88 88
 
@@ -91,11 +91,11 @@  discard block
 block discarded – undo
91 91
             WHERE g.glossary_id=eq.glossary_id AND u.user_id=eq.user_id AND g.visible=1 AND eq.approved=1
92 92
             ORDER by g.title");
93 93
         if ($q->success() && $q->rows()) {
94
-            for ($i=0; $i < $q->rows(); $i++) {
95
-                $this->terms[ $q->field($i,"glossary_id") ] = $q->row($i);
94
+            for ($i = 0; $i < $q->rows(); $i++) {
95
+                $this->terms[$q->field($i, "glossary_id")] = $q->row($i);
96 96
                 // Now add the epobject to the alphabet navigation.
97
-                $first_letter = strtoupper(substr($q->field($i,"title"),0,1));
98
-                $this->alphabet[$first_letter][] = $q->field($i,"glossary_id");
97
+                $first_letter = strtoupper(substr($q->field($i, "title"), 0, 1));
98
+                $this->alphabet[$first_letter][] = $q->field($i, "glossary_id");
99 99
             }
100 100
 
101 101
             $this->num_terms = $q->rows();
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         }
139 139
     }
140 140
 
141
-    public function search_glossary($args=array()) {
141
+    public function search_glossary($args = array()) {
142 142
         // Search for and fetch glossary item with a title
143 143
         // Useful for the search page, and nowhere else (so far)
144 144
 
@@ -153,8 +153,8 @@  discard block
 block discarded – undo
153 153
             ORDER by g.title";
154 154
         $q = $this->db->query($query);
155 155
         if ($q->success() && $q->rows()) {
156
-            for ($i=0; $i < $q->rows(); $i++) {
157
-                $this->search_matches[ $q->field($i,"glossary_id") ] = $q->row($i);
156
+            for ($i = 0; $i < $q->rows(); $i++) {
157
+                $this->search_matches[$q->field($i, "glossary_id")] = $q->row($i);
158 158
             }
159 159
             $this->num_search_matches = $q->rows();
160 160
         }
@@ -190,12 +190,12 @@  discard block
 block discarded – undo
190 190
         global $THEUSER;
191 191
 
192 192
         if ($data['title'] == '') {
193
-            error ("Sorry, you can't define a term without a title");
193
+            error("Sorry, you can't define a term without a title");
194 194
             return false;
195 195
         }
196 196
 
197 197
         if ($data['body'] == '') {
198
-            error ("You haven't entered a definition!");
198
+            error("You haven't entered a definition!");
199 199
             return false;
200 200
         }
201 201
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
         }
249 249
     }
250 250
 
251
-    public function glossarise($body, $tokenize=0, $urlize=0) {
251
+    public function glossarise($body, $tokenize = 0, $urlize = 0) {
252 252
     // Turn a body of text into a link-up wonderland of glossary joy
253 253
 
254 254
         global $this_page;
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
             }
292 292
             else {
293 293
                 if ($this_page == "admin_glossary") {
294
-                    $link_url = "#gl".$glossary_id;
294
+                    $link_url = "#gl" . $glossary_id;
295 295
                 }
296 296
                 else {
297 297
                     $link_url = $URL->generate('url');
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/error.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 
7 7
             <p><?= $error ?></p>
8 8
 
9
-        <?php if ( $rep_search_url ) { ?>
9
+        <?php if ($rep_search_url) { ?>
10 10
         </div>
11 11
 
12 12
         <div class="full-page__unit">
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/votes.php 4 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
                               <?php foreach ($segment['votes']->positions as $key_vote) {
61 61
 
62 62
                                 if (isset($policy_last_update[$key_vote['policy_id']]) && $policy_last_update[$key_vote['policy_id']] > $most_recent) {
63
-                                  $most_recent = $policy_last_update[$key_vote['policy_id']];
63
+                                    $most_recent = $policy_last_update[$key_vote['policy_id']];
64 64
                                 }
65 65
 
66 66
                                 if ( $key_vote['has_strong'] || $key_vote['position'] == 'has never voted on' ) {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
                                 include '_vote_description.php';
83 83
 
84
-                              } ?>
84
+                                } ?>
85 85
                             </ul>
86 86
 
87 87
                             <div class="share-vote-descriptions">
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,13 +110,16 @@
 block discarded – undo
110 110
 
111 111
                         <?php endif; ?>
112 112
 
113
-                    <?php else: ?>
113
+                    <?php else {
114
+    : ?>
114 115
 
115 116
                         <div class="panel">
116 117
                             <p>This person has not voted on any of the key issues which we keep track of.</p>
117 118
                         </div>
118 119
 
119
-                    <?php endif; ?>
120
+                    <?php endif;
121
+}
122
+?>
120 123
 
121 124
                 <?php endif; ?>
122 125
 
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
                 <?php if ($has_voting_record): ?>
44 44
 
45
-                    <?php $displayed_votes = FALSE; ?>
45
+                    <?php $displayed_votes = false; ?>
46 46
 
47 47
                     <?php foreach ($key_votes_segments as $segment): ?>
48 48
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
                                 <small>Last updated: <?= format_date($most_recent, LONGDATEFORMAT) ?></small>
95 95
                             </div>
96 96
 
97
-                            <?php $displayed_votes = TRUE; ?>
97
+                            <?php $displayed_votes = true; ?>
98 98
 
99 99
                         <?php endif; ?>
100 100
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
                                   $most_recent = $policy_last_update[$key_vote['policy_id']];
64 64
                                 }
65 65
 
66
-                                if ( $key_vote['has_strong'] || $key_vote['position'] == 'has never voted on' ) {
66
+                                if ($key_vote['has_strong'] || $key_vote['position'] == 'has never voted on') {
67 67
                                     $description = ucfirst($key_vote['desc']);
68 68
                                 } else {
69 69
                                     $description = sprintf(
Please login to merge, or discard this patch.