mysociety / theyworkforyou

www/docs/api/api_getMembers.php

Spacing +3 added lines, -3 removed lines

@@ -8,14 +8,14 @@ 
     $q = $db->query($sql, $params);
     $output = array();
     $last_mod = 0;
-    for ($i=0; $i<$q->rows(); $i++) {
+    for ($i = 0; $i < $q->rows(); $i++) {
         $pid = $q->field($i, 'person_id');
         $row = array(
             'member_id' => $q->field($i, 'member_id'),
             'person_id' => $pid,
             'name' => html_entity_decode(member_full_name($q->field($i, 'house'), $q->field($i, 'title'),
                 $q->field($i, 'given_name'), $q->field($i, 'family_name'),
-                $q->field($i, 'lordofname') )),
+                $q->field($i, 'lordofname'))),
             'party' => isset($parties[$q->field($i, 'party')]) ? $parties[$q->field($i, 'party')] : $q->field($i, 'party'),
         );
         if ($q->field($i, 'house') != 2) {
@@ -32,7 +32,7 @@ 
     if (count($pids)) {
         $q = $db->query('SELECT person, dept, position, from_date, to_date FROM moffice
             WHERE to_date="9999-12-31" AND person IN (' . join(',', $pids) . ')');
-        for ($i=0; $i<$q->rows(); $i++) {
+        for ($i = 0; $i < $q->rows(); $i++) {
             $row = $q->row($i);
             $pid = $row['person'];
             unset($row['person']);

www/docs/api/api_getConstituency.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
     $q = $db->query("select constituency, data_key, data_value from consinfo
                      where constituency = :constituency", array(':constituency' => $constituency));
     if ($q->rows()) {
-        for ($i=0; $i<$q->rows(); $i++) {
+        for ($i = 0; $i < $q->rows(); $i++) {
             $data_key = $q->field($i, 'data_key');
             $output[$data_key] = $q->field($i, 'data_value');
         }

www/docs/mps/index.php

Spacing +2 added lines, -2 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
 include_once '../../includes/easyparliament/init.php';
-include_once INCLUDESPATH."easyparliament/people.php";
+include_once INCLUDESPATH . "easyparliament/people.php";
 
 if (get_http_var('msp')) {
     $type = 'MSPs';
@@ -18,7 +18,7 @@ 
 $args = $people->getArgs();
 $people->setMetaData($args);
 $data = $people->getData($args);
-if ( isset($args['f']) && $args['f'] == 'csv' ) {
+if (isset($args['f']) && $args['f'] == 'csv') {
     $people->sendAsCSV($data);
 } else {
     MySociety\TheyWorkForYou\Renderer::output("people/index", $data);

www/docs/images/mps/photo-status.php

Spacing +2 added lines, -2 removed lines

@@ -11,7 +11,7 @@ 
     WHERE house=1 AND left_house = (SELECT MAX(left_house) FROM member) ';
 $q = $db->query($query . "ORDER BY person_id");
 $out = array('both'=>'', 'small'=>'', 'none'=>array());
-for ($i=0; $i<$q->rows(); $i++) {
+for ($i = 0; $i < $q->rows(); $i++) {
     $p_id = $q->field($i, 'person_id');
     list($dummy, $sz) = MySociety\TheyWorkForYou\Utility\Member::findMemberImage($p_id);
     if ($sz == 'L') {
@@ -22,7 +22,7 @@ 
         array_push($out['none'], '<li>' . $q->field($i, 'person_id') . ' (' . $q->field($i, 'party') . ')' . ', ' . $q->field($i, 'constituency'));
     }
 }
-print '<h3>Missing completely ('.count($out['none']).')</h3> <ul>';
+print '<h3>Missing completely (' . count($out['none']) . ')</h3> <ul>';
 print join($out['none'], "\n");
 print '</ul>';
 print '<h3>Large and small</h3> <p>';

www/includes/easyparliament/trackback.php

Spacing +19 added lines, -19 removed lines

@@ -51,7 +51,7 @@ 
     public function moderate_trackbacks() { return $this->moderate_trackbacks; }
 
 
-    public function display ($view, $args=array(), $format='html') {
+    public function display($view, $args = array(), $format = 'html') {
         // $view is one of:
         //	'epobject_id' - display the pings for one epobject.
         // 	'recent' - to get the most recent pings to anywhere.
@@ -64,18 +64,18 @@ 
         if ($view == 'epobject_id' || $view == 'recent') {
 
             // What function do we call for this view?
-            $function = '_get_trackbacks_by_'.$view;
+            $function = '_get_trackbacks_by_' . $view;
             // Get all the data that's to be rendered.
             $trackbackdata = $this->$function($args);
 
         } else {
-            $PAGE->error_message ("You haven't specified a valid view type.");
+            $PAGE->error_message("You haven't specified a valid view type.");
             return false;
         }
 
-        $data = array (
+        $data = array(
             'data' 	=> $trackbackdata,
-            'info'	=> array (
+            'info'	=> array(
                 'view' => $view
             )
         );
@@ -86,7 +86,7 @@ 
         $this->render($view, $data, $format);
     }
 
-    public function render($view, $data, $format='html') {
+    public function render($view, $data, $format = 'html') {
 
         if ($format != 'html') {
             $format = 'html';
@@ -95,7 +95,7 @@ 
         // We currently only have one kind of trackback template, so
         // we're ignoring $view here I'm afraid...
 
-        include (INCLUDESPATH."easyparliament/templates/$format/trackbacks" . ".php");
+        include (INCLUDESPATH . "easyparliament/templates/$format/trackbacks" . ".php");
 
     }
 
@@ -131,14 +131,14 @@ 
 
 
         // Still here? Then we're trackbacking to a valid hansard item.
-        $url 		= $trackbackdata['url'];
-        $source_ip	= $trackbackdata['source_ip'];
+        $url = $trackbackdata['url'];
+        $source_ip = $trackbackdata['source_ip'];
         // These all strip_tags too.
-        $title 		= trim_characters(html_entity_decode($trackbackdata['title']), 0, 255);
-        $excerpt 	= trim_characters(html_entity_decode($trackbackdata['excerpt']), 0, 255);
-        $blog_name 	= trim_characters(html_entity_decode($trackbackdata['blog_name']), 0, 255);
+        $title = trim_characters(html_entity_decode($trackbackdata['title']), 0, 255);
+        $excerpt = trim_characters(html_entity_decode($trackbackdata['excerpt']), 0, 255);
+        $blog_name = trim_characters(html_entity_decode($trackbackdata['blog_name']), 0, 255);
 
-        $visible 		= $this->moderate_trackbacks ? 0 : 1;
+        $visible = $this->moderate_trackbacks ? 0 : 1;
 
         $q = $this->db->query("INSERT INTO trackbacks
                         (epobject_id, blog_name, title, excerpt, url, source_ip, posted, visible)
@@ -198,8 +198,8 @@ 
                         ");
 
         if ($q->rows() > 0) {
-            for ($row=0; $row<$q->rows(); $row++) {
-                $trackbackdata[] = array (
+            for ($row = 0; $row < $q->rows(); $row++) {
+                $trackbackdata[] = array(
                     'trackback_id' 	=> $q->field($row, 'trackback_id'),
                     'epobject_id'	=> $q->field($row, 'epobject_id'),
                     'blog_name' 	=> $q->field($row, 'blog_name'),
@@ -247,8 +247,8 @@ 
                         ");
 
         if ($q->rows() > 0) {
-            for ($row=0; $row<$q->rows(); $row++) {
-                $trackbackdata[] = array (
+            for ($row = 0; $row < $q->rows(); $row++) {
+                $trackbackdata[] = array(
                     'trackback_id' 	=> $q->field($row, 'trackback_id'),
                     'epobject_id'	=> $q->field($row, 'epobject_id'),
                     'blog_name' 	=> $q->field($row, 'blog_name'),
@@ -277,13 +277,13 @@ 
             // This page just does XML.
 
             if ($error) {
-                echo '<?xml version="1.0" encoding="utf-8"?'.">\n";
+                echo '<?xml version="1.0" encoding="utf-8"?' . ">\n";
                 echo "<response>\n";
                 echo "<error>1</error>\n";
                 echo "<message>$error_message</message>\n";
                 echo "</response>";
             } else {
-                echo '<?xml version="1.0" encoding="utf-8"?'.">\n";
+                echo '<?xml version="1.0" encoding="utf-8"?' . ">\n";
                 echo "<response>\n";
                 echo "<error>0</error>\n";
                 echo "</response>";

www/includes/easyparliament/glossarylist.php

Spacing +2 added lines, -2 removed lines

@@ -2,7 +2,7 @@ 
 
 class GLOSSARYLIST {
 
-    public function render($data, $format='html', $template='glossary') {
+    public function render($data, $format = 'html', $template = 'glossary') {
         // Once we have the data that's to be rendered,
         // include the template.
 
@@ -10,7 +10,7 @@ 
             $format = 'html';
         }
 
-        include (INCLUDESPATH."easyparliament/templates/$format/$template.php");
+        include (INCLUDESPATH . "easyparliament/templates/$format/$template.php");
 
     }
 

www/includes/easyparliament/templates/html/search/form_main.php

Spacing +2 added lines, -2 removed lines

@@ -4,7 +4,7 @@ 
             <input type="text" name="q" value="<?= _htmlentities($search_keyword) ?>" class="form-control">
             <input type="submit" class="button" value="Search">
         </p>
-      <?php if (isset($warnings) ) { ?>
+      <?php if (isset($warnings)) { ?>
         <p class="error">
             <?= $warnings ?>
         </p>
@@ -18,7 +18,7 @@ 
         <p>
             <ul class="search-result-display-options">
                 <li><a href="#options" class="search-options-toggle js-toggle-search-options">Advanced search</a></li>
-              <?php if ( $is_adv ) { ?>
+              <?php if ($is_adv) { ?>
                 <?= $search_phrase ? '<li>Exactly: ' . _htmlentities($search_phrase) . '</li>' : '' ?>
                 <?= $search_exclude ? '<li>Excluding: ' . _htmlentities($search_exclude) . '</li>' : '' ?>
                 <?= $search_from ? '<li>From: ' . _htmlentities($search_from) . '</li>' : '' ?>

www/includes/easyparliament/templates/html/search/person.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
     <p class="search-result__description">
     <?php $details = $member->getMostRecentMembership(); ?>
     <?= $details['left_house'] != '9999-12-31' ? 'Former ' : '' ?><?= $details['party'] ? $details['party'] . ' ' : '' ?><?= $details['rep_name'] ?><?= $details['cons'] ? ', ' . $details['cons'] : ''?>
-    <?php if ( $details['entered_house'] || ( $details['left_house'] && $details['left_house'] != '9999-12-31' )  ) { ?>
+    <?php if ($details['entered_house'] || ($details['left_house'] && $details['left_house'] != '9999-12-31')) { ?>
 , <?= format_date($details['entered_house'], SHORTDATEFORMAT) ?> &ndash; <?= $details['left_house'] != '9999-12-31' ? format_date($details['left_house'], SHORTDATEFORMAT) : '' ?>
     <?php } ?>
     </p>

www/includes/easyparliament/templates/html/search/by-person.php

Spacing +22 added lines, -22 removed lines

@@ -9,17 +9,17 @@ 
             <div class="search-page__section__primary">
                 <h2>Who says <em class="current-search-term"><?= _htmlentities($searchstring) ?></em> the most?</h2>
 
-              <?php if ( isset($error) ) { ?>
-                <?php if ( $error == 'No results' && isset( $house ) && $house != 0 ) { ?>
+              <?php if (isset($error)) { ?>
+                <?php if ($error == 'No results' && isset($house) && $house != 0) { ?>
                   <ul class="search-result-display-options">
                       <li>
-                        <?php if ( $house == 1 ) { ?>
+                        <?php if ($house == 1) { ?>
                           No results for MPs only
-                        <?php } else if ( $house == 2 ) { ?>
+                        <?php } else if ($house == 2) { ?>
                           No results for Peers only
-                        <?php } else if ( $house == 4 ) { ?>
+                        <?php } else if ($house == 4) { ?>
                           No results for MSPs only
-                        <?php } else if ( $house == 3 ) { ?>
+                        <?php } else if ($house == 3) { ?>
                           No results for MLAs only
                         <?php } ?>
                           |
@@ -31,7 +31,7 @@ 
                 <?php } ?>
               <?php } ?>
 
-              <?php if ( $wtt ) { ?>
+              <?php if ($wtt) { ?>
                 <p><strong>Now, try reading what a couple of these Lords are saying,
                 to help you find someone appropriate. When you've found someone,
                 hit the "I want to write to this Lord" button on their results page
@@ -39,37 +39,37 @@ 
                 </strong></p>
               <?php } ?>
 
-              <?php if ( isset($speakers) && count($speakers) ) { ?>
+              <?php if (isset($speakers) && count($speakers)) { ?>
 
-                  <?php if ( !$wtt ) { ?>
+                  <?php if (!$wtt) { ?>
                     <ul class="search-result-display-options">
                         <li>Results grouped by person</li>
                         <li>
-                          <?php if ( $house == 0 ) { ?>
+                          <?php if ($house == 0) { ?>
                             Show All
                           <?php } else { ?>
                             <a href="<?= $this_url->generate('html') ?>">Show All</a>
                           <?php } ?>
                             |
-                          <?php if ( $house == 1 ) { ?>
+                          <?php if ($house == 1) { ?>
                             MPs only
                           <?php } else { ?>
                             <a href="<?= $this_url->generate('html', array('house'=>1)) ?>">MPs only</a>
                           <?php } ?>
                             |
-                          <?php if ( $house == 2 ) { ?>
+                          <?php if ($house == 2) { ?>
                             Peers only
                           <?php } else { ?>
                             <a href="<?= $this_url->generate('html', array('house'=>2)) ?>">Lords only</a>
                           <?php } ?>
                             |
-                          <?php if ( $house == 4 ) { ?>
+                          <?php if ($house == 4) { ?>
                             MSPs only
                           <?php } else { ?>
                             <a href="<?= $this_url->generate('html', array('house'=>4)) ?>">MSPs only</a>
                           <?php } ?>
                             |
-                          <?php if ( $house == 3 ) { ?>
+                          <?php if ($house == 3) { ?>
                             MLAs only
                           <?php } else { ?>
                             <a href="<?= $this_url->generate('html', array('house'=>3)) ?>">MLAs only</a>
@@ -90,25 +90,25 @@ 
                         </tr>
                     </thead>
                     <tbody>
-                      <?php foreach ( $speakers as $pid => $speaker ) { ?>
+                      <?php foreach ($speakers as $pid => $speaker) { ?>
 
-                        <?php if ( $wtt && $pid == 0 ) { continue; } // skip heading count for WTT lords list ?>
+                        <?php if ($wtt && $pid == 0) { continue; } // skip heading count for WTT lords list ?>
 
                         <tr>
                             <td><?= $speaker['count'] ?></td>
                             <td>
-                              <?php if ( $pid ) { ?>
-                                <?php if ( !$wtt || $speaker['left'] == '9999-12-31' ) { ?>
+                              <?php if ($pid) { ?>
+                                <?php if (!$wtt || $speaker['left'] == '9999-12-31') { ?>
                                   <a href="/search/?q=<?= _htmlentities($searchstring) ?>&amp;pid=<?= $pid ?><?= isset($wtt) && $speaker['left'] == '9999-12-31' ? '&amp;wtt=2' : '' ?>">
                                 <?php } ?>
                                 <?= isset($speaker['name']) ? $speaker['name'] : 'N/A' ?>
-                                <?php if ( !$wtt || $speaker['left'] == '9999-12-31' ) { ?>
+                                <?php if (!$wtt || $speaker['left'] == '9999-12-31') { ?>
                                   </a>
                                 <?php } ?>
-                                <?php if ( isset($speaker['party']) ) { ?>
+                                <?php if (isset($speaker['party'])) { ?>
                                   <span class="search-results-grouped__speaker-party">(<?= $speaker['party'] ?>)</span>
                                 <?php } ?>
-                                <?php if ( $house != 2 ) { ?>
+                                <?php if ($house != 2) { ?>
                                   <?= isset($speaker['office']) ? ' - ' . join('; ', $speaker['office']) : '' ?>
                                 <?php } ?>
                               <?php } else { // no $pid ?>
@@ -116,7 +116,7 @@ 
                               <?php } ?>
                             </td>
                             <td>
-                              <?php if ( format_date($speaker['pmindate'], 'M Y') == format_date($speaker['pmaxdate'], 'M Y') ) { ?>
+                              <?php if (format_date($speaker['pmindate'], 'M Y') == format_date($speaker['pmaxdate'], 'M Y')) { ?>
                                 <?= format_date($speaker['pmindate'], 'M Y') ?>
                               <?php } else { ?>
                                 <?= format_date($speaker['pmindate'], 'M Y') ?>&nbsp;&ndash;&nbsp;<?= format_date($speaker['pmaxdate'], 'M Y') ?>

Braces +2 added lines, -1 removed lines

@@ -111,7 +111,8 @@
                                 <?php if ( $house != 2 ) { ?>
                                   <?= isset($speaker['office']) ? ' - ' . join('; ', $speaker['office']) : '' ?>
                                 <?php } ?>
-                              <?php } else { // no $pid ?>
+                              <?php } else {
+// no $pid ?>
                                 <?= $speaker['name'] ?>
                               <?php } ?>
                             </td>