mysociety / theyworkforyou

classes/Utility/Wikipedia.php

Indentation +37 added lines, -37 removed lines

@@ -136,63 +136,63 @@
 
     public static function antiTagInTag($content = '', $format = 'htmlhead')
     {
-      $contentwalker = 0;
-      $length = strlen( $content );
-      $tagend = -1;
-      for( $tagstart = strpos( $content, '<', $tagend + 1 ) ; $tagstart !== false && $tagstart < strlen( $content ); $tagstart = strpos( $content, '<', $tagend ) )
+        $contentwalker = 0;
+        $length = strlen( $content );
+        $tagend = -1;
+        for( $tagstart = strpos( $content, '<', $tagend + 1 ) ; $tagstart !== false && $tagstart < strlen( $content ); $tagstart = strpos( $content, '<', $tagend ) )
         {
-          // got the start of a tag.  Now find the proper end!
-          $walker = $tagstart + 1;
-          $open = 1;
-          while( $open != 0 && $walker < strlen( $content ) )
+            // got the start of a tag.  Now find the proper end!
+            $walker = $tagstart + 1;
+            $open = 1;
+            while( $open != 0 && $walker < strlen( $content ) )
         {
-          $nextopen = strpos( $content, '<', $walker );
-          $nextclose = strpos( $content, '>', $walker );
-          if( $nextclose === false )
+            $nextopen = strpos( $content, '<', $walker );
+            $nextclose = strpos( $content, '>', $walker );
+            if( $nextclose === false )
             {    // ERROR! Open waka without close waka!
-              // echo '<code>Error in antiTagInTag - malformed tag!</code> ';
-              return $content;
+                // echo '<code>Error in antiTagInTag - malformed tag!</code> ';
+                return $content;
             }
-          if( $nextopen === false || $nextopen > $nextclose )
+            if( $nextopen === false || $nextopen > $nextclose )
             { // No more opens, but there was a close; or, a close happens before the next open.
-              // walker goes to the close+1, and open decrements
-              $open --;
-              $walker = $nextclose + 1;
+                // walker goes to the close+1, and open decrements
+                $open --;
+                $walker = $nextclose + 1;
             }
-          elseif( $nextopen < $nextclose )
+            elseif( $nextopen < $nextclose )
             { // an open before the next close
-              $open ++;
-              $walker = $nextopen + 1;
+                $open ++;
+                $walker = $nextopen + 1;
             }
         }
-          $tagend = $walker;
-          if( $tagend > strlen( $content ) )
+            $tagend = $walker;
+            if( $tagend > strlen( $content ) )
         $tagend = strlen( $content );
-          else
+            else
         {
-          $tagend --;
-          $tagstart ++;
+            $tagend --;
+            $tagstart ++;
         }
-          $tag = substr( $content, $tagstart, $tagend - $tagstart );
-          $tags[] = '<' . $tag . '>';
+            $tag = substr( $content, $tagstart, $tagend - $tagstart );
+            $tags[] = '<' . $tag . '>';
 
-          if (function_exists('format_to_output')) {
+            if (function_exists('format_to_output')) {
             $newtag = format_to_output($tag, $format);
-          } else {
+            } else {
             $newtag = strip_tags($tag);
-          }
+            }
 
-          $newtags[] = '<' . $newtag . '>';
+            $newtags[] = '<' . $newtag . '>';
 
-          if (function_exists('format_to_output')) {
+            if (function_exists('format_to_output')) {
             $newtag = format_to_output($tag, $format);
-          } else {
+            } else {
             $newtag = strip_tags($tag);
-          }
+            }
+        }
+        if (isset($tags)&&isset($newtags)) {
+        $content = str_replace($tags, $newtags, $content);
         }
-      if (isset($tags)&&isset($newtags)) {
-      $content = str_replace($tags, $newtags, $content);
-      }
 
     return $content;
 

Spacing +18 added lines, -18 removed lines

@@ -83,7 +83,7 @@ 
         $source = explode('|||', $source);
         $q = $db->query("SELECT titles.title FROM titles LEFT JOIN titles_ignored ON titles.title=titles_ignored.title WHERE titles.title IN (" . join(',', array_keys($params)) . ") AND titles_ignored.title IS NULL", $params);
         $phrases = array();
-        for ($i=0; $i<$q->rows(); $i++) {
+        for ($i = 0; $i < $q->rows(); $i++) {
             $phrases[] = $q->field($i, 'title');
         }
 
@@ -105,7 +105,7 @@ 
 
             twfy_debug("WIKIPEDIA", "Matched '$phrase'");
             # 1 means only replace one match for phrase per paragraph
-            $source = preg_replace ('{
+            $source = preg_replace('{
             \b(' . $phrase_re . ')\b # Match the phrase itself
             (?!                      # Match as long as the following does *not* apply:
                 (?:                  #   Match, possessively, as many strings of:
@@ -137,43 +137,43 @@ 
     public static function antiTagInTag($content = '', $format = 'htmlhead')
     {
       $contentwalker = 0;
-      $length = strlen( $content );
+      $length = strlen($content);
       $tagend = -1;
-      for( $tagstart = strpos( $content, '<', $tagend + 1 ) ; $tagstart !== false && $tagstart < strlen( $content ); $tagstart = strpos( $content, '<', $tagend ) )
+      for ($tagstart = strpos($content, '<', $tagend + 1); $tagstart !== false && $tagstart < strlen($content); $tagstart = strpos($content, '<', $tagend))
         {
           // got the start of a tag.  Now find the proper end!
           $walker = $tagstart + 1;
           $open = 1;
-          while( $open != 0 && $walker < strlen( $content ) )
+          while ($open != 0 && $walker < strlen($content))
         {
-          $nextopen = strpos( $content, '<', $walker );
-          $nextclose = strpos( $content, '>', $walker );
-          if( $nextclose === false )
+          $nextopen = strpos($content, '<', $walker);
+          $nextclose = strpos($content, '>', $walker);
+          if ($nextclose === false)
             {    // ERROR! Open waka without close waka!
               // echo '<code>Error in antiTagInTag - malformed tag!</code> ';
               return $content;
             }
-          if( $nextopen === false || $nextopen > $nextclose )
+          if ($nextopen === false || $nextopen > $nextclose)
             { // No more opens, but there was a close; or, a close happens before the next open.
               // walker goes to the close+1, and open decrements
-              $open --;
+              $open--;
               $walker = $nextclose + 1;
             }
-          elseif( $nextopen < $nextclose )
+          elseif ($nextopen < $nextclose)
             { // an open before the next close
-              $open ++;
+              $open++;
               $walker = $nextopen + 1;
             }
         }
           $tagend = $walker;
-          if( $tagend > strlen( $content ) )
-        $tagend = strlen( $content );
+          if ($tagend > strlen($content))
+        $tagend = strlen($content);
           else
         {
-          $tagend --;
-          $tagstart ++;
+          $tagend--;
+          $tagstart++;
         }
-          $tag = substr( $content, $tagstart, $tagend - $tagstart );
+          $tag = substr($content, $tagstart, $tagend - $tagstart);
           $tags[] = '<' . $tag . '>';
 
           if (function_exists('format_to_output')) {
@@ -190,7 +190,7 @@ 
             $newtag = strip_tags($tag);
           }
         }
-      if (isset($tags)&&isset($newtags)) {
+      if (isset($tags) && isset($newtags)) {
       $content = str_replace($tags, $newtags, $content);
       }
 

Braces +15 added lines, -15 removed lines

@@ -99,8 +99,9 @@ 
 
             # See if already matched a string this one is contained within
             foreach ($matched as $got) {
-                if (strstr($got, $phrase))
-                    continue 2;
+                if (strstr($got, $phrase)) {
+                                    continue 2;
+                }
             }
 
             twfy_debug("WIKIPEDIA", "Matched '$phrase'");
@@ -119,8 +120,9 @@ 
             array_push($matched, $phrase);
         }
 
-        if (!$was_array)
-            $source = join('|||', $source);
+        if (!$was_array) {
+                    $source = join('|||', $source);
+        }
 
         return $source;
 
@@ -148,28 +150,26 @@ 
         {
           $nextopen = strpos( $content, '<', $walker );
           $nextclose = strpos( $content, '>', $walker );
-          if( $nextclose === false )
-            {    // ERROR! Open waka without close waka!
+          if( $nextclose === false ) {
+// ERROR! Open waka without close waka!
               // echo '<code>Error in antiTagInTag - malformed tag!</code> ';
               return $content;
             }
-          if( $nextopen === false || $nextopen > $nextclose )
-            { // No more opens, but there was a close; or, a close happens before the next open.
+          if( $nextopen === false || $nextopen > $nextclose ) {
+// No more opens, but there was a close; or, a close happens before the next open.
               // walker goes to the close+1, and open decrements
               $open --;
               $walker = $nextclose + 1;
-            }
-          elseif( $nextopen < $nextclose )
-            { // an open before the next close
+            } elseif( $nextopen < $nextclose ) {
+// an open before the next close
               $open ++;
               $walker = $nextopen + 1;
             }
         }
           $tagend = $walker;
-          if( $tagend > strlen( $content ) )
-        $tagend = strlen( $content );
-          else
-        {
+          if( $tagend > strlen( $content ) ) {
+                  $tagend = strlen( $content );
+          } else {
           $tagend --;
           $tagstart ++;
         }

classes/Utility/Constituencies.php

Braces +6 added lines, -4 removed lines

@@ -31,13 +31,15 @@
         $q1 = $db->query($query, array(
             ':name' => $name
             ));
-        if ($q1->rows <= 0)
-            return false;
+        if ($q1->rows <= 0) {
+                    return false;
+        }
 
         $query = "select name from constituency where main_name and cons_id = '".$q1->field(0,'cons_id')."'";
         $q2 = $db->query($query);
-        if ($q2->rows <= 0)
-            return false;
+        if ($q2->rows <= 0) {
+                    return false;
+        }
 
         return $q2->field(0, "name");
     }

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         if ($q1->rows <= 0)
             return false;
 
-        $query = "select name from constituency where main_name and cons_id = '".$q1->field(0,'cons_id')."'";
+        $query = "select name from constituency where main_name and cons_id = '" . $q1->field(0, 'cons_id') . "'";
         $q2 = $db->query($query);
         if ($q2->rows <= 0)
             return false;

classes/Utility/Search.php

Braces +15 added lines, -7 removed lines

@@ -28,8 +28,9 @@ 
 
             return $data;
         }
-        if (count($gids) == 5000)
-            $data['limit_reached'] = true;
+        if (count($gids) == 5000) {
+                    $data['limit_reached'] = true;
+        }
 
         # Fetch all the speakers of the results, count them up and get min/max date usage
         $speaker_count = array();
@@ -46,8 +47,12 @@ 
                 $mindate[$person_id] = '9999-12-31';
             }
             $speaker_count[$person_id]++;
-            if ($hdate < $mindate[$person_id]) $mindate[$person_id] = $hdate;
-            if ($hdate > $maxdate[$person_id]) $maxdate[$person_id] = $hdate;
+            if ($hdate < $mindate[$person_id]) {
+                $mindate[$person_id] = $hdate;
+            }
+            if ($hdate > $maxdate[$person_id]) {
+                $maxdate[$person_id] = $hdate;
+            }
         }
 
         # Fetch details of all the speakers
@@ -81,8 +86,9 @@ 
                 $dept = $q->field($n, 'dept');
                 $posn = $q->field($n, 'position');
                 $moffice_id = $q->field($n, 'moffice_id');
-                if ($dept && $q->field($n, 'to_date') == '9999-12-31')
-                    $speakers[$pid]['office'][$moffice_id] = prettify_office($posn, $dept);
+                if ($dept && $q->field($n, 'to_date') == '9999-12-31') {
+                                    $speakers[$pid]['office'][$moffice_id] = prettify_office($posn, $dept);
+                }
                 if (!isset($speakers[$pid]['name'])) {
                     $speakers[$pid]['name'] = $full_name . ($house==1?' MP':'');
                 }
@@ -140,7 +146,9 @@ 
      */
 
     public static function searchMemberDbLookup($searchstring, $current_only=false) {
-        if (!$searchstring) return false;
+        if (!$searchstring) {
+            return false;
+        }
         $searchwords = explode(' ', $searchstring, 3);
         $params = array();
         if (count($searchwords) == 1) {

Spacing +18 added lines, -18 removed lines

@@ -36,7 +36,7 @@ 
         $gids = join('","', $gids);
         $db = new \ParlDB;
         $q = $db->query('SELECT gid,person_id,hdate FROM hansard WHERE gid IN ("' . $gids . '")');
-        for ($n=0; $n<$q->rows(); $n++) {
+        for ($n = 0; $n < $q->rows(); $n++) {
             $gid = $q->field($n, 'gid');
             $person_id = $q->field($n, 'person_id');
             $hdate = $q->field($n, 'hdate');
@@ -63,7 +63,7 @@ 
                             WHERE member.person_id IN (' . $person_ids . ')
                             ' . ($house ? " AND house=$house" : '') . '
                             ORDER BY left_house DESC');
-            for ($n=0; $n<$q->rows(); $n++) {
+            for ($n = 0; $n < $q->rows(); $n++) {
                 $mid = $q->field($n, 'member_id');
                 if (!isset($pids[$mid])) {
                     $title = $q->field($n, 'title');
@@ -84,9 +84,9 @@ 
                 if ($dept && $q->field($n, 'to_date') == '9999-12-31')
                     $speakers[$pid]['office'][$moffice_id] = prettify_office($posn, $dept);
                 if (!isset($speakers[$pid]['name'])) {
-                    $speakers[$pid]['name'] = $full_name . ($house==1?' MP':'');
+                    $speakers[$pid]['name'] = $full_name . ($house == 1 ? ' MP' : '');
                 }
-                if ( !isset($speakers[$pid]['party']) && $party ) {
+                if (!isset($speakers[$pid]['party']) && $party) {
                     $speakers[$pid]['party'] = $party;
                 }
             }
@@ -139,7 +139,7 @@ 
      * Return query result from looking for MPs
      */
 
-    public static function searchMemberDbLookup($searchstring, $current_only=false) {
+    public static function searchMemberDbLookup($searchstring, $current_only = false) {
         if (!$searchstring) return false;
         $searchwords = explode(' ', $searchstring, 3);
         $params = array();
@@ -151,8 +151,8 @@ 
             // And here we're assuming the user's put the names in the right order.
             $params[':like_0'] = '%' . $searchwords[0] . '%';
             $params[':like_1'] = '%' . $searchwords[1] . '%';
-            $params[':like_0_and_1'] = '%' . $searchwords[0] . ' '. $searchwords[1] . '%';
-            $params[':like_0_and_1_hyphen'] = '%' . $searchwords[0] . '-'. $searchwords[1] . '%';
+            $params[':like_0_and_1'] = '%' . $searchwords[0] . ' ' . $searchwords[1] . '%';
+            $params[':like_0_and_1_hyphen'] = '%' . $searchwords[0] . '-' . $searchwords[1] . '%';
             $where = "(given_name LIKE :like_0 AND family_name LIKE :like_1)";
             $where .= " OR (given_name LIKE :like_1 AND family_name LIKE :like_0)";
             $where .= " OR (title LIKE :like_0 AND family_name LIKE :like_1)";
@@ -167,9 +167,9 @@ 
             $params[':like_0'] = '%' . $searchwords[0] . '%';
             $params[':like_1'] = '%' . $searchwords[1] . '%';
             $params[':like_2'] = '%' . $searchwords[2] . '%';
-            $params[':like_0_and_1'] = '%' . $searchwords[0] . ' '. $searchwords[1] . '%';
-            $params[':like_1_and_2'] = '%' . $searchwords[1] . ' '. $searchwords[2] . '%';
-            $params[':like_1_and_2_hyphen'] = '%' . $searchwords[1] . '-'. $searchwords[2] . '%';
+            $params[':like_0_and_1'] = '%' . $searchwords[0] . ' ' . $searchwords[1] . '%';
+            $params[':like_1_and_2'] = '%' . $searchwords[1] . ' ' . $searchwords[2] . '%';
+            $params[':like_1_and_2_hyphen'] = '%' . $searchwords[1] . '-' . $searchwords[2] . '%';
             $where = "(given_name LIKE :like_0_and_1 AND family_name LIKE :like_2)";
             $where .= " OR (given_name LIKE :like_0 AND family_name LIKE :like_1_and_2)";
             $where .= " OR (given_name LIKE :like_0 AND family_name LIKE :like_1_and_2_hyphen)";
@@ -184,15 +184,15 @@ 
         return $q;
     }
 
-    public static function searchMemberDbLookupWithNames($searchstring, $current_only=false) {
+    public static function searchMemberDbLookupWithNames($searchstring, $current_only = false) {
         $q = self::searchMemberDbLookup($searchstring, $current_only);
 
-        if ( !$q->rows ) {
+        if (!$q->rows) {
             return $q;
         }
 
         $person_ids = array();
-        for ($i=0; $i<$q->rows(); ++$i) {
+        for ($i = 0; $i < $q->rows(); ++$i) {
             $pid = $q->field($i, 'person_id');
             $person_ids[$pid] = 1;
         }
@@ -239,7 +239,7 @@ 
             // Looks like a postcode - can we find the constituency?
             $constituency = Postcode::postcodeToConstituency($searchterm);
             if ($constituency) {
-                return array( array($constituency), true );
+                return array(array($constituency), true);
             }
         }
 
@@ -253,11 +253,11 @@ 
         $q = $db->query($query, array(':try' => '%' . $try . '%'));
 
         $constituencies = array();
-        for ($n=0; $n<$q->rows(); $n++) {
+        for ($n = 0; $n < $q->rows(); $n++) {
             $constituencies[] = $q->field($n, 'name');
         }
 
-        return array( $constituencies, false );
+        return array($constituencies, false);
     }
 
     /**
@@ -273,7 +273,7 @@ 
         $speakers = [];
 
         foreach ($criteria as $c) {
-            if (preg_match('#^speaker:(\d+)#',$c,$m)) {
+            if (preg_match('#^speaker:(\d+)#', $c, $m)) {
                 $MEMBER = new \MEMBER(array('person_id'=>$m[1]));
                 $speakers[$m[1]] = $MEMBER->full_name();
             }
@@ -292,7 +292,7 @@ 
     public static function speakerIDsToNames($searchstring) {
         $speakers = self::speakerNamesForIDs($searchstring);
 
-        foreach ( $speakers as $id => $name ) {
+        foreach ($speakers as $id => $name) {
             $searchstring = str_replace('speaker:' . $id, "speaker:$name", $searchstring);
         }
 

classes/Topics.php

Indentation +36 added lines, -36 removed lines

@@ -25,59 +25,59 @@
     }
 
     public function getTopics() {
-      $q = $this->db->query("SELECT id, slug, title, description, search_string, front_page, image FROM topics");
+        $q = $this->db->query("SELECT id, slug, title, description, search_string, front_page, image FROM topics");
 
-      $topics = array();
-      $count = $q->rows();
+        $topics = array();
+        $count = $q->rows();
 
-      for ($i = 0; $i < $count; $i++ ) {
-          $topic = $q->row($i);
-          $topics[$topic['slug']] = new Topic($topic);
-      }
-      return $topics;
+        for ($i = 0; $i < $count; $i++ ) {
+            $topic = $q->row($i);
+            $topics[$topic['slug']] = new Topic($topic);
+        }
+        return $topics;
     }
 
     public function getTopic($topic_name) {
-      $q = $this->db->query(
-          "SELECT id, slug, title, description, search_string, front_page, image FROM topics WHERE slug = :slug",
-          array(':slug' => $topic_name)
-      );
-      if ($q->rows) {
-          return new Topic($q->row(0));
-      }
-
-      return NULL;
+        $q = $this->db->query(
+            "SELECT id, slug, title, description, search_string, front_page, image FROM topics WHERE slug = :slug",
+            array(':slug' => $topic_name)
+        );
+        if ($q->rows) {
+            return new Topic($q->row(0));
+        }
+
+        return NULL;
     }
 
     public function getFrontPageTopics() {
-      $q = $this->db->query(
-          "SELECT id, slug, title, description, search_string, front_page, image FROM topics WHERE front_page = TRUE"
-      );
-
-      $topics = array();
-      $count = $q->rows();
-
-      for ($i = 0; $i < $count; $i++ ) {
-          $topic = $q->row($i);
-          $topics[$topic['slug']] = new Topic($topic);
-      }
-      return $topics;
+        $q = $this->db->query(
+            "SELECT id, slug, title, description, search_string, front_page, image FROM topics WHERE front_page = TRUE"
+        );
+
+        $topics = array();
+        $count = $q->rows();
+
+        for ($i = 0; $i < $count; $i++ ) {
+            $topic = $q->row($i);
+            $topics[$topic['slug']] = new Topic($topic);
+        }
+        return $topics;
     }
 
     public function updateFrontPageTopics($topics) {
         // PDO doesn't cope with arrays so we have to do this by hand :|
         $quoted = array();
         if ($topics) {
-          foreach ($topics as $topic) {
-              $quoted[] = $this->db->quote($topic);
-          }
-          $topics_str = implode(',', $quoted);
+            foreach ($topics as $topic) {
+                $quoted[] = $this->db->quote($topic);
+            }
+            $topics_str = implode(',', $quoted);
 
-          $q = $this->db->query("UPDATE topics SET front_page = TRUE WHERE slug IN ($topics_str)");
+            $q = $this->db->query("UPDATE topics SET front_page = TRUE WHERE slug IN ($topics_str)");
 
-          $q = $this->db->query("UPDATE topics SET front_page = FALSE WHERE slug NOT IN ($topics_str)");
+            $q = $this->db->query("UPDATE topics SET front_page = FALSE WHERE slug NOT IN ($topics_str)");
         } else {
-          $q = $this->db->query("UPDATE topics SET front_page = FALSE");
+            $q = $this->db->query("UPDATE topics SET front_page = FALSE");
         }
 
         return true;

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
       $topics = array();
       $count = $q->rows();
 
-      for ($i = 0; $i < $count; $i++ ) {
+      for ($i = 0; $i < $count; $i++) {
           $topic = $q->row($i);
           $topics[$topic['slug']] = new Topic($topic);
       }
@@ -57,7 +57,7 @@ 
       $topics = array();
       $count = $q->rows();
 
-      for ($i = 0; $i < $count; $i++ ) {
+      for ($i = 0; $i < $count; $i++) {
           $topic = $q->row($i);
           $topics[$topic['slug']] = new Topic($topic);
       }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
           return new Topic($q->row(0));
       }
 
-      return NULL;
+      return null;
     }
 
     public function getFrontPageTopics() {

classes/Policies.php

Indentation +13 added lines, -13 removed lines

@@ -309,7 +309,7 @@ 
     }
 
     public function getSetDescriptions() {
-      return $this->set_descs;
+        return $this->set_descs;
     }
 
     /**
@@ -397,18 +397,18 @@ 
     }
 
     public function limitToArray($policies) {
-          $out = array();
-          // Reassemble the new policies list based on the set.
-          foreach ($policies as $policy) {
-              if (isset($this->policies[$policy])) {
-                  $out[$policy] = $this->policies[$policy];
-              }
-          }
-
-          $new_policies = new self();
-          $new_policies->policies = $out;
-
-          return $new_policies;
+            $out = array();
+            // Reassemble the new policies list based on the set.
+            foreach ($policies as $policy) {
+                if (isset($this->policies[$policy])) {
+                    $out[$policy] = $this->policies[$policy];
+                }
+            }
+
+            $new_policies = new self();
+            $new_policies->policies = $out;
+
+            return $new_policies;
     }
 
     public function getPolicyDetails($policyID) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -293,7 +293,7 @@
 
     private $policy_id;
 
-    public function __construct($policy_id = NULL) {
+    public function __construct($policy_id = null) {
         $this->db = new \ParlDB;
 
         if ( $policy_id ) {

Spacing +5 added lines, -5 removed lines

@@ -296,7 +296,7 @@ 
     public function __construct($policy_id = NULL) {
         $this->db = new \ParlDB;
 
-        if ( $policy_id ) {
+        if ($policy_id) {
             $this->policy_id = $policy_id;
             $this->policies = array(
                 $policy_id => $this->policies[$policy_id]
@@ -380,8 +380,8 @@ 
                     // want to complain here if we're looking for that policy and
                     // it does not exist. Otherwise, if the single policy isn't in
                     // the set we want to return an empty set
-                    if ( !isset($this->policy_id) || $set_policy == $this->policy_id ) {
-                        throw new \Exception ('Policy ' . $set_policy . ' in set "' . $set . '" does not exist.');
+                    if (!isset($this->policy_id) || $set_policy == $this->policy_id) {
+                        throw new \Exception('Policy ' . $set_policy . ' in set "' . $set . '" does not exist.');
                     }
                 }
             }
@@ -392,7 +392,7 @@ 
             return $new_policies;
 
         } else {
-            throw new \Exception ('Policy set "' . $set . '" does not exist.');
+            throw new \Exception('Policy set "' . $set . '" does not exist.');
         }
     }
 
@@ -433,7 +433,7 @@ 
 
         $image = $q->field(0, 'image');
 
-        if ( $image && file_exists(BASEDIR . '/' . $image)) {
+        if ($image && file_exists(BASEDIR . '/' . $image)) {
             $props['image'] = $image;
             $props['image_license'] = $q->field(0, 'image_license');
             $props['image_attribution'] = $q->field(0, 'image_attrib');

Braces +2 added lines, -4 removed lines

@@ -366,14 +366,12 @@
     public function limitToSet($set) {
 
         // Sanity check the set exists
-        if (isset($this->sets[$set]))
-        {
+        if (isset($this->sets[$set])) {
             $out = array();
             // Reassemble the new policies list based on the set.
             foreach ($this->sets[$set] as $set_policy)
             {
-                if (isset($this->policies[$set_policy]))
-                {
+                if (isset($this->policies[$set_policy])) {
                     $out[$set_policy] = $this->policies[$set_policy];
                 } else {
                     // if we've limited the policies to a single one then we only

classes/Search.php

Switch Indentation +36 added lines, -36 removed lines

@@ -82,42 +82,42 @@
     private function prettify_search_section($section) {
         $name = '';
         switch ($section) {
-        case 'wrans':
-            $name = 'Written Answers';
-            break;
-        case 'uk':
-            $name = 'All UK';
-            break;
-        case 'debates':
-            $name = 'House of Commons debates';
-            break;
-        case 'whall':
-            $name = 'Westminster Hall debates';
-            break;
-        case 'lords':
-            $name = 'House of Lords debates';
-            break;
-        case 'wms':
-            $name = 'Written ministerial statements';
-            break;
-        case 'standing':
-            $name = 'Bill Committees';
-            break;
-        case 'future':
-            $name = 'Future Business';
-            break;
-        case 'ni':
-            $name = 'Northern Ireland Assembly Debates';
-            break;
-        case 'scotland':
-            $name = 'All Scotland';
-            break;
-        case 'sp':
-            $name = 'Scottish Parliament Debates';
-            break;
-        case 'spwrans':
-            $name = 'Scottish Parliament Written answers';
-            break;
+            case 'wrans':
+                $name = 'Written Answers';
+                break;
+            case 'uk':
+                $name = 'All UK';
+                break;
+            case 'debates':
+                $name = 'House of Commons debates';
+                break;
+            case 'whall':
+                $name = 'Westminster Hall debates';
+                break;
+            case 'lords':
+                $name = 'House of Lords debates';
+                break;
+            case 'wms':
+                $name = 'Written ministerial statements';
+                break;
+            case 'standing':
+                $name = 'Bill Committees';
+                break;
+            case 'future':
+                $name = 'Future Business';
+                break;
+            case 'ni':
+                $name = 'Northern Ireland Assembly Debates';
+                break;
+            case 'scotland':
+                $name = 'All Scotland';
+                break;
+            case 'sp':
+                $name = 'Scottish Parliament Debates';
+                break;
+            case 'spwrans':
+                $name = 'Scottish Parliament Written answers';
+                break;
         }
 
         return $name;

Spacing +16 added lines, -16 removed lines

@@ -19,7 +19,7 @@ 
         $this->searchstring = $argparser->construct_search_string();
         $this->searchkeyword = $argparser->searchkeyword;
 
-        if ( !$this->searchstring ) {
+        if (!$this->searchstring) {
             $data = $this->get_form_params($data);
             $data['searchstring'] = '';
             $data['template'] = 'search/results';
@@ -28,14 +28,14 @@ 
 
         $this->searchstring = filter_user_input($this->searchstring, 'strict');
         $warnings = $this->validate_search_string();
-        if ( $warnings ) {
+        if ($warnings) {
             $data['warnings'] = $warnings;
             $data['template'] = 'search/results';
             $data['searchstring'] = $this->searchstring;
             $data = $this->get_form_params($data);
             return $data;
         } else {
-            if (get_http_var('o')=='p') {
+            if (get_http_var('o') == 'p') {
                 $search = new Search\ByUsage();
                 $data = $search->search($this->searchstring);
                 $data['template'] = 'search/by-person';
@@ -52,7 +52,7 @@ 
             $data['person_name'] = $MEMBER->full_name();
         }
 
-        if ( isset($data['info']['spelling_correction']) ) {
+        if (isset($data['info']['spelling_correction'])) {
             $data['info']['spelling_correction_display'] = $this->prettifySearchString($data['info']['spelling_correction']);
         }
 
@@ -144,15 +144,15 @@ 
         $data['search_keyword'] = $this->searchkeyword;
 
         $is_adv = false;
-        foreach ( array('to', 'from', 'person', 'section', 'column', 'phrase', 'exclude' ) as $var ) {
+        foreach (array('to', 'from', 'person', 'section', 'column', 'phrase', 'exclude') as $var) {
             $key = "search_$var";
-            $data[$key] = get_http_var( $var );
-            if ( $data[$key] ) {
+            $data[$key] = get_http_var($var);
+            if ($data[$key]) {
                 $is_adv = true;
             }
         }
 
-        if ( isset($data['search_section']) ) {
+        if (isset($data['search_section'])) {
             $data['search_section_pretty'] = $this->prettify_search_section($data['search_section']);
         }
 
@@ -162,16 +162,16 @@ 
 
     private function set_wtt_options($data) {
         $data['wtt'] = '';
-        if ( $wtt = get_http_var('wtt') ) {
+        if ($wtt = get_http_var('wtt')) {
             $data['wtt'] = $wtt;
-            if ( $wtt == 2 && $pid = get_http_var('pid') ) {
+            if ($wtt == 2 && $pid = get_http_var('pid')) {
                 $data['pid'] = null;
                 try {
                     $lord = new Member(array('person_id' => $pid, 'house' => 2));
-                } catch ( MemberException $e ) {
+                } catch (MemberException $e) {
                     return $data;
                 }
-                if ( $lord->valid ) {
+                if ($lord->valid) {
                     $data['pid'] = $pid;
                     $data['wtt_lord_name'] = $lord->full_name();
                 }
@@ -196,11 +196,11 @@ 
             $url->insert(array('q' => $value));
         }
 
-        if ( $params ) {
-            if ( get_http_var('house') ) {
+        if ($params) {
+            if (get_http_var('house')) {
                 $url->insert(array('house' => get_http_var('house')));
             }
-            if ( get_http_var('wtt') ) {
+            if (get_http_var('wtt')) {
                 $url->insert(array('wtt' => get_http_var('wtt')));
             }
         } else {
@@ -214,7 +214,7 @@ 
         global $DATA, $this_page;
 
         $pagetitle = '';
-        if ( isset($data['search_type']) && $data['search_type'] == 'person' ) {
+        if (isset($data['search_type']) && $data['search_type'] == 'person') {
             if (isset($data['wtt']) && $data['wtt'] > 0) {
                 $pagetitle = 'League table of Lords who say ' . $data['pagetitle'];
             } else {

classes/Homepage.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     }
 
     protected function getRegionalList() {
-        return NULL;
+        return null;
     }
 
     protected function getEditorialContent() {

Spacing +10 added lines, -10 removed lines

@@ -57,14 +57,14 @@ 
         $gid = $featured->get_gid();
         $gidCheck = new Gid($gid);
         $gid = $gidCheck->checkForRedirect();
-        if ( $gid ) {
+        if ($gid) {
             $title = $featured->get_title();
             $context = $featured->get_context();
             $related = $featured->get_related();
             $item = $this->getFeaturedDebate($gid, $title, $context, $related);
         } else {
             $item = $debatelist->display('recent_debates', array('days' => 7, 'num' => 1), 'none');
-            if ( isset($item['data']) && count($item['data']) ) {
+            if (isset($item['data']) && count($item['data'])) {
                 $item = $item['data'][0];
                 $more_url = new Url('debates');
                 $item['more_url'] = $more_url->generate();
@@ -95,8 +95,8 @@ 
         $item['featured'] = true;
 
         $related_debates = array();
-        foreach ( $related as $related_gid ) {
-            if ( $related_gid ) {
+        foreach ($related as $related_gid) {
+            if ($related_gid) {
                 $related_item = $debatelist->display('featured_gid', array('gid' => $related_gid), 'none');
                 $related_debates[] = $related_item['data'];
             }
@@ -121,21 +121,21 @@ 
 
         $recent_content = array();
 
-        foreach ( $this->recent_types as $class => $recent ) {
+        foreach ($this->recent_types as $class => $recent) {
             $class = "\\$class";
             $instance = new $class();
             $more_url = new Url($recent[1]);
-            if ( $recent[0] == 'recent_pbc_debates' ) {
-                $content = array( 'data' => $instance->display($recent[0], array('num' => 5), 'none') );
+            if ($recent[0] == 'recent_pbc_debates') {
+                $content = array('data' => $instance->display($recent[0], array('num' => 5), 'none'));
             } else {
                 $content = $instance->display($recent[0], array('days' => 7, 'num' => 1), 'none');
-                if ( isset($content['data']) && count($content['data']) ) {
+                if (isset($content['data']) && count($content['data'])) {
                     $content = $content['data'][0];
                 } else {
                     $content = array();
                 }
             }
-            if ( $content ) {
+            if ($content) {
                 $content['more_url'] = $more_url->generate();
                 $content['desc'] = $recent[2];
                 $recent_content[] = $content;
@@ -154,7 +154,7 @@ 
             WHERE event_date >= :date
             AND deleted = 0
             ORDER BY event_date, chamber, pos",
-            array( ':date' => $date )
+            array(':date' => $date)
         );
 
         if (!$q->rows()) {

classes/Utility/Hansard.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 class Hansard
 {
     public static function get_gid_from_url($url) {
-        $gid = NULL;
+        $gid = null;
         $parts = parse_url($url);
         parse_str($parts['query'], $query);
 

Spacing +3 added lines, -3 removed lines

@@ -15,7 +15,7 @@ 
         $parts = parse_url($url);
         parse_str($parts['query'], $query);
 
-        if ( $query['id'] ) {
+        if ($query['id']) {
             if (strpos($parts['path'], 'lords') !== false) {
                 $gid = 'uk.org.publicwhip/lords/';
             } elseif (strpos($parts['path'], 'whall') !== false) {
@@ -30,13 +30,13 @@ 
 
 
     public static function gid_to_url($gid) {
-        if ( !$gid ) {
+        if (!$gid) {
             return '';
         }
         global $hansardmajors;
         $db = new \ParlDB();
 
-        $q = $db->query("SELECT major FROM hansard WHERE gid = :gid", array( ':gid' => $gid ));
+        $q = $db->query("SELECT major FROM hansard WHERE gid = :gid", array(':gid' => $gid));
         $url_gid = fix_gid_from_db($gid);
         $url = new \MySociety\TheyWorkForYou\Url($hansardmajors[$q->field(0, 'major')]['page']);
         $url->insert(array('id' => $url_gid));

classes/Utility/Gaze.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         if (defined('OPTION_GAZE_URL') && OPTION_GAZE_URL) {
             return gaze_get_country_from_ip($ip);
         } else {
-            return NULL;
+            return null;
         }
 
     }