mysociety / theyworkforyou

www/includes/easyparliament/templates/html/mp/profile.php

Braces +5 added lines, -2 removed lines

@@ -190,11 +190,14 @@
                         <?= $recent_appearances['additional_links'] ?>
                         <?php endif; ?>
 
-                    <?php else: ?>
+                    <?php else {
+    : ?>
 
                         <p>No recent appearances to display.</p>
 
-                    <?php endif; ?>
+                    <?php endif;
+}
+?>
 
                 </div>
                 <?php endif; ?>

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
                         <ul class="vote-descriptions">
                           <?php foreach ($sorted_diffs as $policy_id => $score) {
 
-                            $key_vote = NULL;
+                            $key_vote = null;
                             $description = sprintf(
                                 '%s <b>%s</b> %s, while most %s MPs <b>%s</b>.',
                                 $full_name,

Indentation +5 added lines, -5 removed lines

@@ -85,7 +85,7 @@ 
 
                             include '_vote_description.php';
 
-                          } ?>
+                            } ?>
                         </ul>
 
                         <p>We have <b>lots more</b> plain English analysis of <?= $full_name ?>&rsquo;s voting record  on issues like health, welfare, taxation and more. Visit <a href="<?= $member_url ?>/votes"><?= $full_name ?>&rsquo;s full vote analysis page</a> for more.</p>
@@ -125,7 +125,7 @@ 
 
                             include '_vote_description.php';
 
-                          } ?>
+                            } ?>
                         </ul>
 
                         <p>We have <b>lots more</b> plain English analysis of <?= $full_name ?>&rsquo;s voting record  on issues like health, welfare, taxation and more. Visit <a href="<?= $member_url ?>/votes"><?= $full_name ?>&rsquo;s full vote analysis page</a> for more.</p>
@@ -154,7 +154,7 @@ 
 
                             include '_vote_description.php';
 
-                          } ?>
+                            } ?>
                         </ul>
 
                         <p>We have <b>lots more</b> plain English analysis of <?= $full_name ?>&rsquo;s voting record  on issues like health, welfare, taxation and more. Visit <a href="<?= $member_url ?>/votes"><?= $full_name ?>&rsquo;s full vote analysis page</a> for more.</p>
@@ -416,7 +416,7 @@ 
                         <a href="http://www.publicwhip.org.uk/mp.php?id=uk.org.publicwhip/member/<?= $member_id ?>&amp;showall=yes">Public Whip</a>.</p>
 
                   <?php if($image && $image['exists']) {
-                      if(isset($data['photo_attribution_text'])) { ?>
+                        if(isset($data['photo_attribution_text'])) { ?>
                     <p>
                       <?php if(isset($data['photo_attribution_link'])) { ?>
                         Profile photo:
@@ -426,7 +426,7 @@ 
                       <?php } ?>
                     </p>
                   <?php }
-                  } else { ?>
+                    } else { ?>
                     <p>
                         We&rsquo;re missing a photo of <?= $full_name ?>.
                         If you have a photo <em>that you can release under

Spacing +6 added lines, -6 removed lines

@@ -64,7 +64,7 @@ 
                 </div>
               <?php endif; ?>
 
-                <?php if ( !$current_member[HOUSE_TYPE_COMMONS] ) { ?>
+                <?php if (!$current_member[HOUSE_TYPE_COMMONS]) { ?>
                     <?php if (count($policyPositions->positions) > 0) { ?>
                     <div class="panel">
                         <a name="votes"></a>
@@ -130,7 +130,7 @@ 
 
                         <p>We have <b>lots more</b> plain English analysis of <?= $full_name ?>&rsquo;s voting record  on issues like health, welfare, taxation and more. Visit <a href="<?= $member_url ?>/votes"><?= $full_name ?>&rsquo;s full vote analysis page</a> for more.</p>
 
-                    <?php elseif (count($policyPositions->positions) > 0 ): ?>
+                    <?php elseif (count($policyPositions->positions) > 0): ?>
                         <?php if (count($party_positions) && $party_member_count > 1) { ?>
                         <p>
                         <?= $full_name ?> is a <?= $party ?> MP, and on the <b>vast majority</b> of issues votes the <b>same way</b> as other <?= $party ?> MPs.
@@ -158,7 +158,7 @@ 
                         </ul>
 
                         <p>We have <b>lots more</b> plain English analysis of <?= $full_name ?>&rsquo;s voting record  on issues like health, welfare, taxation and more. Visit <a href="<?= $member_url ?>/votes"><?= $full_name ?>&rsquo;s full vote analysis page</a> for more.</p>
-                    <?php elseif (count($policyPositions->positions) == 0 ): ?>
+                    <?php elseif (count($policyPositions->positions) == 0): ?>
 
                         <p>No votes to display.</p>
 
@@ -415,10 +415,10 @@ 
                         of sources. Voting information from
                         <a href="http://www.publicwhip.org.uk/mp.php?id=uk.org.publicwhip/member/<?= $member_id ?>&amp;showall=yes">Public Whip</a>.</p>
 
-                  <?php if($image && $image['exists']) {
-                      if(isset($data['photo_attribution_text'])) { ?>
+                  <?php if ($image && $image['exists']) {
+                      if (isset($data['photo_attribution_text'])) { ?>
                     <p>
-                      <?php if(isset($data['photo_attribution_link'])) { ?>
+                      <?php if (isset($data['photo_attribution_link'])) { ?>
                         Profile photo:
                         <a href="<?= $data['photo_attribution_link'] ?>"><?= $data['photo_attribution_text'] ?></a>
                       <?php } else { ?>

www/includes/easyparliament/templates/html/mp/_vote_description.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <li>
     <?= $description ?>
-    <?php if ( $show_link ) { ?>
+    <?php if ($show_link) { ?>
         <a class="vote-description__source" href="<?= $link ?>">Show votes</a>
         <?php if (isset($key_vote)) { ?>
         <a class="vote-description__evidence" href="<?= $link ?>"><?= $key_vote['summary'] ?></a>

www/includes/easyparliament/templates/html/mp/votes_svg.php

Indentation +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
     echo '<?xml version="1.0" encoding="iso-8859-1"?>';
 
- ?>
+    ?>
 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
 <svg width="1000" height="500" viewBox="0 0 1000 500" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" font-family="Droid Sans, Trebuchet">
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     <text font-size="24" font-weight="normal" fill="#000000">
         <?php foreach ($lines as $j=>$line) { ?>
             <tspan x="40" y="<?= $stance_y + $stance_padding_top + $stance_baseline_offset + ($stance_lineheight * $j) ?>"><?php
-                if (strpos($line, '*') !== False) {
+                if (strpos($line, '*') !== false) {
                     echo preg_replace(
                         '#(?:^|[*])([^\r\n *][^*\n]*[^\r\n *])(?:$|[*])#i',
                         $tspan_bold_open . '$1' . $tspan_bold_close,

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
     $stances = array();
 
     foreach ($segment['votes']->positions as $key_vote) {
-        if ( $key_vote['has_strong'] || $key_vote['position'] == 'has never voted on' ) {
+        if ($key_vote['has_strong'] || $key_vote['position'] == 'has never voted on') {
             $stance = strip_tags($key_vote['desc'], '<b>');
             $stance = ucfirst($stance);
             $stance = preg_replace('#</?b>#i', '*', $stance);

www/includes/easyparliament/templates/html/alert/index.php

Indentation +9 added lines, -9 removed lines

@@ -122,25 +122,25 @@ 
       <?php } ?>
 
       <?php
-          if(
-              (isset($members) && $members->rows() > 0) ||
+            if(
+                (isset($members) && $members->rows() > 0) ||
               (isset($constituencies) && count($constituencies) > 0) ||
               ($alertsearch)
-          ) {
-              /* We need to disambiguate the user's instructions */
-              $member_options = false;
-      ?>
+            ) {
+                /* We need to disambiguate the user's instructions */
+                $member_options = false;
+        ?>
         <div class="alert-section alert-section--disambiguation">
             <div class="alert-section__primary">
 
               <?php if (isset($members) && $members->rows() > 0) {
-                  $member_options = true; ?>
+                    $member_options = true; ?>
                 <h3>Sign up for alerts when people matching <i><?= _htmlspecialchars($alertsearch) ?></i> speaks</h3>
                 <ul>
                   <?php
                     $q = $members;
                     for ($n=0; $n<$q->rows(); $n++) {
-                  ?>
+                    ?>
                     <li>
                         <form action="<?= $actionurl ?>" method="post">
                             <input type="hidden" name="t" value="<?= _htmlspecialchars($token) ?>">
@@ -160,7 +160,7 @@ 
               <?php } ?>
 
               <?php if (isset($constituencies) && count($constituencies) > 0) {
-                  $member_options = true; ?>
+                    $member_options = true; ?>
                 <h3>Sign up for alerts when MPs for constituencies matching <i><?= _htmlspecialchars($alertsearch) ?></i> speaks</h3>
                 <ul>
                 <?php foreach ($constituencies as $constituency => $member) { ?>

Spacing +21 added lines, -21 removed lines

@@ -1,7 +1,7 @@ 
 <div class="full-page">
     <div class="full-page__row">
 
-      <?php if ( $message ) { ?>
+      <?php if ($message) { ?>
         <div class="alert-section alert-section--feedback">
             <div class="alert-section__primary">
                 <h3><?= $message['title'] ?></h3>
@@ -12,10 +12,10 @@ 
         </div>
       <?php } ?>
 
-      <?php if ( $results ) { ?>
+      <?php if ($results) { ?>
         <div class="alert-section alert-section--feedback">
             <div class="alert-section__primary">
-              <?php if ( $results == 'alert-confirmed' ) { ?>
+              <?php if ($results == 'alert-confirmed') { ?>
                 <h3>Your alert has been confirmed</h3>
                 <p>
                     You will now receive email alerts for the following criteria:
@@ -45,32 +45,32 @@ 
                 </div>
                 </noscript>
 
-              <?php } elseif ( $results == 'alert-suspended' ) { ?>
+              <?php } elseif ($results == 'alert-suspended') { ?>
                 <h3>Alert suspended</h3>
                 <p>
                     You can reactivate the alert at any time, from the sidebar below.
                 </p>
 
-              <?php } elseif ( $results == 'alert-resumed' ) { ?>
+              <?php } elseif ($results == 'alert-resumed') { ?>
                 <h3>Alert resumed</h3>
                 <p>
                     You will now receive email alerts on any day when there
                     are entries in Hansard that match your criteria.
                 </p>
 
-              <?php } elseif ( $results == 'alert-deleted' ) { ?>
+              <?php } elseif ($results == 'alert-deleted') { ?>
                 <h3>Alert deleted</h3>
                 <p>
                     You will no longer receive this alert.
                 </p>
 
-              <?php } elseif ( $results == 'all-alerts-deleted' ) { ?>
+              <?php } elseif ($results == 'all-alerts-deleted') { ?>
                 <h3>All alerts deleted</h3>
                 <p>
                     You will no longer receive any alerts.
                 </p>
 
-              <?php } elseif ( $results == 'alert-fail' ) { ?>
+              <?php } elseif ($results == 'alert-fail') { ?>
                 <h3>Hmmm, something&rsquo;s not right</h3>
                 <p>
                     The link you followed to reach this page appears to be incomplete.
@@ -86,14 +86,14 @@ 
                     and let us know, and we'll help out!
                 </p>
 
-              <?php } elseif ( $results == 'alert-added' ) { ?>
+              <?php } elseif ($results == 'alert-added') { ?>
                 <h3>Your alert has been added</h3>
                 <p>
                     You will now receive email alerts on any day when
                     <?= _htmlspecialchars($criteria) ?> in parliament.
                 </p>
 
-              <?php } elseif ( $results == 'alert-confirmation' ) { ?>
+              <?php } elseif ($results == 'alert-confirmation') { ?>
                 <h3>We&rsquo;re nearly done&hellip;</h3>
                 <p>
                     You should receive an email shortly which will contain a link.
@@ -101,20 +101,20 @@ 
                     and receive future alerts. Thanks.
                 </p>
 
-              <?php } elseif ( $results == 'alert-exists' ) { ?>
+              <?php } elseif ($results == 'alert-exists') { ?>
                 <h3>You&rsquo;re already subscribed to that!</h3>
                 <p>
                     It&rsquo;s good to know you&rsquo;re keen though.
                 </p>
 
-              <?php } elseif ( $results == 'alert-already-signed' ) { ?>
+              <?php } elseif ($results == 'alert-already-signed') { ?>
                 <h3>We&rsquo;re nearly done</h3>
                 <p>
                     You should receive an email shortly which will contain a link.
                     You will need to follow that link to confirm your email address to receive the alert. Thanks.
                 </p>
 
-              <?php } elseif ( $results == 'alert-fail' ) { ?>
+              <?php } elseif ($results == 'alert-fail') { ?>
                 <h3>Alert could not be created</h3>
                 <p>
                     Sorry, we were unable to create that alert. Please
@@ -128,7 +128,7 @@ 
       <?php } ?>
 
       <?php
-          if(
+          if (
               (isset($members) && $members->rows() > 0) ||
               (isset($constituencies) && count($constituencies) > 0) ||
               ($alertsearch)
@@ -145,7 +145,7 @@ 
                 <ul>
                   <?php
                     $q = $members;
-                    for ($n=0; $n<$q->rows(); $n++) {
+                    for ($n = 0; $n < $q->rows(); $n++) {
                   ?>
                     <li>
                         <form action="<?= $actionurl ?>" method="post">
@@ -153,7 +153,7 @@ 
                             <input type="hidden" name="email" value="<?= _htmlspecialchars($email) ?>">
                             <input type="hidden" name="pid" value="<?= $q->field($n, 'person_id') ?>">
                             When
-                            <?= member_full_name($q->field($n, 'house'), $q->field($n, 'title'), $q->field($n, 'given_name'), $q->field($n, 'family_name'), $q->field($n, 'lordofname') ) ?>
+                            <?= member_full_name($q->field($n, 'house'), $q->field($n, 'title'), $q->field($n, 'given_name'), $q->field($n, 'family_name'), $q->field($n, 'lordofname')) ?>
                             <?php if ($q->field($n, 'constituency')) { ?>
                                 (<?= $q->field($n, 'constituency') ?>)
                             <?php } ?>
@@ -184,7 +184,7 @@ 
               <?php } ?>
 
               <?php if ($alertsearch) {
-                if ( $member_options ) { ?>
+                if ($member_options) { ?>
                 <h3>Sign up for alerts for topics</h3>
                 <?php } else { ?>
                 <h3>Great! Can you just confirm what you mean?</h3>
@@ -198,7 +198,7 @@ 
                             Receive alerts when <?= _htmlspecialchars($alertsearch_pretty) ?>
                             <input type="submit" class="button small" value="Subscribe">
                         </form>
-                      <?php if ( isset($mistakes['multiple']) ) { ?>
+                      <?php if (isset($mistakes['multiple'])) { ?>
                         <em class="error">
                             You have used a comma in your search term &ndash;
                             are you sure this is what you want? You cannot
@@ -207,7 +207,7 @@ 
                             for each individual term.
                         </em>
                       <?php } ?>
-                      <?php if ( isset($mistakes['postcode_and']) ) { ?>
+                      <?php if (isset($mistakes['postcode_and'])) { ?>
                         <em class="error">
                             You have used a postcode and something else in your
                             search term &ndash; are you sure this is what you
@@ -256,11 +256,11 @@ 
             <div class="alert-section__secondary">
               <?php if ($email_verified) { ?>
 
-                  <?php if ( $alerts ) { ?>
+                  <?php if ($alerts) { ?>
                     <?php include('_list.php'); ?>
                   <?php } ?>
 
-                  <?php if ( $current_mp ) { ?>
+                  <?php if ($current_mp) { ?>
                     <h3>Your MP alert</h3>
                     <ul class="alerts-manage__list">
                         <li>

www/includes/easyparliament/templates/html/homepage/featured.php

Spacing +6 added lines, -6 removed lines

@@ -1,8 +1,8 @@ 
-                        <?php if ( $featured['featured'] ) { ?>
+                        <?php if ($featured['featured']) { ?>
                         <h2>In the news</h2>
-                        <?php if ( isset($featured['headline']) ) { ?>
+                        <?php if (isset($featured['headline'])) { ?>
                         <h3 class="in-the-news__topic"><a href="<?= $featured['list_url'] ?>"><?= $featured['headline'] ?></a></h3>
-                        <?php if ( isset($featured['context']) ) { ?>
+                        <?php if (isset($featured['context'])) { ?>
                         <p class="in-the-news__context"><?= $featured['context'] ?></p>
                         <?php } ?>
                         <?php } ?>
@@ -15,21 +15,21 @@ 
                             <p class="meta excerpt__category"><a href="<?= $featured['more_url'] ?>"><?= $featured['desc'] ?></a></p>
                             <p class="excerpt__statement">
                                 <q>
-                                <?php if ( $featured['child']['speaker'] ) { ?>
+                                <?php if ($featured['child']['speaker']) { ?>
                                 <a href="<?= $featured['child']['speaker']['url'] ?>"><?= $featured['child']['speaker']['name'] ?></a> :
                                 <?php } ?>
                                 <?= trim_characters($featured['child']['body'], 0, 200) ?>
                                 </q>
                             </p>
                         </div>
-                        <?php if ( count($featured['related']) ) { ?>
+                        <?php if (count($featured['related'])) { ?>
                         <div class="in-the-news__key-events">
                             <!-- No maximum, but less than 4 looks best -->
                             <ul class="key-events__list">
                                 <li>
                                     <h4>Key events</h4>
                                 </li>
-                                <?php foreach ( $featured['related'] as $related ) { ?>
+                                <?php foreach ($featured['related'] as $related) { ?>
                                  <li>
                                      <a href="<?= $related['list_url'] ?>"><?= $related['parent']['body'] ?></a>
                                     <p class="meta"><?= format_date($related['hdate'], SHORTDATEFORMAT) ?></p>

www/includes/easyparliament/templates/html/section/_business_list.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
         <div class="business-section__primary">
             <ul class="business-list">
-              <?php foreach ( $data as $item ) { ?>
+              <?php foreach ($data as $item) { ?>
                 <li>
                     <?php include '_business_list_item.php'; ?>
                 </li>

www/includes/easyparliament/templates/html/section/year.php

Indentation +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
                 foreach ( $years as $year => $months ) { ?>
             <div class="calendar-year">
                 <?php foreach ($months as $month => $dates) {
-                  include '_calendar.php';
+                    include '_calendar.php';
                 } ?>
             </div>
             <?php }

Spacing +4 added lines, -4 removed lines

@@ -8,20 +8,20 @@
         </div>
         <div class="business-section__solo">
             <div class="calendar__controls">
-                <?php if ( isset( $prev ) ) { ?>
+                <?php if (isset($prev)) { ?>
                 <a href="<?= $prev['url'] ?>" class="calendar__controls__previous">&larr; <?= $prev['title'] ?></a>
                 <?php } else { ?>
                 <span class="calendar__controls__previous"></span>
                 <?php } ?>
                 <span class="calendar__controls__current"><?= $year ?></span>
-                <?php if ( isset( $next ) ) { ?>
+                <?php if (isset($next)) { ?>
                 <a href="<?= $next['url'] ?>" class="calendar__controls__next"><?= $next['title'] ?> &rarr;</a>
                 <?php } else { ?>
                 <span class="calendar__controls__next"></span>
                 <?php } ?>
             </div>
-            <?php if ( isset($years) ) {
-                foreach ( $years as $year => $months ) { ?>
+            <?php if (isset($years)) {
+                foreach ($years as $year => $months) { ?>
             <div class="calendar-year">
                 <?php foreach ($months as $month => $dates) {
                   include '_calendar.php';

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -34,6 +34,6 @@
         </div>
     </div>
 
-    <?php $search_title = "Search $title"; include '_search.php'; ?>
+    <?php $search_title = "search $title"; include '_search.php'; ?>
 
 </div>

www/includes/easyparliament/templates/html/section/pbc_index.php

Spacing +2 added lines, -2 removed lines

@@ -22,14 +22,14 @@
 
         <div class="business-section__primary">
             <ul class="business-list">
-                <?php foreach ( $content['data'] as $date => $bills ) { ?>
+                <?php foreach ($content['data'] as $date => $bills) { ?>
                 <li>
                     <span class="business-list__title">
                         <h3>
                             <?= $date ?>
                         </h3>
                     </span>
-                    <?php foreach ( $bills as $bill ) { ?>
+                    <?php foreach ($bills as $bill) { ?>
                     <p>
                     <a href="<?= $bill['url'] ?>" class="business-list__title">
                         <?= $bill['bill'] ?> &ndash; <?= $bill['sitting'] ?>

www/includes/easyparliament/templates/html/section/_calendar_section.php

Indentation +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
             <?php
             foreach ( $calendar as $year => $months ) {
                 foreach ($months as $month => $dates) {
-                     include '_calendar.php';
+                        include '_calendar.php';
                 }
             } ?>

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
             <?php
-            foreach ( $calendar as $year => $months ) {
+            foreach ($calendar as $year => $months) {
                 foreach ($months as $month => $dates) {
                      include '_calendar.php';
                 }