mysociety / theyworkforyou

www/docs/mp/index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
 // Basic name, title and description
 $member_name = ucfirst($MEMBER->full_name());
 $title = $member_name;
-$desc = "Read $member_name's contributions to Parliament, including speeches and questions";
+$desc = "read $member_name's contributions to Parliament, including speeches and questions";
 
 // Enhance description if this is a current member
 if ($MEMBER->current_member_anywhere()) {

Spacing +12 added lines, -12 removed lines

@@ -414,7 +414,7 @@ 
                 'health', 'education', 'reform', 'home', 'environment',
                 'transport', 'housing', 'justice', 'misc',
             ];
-            $sets = array_filter($sets, function ($v) use ($set_descriptions) {
+            $sets = array_filter($sets, function($v) use ($set_descriptions) {
                 return array_key_exists($v, $set_descriptions);
             });
             shuffle($sets);
@@ -656,7 +656,7 @@ 
 function person_error_page($message) {
     global $this_page;
     $SEARCHURL = '';
-    switch($this_page) {
+    switch ($this_page) {
         case 'peer':
             $people = new MySociety\TheyWorkForYou\People\Peers();
             $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
@@ -844,16 +844,16 @@ 
     $recent_speeches = $memcache->get($speeches_key);
 
     if (!$recent_speeches) {
-        $searchstring_speeches = "speaker:$person_id -section:wrans";  // Exclude written answers section
+        $searchstring_speeches = "speaker:$person_id -section:wrans"; // Exclude written answers section
         $SEARCHENGINE = new \SEARCHENGINE($searchstring_speeches);
 
         // Search query excluding written questions
         $args_speeches = [
             's' => $searchstring_speeches,
-            'p' => 1,                       // First page
-            'num' => 8,                     // 8 recent speeches/debates
-            'pop' => 1,                     // Disable search logging
-            'o' => 'd',                     // Decending by date order
+            'p' => 1, // First page
+            'num' => 8, // 8 recent speeches/debates
+            'pop' => 1, // Disable search logging
+            'o' => 'd', // Decending by date order
         ];
         $results_speeches = $hansard->search($searchstring_speeches, $args_speeches);
         $recent_speeches = serialize($results_speeches['rows'] ?? []);
@@ -866,7 +866,7 @@ 
     $recent_wrans = $memcache->get($wrans_key);
 
     if (!$recent_wrans) {
-        $searchstring_wrans = "speaker:$person_id section:wrans";  // Only written answers section
+        $searchstring_wrans = "speaker:$person_id section:wrans"; // Only written answers section
         $SEARCHENGINE = new \SEARCHENGINE($searchstring_wrans);
 
         // Search query for written questions only
@@ -1191,7 +1191,7 @@ 
 
     $lang = LANGUAGE;
 
-    $reg = ['chamber_registers' => [] ];
+    $reg = ['chamber_registers' => []];
 
     foreach ($valid_chambers as $chamber) {
         $key = 'person_regmem_' . $chamber . '_' . $lang;
@@ -1206,7 +1206,7 @@ 
     }
 
     // sort chamber registers by published_date
-    uasort($reg['chamber_registers'], function ($a, $b) {
+    uasort($reg['chamber_registers'], function($a, $b) {
         return $a->published_date <=> $b->published_date;
     });
 
@@ -1300,8 +1300,8 @@ 
         }
     }
 
-    foreach($mreg as $reg) {
-        $data['members'][] =  [
+    foreach ($mreg as $reg) {
+        $data['members'][] = [
             'url' => '/' . $rep_type . '/?p=' . $reg['person_id'],
             'name' => $reg['given_name'] . ' ' . $reg['family_name'],
         ];

www/docs/api/api_convertURL.php

Spacing +2 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
     $LISTURL = new \MySociety\TheyWorkForYou\Url($hansardmajors[$id_data['major']]['page_all']);
     $fragment = '';
     if ($id_data['htype'] == '11' || $id_data['htype'] == '10') {
-        $LISTURL->insert([ 'id' => $id_data['gid'] ]);
+        $LISTURL->insert(['id' => $id_data['gid']]);
     } else {
         $parent_epobject_id = $id_data['subsection_id'];
         $parent_gid = '';
@@ -55,7 +55,7 @@ 
             $parent_gid = fix_gid_from_db($r['gid']);
         }
         if ($parent_gid != '') {
-            $LISTURL->insert([ 'id' => $parent_gid ]);
+            $LISTURL->insert(['id' => $parent_gid]);
             $fragment = '#g' . gid_to_anchor($id_data['gid']);
         }
     }

www/docs/api/api_getConstituencies.php

Spacing +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
             );
         }
     }
-    usort($out, function ($a, $b) {
+    usort($out, function($a, $b) {
         if ($a['distance'] > $b['distance']) {
             return 1;
         }

www/docs/api/api_getPerson.php

Spacing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
         if ($constituencies == 'CONNECTION_TIMED_OUT') {
             api_error('Connection timed out');
         } elseif ($types && isset($constituencies[$types[0]])) {
-            $constituencies = array_map(function ($c) use ($constituencies) { return $constituencies[$c]; }, $types);
+            $constituencies = array_map(function($c) use ($constituencies) { return $constituencies[$c]; }, $types);
             _api_getPerson_constituency($constituencies, $house);
         } elseif ($types && isset($constituencies['WMC'])) {
             api_error('Postcode not in correct region');

www/docs/calendar/index.php

Spacing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
     foreach ($data['order'] as &$chamber) {
         if (in_array($chamber['major'] ?? 0, $majors)) {
             $URL = new \MySociety\TheyWorkForYou\Url($hansardmajors[$chamber['major']]['page_all']);
-            $URL->insert([ 'd' => $date ]);
+            $URL->insert(['d' => $date]);
             $chamber['url'] = $URL->generate();
         }
     }
@@ -110,7 +110,7 @@ 
     [$firstyear, $firstmonth, $day] = explode('-', $min_future_date);
     [$finalyear, $finalmonth, $day] = explode('-', $max_future_date);
 
-    $q =  $db->query("SELECT DISTINCT(event_date) AS event_date FROM future
+    $q = $db->query("SELECT DISTINCT(event_date) AS event_date FROM future
         WHERE event_date >= :firstdate
         AND event_date <= :finaldate
         AND deleted = 0

www/docs/user/login/index.php

Spacing +2 added lines, -2 removed lines

@@ -19,14 +19,14 @@
 if (get_http_var("submitted") == "true") {
     // Form has been submitted, so check input.
 
-    $email 		= get_http_var("email");
+    $email = get_http_var("email");
     $password 	= get_http_var("password");
     $remember 	= get_http_var("remember");
 
     // The user may have tried to do something that requires being logged in.
     // In which case we should arrive here with that page's URL in 'ret'.
     // We can then send the user there after log in.
-    $returnurl 	= get_http_var("ret");
+    $returnurl = get_http_var("ret");
 
     $errors = [];
 

scripts/alertmailer.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -469,7 +469,7 @@
 
     $text .= '====================';
     $sentemails++;
-    mlog("SEND $sentemails : Sending email to $current[email] ... ");
+    mlog("send $sentemails : Sending email to $current[email] ... ");
     $d = ['to' => $current['email'], 'template' => $template];
     $m = [
         'DATA' => $text,

scripts/alertgonemps.php

Braces +2 added lines, -1 removed lines

@@ -166,7 +166,8 @@
         $success = send_template_email($d, $m, true);
         mlog("sent ... ");
         # sleep if time between sending mails is less than a certain number of seconds on average
-        if (((time() - $start_time) / $sentemails) < 0.5) { # number of seconds per mail not to be quicker than
+        if (((time() - $start_time) / $sentemails) < 0.5) {
+# number of seconds per mail not to be quicker than
             mlog("pausing ... ");
             sleep(1);
         }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -154,7 +154,7 @@
     global $globalsuccess, $sentemails, $nomail, $start_time;
 
     $sentemails++;
-    mlog("SEND $sentemails : Sending email to $current[email] ... ");
+    mlog("send $sentemails : Sending email to $current[email] ... ");
     $d = ['to' => $current['email'], 'template' => $template];
     $m = [
         'DATA' => join("\n", $data),

scripts/mprss.php

Braces +2 added lines, -1 removed lines

@@ -106,7 +106,8 @@
     // Write the text to the file...
     $filename = $rsspath . $person_id . '.rdf';
     $fh = @fopen($filename, "w");
-    if (!$fh) { # Problem writing, just carry on
+    if (!$fh) {
+# Problem writing, just carry on
         echo "Could not write to file ($filename)\n";
         continue;
     }

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 foreach ($q as $person) {
     $person_id = $person['person_id'];
 
-    $args =  [ 'person_id' => $person_id ];
+    $args = ['person_id' => $person_id];
     $speeches = $HANSARDLIST->display('person', $args, 'none');
 
     // Some data about this person that we'll need for the feed.