AtoZView::get_next_prev() - Code Metrics - Inspection of "remove unused glossary functions" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1d068a...ac1bb1 )

by Struan

created 2025-10-09 10:04 UTC

AtoZView::get_next_prev() A

↳ Parent: AtoZView

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	15
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	21
rs	9.7666

<?php

namespace MySociety\TheyWorkForYou\GlossaryView;

class AtoZView extends BaseView {
    public function display(): array {
        $data = [
            'template_name' => 'atoz',
            'this_page' => 'glossary',
        ];


        $az = filter_input(INPUT_GET, 'az', FILTER_VALIDATE_REGEXP, ['options' => ['default' => 'A', 'regexp' => '#^[A-Z]$#']]);

        $data['letter'] = $az;

        if ($this->has_edit_access()) {
            $url = new \MySociety\TheyWorkForYou\Url('glossary_addterm');
            $data['add_url'] = $url->generate('url');
        }

        $glossary = new \GLOSSARY(['sort' => 'regexp_replace']);
        $glossary->current_letter = $az;

        $data['page_title'] = $az . ': Glossary Index';
        $data['glossary'] = $glossary;
        return $data;
    }

    private function get_next_prev($glossary): array {

        $url = new \MySociety\TheyWorkForYou\Url('glossary');
        $url->insert(['gl' => $glossary->previous_term['glossary_id']]);
        $previous_link = $url->generate('url');
        $url->insert(['gl' => $glossary->next_term['glossary_id']]);
        $next_link = $url->generate('url');

        $nextprev =  [
            'next'	=>  [
                'url'	=> $next_link,
                'title'	=> 'Next term',
                'body'	=> $glossary->next_term['title'],
            ],
            'prev'	=>  [
                'url'	=> $previous_link,
                'title'	=> 'Previous term',
                'body'	=> $glossary->previous_term['title'],
            ],
        ];

        return $nextprev;
    }
}


1			<?php
2
3			namespace MySociety\TheyWorkForYou\GlossaryView;
4
5			class AtoZView extends BaseView {
6			public function display(): array {
7			$data = [
8			'template_name' => 'atoz',
9			'this_page' => 'glossary',
10			];
11
12
13			$az = filter_input(INPUT_GET, 'az', FILTER_VALIDATE_REGEXP, ['options' => ['default' => 'A', 'regexp' => '#^[A-Z]$#']]);
14
15			$data['letter'] = $az;
16
17			if ($this->has_edit_access()) {
18			$url = new \MySociety\TheyWorkForYou\Url('glossary_addterm');
19			$data['add_url'] = $url->generate('url');
20			}
21
22			$glossary = new \GLOSSARY(['sort' => 'regexp_replace']);
23			$glossary->current_letter = $az;
24
25			$data['page_title'] = $az . ': Glossary Index';
26			$data['glossary'] = $glossary;
27			return $data;
28			}
29
30			private function get_next_prev($glossary): array {
			0 ignored issues – show Unused Code introduced 2025-10-07 13:27 UTC by Report Bug Copy Issue Report The method `get_next_prev()` is not used, and could be removed. This check looks for private methods that have been defined, but are not used inside the class. Loading history...
31			$url = new \MySociety\TheyWorkForYou\Url('glossary');
32			$url->insert(['gl' => $glossary->previous_term['glossary_id']]);
33			$previous_link = $url->generate('url');
34			$url->insert(['gl' => $glossary->next_term['glossary_id']]);
35			$next_link = $url->generate('url');
36
37			$nextprev = [
38			'next' => [
39			'url' => $next_link,
40			'title' => 'Next term',
41			'body' => $glossary->next_term['title'],
42			],
43			'prev' => [
44			'url' => $previous_link,
45			'title' => 'Previous term',
46			'body' => $glossary->previous_term['title'],
47			],
48			];
49
50			return $nextprev;
51			}
52			}
53

mysociety / theyworkforyou

Push — master ( 1d068a...ac1bb1 )

AtoZView::get_next_prev() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like