mysociety / theyworkforyou

www/docs/admin/badusers.php

Spacing +9 added lines, -9 removed lines

@@ -1,7 +1,7 @@ 
 <?php
 
 include_once '../../includes/easyparliament/init.php';
-include_once (INCLUDESPATH."easyparliament/commentreportlist.php");
+include_once (INCLUDESPATH . "easyparliament/commentreportlist.php");
 
 $this_page = "admin_badusers";
 
@@ -42,7 +42,7 @@ 
 
     $totalcomments = $r['totalcount'];
 
-    $percentagedeleted = ( $row['deletedcount'] / $totalcomments ) * 100;
+    $percentagedeleted = ($row['deletedcount'] / $totalcomments) * 100;
 
 
     // Get complaints made about this user's comments, but not upheld.
@@ -57,17 +57,17 @@ 
 
     $USERURL->insert(array('u'=>$user_id));
 
-    $rows[] = array (
+    $rows[] = array(
         '<a href="' . $USERURL->generate() . '">' . $row['firstname'] . ' ' . $row['lastname'] . '</a>',
         $totalcomments,
         $row['deletedcount'],
-        $percentagedeleted.'%',
+        $percentagedeleted . '%',
         $notupheldcount
     );
 }
 
-$tabledata = array (
-    'header' => array (
+$tabledata = array(
+    'header' => array(
         'Name',
         'Total comments',
         'Number deleted',
@@ -114,15 +114,15 @@ 
                     WHERE	user_id = '$user_id'
                     AND		upheld = '1'")->first();
 
-    $rows[] = array (
+    $rows[] = array(
         '<a href="' . $USERURL->generate() . '">' . $row['firstname'] . ' ' . $row['lastname'] . '</a>',
         $row['rejectedcount'],
         $r['upheldcount']
     );
 
 }
-$tabledata = array (
-    'header' => array (
+$tabledata = array(
+    'header' => array(
         'Name',
         'Reports not upheld',
         'Reports upheld'

www/docs/admin/reporting_stats.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 
 $PAGE->page_start();
 $PAGE->stripe_start();
-$PAGE->block_start(array ('id'=>'alerts', 'title'=>'Reporting Statistics'));
+$PAGE->block_start(array('id'=>'alerts', 'title'=>'Reporting Statistics'));
 $db = new ParlDB;
 $q = $db->query('select year(created) as the_year, month(created) as the_month, count(*) as c from alerts where confirmed and not deleted group by year(created) desc, month(created) desc');
 print '<h3>Alert signups per month</h3> <table>';

www/docs/admin/alert_stats.php

Spacing +13 added lines, -13 removed lines

@@ -7,7 +7,7 @@ 
 
 $PAGE->page_start();
 $PAGE->stripe_start();
-$PAGE->block_start(array ('id'=>'alerts', 'title'=>'Alert Statistics'));
+$PAGE->block_start(array('id'=>'alerts', 'title'=>'Alert Statistics'));
 $db = new ParlDB;
 
 $q_confirmed = $db->query('select count(*) as c from alerts where confirmed and not deleted')->first()['c'];
@@ -18,13 +18,13 @@ 
 
 print '<h3>Headline stats</h3> <table>';
 $data = array(
-    'header' => array( 'Alert Type', 'Count' ),
+    'header' => array('Alert Type', 'Count'),
     'rows' => array(
-        array( 'Confirmed', $q_confirmed ),
-        array( 'Not Confirmed', $q_not_confirmed ),
-        array( 'Deleted', $q_deleted ),
-        array( 'For a Speaker<sup>*</sup>', $q_speaker ),
-        array( 'For a Keyword', $q_keyword ),
+        array('Confirmed', $q_confirmed),
+        array('Not Confirmed', $q_not_confirmed),
+        array('Deleted', $q_deleted),
+        array('For a Speaker<sup>*</sup>', $q_speaker),
+        array('For a Keyword', $q_keyword),
     )
 );
 
@@ -40,7 +40,7 @@ 
     $criteria = $row['criteria'];
     $rows[] = array($id, $critera);
 }
-$data = array( 'rows' => $rows );
+$data = array('rows' => $rows);
 $PAGE->display_table($data);
 
 $q = $db->query('select count(*) as c, criteria from alerts where criteria like "speaker:%" and confirmed and not deleted group by criteria order by c desc');
@@ -70,15 +70,15 @@ 
     }
 }
 
-$people_header = array( 'Name', 'Confirmed', 'Unconfirmed');
+$people_header = array('Name', 'Confirmed', 'Unconfirmed');
 print '<h3>Alert signups by MP/Peer</h3>';
 $rows = array();
 foreach ($tots as $person_id => $c) {
     $u = isset($unconfirmed[$person_id]) ? $unconfirmed[$person_id] : 0;
-    $rows[] = array( $name[$person_id], $c, $u );
+    $rows[] = array($name[$person_id], $c, $u);
 }
 $data = array(
-    'header' => array( 'Name', 'Confirmed', 'Unconfirmed'),
+    'header' => array('Name', 'Confirmed', 'Unconfirmed'),
     'rows' => $rows
 );
 $PAGE->display_table($data);
@@ -105,10 +105,10 @@ 
 foreach ($total as $criteria => $tot) {
     $c = isset($confirmed[$criteria]) ? $confirmed[$criteria] : 0;
     $u = isset($unconfirmed[$criteria]) ? $unconfirmed[$criteria] : 0;
-    $rows[] = array( $criteria, $c, $u );
+    $rows[] = array($criteria, $c, $u);
 }
 $data = array(
-    'header' => array( 'Criteria', 'Confirmed', 'Unconfirmed'),
+    'header' => array('Criteria', 'Confirmed', 'Unconfirmed'),
     'rows' => $rows
 );
 $PAGE->display_table($data);

Braces +12 added lines, -4 removed lines

@@ -48,11 +48,15 @@ 
 foreach ($q as $row) {
     $c = $row['c'];
     $criteria = $row['criteria'];
-    if (!preg_match('#^speaker:(\d+)#', $criteria, $m)) continue;
+    if (!preg_match('#^speaker:(\d+)#', $criteria, $m)) {
+        continue;
+    }
     $person_id = $m[1];
     $MEMBER = new MEMBER(array('person_id'=>$person_id));
     if ($MEMBER->valid) {
-        if (!array_key_exists($person_id, $tots)) $tots[$person_id] = 0;
+        if (!array_key_exists($person_id, $tots)) {
+            $tots[$person_id] = 0;
+        }
         $tots[$person_id] += $c;
         $name[$person_id] = $MEMBER->full_name();
     }
@@ -62,10 +66,14 @@ 
 foreach ($q as $row) {
     $c = $row['c'];
     $criteria = $row['criteria'];
-    if (!preg_match('#^speaker:(\d+)#', $criteria, $m)) continue;
+    if (!preg_match('#^speaker:(\d+)#', $criteria, $m)) {
+        continue;
+    }
     $person_id = $m[1];
     if (isset($name[$person_id])) {
-        if (!array_key_exists($person_id, $unconfirmed)) $unconfirmed[$person_id] = 0;
+        if (!array_key_exists($person_id, $unconfirmed)) {
+            $unconfirmed[$person_id] = 0;
+        }
         $unconfirmed[$person_id] += $c;
     }
 }

www/docs/video/stamps.php

Spacing +6 added lines, -6 removed lines

@@ -19,7 +19,7 @@ 
 $video = \MySociety\TheyWorkForYou\Utility\Video::fromTimestamp($videodb, $adate, $atime);
 if (!$video) exit;
 
-$start = date('H:i:s', strtotime($video['broadcast_start']. ' GMT'));
+$start = date('H:i:s', strtotime($video['broadcast_start'] . ' GMT'));
 $end = date('H:i:s', strtotime($video['broadcast_end'] . ' GMT'));
 
 $q = $db->query("select video_timestamps.gid, adate, atime, time_to_sec(timediff(atime, '$start')) as timediff,
@@ -37,22 +37,22 @@ 
     $gid = str_replace('uk.org.publicwhip/', '', $row['gid']);
     if (isset($gids[$gid])) continue;
     $timetoend = $row['timetoend'] - $file_offset;
-    if ($timetoend>0) {
+    if ($timetoend > 0) {
         $video = \MySociety\TheyWorkForYou\Utility\Video::fromTimestamp($videodb, $row['adate'], $row['atime']);
-        $new_start = date('H:i:s', strtotime($video['broadcast_start']. ' GMT'));
+        $new_start = date('H:i:s', strtotime($video['broadcast_start'] . ' GMT'));
         $file_offset += timediff($new_start, $start);
         $start = $new_start;
         $end = date('H:i:s', strtotime($video['broadcast_end'] . ' GMT'));
     }
     $timediff = $row['timediff'] - $file_offset;
-    if ($timediff>=0)
+    if ($timediff >= 0)
         print "<stamp><gid>$gid</gid><file>$video[id]</file><time>$timediff</time></stamp>\n";
     $gids[$gid] = true;
 }
 print '</stamps>';
 
 function timediff($a, $b) {
-    return substr($a, 0, 2)*3600 + substr($a, 3, 2)*60 + substr($a, 6, 2)
-        - substr($b, 0, 2)*3600 - substr($b, 3, 2)*60 - substr($b, 6, 2);
+    return substr($a, 0, 2) * 3600 + substr($a, 3, 2) * 60 + substr($a, 6, 2)
+        - substr($b, 0, 2) * 3600 - substr($b, 3, 2) * 60 - substr($b, 6, 2);
 
 }

Braces +9 added lines, -4 removed lines

@@ -17,7 +17,9 @@ 
 $adate = $q['adate'];
 $atime = $q['atime'];
 $video = \MySociety\TheyWorkForYou\Utility\Video::fromTimestamp($videodb, $adate, $atime);
-if (!$video) exit;
+if (!$video) {
+    exit;
+}
 
 $start = date('H:i:s', strtotime($video['broadcast_start']. ' GMT'));
 $end = date('H:i:s', strtotime($video['broadcast_end'] . ' GMT'));
@@ -35,7 +37,9 @@ 
 print '<stamps>';
 foreach ($q as $row) {
     $gid = str_replace('uk.org.publicwhip/', '', $row['gid']);
-    if (isset($gids[$gid])) continue;
+    if (isset($gids[$gid])) {
+        continue;
+    }
     $timetoend = $row['timetoend'] - $file_offset;
     if ($timetoend>0) {
         $video = \MySociety\TheyWorkForYou\Utility\Video::fromTimestamp($videodb, $row['adate'], $row['atime']);
@@ -45,8 +49,9 @@ 
         $end = date('H:i:s', strtotime($video['broadcast_end'] . ' GMT'));
     }
     $timediff = $row['timediff'] - $file_offset;
-    if ($timediff>=0)
-        print "<stamp><gid>$gid</gid><file>$video[id]</file><time>$timediff</time></stamp>\n";
+    if ($timediff>=0) {
+            print "<stamp><gid>$gid</gid><file>$video[id]</file><time>$timediff</time></stamp>\n";
+    }
     $gids[$gid] = true;
 }
 print '</stamps>';

www/docs/video/index.php

Braces +80 added lines, -33 removed lines

@@ -47,8 +47,12 @@ 
 $htime = $q['htime'];
 $atime = $q['atime'];
 $adate = $q['adate'];
-if ($atime) $htime = $atime;
-if ($adate) $hdate = $adate;
+if ($atime) {
+    $htime = $atime;
+}
+if ($adate) {
+    $hdate = $adate;
+}
 $parent_gid = str_replace('uk.org.publicwhip/debate/', '/debates/?id=', $q['parent_gid']);
 $parent_gid = str_replace('uk.org.publicwhip/lords/', '/lords/?gid=', $parent_gid);
 $parent_body = $q['parent_body'];
@@ -88,8 +92,12 @@ 
 $gids_following = array();
 $gid_actual = array();
 foreach ($q as $row) {
-    if ($row['adate']) $row['hdate'] = $row['adate'];
-    if ($row['atime']) $row['htime'] = $row['atime'];
+    if ($row['adate']) {
+        $row['hdate'] = $row['adate'];
+    }
+    if ($row['atime']) {
+        $row['htime'] = $row['atime'];
+    }
     if ($row['hpos'] < $hpos) {
         $gids_previous[] = $row;
     } elseif ($row['hpos'] > $hpos) {
@@ -132,14 +140,20 @@ 
 }
 $video = \MySociety\TheyWorkForYou\Utility\Video::fromTimestamp($videodb, $hdate, $htime);
 
-if (!$start)
+if (!$start) {
     $start = $video['offset'] - $offset;
-if ($start < 0) $start = 0;
+}
+if ($start < 0) {
+    $start = 0;
+}
 
-if (get_http_var('barcamp'))
+if (get_http_var('barcamp')) {
     $video['id'] -= 4000;
+}
 
-if (!$file) $file = $video['id'];
+if (!$file) {
+    $file = $video['id'];
+}
 
 # Start displaying
 
@@ -273,14 +287,26 @@ 
     global $THEUSER;
     if ($THEUSER->user_id() && ($rank_today || $rank_week || $rank_overall)) {
         echo '<p align="center"><big>You are ';
-        if ($rank_today) echo make_ranking($rank_today), ' today, ';
-        if ($rank_week) echo make_ranking($rank_week), ' last 4 weeks, ';
-        if ($rank_overall) echo make_ranking($rank_overall), ' overall';
+        if ($rank_today) {
+            echo make_ranking($rank_today), ' today, ';
+        }
+        if ($rank_week) {
+            echo make_ranking($rank_week), ' last 4 weeks, ';
+        }
+        if ($rank_overall) {
+            echo make_ranking($rank_overall), ' overall';
+        }
         echo '</big></p>';
     }
-    if ($out_today) echo "<h3>Top timestampers (today)</h3> <ol>$out_today</ol>";
-    if ($out_week) echo "<h3>Top timestampers (last 4 weeks)</h3> <ol>$out_week</ol>";
-    if ($out_overall) echo "<h3>Top timestampers (overall)</h3> <ol>$out_overall</ol>";
+    if ($out_today) {
+        echo "<h3>Top timestampers (today)</h3> <ol>$out_today</ol>";
+    }
+    if ($out_week) {
+        echo "<h3>Top timestampers (last 4 weeks)</h3> <ol>$out_week</ol>";
+    }
+    if ($out_overall) {
+        echo "<h3>Top timestampers (overall)</h3> <ol>$out_overall</ol>";
+    }
     echo '</div>';
 ?>
 <div style="float: right; width: 50%">
@@ -347,18 +373,24 @@ 
         $name = $row['firstname'] . ' ' . $row['lastname'];
         $user_id = $row['user_id'];
         #if ($user_id == -1) continue; # $name = 'CaptionerBot';
-        if ($user_id == 0) $name = 'Anonymous';
+        if ($user_id == 0) {
+            $name = 'Anonymous';
+        }
         $count = $row['c'];
         if ($THEUSER->user_id() == $user_id) {
             $rank = $i+1;
         }
-        if ($i>=$limit) continue;
+        if ($i>=$limit) {
+            continue;
+        }
         $out .= '<li>';
-        if ($THEUSER->user_id() == $user_id)
-            $out .= '<strong>';
+        if ($THEUSER->user_id() == $user_id) {
+                    $out .= '<strong>';
+        }
         $out .= "$name : $count";
-        if ($THEUSER->user_id() == $user_id)
-            $out .= '</strong>';
+        if ($THEUSER->user_id() == $user_id) {
+                    $out .= '</strong>';
+        }
         #if ($user_id == -1) {
         #	echo ' <small>(initial run program that tries to guess timestamp from captions, wildly variable)</small>';
         #}
@@ -377,8 +409,10 @@ 
 
 function basic_instructions($pid) {
     $pid_url = '';
-    if ($pid) $pid_url = "&amp;pid=$pid";
-?>
+    if ($pid) {
+        $pid_url = "&amp;pid=$pid";
+    }
+    ?>
 <ol style="font-size: 150%;">
 <li>Have a quick scan of the speech under the video, then press &ldquo;Play&rdquo;.
 <li>When you hear the start of that speech, press &ldquo;Now!&rdquo;.
@@ -396,8 +430,10 @@ 
 function basic_hints($gid_safe, $file, $pid) {
     global $THEUSER;
     $pid_url = '';
-    if ($pid) $pid_url = "&amp;pid=$pid";
-?>
+    if ($pid) {
+        $pid_url = "&amp;pid=$pid";
+    }
+    ?>
 
 <ul>
 <?php	if (!$THEUSER->loggedin()) { ?>
@@ -427,8 +463,10 @@ 
 function advanced_hints($gid_safe, $file, $pid) {
     global $THEUSER;
     $pid_url = '';
-    if ($pid) $pid_url = "&amp;pid=$pid";
-?>
+    if ($pid) {
+        $pid_url = "&amp;pid=$pid";
+    }
+    ?>
 
 <p align="center">Actions:
 <a href="/video/next.php?action=random">Skip</a> |
@@ -463,14 +501,23 @@ 
 
 function disp_speech($row, $count) {
     echo '<li';
-    if ($row['htype']==13 || $row['htype']==14) echo ' class="unspoken"';
-    elseif ($row['htype']<12) echo ' class="heading"';
-    if (!($count%2)) echo ' style="background-color: #F5FDEA;"';
-    else echo ' style="background-color: #E8FDCB;"';
+    if ($row['htype']==13 || $row['htype']==14) {
+        echo ' class="unspoken"';
+    } elseif ($row['htype']<12) {
+        echo ' class="heading"';
+    }
+    if (!($count%2)) {
+        echo ' style="background-color: #F5FDEA;"';
+    } else {
+        echo ' style="background-color: #E8FDCB;"';
+    }
     echo '>';
-    if ($count) echo "<em>$count earlier:</em> ";
-    if ($row['htype']==12)
-        echo '<span class="video_name">' . $row['given_name'] . ' ' . $row['family_name'] . '</span> ';
+    if ($count) {
+        echo "<em>$count earlier:</em> ";
+    }
+    if ($row['htype']==12) {
+            echo '<span class="video_name">' . $row['given_name'] . ' ' . $row['family_name'] . '</span> ';
+    }
     echo $row['body'];
     echo '</li>';
 }

Spacing +12 added lines, -12 removed lines

@@ -54,7 +54,7 @@ 
 $parent_body = $q['parent_body'];
 $parent_epid = $q['subsection_id'];
 
-if (!($video_status&1) || ($video_status&8)) {
+if (!($video_status & 1) || ($video_status & 8)) {
     $PAGE->error_message('That GID does not appear to have any video. Please visit the <a href="/video/">video front page</a>.', true, 404);
     exit;
 }
@@ -177,7 +177,7 @@ 
 <?php
     $hidden_int = (isset($_COOKIE['hideVideoInt']) && $_COOKIE['hideVideoInt']);
     echo '<table id="video_table" border="0" cellspacing="0" cellpadding="5"><tr valign="top"><td width="50%">';
-    if ($gid_actual['video_status']&4) {
+    if ($gid_actual['video_status'] & 4) {
         $max = $db->query("select timediff(current_timestamp,max(whenstamped)) as ws from video_timestamps where gid='$q_gid' and (user_id is null or user_id != -1) and deleted=0")->first()['ws'];
         echo '<p class="informational">Thanks, but this speech has <strong>already been stamped</strong>';
         if ($max < '00:15:00') {
@@ -238,7 +238,7 @@ 
         $count = $row['c'];
         $totaliser[$status] = $count;
     }
-    $percentage = round($totaliser[4] / ($totaliser[0]+$totaliser[4]) * 10000) / 100;
+    $percentage = round($totaliser[4] / ($totaliser[0] + $totaliser[4]) * 10000) / 100;
     $out = "$totaliser[4] timestamped out of " . ($totaliser[0] + $totaliser[4]) . " ($percentage%)"
 ?>
 
@@ -341,7 +341,7 @@ 
     $q = $db->query('select firstname,lastname,video_timestamps.user_id,count(*) as c
         from video_timestamps left join users on video_timestamps.user_id=users.user_id
         where video_timestamps.deleted=0 and (video_timestamps.user_id is null or video_timestamps.user_id!=-1) '
-        . $q . ' group by user_id order by c desc' . ($THEUSER->user_id() ? '' : " limit $limit") );
+        . $q . ' group by user_id order by c desc' . ($THEUSER->user_id() ? '' : " limit $limit"));
     $out = ''; $rank = 0;
     $i = 0;
     foreach ($q as $row) {
@@ -351,9 +351,9 @@ 
         if ($user_id == 0) $name = 'Anonymous';
         $count = $row['c'];
         if ($THEUSER->user_id() == $user_id) {
-            $rank = $i+1;
+            $rank = $i + 1;
         }
-        if ($i>=$limit) continue;
+        if ($i >= $limit) continue;
         $out .= '<li>';
         if ($THEUSER->user_id() == $user_id)
             $out .= '<strong>';
@@ -407,7 +407,7 @@ 
 <?php	} ?>
 <li>If the video suddenly <strong>jumps</strong> a couple of hours, or otherwise appears broken, <a href="mailto:<?=str_replace('@', '&#64;', CONTACTEMAIL) ?>?subject=Video%20<?=$file?>%20for%20ID%20<?=$gid_safe?>%20broken">let us know</a>.
 <li>If the speech you're looking for is <strong>beyond the end</strong> of the video,
-<a href="/video/?gid=<?=$gid_safe?>&amp;file=<?=$file+1?>&amp;start=1<?=$pid_url?>">move on to the next video chunk</a>.
+<a href="/video/?gid=<?=$gid_safe?>&amp;file=<?=$file + 1?>&amp;start=1<?=$pid_url?>">move on to the next video chunk</a>.
 <li>If you're right at the start of a day, it's quite possible the start of the video
 will be the end of the previous programme on BBC Parliament, skip ahead some minutes
 to check :)
@@ -438,7 +438,7 @@ 
 <a href="/user/login/?ret=/video/">Log in</a> |
 <?php	} ?>
 <a href="mailto:<?=str_replace('@', '&#64;', CONTACTEMAIL) ?>?subject=Video%20<?=$file?>%20for%20ID%20<?=$gid_safe?>%20broken">Broken video</a> |
-<a href="/video/?gid=<?=$gid_safe?>&amp;file=<?=$file+1?>&amp;start=1<?=$pid_url?>" title="Loads the next video chunk">Speech past end of video</a>
+<a href="/video/?gid=<?=$gid_safe?>&amp;file=<?=$file + 1?>&amp;start=1<?=$pid_url?>" title="Loads the next video chunk">Speech past end of video</a>
 </p>
 
 <p align="right"><small><!-- <b>Credits:</b> Video from <a href='http://www.bbc.co.uk/parliament/'>BBC Parliament</a> and mySociety. -->
@@ -465,13 +465,13 @@ 
 
 function disp_speech($row, $count) {
     echo '<li';
-    if ($row['htype']==13 || $row['htype']==14) echo ' class="unspoken"';
-    elseif ($row['htype']<12) echo ' class="heading"';
-    if (!($count%2)) echo ' style="background-color: #F5FDEA;"';
+    if ($row['htype'] == 13 || $row['htype'] == 14) echo ' class="unspoken"';
+    elseif ($row['htype'] < 12) echo ' class="heading"';
+    if (!($count % 2)) echo ' style="background-color: #F5FDEA;"';
     else echo ' style="background-color: #E8FDCB;"';
     echo '>';
     if ($count) echo "<em>$count earlier:</em> ";
-    if ($row['htype']==12)
+    if ($row['htype'] == 12)
         echo '<span class="video_name">' . $row['given_name'] . ' ' . $row['family_name'] . '</span> ';
     echo $row['body'];
     echo '</li>';

www/docs/video/distance.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
     $want['hpos'] = $q['hpos'];
 
     $LIST = new DEBATELIST;
-        $args = array (
+        $args = array(
             's' => $search,
             'p' => 1,
             'num' => 200,

www/docs/video/submit.php

Braces +8 added lines, -3 removed lines

@@ -18,11 +18,16 @@
 $htime = $q['htime'];
 $atime = $q['atime'];
 $adate = $q['adate'];
-if ($atime) $htime = $atime;
-if ($adate) $hdate = $adate;
+if ($atime) {
+    $htime = $atime;
+}
+if ($adate) {
+    $hdate = $adate;
+}
 
-if (!$hdate || !$htime || !$time)
+if (!$hdate || !$htime || !$time) {
     exit;
+}
 
 $videodb = \MySociety\TheyWorkForYou\Utility\Video::dbConnect();
 if (!$file) {

www/docs/api/api_getMPsInfo.php

Braces +21 added lines, -11 removed lines

@@ -20,7 +20,9 @@ 
     $ids = preg_split('#\s*,\s*#', $ids, -1, PREG_SPLIT_NO_EMPTY);
     $safe_ids = array(0);
     foreach ($ids as $id) {
-        if (ctype_digit($id)) $safe_ids[] = $id;
+        if (ctype_digit($id)) {
+            $safe_ids[] = $id;
+        }
     }
     $ids = join(',', $safe_ids);
 
@@ -32,13 +34,15 @@ 
         $output = array();
         foreach ($q as $row) {
             $data_key = $row['data_key'];
-            if (count($fields) && !in_array($data_key, $fields))
-                continue;
+            if (count($fields) && !in_array($data_key, $fields)) {
+                            continue;
+            }
             $pid = $row['person_id'];
             $output[$pid][$data_key] = $row['data_value'];
             $time = strtotime($row['lastupdate']);
-            if ($time > $last_mod)
-                $last_mod = $time;
+            if ($time > $last_mod) {
+                            $last_mod = $time;
+            }
         }
         $q = $db->query("select memberinfo.*, person_id from memberinfo, member
             where memberinfo.member_id=member.member_id and person_id in (" . $ids . ")
@@ -46,16 +50,22 @@ 
         if ($q->rows()) {
             foreach ($q as $row) {
                 $data_key = $row['data_key'];
-                if (count($fields) && !in_array($data_key, $fields))
-                    continue;
+                if (count($fields) && !in_array($data_key, $fields)) {
+                                    continue;
+                }
                 $mid = $row['member_id'];
                 $pid = $row['person_id'];
-                if (!isset($output[$pid]['by_member_id'])) $output[$pid]['by_member_id'] = array();
-                if (!isset($output[$pid]['by_member_id'][$mid])) $output[$pid]['by_member_id'][$mid] = array();
+                if (!isset($output[$pid]['by_member_id'])) {
+                    $output[$pid]['by_member_id'] = array();
+                }
+                if (!isset($output[$pid]['by_member_id'][$mid])) {
+                    $output[$pid]['by_member_id'][$mid] = array();
+                }
                 $output[$pid]['by_member_id'][$mid][$data_key] = $row['data_value'];
                 $time = strtotime($row['lastupdate']);
-                if ($time > $last_mod)
-                    $last_mod = $time;
+                if ($time > $last_mod) {
+                                    $last_mod = $time;
+                }
             }
         }
         ksort($output);

www/docs/api/api_getMembers.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
             'person_id' => $pid,
             'name' => html_entity_decode(member_full_name($row['house'], $row['title'],
                 $row['given_name'], $row['family_name'],
-                $row['lordofname'] )),
+                $row['lordofname'])),
             'party' => isset($parties[$row['party']]) ? $parties[$row['party']] : $row['party'],
         );
         if ($row['house'] != HOUSE_TYPE_LORDS) {