Passed
Pull Request — master (#1428)
by Nick
06:09
created
classes/Topic.php 3 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
      *
29 29
      */
30 30
 
31
-    public function __construct($data = NULL)
31
+    public function __construct($data = null)
32 32
     {
33 33
         $this->db = new \ParlDB;
34 34
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
     public function sctitle() {
55 55
         $title = $this->title;
56
-        if (strpos($title, 'The ') === 0 ) {
56
+        if (strpos($title, 'The ') === 0) {
57 57
             $title = lcfirst($title);
58 58
         }
59 59
 
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
             );
243 243
         } else {
244 244
             foreach ($sets as $set) {
245
-                if ($set == '' ) {
245
+                if ($set == '') {
246 246
                     continue;
247 247
                 }
248 248
                 $q = $this->db->query(
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
             );
286 286
         } else {
287 287
             foreach ($policies as $policy) {
288
-                if ($policy == '' ) {
288
+                if ($policy == '') {
289 289
                     continue;
290 290
                 }
291 291
                 $q = $this->db->query(
Please login to merge, or discard this patch.
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $this->db = new \ParlDB;
34 34
 
35 35
         if (is_null($data)) {
36
-          return;
36
+            return;
37 37
         }
38 38
 
39 39
         $this->id = $data['id'];
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
     private function _getContentIDs() {
126 126
         $q = $this->db->query(
127
-          "SELECT body, gid, ep.epobject_id FROM epobject ep
127
+            "SELECT body, gid, ep.epobject_id FROM epobject ep
128 128
            JOIN hansard h on ep.epobject_id = h.epobject_id
129 129
            JOIN topic_epobjects te on te.epobject_id = ep.epobject_id
130 130
            WHERE topic_key = :topic_key",
@@ -178,24 +178,24 @@  discard block
 block discarded – undo
178 178
 
179 179
     public function addContent($gid) {
180 180
         $q = $this->db->query(
181
-          "SELECT epobject_id FROM hansard WHERE gid = :gid",
182
-          array(
181
+            "SELECT epobject_id FROM hansard WHERE gid = :gid",
182
+            array(
183 183
             ":gid" => $gid
184
-          )
184
+            )
185 185
         )->first();
186 186
 
187 187
         if (!$q) {
188
-          return false;
188
+            return false;
189 189
         }
190 190
 
191 191
         $epobject_id = $q['epobject_id'];
192 192
 
193 193
         $q = $this->db->query(
194
-          "INSERT INTO topic_epobjects (topic_key, epobject_id) VALUES (:topic, :ep_id)",
195
-          array(
194
+            "INSERT INTO topic_epobjects (topic_key, epobject_id) VALUES (:topic, :ep_id)",
195
+            array(
196 196
             ":topic" => $this->id,
197 197
             ":ep_id" => $epobject_id
198
-          )
198
+            )
199 199
         );
200 200
 
201 201
         return $q->success();
@@ -203,23 +203,23 @@  discard block
 block discarded – undo
203 203
 
204 204
     public function deleteContent($id) {
205 205
         $q = $this->db->query(
206
-          "DELETE FROM topic_epobjects WHERE topic_key = :topic AND epobject_id = :ep_id",
207
-          array(
206
+            "DELETE FROM topic_epobjects WHERE topic_key = :topic AND epobject_id = :ep_id",
207
+            array(
208 208
             ":topic" => $this->id,
209 209
             ":ep_id" => $id
210
-          )
210
+            )
211 211
         );
212 212
 
213 213
         return $q->success();
214 214
     }
215 215
 
216 216
     public function getPolicySets() {
217
-      $q = $this->db->query(
217
+        $q = $this->db->query(
218 218
         "SELECT policyset FROM topic_policysets WHERE topic_key = :key",
219 219
         array(
220
-          ':key' => $this->id
220
+            ':key' => $this->id
221 221
         )
222
-      );
222
+        );
223 223
 
224 224
         $sets = array();
225 225
         foreach ($q as $row) {
@@ -256,12 +256,12 @@  discard block
 block discarded – undo
256 256
     }
257 257
 
258 258
     public function getPolicies() {
259
-      $q = $this->db->query(
259
+        $q = $this->db->query(
260 260
         'SELECT policy_id FROM topic_policies WHERE topic_key = :key',
261 261
         array(
262
-          ':key' => $this->id
262
+            ':key' => $this->id
263 263
         )
264
-      );
264
+        );
265 265
 
266 266
         $policies = array();
267 267
         foreach ($q as $row) {
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
 
313 313
     public function save() {
314 314
         $q = $this->db->query(
315
-          "REPLACE INTO topics
315
+            "REPLACE INTO topics
316 316
           (id, title, slug, description, search_string, front_page, image)
317 317
           VALUES
318 318
           (:id, :title, :slug, :description, :search_string, :front_page, :image)",
Please login to merge, or discard this patch.
classes/SectionView/PbcView.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
         } elseif ($this->session) {
66 66
             # Display the bills for a particular session
67 67
             $this_page = 'pbc_session';
68
-            $DATA->set_page_metadata($this_page, 'title', "Session $this->session");
68
+            $DATA->set_page_metadata($this_page, 'title', "session $this->session");
69 69
             $args = array (
70 70
                 'session' => $this->session,
71 71
             );
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         } elseif ($bill_id) {
48 48
             # Display the page for a particular bill
49 49
             $this_page = 'pbc_bill';
50
-            $args = array (
50
+            $args = array(
51 51
                 'id' => $bill_id,
52 52
                 'title' => $this->bill,
53 53
                 'session' => $this->session,
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
             # Display the bills for a particular session
67 67
             $this_page = 'pbc_session';
68 68
             $DATA->set_page_metadata($this_page, 'title', "Session $this->session");
69
-            $args = array (
69
+            $args = array(
70 70
                 'session' => $this->session,
71 71
             );
72 72
             $data = array();
@@ -88,12 +88,12 @@  discard block
 block discarded – undo
88 88
 
89 89
     protected function getSearchSections() {
90 90
         return array(
91
-            array( 'section' => 'pbc' )
91
+            array('section' => 'pbc')
92 92
         );
93 93
     }
94 94
 
95 95
     protected function front_content() {
96
-        return $this->list->display( 'recent_pbc_debates', array( 'num' => 50 ), 'none' );
96
+        return $this->list->display('recent_pbc_debates', array('num' => 50), 'none');
97 97
     }
98 98
 
99 99
     protected function display_front() {
Please login to merge, or discard this patch.
classes/SectionView/SectionView.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -512,7 +512,7 @@
 block discarded – undo
512 512
             if ($row['totalcomments'] > 1) {
513 513
                 $morecount = $row['totalcomments'] - 1;
514 514
                 $plural = $morecount == 1 ? 'annotation' : 'annotations';
515
-                $linktext = "Read $morecount more $plural";
515
+                $linktext = "read $morecount more $plural";
516 516
             }
517 517
 
518 518
         } else {
Please login to merge, or discard this patch.
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
             $data = $this->addCommonData($data);
33 33
         } elseif ($date = get_http_var('d')) {
34 34
             $data = $this->display_day($date);
35
-            if ( !isset($data['template']) ) {
35
+            if (!isset($data['template'])) {
36 36
                 $data['template'] = 'section/day';
37 37
             }
38 38
             $data = $this->addCommonData($data);
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
             $data = $this->display_section_or_speech();
41 41
         } else {
42 42
             $data = $this->display_front();
43
-            if ( !isset($data['template']) ) {
43
+            if (!isset($data['template'])) {
44 44
                 $data['template'] = 'section/recent';
45 45
             }
46 46
             $data['search_sections'] = $this->getSearchSections();
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
         $data['recess_major'] = $this->getRecessMajor();
60 60
 
61 61
         $nextprev = $DATA->page_metadata($this_page, 'nextprev');
62
-        if ( isset($nextprev['next']['url']) ) {
62
+        if (isset($nextprev['next']['url'])) {
63 63
             $data['next'] = $nextprev['next'];
64 64
         }
65
-        if ( isset($nextprev['prev']['url']) ) {
65
+        if (isset($nextprev['prev']['url'])) {
66 66
             $data['prev'] = $nextprev['prev'];
67 67
         }
68 68
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         if (!isset($data['title']) && $parent_page != '') {
72 72
             $data['title'] = $DATA->page_metadata($parent_page, 'title');
73 73
         }
74
-        if ( $parent_page ) {
74
+        if ($parent_page) {
75 75
             $data['parent_title'] = $DATA->page_metadata($parent_page, 'title');
76 76
         }
77 77
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
         $urls = array_merge($urls, $this->getViewUrls());
89 89
 
90
-        if ( isset($data['info']['page']) ) {
90
+        if (isset($data['info']['page'])) {
91 91
             $day = new \MySociety\TheyWorkForYou\Url($data['info']['page']);
92 92
             $urls['day'] = $day;
93 93
         }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
             $DATA->set_page_metadata($this_page, 'title', $year);
134 134
         }
135 135
 
136
-        $args = array ( 'year' => $year );
136
+        $args = array('year' => $year);
137 137
         $data = $this->list->display('calendar', $args, 'none');
138 138
         return $data;
139 139
     }
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     protected function display_column($date, $column) {
142 142
         global $this_page;
143 143
         $this_page = $this->page_base;
144
-        $args = array( 'date' => $date, 'column' => $column );
144
+        $args = array('date' => $date, 'column' => $column);
145 145
         $content = $this->list->display('column', $args, 'none');
146 146
 
147 147
         $data = array();
@@ -166,12 +166,12 @@  discard block
 block discarded – undo
166 166
     protected function display_day($date) {
167 167
         global $this_page;
168 168
         $this_page = $this->page_base . 'day';
169
-        $args = array ( 'date' => get_http_var('d') );
169
+        $args = array('date' => get_http_var('d'));
170 170
         $data = $this->list->display('date', $args, 'none');
171 171
         list($year, $month, $day) = explode('-', $date);
172
-        $args = array( 'year' => $year, 'month' => $month, 'day' => $day);
172
+        $args = array('year' => $year, 'month' => $month, 'day' => $day);
173 173
         $calendar = $this->list->display('calendar', $args, 'none');
174
-        if ( isset($calendar['years']) ) {
174
+        if (isset($calendar['years'])) {
175 175
             $data['calendar'] = $calendar['years'];
176 176
         }
177 177
         return $data;
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
         global $DATA, $this_page, $THEUSER;
182 182
 
183 183
         # += as we *don't* want to override any already supplied argument
184
-        $args += array (
184
+        $args += array(
185 185
             'gid' => get_http_var('id'),
186 186
             's' => get_http_var('s'), // Search terms to be highlighted.
187 187
             'member_id' => get_http_var('m'), // Member's speeches to be highlighted.
@@ -198,14 +198,14 @@  discard block
 block discarded – undo
198 198
             if ($this->major == 6) {
199 199
                 # Magically (as in I can't remember quite why), pbc_clause will
200 200
                 # contain the new URL without any change...
201
-                $URL->remove( array('id') );
201
+                $URL->remove(array('id'));
202 202
             } else {
203
-                $URL->insert( array('id'=>$e->getMessage()) );
203
+                $URL->insert(array('id'=>$e->getMessage()));
204 204
             }
205 205
             # put the search term back in so highlighting works.
206 206
             # NB: as we don't see the # part of the URL we lose this :(
207
-            if ( $args['s'] !== '' ) {
208
-                $URL->insert( array('s'=>$args['s']) );
207
+            if ($args['s'] !== '') {
208
+                $URL->insert(array('s'=>$args['s']));
209 209
             }
210 210
             redirect($URL->generate('none'));
211 211
         }
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
         if (array_key_exists('text_heading', $data['info'])) {
274 274
             // avoid having Clause 1 etc as the alert text search string on PBC pages as it's
275 275
             // almost certainly not what the person wants
276
-            if ( $this->major == 6 ) {
276
+            if ($this->major == 6) {
277 277
                 $data['email_alert_text'] = $data['section_title'];
278 278
             } else {
279 279
                 $data['email_alert_text'] = $data['info']['text_heading'];
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
             $body = preg_replace('#<phrase class="honfriend" id="uk.org.publicwhip/member/(\d+)" name="([^"]*?)">(.*?\s*\((.*?)\))</phrase>#', '<a href="/mp/?m=$1" title="Our page on $2 - \'$3\'">$4</a>', $body);
321 321
             $body = preg_replace('#<phrase class="honfriend" name="([^"]*?)" person_id="uk.org.publicwhip/person/(\d+)">(.*?\s*\((.*?)\))</phrase>#', '<a href="/mp/?p=$2" title="Our page on $1 - \'$3\'">$4</a>', $body);
322 322
             $body = preg_replace_callback('#<phrase class="offrep" id="(.*?)/(\d+)-(\d+)-(\d+)\.(.*?)">(.*?)</phrase>#', function($matches) {
323
-                return '<a href="/search/?pop=1&s=date:' . $matches[2] . $matches[3] . $matches[4] . '+column:' . $matches[5] . '+section:' . $matches[1] .'">' . str_replace("Official Report", "Hansard", $matches[6]) . '</a>';
323
+                return '<a href="/search/?pop=1&s=date:' . $matches[2] . $matches[3] . $matches[4] . '+column:' . $matches[5] . '+section:' . $matches[1] . '">' . str_replace("Official Report", "Hansard", $matches[6]) . '</a>';
324 324
             }, $body);
325 325
             #$body = preg_replace('#<phrase class="offrep" id="((.*?)/(\d+)-(\d+)-(\d+)\.(.*?))">(.*?)</phrase>#e', "\"<a href='/search/?pop=1&amp;s=date:$3$4$5+column:$6+section:$2&amp;match=$1'>\" . str_replace('Official Report', 'Hansard', '$7') . '</a>'", $body);
326 326
             $bodies[] = $body;
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
         $data['section_title'] = '';
354 354
         $subsection_title = '';
355 355
         $rows = count($data['rows']);
356
-        for ($i=0; $i<$rows; $i++) {
356
+        for ($i = 0; $i < $rows; $i++) {
357 357
             $row = $data['rows'][$i];
358 358
             $htype = $row['htype'];
359 359
             // HPOS should be defined below if it's needed; otherwise default to 0
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
                 # Voting links
377 377
                 $data['rows'][$i]['voting_data'] = '';
378 378
                 if (isset($row['votes'])) {
379
-                    $data['rows'][$i]['voting_data'] = $this->generate_votes( $row['votes'], $row['epobject_id'], $row['gid'] );
379
+                    $data['rows'][$i]['voting_data'] = $this->generate_votes($row['votes'], $row['epobject_id'], $row['gid']);
380 380
                 }
381 381
 
382 382
                 # Annotation link
@@ -417,47 +417,47 @@  discard block
 block discarded – undo
417 417
 
418 418
     private function getCountryDetails() {
419 419
         $details = array(
420
-            1 => array (
420
+            1 => array(
421 421
                 'country' => 'UK',
422 422
                 'assembly' => 'uk-commons',
423 423
                 'location' => '&ndash; in the House of Commons'
424 424
             ),
425
-            2 => array (
425
+            2 => array(
426 426
                 'country' => 'UK',
427 427
                 'assembly' => 'uk-commons',
428 428
                 'location' => '&ndash; in Westminster Hall'
429 429
             ),
430
-            3 => array (
430
+            3 => array(
431 431
                 'country' => 'UK',
432 432
                 'assembly' => 'uk-commons',
433 433
                 'location' => 'written question &ndash; answered'
434 434
             ),
435
-            4 => array (
435
+            4 => array(
436 436
                 'country' => 'UK',
437 437
                 'assembly' => 'uk-commons',
438 438
                 'location' => 'written statement &ndash; made'
439 439
             ),
440
-            5 => array (
440
+            5 => array(
441 441
                 'country' => 'NORTHERN IRELAND',
442 442
                 'assembly' => 'ni',
443 443
                 'location' => '&ndash; in the Northern Ireland Assembly'
444 444
             ),
445
-            6 => array (
445
+            6 => array(
446 446
                 'country' => 'UK',
447 447
                 'assembly' => 'uk-commons',
448 448
                 'location' => '&ndash; in a Public Bill Committee'
449 449
             ),
450
-            7 => array (
450
+            7 => array(
451 451
                 'country' => 'SCOTLAND',
452 452
                 'assembly' => 'scotland',
453 453
                 'location' => '&ndash; in the Scottish Parliament'
454 454
             ),
455
-            8 => array (
455
+            8 => array(
456 456
                 'country' => 'SCOTLAND',
457 457
                 'assembly' => 'scotland',
458 458
                 'location' => '&ndash; Scottish Parliament written question &ndash; answered'
459 459
             ),
460
-            101 => array (
460
+            101 => array(
461 461
                 'country' => 'UK',
462 462
                 'assembly' => 'uk-lords',
463 463
                 'location' => '&ndash; in the House of Lords'
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
         global $DATA, $this_page;
473 473
         $this_page = $this->page_base . 'front';
474 474
         $data = array();
475
-        if ( $this->index_template ) {
475
+        if ($this->index_template) {
476 476
             $data['template'] = $this->index_template;
477 477
         }
478 478
 
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
 
483 483
         $content['calendar'] = $class->display('calendar', array('months' => 1), 'none');
484 484
 
485
-        if ( $rssurl = $DATA->page_metadata($this_page, 'rss') ) {
485
+        if ($rssurl = $DATA->page_metadata($this_page, 'rss')) {
486 486
             $content['rssurl'] = $rssurl;
487 487
         }
488 488
 
@@ -497,7 +497,7 @@  discard block
 block discarded – undo
497 497
     }
498 498
 
499 499
     //$totalcomments, $comment, $commenturl
500
-    function generate_commentteaser ($row) {
500
+    function generate_commentteaser($row) {
501 501
         // Returns HTML for the one fragment of comment and link for the sidebar.
502 502
         // $totalcomments is the number of comments this item has on it.
503 503
         // $comment is an array like:
Please login to merge, or discard this patch.
classes/PolicyPositions.php 3 patches
Upper-Lower-Casing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
         $this->summaries = isset($options['summaries']) ? $options['summaries'] : array();
64 64
         $this->divisions = new \MySociety\TheyWorkForYou\Divisions($member);
65 65
 
66
-        $limit = isset($options['limit']) ? $options['limit'] : NULL;
66
+        $limit = isset($options['limit']) ? $options['limit'] : null;
67 67
 
68 68
         // Do the actual getting of positions
69 69
         $this->getMemberPolicyPositions($limit);
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
      * @param int $limit The number of results to limit the output to.
78 78
      */
79 79
 
80
-    private function getMemberPolicyPositions ($limit = NULL) {
80
+    private function getMemberPolicyPositions ($limit = null) {
81 81
 
82 82
         // Make sure member info has actually been set.
83 83
         if (count($this->member->extra_info) === 0) {
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $member_houses = $this->member->houses();
90 90
 
91 91
         // Determine the policy limit.
92
-        if ($limit !== NULL AND is_int($limit))
92
+        if ($limit !== null and is_int($limit))
93 93
         {
94 94
             $policy_limit = $limit;
95 95
         } else {
@@ -208,12 +208,12 @@  discard block
 block discarded – undo
208 208
         $current_member = $this->member->current_member();
209 209
 
210 210
         if (count($this->policies) > 0) {
211
-            if (in_array(HOUSE_TYPE_COMMONS, $member_houses) AND
211
+            if (in_array(HOUSE_TYPE_COMMONS, $member_houses) and
212 212
                 $entered_house[HOUSE_TYPE_COMMONS]['date'] > '2001-06-07'
213 213
             ) {
214 214
                 $since = '';
215
-            } elseif (!in_array(HOUSE_TYPE_COMMONS, $member_houses) AND
216
-                in_array(HOUSE_TYPE_LORDS, $member_houses) AND
215
+            } elseif (!in_array(HOUSE_TYPE_COMMONS, $member_houses) and
216
+                in_array(HOUSE_TYPE_LORDS, $member_houses) and
217 217
                 $entered_house[HOUSE_TYPE_LORDS]['date'] > '2001-06-07'
218 218
             ) {
219 219
                 $since = '';
@@ -223,9 +223,9 @@  discard block
 block discarded – undo
223 223
                 $since = ' since 2001';
224 224
             }
225 225
             # If not current MP/Lord, but current MLA/MSP, need to say voting record is when MP
226
-            if (!$current_member[HOUSE_TYPE_COMMONS] AND
227
-                !$current_member[HOUSE_TYPE_LORDS] AND
228
-                ( $current_member[HOUSE_TYPE_SCOTLAND] OR $current_member[HOUSE_TYPE_NI] )
226
+            if (!$current_member[HOUSE_TYPE_COMMONS] and
227
+                !$current_member[HOUSE_TYPE_LORDS] and
228
+                ( $current_member[HOUSE_TYPE_SCOTLAND] or $current_member[HOUSE_TYPE_NI] )
229 229
             ) {
230 230
                 $since .= ' whilst an MP';
231 231
             }
@@ -246,10 +246,10 @@  discard block
 block discarded – undo
246 246
                 '" title="At The Guardian">well-known issues</a> <small>(from the Guardian)</small>';
247 247
         }
248 248
         if (
249
-            ( isset($extra_info['public_whip_division_attendance']) AND
249
+            ( isset($extra_info['public_whip_division_attendance']) and
250 250
             $extra_info['public_whip_division_attendance'] != 'n/a' )
251
-            OR
252
-            ( isset($extra_info['Lpublic_whip_division_attendance']) AND
251
+            or
252
+            ( isset($extra_info['Lpublic_whip_division_attendance']) and
253 253
             $extra_info['Lpublic_whip_division_attendance'] != 'n/a' )
254 254
         ) {
255 255
             $record[] = '<a href="http://www.publicwhip.org.uk/mp.php?id=uk.org.publicwhip/member/' .
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
      * @param int $limit The number of results to limit the output to.
78 78
      */
79 79
 
80
-    private function getMemberPolicyPositions ($limit = NULL) {
80
+    private function getMemberPolicyPositions($limit = NULL) {
81 81
 
82 82
         // Make sure member info has actually been set.
83 83
         if (count($this->member->extra_info) === 0) {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
             // don't return votes where they haven't voted on a strong division
118 118
             // if we're limiting the number of votes
119
-            if ( $limit && !empty($dream_info) && !$dream_info['has_strong'] ) {
119
+            if ($limit && !empty($dream_info) && !$dream_info['has_strong']) {
120 120
                 continue;
121 121
             }
122 122
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
                 $has_strong = 1;
196 196
             }
197 197
             $full_sentence = $consistency . ' ' . $policy_description;
198
-            $out = array( 'full_sentence' => $full_sentence, 'score' => $dmpscore, 'position' => $consistency, 'has_strong' => $has_strong );
198
+            $out = array('full_sentence' => $full_sentence, 'score' => $dmpscore, 'position' => $consistency, 'has_strong' => $has_strong);
199 199
         }
200 200
 
201 201
         return $out;
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
             # If not current MP/Lord, but current MLA/MSP, need to say voting record is when MP
227 227
             if (!$current_member[HOUSE_TYPE_COMMONS] AND
228 228
                 !$current_member[HOUSE_TYPE_LORDS] AND
229
-                ( $current_member[HOUSE_TYPE_SCOTLAND] OR $current_member[HOUSE_TYPE_NI] )
229
+                ($current_member[HOUSE_TYPE_SCOTLAND] OR $current_member[HOUSE_TYPE_NI])
230 230
             ) {
231 231
                 $since .= ' whilst an MP';
232 232
             }
@@ -247,11 +247,11 @@  discard block
 block discarded – undo
247 247
                 '" title="At The Guardian">well-known issues</a> <small>(from the Guardian)</small>';
248 248
         }
249 249
         if (
250
-            ( isset($extra_info['public_whip_division_attendance']) AND
251
-            $extra_info['public_whip_division_attendance'] != 'n/a' )
250
+            (isset($extra_info['public_whip_division_attendance']) AND
251
+            $extra_info['public_whip_division_attendance'] != 'n/a')
252 252
             OR
253
-            ( isset($extra_info['Lpublic_whip_division_attendance']) AND
254
-            $extra_info['Lpublic_whip_division_attendance'] != 'n/a' )
253
+            (isset($extra_info['Lpublic_whip_division_attendance']) AND
254
+            $extra_info['Lpublic_whip_division_attendance'] != 'n/a')
255 255
         ) {
256 256
             $record[] = '<a href="http://www.publicwhip.org.uk/mp.php?id=uk.org.publicwhip/member/' .
257 257
                 $this->member->member_id() .
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -95,8 +95,7 @@
 block discarded – undo
95 95
         $member_houses = $this->member->houses();
96 96
 
97 97
         // Determine the policy limit.
98
-        if ($limit !== NULL AND is_int($limit))
99
-        {
98
+        if ($limit !== NULL AND is_int($limit)) {
100 99
             $policy_limit = $limit;
101 100
         } else {
102 101
             $policy_limit = count($policies);
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/divisions.php 2 patches
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
                 </div>
34 34
                 <?php endif; ?>
35 35
 
36
-                <?php $displayed_votes = FALSE; ?>
36
+                <?php $displayed_votes = false; ?>
37 37
                 <?php if ( isset($policydivisions) && $policydivisions ) { ?>
38 38
 
39 39
                     <?php if ($has_voting_record) { ?>
@@ -86,14 +86,14 @@  discard block
 block discarded – undo
86 86
 
87 87
                                     <ul class="vote-descriptions policy-votes">
88 88
                                     <?php
89
-                                        $show_all = FALSE;
89
+                                        $show_all = false;
90 90
                                         if ( $policy['weak_count'] == 0 || $policy['weak_count'] == count($policy['divisions']) ) {
91
-                                            $show_all = TRUE;
91
+                                            $show_all = true;
92 92
                                         }
93 93
                                     ?>
94 94
                                     <?php foreach ($policy['divisions'] as $division) {
95 95
                                         include('_division_description.php');
96
-                                        $displayed_votes = TRUE;
96
+                                        $displayed_votes = true;
97 97
                                     } ?>
98 98
                                     </ul>
99 99
 
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
         </div>
16 16
         <div class="person-panels">
17 17
             <div class="sidebar__unit in-page-nav">
18
-                <?php if ( isset($policydivisions) && $policydivisions && count($policydivisions) == 1 ) { ?>
18
+                <?php if (isset($policydivisions) && $policydivisions && count($policydivisions) == 1) { ?>
19 19
                 <p class="policy-votes-intro">
20 20
                     How <?= $full_name ?> voted on <?= $policydivisions[array_keys($policydivisions)[0]]['desc'] ?>.
21 21
                 </p>
@@ -34,17 +34,17 @@  discard block
 block discarded – undo
34 34
                 <?php endif; ?>
35 35
 
36 36
                 <?php $displayed_votes = FALSE; ?>
37
-                <?php if ( isset($policydivisions) && $policydivisions ) { ?>
37
+                <?php if (isset($policydivisions) && $policydivisions) { ?>
38 38
 
39 39
                     <?php if ($has_voting_record) { ?>
40 40
 
41 41
                         <?php foreach ($policydivisions as $policy) { ?>
42 42
 
43
-                            <?php if ( isset($policy['header']) ) { ?>
43
+                            <?php if (isset($policy['header'])) { ?>
44 44
                                 <div class="panel policy-votes-hero" style="background-image: url('<?php echo $policy['header']['image']; ?>');">
45 45
                                     <h2><?php echo $policy['header']['title']; ?></h2>
46 46
                                     <p><?php echo $policy['header']['description']; ?>.</p>
47
-                                    <?php if ( $policy['header']['image_source'] ) { ?>
47
+                                    <?php if ($policy['header']['image_source']) { ?>
48 48
                                     <span class="policy-votes-hero__image-attribution">
49 49
                                         Photo:
50 50
                                         <a href="<?php echo $policy['header']['image_source']; ?>">
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
59 59
                             <?php } ?>
60 60
 
61 61
 
62
-                            <?php if ( isset($policy['position']) ) { ?>
62
+                            <?php if (isset($policy['position'])) { ?>
63 63
                                 <div class="panel">
64
-                                    <?php if ( $policy['position']['has_strong'] ) { ?>
64
+                                    <?php if ($policy['position']['has_strong']) { ?>
65 65
                                         <h3 class="policy-vote-overall-stance">
66 66
                                             <?= $full_name . ' ' . $policy['position']['desc'] ?>
67 67
                                         </h3>
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
                                     <ul class="vote-descriptions policy-votes">
88 88
                                     <?php
89 89
                                         $show_all = FALSE;
90
-                                        if ( $policy['weak_count'] == 0 || $policy['weak_count'] == count($policy['divisions']) ) {
90
+                                        if ($policy['weak_count'] == 0 || $policy['weak_count'] == count($policy['divisions'])) {
91 91
                                             $show_all = TRUE;
92 92
                                         }
93 93
                                     ?>
@@ -99,14 +99,14 @@  discard block
 block discarded – undo
99 99
 
100 100
                                     <div class="policy-votes-list-footer">
101 101
                                     <p class="policy-votes__byline">Vote information from <a href="http://www.publicwhip.org.uk/mp.php?mpid=<?= $member_id ?>&dmp=<?= $policy['policy_id'] ?>">PublicWhip</a>. Last updated: <?= $policy_last_update[$policy['policy_id']] ?></p>
102
-                                        <?php if ( !$show_all && $policy['weak_count'] > 0 ) { ?>
102
+                                        <?php if (!$show_all && $policy['weak_count'] > 0) { ?>
103 103
                                         <p><button class="button secondary-button small js-show-all-votes">Show all votes, including <?= $policy['weak_count'] ?> less important <?= $policy['weak_count'] == 1 ? 'vote' : 'votes' ?></button></p>
104 104
                                         <?php } ?>
105 105
                                     </div>
106 106
 
107 107
                                     <script type="text/javascript">
108 108
                                     $(function(){
109
-                                        <?php if ( !$show_all ) { ?>
109
+                                        <?php if (!$show_all) { ?>
110 110
                                         $('#policy-votes-type').text('Key');
111 111
                                         <?php } ?>
112 112
                                         $('.js-show-all-votes').on('click', function(){
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/static/linktous.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     </form>
25 25
 </div>
26 26
 <!-- TheyWorkForYou box, end -->
27
-END;
27
+end;
28 28
 print $link_to_us_form;
29 29
 ?>
30 30
 
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/scotland/index.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
                 <div class="row nested-row">
42 42
                     <div class="homepage-in-the-news homepage-content-section">
43 43
                         <?php if ( $featured ) {
44
-                             include dirname(__FILE__) . "/../homepage/featured.php";
44
+                                include dirname(__FILE__) . "/../homepage/featured.php";
45 45
                         } ?>
46 46
                     </div>
47 47
                     <div class="homepage-create-alert homepage-content-section">
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -11,10 +11,10 @@  discard block
 block discarded – undo
11 11
                 </div>
12 12
                 <div class="row">
13 13
                     <div class="medium-9 columns">
14
-                    <?php if ( count($data['regional']) > 0 ) { ?>
14
+                    <?php if (count($data['regional']) > 0) { ?>
15 15
                         <ul class="homepage-rep-list">
16 16
                         <li>Your Regional MSPs:</li>
17
-                        <?php foreach ( $data['regional'] as $msp ) { ?>
17
+                        <?php foreach ($data['regional'] as $msp) { ?>
18 18
                             <li class="homepage-rep-list__rep"><a href="/msp/?p=<?= $msp['person_id'] ?>"><?= $msp['name'] ?></a></li>
19 19
                         <?php } ?>
20 20
                         </ul>
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
             <div class="panel panel--flushtop clearfix">
58 58
                 <div class="row nested-row">
59 59
                     <div class="homepage-in-the-news homepage-content-section">
60
-                        <?php if ( $featured ) {
60
+                        <?php if ($featured) {
61 61
                              include dirname(__FILE__) . "/../homepage/featured.php";
62 62
                         } ?>
63 63
                     </div>
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
                         <h2>Recently in Parliament</h2>
106 106
                         <ul class="recently__list"><?php
107
-                            foreach ( $debates['recent'] as $recent ) {
107
+                            foreach ($debates['recent'] as $recent) {
108 108
                                 include dirname(__FILE__) . '/../homepage/recent-debates.php';
109 109
                             }
110 110
                         ?></ul>
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/section/_section_content.php 4 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
               <?php # XXX
158 158
                 if ($data['info']['major'] == 8 && preg_match('#\d{4}-\d\d-\d\d\.(.*?)\.q#', $speech['gid'], $m)) {
159 159
                     ?><p class="debate-speech__question_id"><small>
160
-                    <?= "Question $m[1]" ?>
160
+                    <?= "question $m[1]" ?>
161 161
                     </small></p>
162 162
               <?php } ?>
163 163
             </h2>
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,8 @@
 block discarded – undo
186 186
                 } # End of voting HTML
187 187
 
188 188
                 // Video
189
-                if ($data['info']['major'] == 1 && !$individual_item) { # Commons debates only
189
+                if ($data['info']['major'] == 1 && !$individual_item) {
190
+# Commons debates only
190 191
                     if ($speech['video_status']&4) { ?>
191 192
                         <a href="<?= $speech['commentsurl'] ?>" class="watch debate-speech__meta__link" onclick="return moveVideo(\'debate/'<?= $speech['gid'] ?>\');">Watch this</a>
192 193
                     <?php
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -12,9 +12,9 @@  discard block
 block discarded – undo
12 12
         if ($hansardmajors[$data['info']['major']]['location'] == 'Scotland') {
13 13
             $body = preg_replace('# (S\d[O0WF]-\d+)[, ]#', ' <a href="/spwrans/?spid=$1">$1</a> ', $body);
14 14
             $body = preg_replace_callback('#<citation id="uk\.org\.publicwhip/(.*?)/(.*?)">\[(.*?)\]</citation>#', function($matches) {
15
-                   if ($matches[1] == 'spor') {
16
-                       $href_segment = 'sp/?g';
17
-                   } elseif ($matches[1] == 'spwa') {
15
+                    if ($matches[1] == 'spor') {
16
+                        $href_segment = 'sp/?g';
17
+                    } elseif ($matches[1] == 'spwa') {
18 18
                         $href_segment = 'spwrans/?';
19 19
                     } else {
20 20
                         $href_segment = 'debates/?';
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
                     $after_mp = $speech['after_mp'];
192 192
                 }
193 193
                 include dirname(__FILE__) . '/../divisions/_your_mp.php';
194
-              } ?>
194
+                } ?>
195 195
                 <div class="debate-speech__division__details">
196 196
                   <?php include dirname(__FILE__) . '/../divisions/_votes.php'; ?>
197 197
                 </div>
Please login to merge, or discard this patch.
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-foreach($data['rows'] as $speech) { ?>
3
+foreach ($data['rows'] as $speech) { ?>
4 4
 
5 5
     <?php
6 6
 
@@ -63,27 +63,27 @@  discard block
 block discarded – undo
63 63
     $source = array();
64 64
 
65 65
     $major = $data['info']['major'];
66
-    if ($major==1 || $major==2 || (($major==3 || $major==4) && isset($speech['speaker']['house'])) || $major==101 || $major==6) {
66
+    if ($major == 1 || $major == 2 || (($major == 3 || $major == 4) && isset($speech['speaker']['house'])) || $major == 101 || $major == 6) {
67 67
         $source['title'] = 'Citation: ';
68
-        if ($major==1 || $major==2) {
68
+        if ($major == 1 || $major == 2) {
69 69
             $source['title'] .= 'HC';
70
-        } elseif ($major==3 || $major==4) {
71
-            if ($speech['speaker']['house']==1) {
70
+        } elseif ($major == 3 || $major == 4) {
71
+            if ($speech['speaker']['house'] == 1) {
72 72
                 $source['title'] .= 'HC';
73 73
             } else {
74 74
                 $source['title'] .= 'HL';
75 75
             }
76
-        } elseif ($major==6) {
76
+        } elseif ($major == 6) {
77 77
             $source['title'] .= $data['section_title'];
78 78
         } else {
79 79
             $source['title'] .= 'HL';
80 80
         }
81 81
         $source['title'] .= ' Deb, ' . format_date($data['info']['date'], LONGDATEFORMAT) . ', c' . $speech['colnum'];
82
-        if ($major==2) {
82
+        if ($major == 2) {
83 83
             $source['title'] .= 'WH';
84
-        } elseif ($major==3) {
84
+        } elseif ($major == 3) {
85 85
             $source['title'] .= 'W';
86
-        } elseif ($major==4) {
86
+        } elseif ($major == 4) {
87 87
             $source['title'] .= 'WS';
88 88
         }
89 89
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
             <div class="debate-speech__speaker-and-content">
113 113
             <?php } ?>
114 114
 
115
-          <?php if(isset($speech['speaker']) && count($speech['speaker']) > 0) { ?>
115
+          <?php if (isset($speech['speaker']) && count($speech['speaker']) > 0) { ?>
116 116
             <h2 class="debate-speech__speaker">
117 117
                 <?php
118 118
 
@@ -179,17 +179,17 @@  discard block
 block discarded – undo
179 179
                 <?php if ($division['has_description']) { ?>
180 180
                 <div class="debate-speech__division__details">
181 181
                     <span class="policy-vote__text">
182
-                        <?php include( dirname(__FILE__) . '/../divisions/_vote_description.php'); ?>
182
+                        <?php include(dirname(__FILE__) . '/../divisions/_vote_description.php'); ?>
183 183
                     </span><br>
184 184
                 </div>
185 185
                 <?php } ?>
186 186
 
187 187
               <?php if (isset($speech['mp_vote'])) {
188
-                $mp_vote = array( 'vote' => $speech['mp_vote']['vote'] );
189
-                if ( isset($speech['before_mp']) ) {
188
+                $mp_vote = array('vote' => $speech['mp_vote']['vote']);
189
+                if (isset($speech['before_mp'])) {
190 190
                     $before_mp = $speech['before_mp'];
191 191
                 }
192
-                if ( isset($speech['after_mp']) ) {
192
+                if (isset($speech['after_mp'])) {
193 193
                     $after_mp = $speech['after_mp'];
194 194
                 }
195 195
                 include dirname(__FILE__) . '/../divisions/_your_mp.php';
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
             <div class="debate-speech__content"><?=$body ?></div>
202 202
             <?php } ?>
203 203
 
204
-            <?php if ( $section ) {
204
+            <?php if ($section) {
205 205
                 if ($speech['voting_data']) { ?>
206 206
 
207 207
                 <div class="debate-speech__question-answered">
@@ -226,10 +226,10 @@  discard block
 block discarded – undo
226 226
 
227 227
                 // Video
228 228
                 if ($data['info']['major'] == 1 && !$individual_item) { # Commons debates only
229
-                    if ($speech['video_status']&4) { ?>
229
+                    if ($speech['video_status'] & 4) { ?>
230 230
                         <a href="<?= $speech['commentsurl'] ?>" class="watch debate-speech__meta__link" onclick="return moveVideo(\'debate/'<?= $speech['gid'] ?>\');">Watch this</a>
231 231
                     <?php
232
-                    } elseif (!$speech['video'] && $speech['video_status']&1 && !($speech['video_status']&8)) {
232
+                    } elseif (!$speech['video'] && $speech['video_status'] & 1 && !($speech['video_status'] & 8)) {
233 233
                         $gid_type = $data['info']['major'] == 1 ? 'debate' : 'lords'; ?>
234 234
                         <a href="/video/?from=debate&amp;gid=<?= $gid_type ?>/<?= $speech['gid'] ?>" class="timestamp debate-speech__meta__link">Video match this</a>
235 235
                     <?php
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
                     $moreinfo[] = $row['totalcomments'] . " $plural";
360 360
                 }
361 361
                 if (count($moreinfo) > 0) {
362
-                    print "<small>(" . implode (', ', $moreinfo) . ") </small>";
362
+                    print "<small>(" . implode(', ', $moreinfo) . ") </small>";
363 363
                 }
364 364
             } else {
365 365
                 // Nothing in this item, so no link.
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/section/recent.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1 1
 <div class="full-page__row">
2 2
     <?php include '_business_section.php'; ?>
3
-    <?php $search_title = "Search $title"; include '_search.php'; ?>
3
+    <?php $search_title = "search $title"; include '_search.php'; ?>
4 4
 </div>
Please login to merge, or discard this patch.