error_handler()

Complexity

Conditions	18
Paths	1025

Size

Total Lines	128
Code Lines	69

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	342

Importance

Changes

0

<?php
function error_handler($errno, $errmsg, $filename, $linenum, $vars) {

The parameter $vars is not used and could be removed.

    // Custom error-handling function.
    // Sends an email to BUGSLIST.
    global $PAGE;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    # Ignore errors we've asked to ignore
    if (error_reporting()==0) return;

   // define an assoc array of error string
   // in reality the only entries we should
   // consider are E_WARNING, E_NOTICE, E_USER_ERROR,
   // E_USER_WARNING and E_USER_NOTICE
   # Commented out are ones that a user function cannot handle.
    $errortype = array (
        #E_ERROR            => "Error",

50% of this comment could be valid code. Did you maybe forget this after debugging?

        E_WARNING           => "Warning",
        #E_PARSE            => "Parsing Error",

50% of this comment could be valid code. Did you maybe forget this after debugging?

        E_NOTICE            => "Notice",
        #E_CORE_ERROR       => "Core Error",

50% of this comment could be valid code. Did you maybe forget this after debugging?

        #E_CORE_WARNING     => "Core Warning",

50% of this comment could be valid code. Did you maybe forget this after debugging?

        #E_COMPILE_ERROR    => "Compile Error",

50% of this comment could be valid code. Did you maybe forget this after debugging?

        #E_COMPILE_WARNING  => "Compile Warning",

50% of this comment could be valid code. Did you maybe forget this after debugging?

        E_USER_ERROR        => "User Error",
        E_USER_WARNING      => "User Warning",
        E_USER_NOTICE       => "User Notice",
        E_STRICT            => "Runtime Notice",
        # 5.3 introduced E_DEPRECATED
        8192                => 'Deprecated',
    );

    $err = '';
    if (isset($_SERVER['REQUEST_URI'])) {
        $err .= "URL:\t\thttps://" . DOMAIN . $_SERVER['REQUEST_URI'] . "\n";

The constant DOMAIN was not found. Maybe you did not declare it correctly or list all dependencies?

    } else {
        $err .= "URL:\t\tNone - running from command line?\n";
    }
    if (isset($_SERVER['HTTP_REFERER'])) {
        $err .= "Referer:\t" . $_SERVER['HTTP_REFERER'] . "\n";
    } else {
        $err .= "Referer:\tNone\n";
    }
    if (isset($_SERVER['HTTP_USER_AGENT'])) {
        $err .= "User-Agent:\t" . $_SERVER['HTTP_USER_AGENT'] . "\n";
    } else {
        $err .= "User-Agent:\tNone\n";
    }
    $err .= "Number:\t\t$errno\n";
    $err .= "Type:\t\t" . $errortype[$errno] . "\n";
    $err .= "Message:\t$errmsg\n";
    $err .= "File:\t\t$filename\n";
    $err .= "Line:\t\t$linenum\n";
    if (count($_POST)) {
        $err .= "_POST:";
        foreach ($_POST as $k => $v) {
            $err .= "\t\t$k => $v\n";
        }
    }

// I'm not sure this bit is actually any use!

    // set of errors for which a var trace will be saved.
//  $user_errors = array(E_USER_ERROR, E_USER_WARNING, E_USER_NOTICE);
//  if (in_array($errno, $user_errors)) {
//      $err .= "Variables:\t" . serialize($vars) . "\n";
//  }


    // Add the problematic line if possible.
    if (is_readable($filename)) {
        $source = file($filename);
        $err .= "\nSource:\n\n";
        // Show the line, plus prev and next, with line numbers.
        $err .= $linenum-2 . " " . $source[$linenum-3];
        $err .= $linenum-1 . " " . $source[$linenum-2];
        $err .= $linenum . " " . $source[$linenum-1];
        $err .= $linenum+1 . " " . $source[$linenum];
        $err .= $linenum+2 . " " . $source[$linenum+1];
    }


    // Will we need to exit after this error?
    $fatal_errors = array(E_ERROR, E_USER_ERROR);
    if (in_array($errno, $fatal_errors)) {
        $fatal = true;
    } else {
        $fatal = false;
    }

    // Finally, display errors and stuff...

    if (DEVSITE || get_http_var(DEBUGTAG)) {

The constant DEBUGTAG was not found. Maybe you did not declare it correctly or list all dependencies?

The constant DEVSITE was not found. Maybe you did not declare it correctly or list all dependencies?

        // On a devsite we just display the problem.
        $errtxt = nl2br($err) . "\n";
        if (!strstr($errmsg, 'mysql_connect')) {
            $errtxt .= "<br><br>Backtrace:<br>" . nl2br(adodb_backtrace(false));
        }
        $message = array(
            'title' => "Error",
            'text' => $errtxt
        );
        if (is_object($PAGE)) {
            $PAGE->error_message($message, $fatal);
        } else {
            vardump($message);
        }

    } else {
        // On live sites we display a nice message and email the problem.

        $message = array(
            'title' => "Sorry, an error has occurred",
            'text' => "We've been notified by email and will try to fix the problem soon!"
        );

        if (is_object($PAGE)) {
            $PAGE->error_message($message, $fatal);
        } else {
            header('HTTP/1.0 500 Internal Server Error');
            print "<p>Oops, sorry, an error has occurred!</p>\n";
        }
        if (!($errno & E_USER_NOTICE) && strpos($errmsg, 'pg_connect')===false && strpos($errmsg, 'mysql_connect')===false) {
            mail(BUGSLIST, "[TWFYBUG]: $errmsg", $err, "From: Bug <" . CONTACTEMAIL . ">\n".  "X-Mailer: PHP/" . phpversion() );

The constant CONTACTEMAIL was not found. Maybe you did not declare it correctly or list all dependencies?

The constant BUGSLIST was not found. Maybe you did not declare it correctly or list all dependencies?

        }
    }

    // Do we need to exit?
    if ($fatal) {
        exit(1);

Using exit here is not recommended.

    }