GLOSSARY::create()

Complexity

Conditions	6
Paths	7

Size

Total Lines	74
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

0

<?php
    public function create(&$data) {
        // Add a Glossary definition.
        // Sets visiblity to 0, and awaits moderator intervention.
        // For this we need to start up an epobject of type 2 and then an editqueue item
        // where editqueue.epobject_id_l = epobject.epobject_id

        $EDITQUEUE = new \MySociety\TheyWorkForYou\GlossaryEditQueue;

        // Assuming that everything is ok, we will need:
        // For epobject:
        // 		title VARCHAR(255),

50% of this comment could be valid code. Did you maybe forget this after debugging?

        // 		body TEXT,
        // 		type INTEGER,
        // 		created DATETIME,
        // 		modified DATETIME,
        // and for editqueue:
        //		edit_id INTEGER PRIMARY KEY NOT NULL,
        //		user_id INTEGER,
        //		edit_type INTEGER,
        //		epobject_id_l INTEGER,
        //		title VARCHAR(255),

50% of this comment could be valid code. Did you maybe forget this after debugging?

        //		body TEXT,
        //		submitted DATETIME,
        //		editor_id INTEGER,
        //		approved BOOLEAN,
        //		decided DATETIME

        global $THEUSER;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        if ($data['title'] == '') {
            error ("Sorry, you can't define a term without a title");
            return false;
        }

        if ($data['body'] == '') {
            error ("You haven't entered a definition!");
            return false;
        }

        if (is_numeric($THEUSER->user_id())) {
            // Flood check - make sure the user hasn't just posted a term recently.
            // To help prevent accidental duplicates, among other nasty things.

            $flood_time_limit = 20; // How many seconds until a user can post again?

            $q = $this->db->query("SELECT glossary_id
                            FROM	editqueue
                            WHERE	user_id = '" . $THEUSER->user_id() . "'
                            AND		submitted + 0 > NOW() - $flood_time_limit");

            if ($q->rows() > 0) {
                error("Sorry, we limit people to posting one term per $flood_time_limit seconds to help prevent duplicate postings. Please go back and try again, thanks.");
                return false;
            }
        }

        // OK, let's get on with it...

        // Tidy up the HTML tags
        // (but we don't make URLs into links; only when displaying the comment).
        // We can display Glossary terms the same as the comments
        $data['title'] = filter_user_input($data['title'], 'comment_title'); // In utility.php
        $data['body'] = filter_user_input($data['body'], 'comment'); // In utility.php
        // Add the time and the edit type for the editqueue
        $data['posted'] = date('Y-m-d H:i:s', time());
        $data['edit_type'] = 2;

        // Add the item to the edit queue
        $success = $EDITQUEUE->add($data);

        if ($success) {
            return ($success);
        } else {
            return false;
        }