MySociety\TheyWorkForYou\Topic

Complexity

Total Complexity

50

Size/Duplication

Total Lines	325
Duplicated Lines	0 %

Importance

Changes

0

28 Methods

Rating	Name	Duplication	Size	Complexity
A	image_path()	0	6	2
A	set_slug()	0	2	1
A	description()	0	2	1
A	set_description()	0	2	1
B	getFullContent()	0	24	6
A	save()	0	18	1
A	set_image()	0	2	1
A	getAllPolicies()	0	11	2
A	title()	0	2	1
A	_getContentIDs()	0	12	1
A	set_search_string()	0	2	1
B	addPolicies()	0	24	5
A	search_string()	0	2	1
B	addPolicySets()	0	24	5
A	getContent()	0	14	2
A	set_title()	0	2	1
A	url()	0	3	1
A	getPolicies()	0	15	2
A	getPolicySets()	0	15	2
A	set_front_page()	0	2	1
A	image()	0	2	1
A	onFrontPage()	0	2	1
A	sctitle()	0	7	2
A	__construct()	0	15	2
A	addContent()	0	23	3
A	image_url()	0	2	1
A	slug()	0	2	1
A	deleteContent()	0	10	1

<?php
/**
 * Topic
 *
 * @package TheyWorkForYou
 */

namespace MySociety\TheyWorkForYou;

class Topic {

    /**
     * DB handle
     */
    private $db;

    private $raw;

The private property $raw is not used, and could be removed.

    private $id;
    private $title;
    private $slug;
    private $description;
    private $image;
    private $search_string;
    private $front_page;

    /**
     * Constructor
     *
     */

    public function __construct($data = NULL)
    {
        $this->db = new \ParlDB;

        if (is_null($data)) {
          return;
        }

        $this->id = $data['id'];
        $this->title = $data['title'];
        $this->slug = $data['slug'];
        $this->description = $data['description'];
        $this->search_string = $data['search_string'];
        $this->front_page = $data['front_page'];
        $this->image = $data['image'];

    }


    function title() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->title;
    }

    function sctitle() {

It is generally recommended to explicitly declare the visibility for methods.

        $title = $this->title;
        if (strpos($title, 'The ') === 0 ) {
            $title = lcfirst($title);
        }

        return $title;
    }

    function set_title($title) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->title = $title;
    }

    function slug() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->slug;
    }

    function set_slug($slug) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->slug = $slug;
    }

    function url() {

It is generally recommended to explicitly declare the visibility for methods.

        $url = new Url('topic');
        return $url->generate() . $this->slug;
    }

    function image() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->image;
    }

    function image_url() {

It is generally recommended to explicitly declare the visibility for methods.

        return "/topic/image.php?id=" . $this->slug();
    }

    function image_path() {

It is generally recommended to explicitly declare the visibility for methods.

        if ($this->image) {
            return sprintf('%s%s%s', TOPICIMAGEPATH, DIRECTORY_SEPARATOR, $this->image);

The constant MySociety\TheyWorkForYou\TOPICIMAGEPATH was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        return false;
    }

    function set_image($image) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->image = $image;
    }


    function description() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->description;
    }

    function set_description($description) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->description = $description;
    }

    function search_string() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->search_string;
    }

    function set_search_string($search_string) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->search_string = $search_string;
    }

    function set_front_page($on) {

It is generally recommended to explicitly declare the visibility for methods.

        $this->front_page = $on;
    }

    function onFrontPage() {

It is generally recommended to explicitly declare the visibility for methods.

        return $this->front_page == 1;
    }

    private function _getContentIDs() {
        $q = $this->db->query(
          "SELECT body, gid, ep.epobject_id FROM epobject ep
           JOIN hansard h on ep.epobject_id = h.epobject_id
           JOIN topic_epobjects te on te.epobject_id = ep.epobject_id
           WHERE topic_key = :topic_key",
            array(
                ':topic_key' => $this->id
            )
        );

        return $q;
    }

    function getContent() {

It is generally recommended to explicitly declare the visibility for methods.

        $q = $this->_getContentIDs();

        $content = array();
        $rows = $q->rows;
        for ($i = 0; $i < $rows; $i++) {
            $content[] = array(
                'title' => $q->field($i, 'body'),
                'href'  => Utility\Hansard::gid_to_url($q->field($i, 'gid')),
                'id'    => $q->field($i, 'epobject_id'),
            );
        }

        return $content;
    }

    function getFullContent() {

It is generally recommended to explicitly declare the visibility for methods.

        $q = $this->_getContentIDs();

        $content = array();
        $rows = $q->rows;
        for ($i = 0; $i < $rows; $i++) {
            $gid = $q->field($i, 'gid');
            if (strpos($gid, 'lords') !== false) {
                $debatelist = new \LORDSDEBATELIST;
            } elseif (strpos($gid, 'westminhall') !== false) {
                $debatelist = new \WHALLLIST;
            } else {
                $debatelist = new \DEBATELIST;
            }
            $data = $debatelist->display('featured_gid', array('gid' => $gid), 'none');

            $item = $data['data'];
            if (isset($item['parent']) && $item['body'] == $item['parent']['body']) {
                unset($item['parent']);
            }
            $content[] = $item;
        }

        return $content;
    }

    function addContent($gid) {

It is generally recommended to explicitly declare the visibility for methods.

        $q = $this->db->query(
          "SELECT epobject_id FROM hansard WHERE gid = :gid",
          array(
            ":gid" => $gid
          )
        );

        if (!$q->success() || $q->rows == 0) {
          return false;
        }

        $epobject_id = $q->field(0, 'epobject_id');

        $q = $this->db->query(
          "INSERT INTO topic_epobjects (topic_key, epobject_id) VALUES (:topic, :ep_id)",
          array(
            ":topic" => $this->id,
            ":ep_id" => $epobject_id
          )
        );

        return $q->success();
    }

    function deleteContent($id) {

It is generally recommended to explicitly declare the visibility for methods.

        $q = $this->db->query(
          "DELETE FROM topic_epobjects WHERE topic_key = :topic AND epobject_id = :ep_id",
          array(
            ":topic" => $this->id,
            ":ep_id" => $id
          )
        );

        return $q->success();
    }

    function getPolicySets() {

It is generally recommended to explicitly declare the visibility for methods.

      $q = $this->db->query(
        "SELECT policyset FROM topic_policysets WHERE topic_key = :key",
        array(
          ':key' => $this->id
        )
      );

      $sets = array();
      $count = $q->rows;
      for ($i = 0; $i < $count; $i++) {
        $sets[] = $q->field($i, 'policyset');
      }

      return $sets;
    }

    function addPolicySets($sets) {

It is generally recommended to explicitly declare the visibility for methods.

        if ($sets === '' or count($sets) == 0) {

Using logical operators such as or instead of || is generally not recommended.

            $q = $this->db->query(
                "DELETE FROM topic_policysets WHERE topic_key = :topic_key",
                array(
                    ":topic_key" => $this->id
                )
            );
        } else {
            foreach ($sets as $set) {
                if ($set == '' ) {
                    continue;
                }
                $q = $this->db->query(
                    "REPLACE INTO topic_policysets (policyset, topic_key) VALUES (:policyset, :topic_key)",
                    array(
                        ':topic_key' => $this->id,
                        ':policyset' => $set
                    )
                );
            }
        }

        return $q->success();

The variable $q does not seem to be defined for all execution paths leading up to this point.

    }

    function getPolicies() {

It is generally recommended to explicitly declare the visibility for methods.

      $q = $this->db->query(
        'SELECT policy_id FROM topic_policies WHERE topic_key = :key',
        array(
          ':key' => $this->id
        )
      );

      $policies = array();
      $count = $q->rows;
      for ($i = 0; $i < $count; $i++) {
        $policies[] = $q->field($i, 'policy_id');
      }

      return $policies;
    }

    function addPolicies($policies) {

It is generally recommended to explicitly declare the visibility for methods.

        if ($policies === '' or count($policies) == 0) {

Using logical operators such as or instead of || is generally not recommended.

            $q = $this->db->query(
                "DELETE FROM topic_policies WHERE topic_key = :topic_key",
                array(
                    ":topic_key" => $this->id
                )
            );
        } else {
            foreach ($policies as $policy) {
                if ($policy == '' ) {
                    continue;
                }
                $q = $this->db->query(
                    "REPLACE INTO topic_policies (policy_id, topic_key) VALUES (:policy, :topic_key)",
                    array(
                        ':topic_key' => $this->id,
                        ':policy' => $policy
                    )
                );
            }
        }

        return $q->success();

The variable $q does not seem to be defined for all execution paths leading up to this point.

    }

    function getAllPolicies() {

It is generally recommended to explicitly declare the visibility for methods.

        $policy_sets = $this->getPolicySets();
        $all_policies = array();
        $policies = new Policies();
        foreach ($policy_sets as $set) {
            $all_policies = array_merge($all_policies, array_keys($policies->limitToSet($set)->getPolicies()));
        }
        $topic_policies = $this->getPolicies();
        $all_policies = array_merge($all_policies, $topic_policies);

        return array_unique($all_policies);
    }

    function save() {

It is generally recommended to explicitly declare the visibility for methods.

        $q = $this->db->query(
          "REPLACE INTO topics
          (id, title, slug, description, search_string, front_page, image)
          VALUES
          (:id, :title, :slug, :description, :search_string, :front_page, :image)",
            array(
                ':id' => $this->id,
                ':slug' => $this->slug(),
                ':title' => $this->title(),
                ':description' => $this->description(),
                ':search_string' => $this->search_string(),
                ':front_page' => $this->onFrontPage(),
                ':image' => $this->image()
            )
        );

        return $q->success();
    }
}