Member - Code Metrics - Inspection of "Ignore dot in URL, so e.g. index.php not matched." - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions
Branch — master (3ce7e2)

by Nick
created 2018-06-21 14:13 UTC
Member F

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	493
Duplicated Lines	0 %
Test Coverage

Coverage
27.94%
Importance

Changes
Metric	Value
c	0
b	0
f	0
dl	0
loc	493
rs	1.5789
ccs	76
cts	272
cp	0.2794
wmc	95
20 Methods

Rating	Name	Size	Complexity
A	offices()	16	4
A	image()	20	3
A	isNew()	14	4
A	getOtherConstituenciesString()	6	2
A	getOfficeObject()	14	4
B	getRegionalList()	46	5
B	left_house_line()	9	5
C	getEnterLeaveStrings()	37	8
B	isDead()	34	6
B	calculatePolicyDiffScore()	17	13
B	getMostRecentMembership()	39	6
B	includeOffice()	14	5
A	entered_house_line()	9	4
B	getRepNameForHouse()	18	5
C	getPartyPolicyDiffs()	26	8
A	getEntryDate()	10	2
B	getOtherPartiesString()	12	5
A	getLeftDate()	10	2
A	getShortParty()	7	2
A	getEUStance()	6	2
How to fix Complexity

<?php
/**
 * Member Class
 *
 * @package TheyWorkForYou
 */

namespace MySociety\TheyWorkForYou;

/**
 * Member
 */

class Member extends \MEMBER {

    /**
     * Is Dead
     *
     * Determine if the member has died or not.
     *
     * @return boolean If the member is dead or not.
     */

    public function isDead() {

        $left_house = $this->left_house();

        if ($left_house) {


            // This member has left a house, and might be dead. See if they are.

            // Types of house to test for death.
            $house_types = array(
                HOUSE_TYPE_COMMONS,
                HOUSE_TYPE_LORDS,
                HOUSE_TYPE_SCOTLAND,
                HOUSE_TYPE_NI,
            );

            foreach ($house_types as $house_type) {

                if (in_array($house_type, $left_house) AND
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    $left_house[$house_type]['reason'] AND
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                    $left_house[$house_type]['reason'] == 'Died'
                ) {

                    // This member has left a house because of death.
                    return TRUE;
                }

            }

        }

        // If we get this far the member hasn't left a house due to death, and
        // is presumably alive.
        return FALSE;

    }

    /*
     * Determine if the member is a new member of a house where new is
     * within the last 6 months.
     *
     * @param int house - identifier for the house, defaults to 1 for westminster
filter:
    dependency_paths: ["lib/*"]
     *
     * @return boolean
     */

    public function isNew($house = HOUSE_TYPE_COMMONS) {
        $date_entered = $this->getEntryDate($house);

        if ($date_entered) {
            $date_entered = new \DateTime($date_entered);
            $now = new \DateTime();

            $diff = $date_entered->diff($now);
            if ( $diff->y == 0 && $diff->m <= 6 ) {
                return TRUE;
            }
        }

        return FALSE;
    }

    /*
     * Get the date the person first entered a house. May not be for their current seat.
     *
     * @param int house - identifier for the house, defaults to 1 for westminster
     *
     * @return string - blank if no entry date for that house otherwise in YYYY-MM-DD format
     */

    public function getEntryDate($house = HOUSE_TYPE_COMMONS) {
        $date_entered = '';

        $entered_house = $this->entered_house($house);

        if ( $entered_house ) {
            $date_entered = $entered_house['date'];
        }

        return $date_entered;
    }

    /*
     * Get the date the person last left the house.
     *
     * @param int house - identifier for the house, defaults to 1 for westminster
     *
     * @return string - 9999-12-31 if they are still in that house otherwise in YYYY-MM-DD format
     */

    public function getLeftDate($house = HOUSE_TYPE_COMMONS) {
        $date_left = '';

        $left_house = $this->left_house($house);

        if ( $left_house ) {
            $date_left = $left_house['date'];
        }

        return $date_left;
    }


    public function getEUStance() {
        if (array_key_exists('eu_ref_stance', $this->extra_info())) {
            return $this->extra_info()['eu_ref_stance'];
        }

        return FALSE;
    }

    /**
    * Image
    *
    * Return a URL for the member's image.
    *
    * @return string The URL of the member's image.
    */

    public function image() {

        $is_lord = $this->house(HOUSE_TYPE_LORDS);
        if ($is_lord) {
            list($image,$size) = Utility\Member::findMemberImage($this->person_id(), false, 'lord');
        } else {
            list($image,$size) = Utility\Member::findMemberImage($this->person_id(), false, true);
        }

        // We can determine if the image exists or not by testing if size is set
        if ($size !== NULL) {
            $exists = TRUE;
        } else {
            $exists = FALSE;
        }

        return array(

            'url' => $image,
            'size' => $size,
            'exists' => $exists
        );

    }

    // TODO: some of this probably wants to go elsewhere
    public function getMostRecentMembership() {
        $last_cons = '';
        $last_house = null;
        $last_party = null;
        if ( $this->current_member_anywhere() ) {
            $houses = array_keys(array_filter($this->current_member(), 'strlen'));

            $last_cons = $this->constituency;
            $last_party = $this->party;
            $last_house = $this->house_disp;
        } else {
            $max_date = null;
            foreach ( array_keys($this->left_house) as $house ) {
                if ($this->left_house[$house]['date'] > $max_date ) {
                    $max_date = $this->left_house[$house]['date'];
                    $last_cons = $this->left_house[$house]['constituency'];
                    $last_party = $this->left_house[$house]['party'];
                    $last_house = $house;
                }
            }
        }
        $details = array(
            'entered_house' => '',
            'left_house' => '',
            'cons' => $last_cons,
            'party' => $last_party,
            'house' => $last_house,
            'rep_name' => $this->getRepNameForHouse($last_house)
        );

        $entered_house = $this->entered_house($last_house);
        $left_house = $this->left_house($last_house);
        if ( isset($entered_house['date']) ) {
            $details['entered_house'] = $entered_house['date'];
        }
        if ( isset($left_house['date']) ) {
            $details['left_house'] = $left_house['date'];
        }

        return $details;
    }

    /**
    * Offices
    *
    * Return an array of Office objects held (or previously held) by the member.
    *
    * @param string $include_only  Restrict the list to include only "previous" or "current" offices.
    * @param bool   $ignore_committees Ignore offices that appear to be committee memberships.
    *
    * @return array An array of Office objects.
    */

    public function offices($include_only = NULL, $ignore_committees = FALSE) {

        $out = array();

        if (array_key_exists('office', $this->extra_info())) {
            $office = $this->extra_info();
            $office = $office['office'];

            foreach ($office as $row) {
                if ( $officeObject = $this->getOfficeObject($include_only, $ignore_committees, $row) ) {
                    $out[] = $officeObject;
                }
            }
        }

        return $out;

    }

    private function getOfficeObject($include_only, $ignore_committees, $row) {
        if (!$this->includeOffice($include_only, $row['to_date'])) {
            return null;
        }
        if ($ignore_committees && strpos($row['moffice_id'], 'Committee')) {
            return null;
        }

        $officeObject = new Office;
        $officeObject->title = prettify_office($row['position'], $row['dept']);
        $officeObject->from_date = $row['from_date'];
        $officeObject->to_date = $row['to_date'];
        $officeObject->source = $row['source'];
        return $officeObject;
    }

    private function includeOffice($include_only, $to_date) {
        $include_office = TRUE;

        // If we should only include previous offices, and the to date is in the future, suppress this office.
        if ($include_only == 'previous' AND $to_date == '9999-12-31') {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $include_office = FALSE;
        }

        // If we should only include previous offices, and the to date is in the past, suppress this office.
        if ($include_only == 'current' AND $to_date != '9999-12-31') {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $include_office = FALSE;
        }

        return $include_office;
    }

    /**
    * Get Other Parties String
    *
    * Return a readable list of party changes for this member.
    *
    * @return string|null A readable list of the party changes for this member.
    */

    public function getOtherPartiesString() {

        if (!empty($this->other_parties) && $this->party != 'Speaker' && $this->party != 'Deputy Speaker') {
            $output = 'Party was ';
            $other_parties = array();
            foreach ($this->other_parties as $r) {
                $other_parties[] = $r['from'] . ' until ' . format_date($r['date'], SHORTDATEFORMAT);
            }
            $output .= join('; ', $other_parties);
            return $output;
        } else {
            return NULL;
        }

    }

    public function getShortParty() {
        $party = $this->party();
        if ($party == 'Labour/Co-operative') {
            $party = 'Labour';
        }
        $party = str_replace(' ', '', $party);
        return $party;
    }

    /**
    * Get Other Constituencies String
    *
    * Return a readable list of other constituencies for this member.
    *
    * @return string|null A readable list of the other constituencies for this member.
    */

    public function getOtherConstituenciesString() {

        if ($this->other_constituencies) {
            return 'Also represented ' . join('; ', array_keys($this->other_constituencies));
        } else {
            return NULL;
        }

    }

    /**
    * Get Entered/Left Strings
    *
    * Return an array of readable strings covering when people entered or left
    * various houses. Returns an array since it's possible for a member to have
    * done several of these things.
    *
    * @return array An array of strings of when this member entered or left houses.
    */
    public function getEnterLeaveStrings() {
        $output = array();

        $output[] = $this->entered_house_line(HOUSE_TYPE_LORDS, 'House of Lords');

        if (isset($this->left_house[HOUSE_TYPE_COMMONS]) && isset($this->entered_house[HOUSE_TYPE_LORDS])) {
            $string = '<strong>Previously MP for ';
            $string .= $this->left_house[HOUSE_TYPE_COMMONS]['constituency'] . ' until ';
            $string .= $this->left_house[HOUSE_TYPE_COMMONS]['date_pretty'] . '</strong>';
            if ($this->left_house[HOUSE_TYPE_COMMONS]['reason']) {
                $string .= ' &mdash; ' . $this->left_house[HOUSE_TYPE_COMMONS]['reason'];
            }
            $output[] = $string;
        }

        $output[] = $this->left_house_line(HOUSE_TYPE_LORDS, 'House of Lords');

        if (isset($this->extra_info['lordbio'])) {
            $output[] = '<strong>Positions held at time of appointment:</strong> ' . $this->extra_info['lordbio'] .
                ' <small>(from <a href="' .
                $this->extra_info['lordbio_from'] . '">Number 10 press release</a>)</small>';
        }

        $output[] = $this->entered_house_line(HOUSE_TYPE_COMMONS, 'House of Commons');

        # If they became a Lord, we handled this above.
        if ($this->house(HOUSE_TYPE_COMMONS) && !$this->current_member(HOUSE_TYPE_COMMONS) && !$this->house(HOUSE_TYPE_LORDS)) {
            $output[] = $this->left_house_line(HOUSE_TYPE_COMMONS, 'House of Commons');
        }

        $output[] = $this->entered_house_line(HOUSE_TYPE_NI, 'Assembly');
        $output[] = $this->left_house_line(HOUSE_TYPE_NI, 'Assembly');
        $output[] = $this->entered_house_line(HOUSE_TYPE_SCOTLAND, 'Scottish Parliament');
        $output[] = $this->left_house_line(HOUSE_TYPE_SCOTLAND, 'Scottish Parliament');

        $output = array_values(array_filter($output));
        return $output;
    }

    private function entered_house_line($house, $house_name) {
        if (isset($this->entered_house[$house]['date'])) {
            $string = "<strong>Entered the $house_name ";
            $string .= strlen($this->entered_house[$house]['date_pretty'])==HOUSE_TYPE_SCOTLAND ? 'in ' : 'on ';
            $string .= $this->entered_house[$house]['date_pretty'] . '</strong>';
            if ($this->entered_house[$house]['reason']) {
                $string .= ' &mdash; ' . $this->entered_house[$house]['reason'];
            }
            return $string;
        }
    }

    private function left_house_line($house, $house_name) {
        if ($this->house($house) && !$this->current_member($house)) {
            $string = "<strong>Left the $house_name ";
            $string .= strlen($this->left_house[$house]['date_pretty'])==4 ? 'in ' : 'on ';
            $string .= $this->left_house[$house]['date_pretty'] . '</strong>';
            if ($this->left_house[$house]['reason']) {
                $string .= ' &mdash; ' . $this->left_house[$house]['reason'];
            }
            return $string;
        }
    }

    public function getPartyPolicyDiffs($party, $policiesList, $positions, $only_diffs = false) {
        $policy_diffs = array();
        $party_positions = $party->getAllPolicyPositions($policiesList);

        if ( !$party_positions ) {
            return $policy_diffs;
        }

        foreach ( $positions->positionsById as $policy_id => $details ) {
            if ( $details['has_strong'] && $details['score'] != -1 && isset($party_positions[$policy_id])) {
                $mp_score = $details['score'];
                $party_score = $party_positions[$policy_id]['score'];

                $score_diff = $this->calculatePolicyDiffScore($mp_score, $party_score);

                // skip anything that isn't a yes vs no diff
                if ( $only_diffs && $score_diff < 2 ) {
                    continue;
                }
                $policy_diffs[$policy_id] = $score_diff;
            }
        }

        arsort($policy_diffs);

        return $policy_diffs;
    }

    private function calculatePolicyDiffScore( $mp_score, $party_score ) {
        $score_diff = abs($mp_score - $party_score);
        // if they are on opposite sides of mixture of for and against
        if (
            ( $mp_score < 0.4 && $party_score > 0.6 ) ||
            ( $mp_score > 0.6 && $party_score < 0.4 )
        ) {
            $score_diff += 2;
        // if on is mixture of for and against and one is for/against
        } else if (
            ( $mp_score > 0.4 && $mp_score < 0.6 && ( $party_score > 0.6 || $party_score < 0.4 ) ) ||

            ( $party_score > 0.4 && $party_score < 0.6 && ( $mp_score > 0.6 || $mp_score < 0.4 ) )
        ) {
            $score_diff += 1;
        }

        return $score_diff;
    }

    public static function getRegionalList($postcode, $house, $type) {
        $db = new \ParlDB;

        $mreg = array();
        $constituencies = \MySociety\TheyWorkForYou\Utility\Postcode::postcodeToConstituencies($postcode);
        if ( isset($constituencies[$type]) ) {
            $cons_name = $constituencies[$type];
            $query_base = "SELECT member.person_id, title, lordofname, given_name, family_name, constituency, house
                FROM member, person_names
                WHERE
                member.person_id = person_names.person_id
                AND person_names.type = 'name'
                AND constituency = :cons_name
                AND house = :house
                AND left_house >= start_date
                AND left_house <= end_date";
            $q = $db->query("$query_base AND left_reason = 'still_in_office'",
                array(
                    ':house' => $house,
                    ':cons_name' => $cons_name
                )
            );
            if ( !$q->rows() && ($dissolution = Dissolution::db()) ) {
                $q = $db->query("$query_base AND $dissolution[query]",
                    array(
                        ':house' => $house,
                        ':cons_name' => $cons_name,
                    ) + $dissolution['params']
                );
            }

            for ($i = 0; $i < $q->rows; $i++) {
                $name = member_full_name($house, $q->field($i, 'title'),
                    $q->field($i, 'given_name'), $q->field($i, 'family_name'),
                    $q->field($i, 'lordofname'));

                $mreg[] = array(
                    'person_id' 	=> $q->field($i, 'person_id'),
                    'name' => $name,
                    'house' => $q->field($i, 'house'),
                    'constituency' 	=> $q->field($i, 'constituency')
                );
            }
        }

        return $mreg;
    }

    public static function getRepNameForHouse($house) {
        switch ( $house ) {
        case HOUSE_TYPE_COMMONS:
            $name = 'MP';
            break;
        case HOUSE_TYPE_LORDS:
            $name = 'Peer';
            break;
        case HOUSE_TYPE_NI:
            $name = 'MLA';
            break;
        case HOUSE_TYPE_SCOTLAND:
            $name = 'MSP';
            break;
        default:
            $name = '';
        }
        return $name;
    }

}

Branch — master (3ce7e2)

Member F

Complexity

Size/Duplication

Test Coverage

Importance

20 Methods

How to fix Complexity

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

mysociety / theyworkforyou

Branch — master (3ce7e2)

Member F

Complexity

Size/Duplication

Test Coverage

Importance

20 Methods

How to fix Complexity

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like
